105788 2012-12-27 03:01:14 -0800 Regression(r138222): Caused http/tests/appcache/main-resource-redirect.html to fail 2012-12-27 12:08:55 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED DUPLICATE 105591 P2 Normal --- 105330 1 cdumez webkit-unassigned ap beidson cgarcia japhet oldest_to_newest 797489 0 cdumez 2012-12-27 03:01:14 -0800 After http://trac.webkit.org/changeset/138222, http/tests/appcache/main-resource-redirect.html started failing (at least on EFL port): crash log for WebKitTestRunner (pid 28658): STDOUT: <empty> STDERR: ASSERTION FAILED: !HashTranslator::equal(KeyTraits::emptyValue(), key) STDERR: /home/buildslave-1/webkit-buildslave/efl-linux-64-debug-wk2/build/Source/WTF/wtf/HashTable.h(588) : void WTF::HashTable<Key, Value, Extractor, HashFunctions, Traits, KeyTraits>::checkKey(const T&) [with HashTranslator = WTF::IdentityHashTranslator<WTF::IntHash<long unsigned int> >, T = long unsigned int, Key = long unsigned int, Value = WTF::KeyValuePair<long unsigned int, WTF::RefPtr<EwkResource> >, Extractor = WTF::KeyValuePairKeyExtractor<WTF::KeyValuePair<long unsigned int, WTF::RefPtr<EwkResource> > >, HashFunctions = WTF::IntHash<long unsigned int>, Traits = WTF::HashMapValueTraits<WTF::HashTraits<long unsigned int>, WTF::HashTraits<WTF::RefPtr<EwkResource> > >, KeyTraits = WTF::HashTraits<long unsigned int>] STDERR: 1 0x7fe1b023efdc void WTF::HashTable<unsigned long, WTF::KeyValuePair<unsigned long, WTF::RefPtr<EwkResource> >, WTF::KeyValuePairKeyExtractor<WTF::KeyValuePair<unsigned long, WTF::RefPtr<EwkResource> > >, WTF::IntHash<unsigned long>, WTF::HashMapValueTraits<WTF::HashTraits<unsigned long>, WTF::HashTraits<WTF::RefPtr<EwkResource> > >, WTF::HashTraits<unsigned long> >::checkKey<WTF::IdentityHashTranslator<WTF::IntHash<unsigned long> >, unsigned long>(unsigned long const&) STDERR: 2 0x7fe1b023ea4b WTF::KeyValuePair<unsigned long, WTF::RefPtr<EwkResource> >* WTF::HashTable<unsigned long, WTF::KeyValuePair<unsigned long, WTF::RefPtr<EwkResource> >, WTF::KeyValuePairKeyExtractor<WTF::KeyValuePair<unsigned long, WTF::RefPtr<EwkResource> > >, WTF::IntHash<unsigned long>, WTF::HashMapValueTraits<WTF::HashTraits<unsigned long>, WTF::HashTraits<WTF::RefPtr<EwkResource> > >, WTF::HashTraits<unsigned long> >::lookup<WTF::IdentityHashTranslator<WTF::IntHash<unsigned long> >, unsigned long>(unsigned long const&) STDERR: 3 0x7fe1b023e133 WTF::HashTable<unsigned long, WTF::KeyValuePair<unsigned long, WTF::RefPtr<EwkResource> >, WTF::KeyValuePairKeyExtractor<WTF::KeyValuePair<unsigned long, WTF::RefPtr<EwkResource> > >, WTF::IntHash<unsigned long>, WTF::HashMapValueTraits<WTF::HashTraits<unsigned long>, WTF::HashTraits<WTF::RefPtr<EwkResource> > >, WTF::HashTraits<unsigned long> >::lookup(unsigned long const&) STDERR: 4 0x7fe1b023d891 WTF::HashMap<unsigned long, WTF::RefPtr<EwkResource>, WTF::IntHash<unsigned long>, WTF::HashTraits<unsigned long>, WTF::HashTraits<WTF::RefPtr<EwkResource> > >::get(unsigned long const&) const STDERR: 5 0x7fe1b023d09d WebKit::ResourceLoadClientEfl::didReceiveResponseForResource(OpaqueWKPage const*, OpaqueWKFrame const*, unsigned long, OpaqueWKURLResponse const*, void const*) STDERR: 6 0x7fe1b009a345 WebKit::WebResourceLoadClient::didReceiveResponseForResource(WebKit::WebPageProxy*, WebKit::WebFrameProxy*, unsigned long, WebCore::ResourceResponse const&) STDERR: 7 0x7fe1b00506ed WebKit::WebPageProxy::didReceiveResponseForResource(unsigned long, unsigned long, WebCore::ResourceResponse const&) STDERR: 8 0x7fe1b0272a65 void CoreIPC::callMemberFunction<WebKit::WebPageProxy, void (WebKit::WebPageProxy::*)(unsigned long, unsigned long, WebCore::ResourceResponse const&), unsigned long, unsigned long, WebCore::ResourceResponse>(CoreIPC::Arguments3<unsigned long, unsigned long, WebCore::ResourceResponse> const&, WebKit::WebPageProxy*, void (WebKit::WebPageProxy::*)(unsigned long, unsigned long, WebCore::ResourceResponse const&)) STDERR: 9 0x7fe1b026eac1 void CoreIPC::handleMessage<Messages::WebPageProxy::DidReceiveResponseForResource, WebKit::WebPageProxy, void (WebKit::WebPageProxy::*)(unsigned long, unsigned long, WebCore::ResourceResponse const&)>(CoreIPC::MessageDecoder&, WebKit::WebPageProxy*, void (WebKit::WebPageProxy::*)(unsigned long, unsigned long, WebCore::ResourceResponse const&)) STDERR: 10 0x7fe1b0268c84 WebKit::WebPageProxy::didReceiveWebPageProxyMessage(CoreIPC::Connection*, CoreIPC::MessageID, CoreIPC::MessageDecoder&) STDERR: 11 0x7fe1b004cb17 WebKit::WebPageProxy::didReceiveMessage(CoreIPC::Connection*, CoreIPC::MessageID, CoreIPC::MessageDecoder&) STDERR: 12 0x7fe1b008db9b WebKit::WebProcessProxy::didReceiveMessage(CoreIPC::Connection*, CoreIPC::MessageID, CoreIPC::MessageDecoder&) STDERR: 13 0x7fe1aff727cc CoreIPC::Connection::dispatchMessage(CoreIPC::MessageID, CoreIPC::MessageDecoder&) STDERR: 14 0x7fe1aff72938 CoreIPC::Connection::dispatchMessage(CoreIPC::Connection::Message<CoreIPC::MessageDecoder>&) STDERR: 15 0x7fe1aff72b83 CoreIPC::Connection::dispatchOneMessage() STDERR: 16 0x7fe1aff7d41a WTF::FunctionWrapper<void (CoreIPC::Connection::*)()>::operator()(CoreIPC::Connection*) STDERR: 17 0x7fe1aff7d220 WTF::BoundFunctionImpl<WTF::FunctionWrapper<void (CoreIPC::Connection::*)()>, void (CoreIPC::Connection*)>::operator()() STDERR: 18 0x7fe1b78579b2 WTF::Function<void ()>::operator()() const STDERR: 19 0x7fe1b392a446 WebCore::RunLoop::performWork() STDERR: 20 0x7fe1b43ffa3e WebCore::RunLoop::wakeUpEvent(void*, void*, unsigned int) STDERR: 21 0x7fe1af335621 STDERR: 22 0x7fe1af334571 STDERR: 23 0x7fe1af334ab7 ecore_main_loop_begin STDERR: 24 0x434a3d WTR::TestController::platformRunUntil(bool&, double) STDERR: 25 0x41f472 WTR::TestController::runUntil(bool&, WTR::TestController::TimeoutDuration) STDERR: 26 0x426581 WTR::TestInvocation::invoke() STDERR: 27 0x41f1aa WTR::TestController::runTest(char const*) STDERR: 28 0x41f2e3 WTR::TestController::runTestingServerLoop() STDERR: 29 0x41f37d WTR::TestController::run() STDERR: 30 0x41ccb3 WTR::TestController::TestController(int, char const**) STDERR: 31 0x434bd6 main The reason for the failure is that WebResourceLoadClient::didReceiveResponseForResource() is now called 0 as identifier value, which is not a valid identifier. 797490 1 cdumez 2012-12-27 03:06:48 -0800 Skipped for EFL WK2 in http://trac.webkit.org/changeset/138495 797525 2 180794 cgarcia 2012-12-27 05:51:33 -0800 Created attachment 180794 Patch The problem is that in case of loading substitute data from app cache due to a redirect, the substitute data id is not initialized. 797526 3 cdumez 2012-12-27 05:55:21 -0800 LGTM. I can confirm this patch fixes the issue on EFL port. 797585 4 180794 darin 2012-12-27 09:46:32 -0800 Comment on attachment 180794 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=180794&action=review > Source/WebCore/loader/MainResourceLoader.cpp:272 > ASSERT(!m_substituteData.isValid()); > documentLoader()->applicationCacheHost()->maybeLoadMainResourceForRedirect(newRequest, m_substituteData); > + if (m_substituteData.isValid()) If two lines earlier we asserted this is not true, how can it be true now? 797606 5 180794 cdumez 2012-12-27 10:14:12 -0800 Comment on attachment 180794 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=180794&action=review >> Source/WebCore/loader/MainResourceLoader.cpp:272 >> + if (m_substituteData.isValid()) > > If two lines earlier we asserted this is not true, how can it be true now? ApplicationCacheHost::maybeLoadMainResourceForRedirect(ResourceRequest& request, SubstituteData& substituteData) may populate m_substituteData since it is passed by reference. 797640 6 ap 2012-12-27 12:08:15 -0800 *** This bug has been marked as a duplicate of bug 105591 *** 797642 7 180794 ap 2012-12-27 12:08:55 -0800 Comment on attachment 180794 Patch Let's discuss various approaches to fixing this in one bug, not two. Clearing review flag. 180794 2012-12-27 05:51:33 -0800 2012-12-27 12:08:54 -0800 Patch wcore-loader-substitute-data-id.diff text/plain 3229 cgarcia ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBiOWQwZjUwLi44NGUzNWRiIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTItMTIt MjcgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgorCisgICAgICAg IFJlZ3Jlc3Npb24ocjEzODIyMik6IENhdXNlZCBodHRwL3Rlc3RzL2FwcGNhY2hlL21haW4tcmVz b3VyY2UtcmVkaXJlY3QuaHRtbCB0byBmYWlsCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xMDU3ODgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICAqIHBsYXRmb3JtL2VmbC13azIvVGVzdEV4cGVjdGF0aW9uczog VW5za2lwCisgICAgICAgIGh0dHAvdGVzdHMvYXBwY2FjaGUvbWFpbi1yZXNvdXJjZS1yZWRpcmVj dC5odG1sLgorCiAyMDEyLTEyLTI1ICBBbmRyZXkgQWRhaWtpbiAgPGFhbmRyZXlAY2hyb21pdW0u b3JnPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IFtDYW52YXNdIHJlcG9ydCBpZiB0aGVyZSBp cyBhbnkgdW5pbnN0cnVtZW50ZWQgY2FudmFzIG9uIGEgcGFnZQpkaWZmIC0tZ2l0IGEvTGF5b3V0 VGVzdHMvcGxhdGZvcm0vZWZsLXdrMi9UZXN0RXhwZWN0YXRpb25zIGIvTGF5b3V0VGVzdHMvcGxh dGZvcm0vZWZsLXdrMi9UZXN0RXhwZWN0YXRpb25zCmluZGV4IGRkM2U1Y2MuLmVhMGRjZWMgMTAw NjQ0Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2VmbC13azIvVGVzdEV4cGVjdGF0aW9ucwor KysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9lZmwtd2syL1Rlc3RFeHBlY3RhdGlvbnMKQEAgLTU5 LDkgKzU5LDYgQEAgd2Via2l0Lm9yZy9iLzEwMjY1MSBbIERlYnVnIF0gbmV0d29ya2luZm9ybWF0 aW9uL3VwZGF0ZXMuaHRtbCBbIENyYXNoIF0KIHdlYmtpdC5vcmcvYi8xMDI2NTEgWyBEZWJ1ZyBd IG5ldHdvcmtpbmZvcm1hdGlvbi9hZGQtbGlzdGVuZXItZnJvbS1jYWxsYmFjay5odG1sIFsgQ3Jh c2ggXQogd2Via2l0Lm9yZy9iLzEwMjY1MSBbIERlYnVnIF0gbmV0d29ya2luZm9ybWF0aW9uL2Jh c2ljLW9wZXJhdGlvbi5odG1sIFsgQ3Jhc2ggXQogCi0jIFJlc291cmNlQ2xpZW50IGlzIHBhc3Nl ZCBhbiBpbnZhbGlkIGlkZW50aWZpZXIgdmFsdWUgKDApLgotd2Via2l0Lm9yZy9iLzEwNTc4OCBb IERlYnVnIF0gaHR0cC90ZXN0cy9hcHBjYWNoZS9tYWluLXJlc291cmNlLXJlZGlyZWN0Lmh0bWwg WyBDcmFzaCBdCi0KICMvLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vCiAjIEZMQUtZIFRF U1RTCiAjLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLwpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IDljYTQ5 YTQuLmNiMDg2N2YgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9T b3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxMi0xMi0yNyAgQ2Fy bG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CisKKyAgICAgICAgUmVncmVz c2lvbihyMTM4MjIyKTogQ2F1c2VkIGh0dHAvdGVzdHMvYXBwY2FjaGUvbWFpbi1yZXNvdXJjZS1y ZWRpcmVjdC5odG1sIHRvIGZhaWwKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTEwNTc4OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIEZpeGVzIGNyYXNoIGluIHRlc3QgaHR0cC90ZXN0cy9hcHBjYWNoZS9tYWlu LXJlc291cmNlLXJlZGlyZWN0Lmh0bWwuCisKKyAgICAgICAgKiBsb2FkZXIvTWFpblJlc291cmNl TG9hZGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Ok1haW5SZXNvdXJjZUxvYWRlcjo6d2lsbFNl bmRSZXF1ZXN0KTogSW4gY2FzZSBvZiBsb2FkaW5nCisgICAgICAgIHN1YnN0aXR1dGUgZGF0YSBm cm9tIGFwcGxpY2F0aW9uIGNhY2hlIGhvc3QgZHVlIHRvIGEgcmVkaXJlY3QsCisgICAgICAgIG1h a2Ugc3VyZSB0aGUgc3Vic3RpdHV0ZSBkYXRhIGlkZW50aWZpZXIgaXMgaW5pdGlhbGl6ZWQuCisK IDIwMTItMTItMjUgIEFuZHJleSBBZGFpa2luICA8YWFuZHJleUBjaHJvbWl1bS5vcmc+CiAKICAg ICAgICAgV2ViIEluc3BlY3RvcjogW0NhbnZhc10gcmVwb3J0IGlmIHRoZXJlIGlzIGFueSB1bmlu c3RydW1lbnRlZCBjYW52YXMgb24gYSBwYWdlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9s b2FkZXIvTWFpblJlc291cmNlTG9hZGVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9NYWlu UmVzb3VyY2VMb2FkZXIuY3BwCmluZGV4IDM1MGViMGQuLjllMDYxMWUgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL2xvYWRlci9NYWluUmVzb3VyY2VMb2FkZXIuY3BwCisrKyBiL1NvdXJjZS9X ZWJDb3JlL2xvYWRlci9NYWluUmVzb3VyY2VMb2FkZXIuY3BwCkBAIC0yNjksNiArMjY5LDggQEAg dm9pZCBNYWluUmVzb3VyY2VMb2FkZXI6OndpbGxTZW5kUmVxdWVzdChSZXNvdXJjZVJlcXVlc3Qm IG5ld1JlcXVlc3QsIGNvbnN0IFJlc28KICAgICAgICAgLy8gV2UgY2hlY2tlZCBhcHBsaWNhdGlv biBjYWNoZSBmb3IgaW5pdGlhbCBVUkwsIG5vdyB3ZSBuZWVkIHRvIGNoZWNrIGl0IGZvciByZWRp cmVjdGVkIG9uZS4KICAgICAgICAgQVNTRVJUKCFtX3N1YnN0aXR1dGVEYXRhLmlzVmFsaWQoKSk7 CiAgICAgICAgIGRvY3VtZW50TG9hZGVyKCktPmFwcGxpY2F0aW9uQ2FjaGVIb3N0KCktPm1heWJl TG9hZE1haW5SZXNvdXJjZUZvclJlZGlyZWN0KG5ld1JlcXVlc3QsIG1fc3Vic3RpdHV0ZURhdGEp OworICAgICAgICBpZiAobV9zdWJzdGl0dXRlRGF0YS5pc1ZhbGlkKCkpCisgICAgICAgICAgICBt X3N1YnN0aXR1dGVEYXRhTG9hZElkZW50aWZpZXIgPSBpZGVudGlmaWVyKCk7CiAgICAgfQogCiAg ICAgLy8gRklYTUU6IElkZWFsbHkgd2UnZCBzdG9wIHRoZSBJL08gdW50aWwgd2UgaGVhciBiYWNr IGZyb20gdGhlIG5hdmlnYXRpb24gcG9saWN5IGRlbGVnYXRlCg==