105782 2012-12-26 17:53:12 -0800 [TexMap] Minor refactoring of TextureMapperLayer. 2012-12-27 18:19:53 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dongseong.hwang dongseong.hwang darin noam webkit.review.bot oldest_to_newest 797434 0 dongseong.hwang 2012-12-26 17:53:12 -0800 This patch has two refactorings. 1. Replace TextureMapperPaintOptions from header to implementation file. 2. Add non copyable property to TextureMapperLayer. 797435 1 180771 dongseong.hwang 2012-12-26 17:54:40 -0800 Created attachment 180771 Patch 797590 2 180771 darin 2012-12-27 09:51:56 -0800 Comment on attachment 180771 Patch OK 797591 3 180771 webkit.review.bot 2012-12-27 09:58:16 -0800 Comment on attachment 180771 Patch Clearing flags on attachment: 180771 Committed r138508: <http://trac.webkit.org/changeset/138508> 797592 4 webkit.review.bot 2012-12-27 09:58:19 -0800 All reviewed patches have been landed. Closing bug. 797602 5 darin 2012-12-27 10:08:43 -0800 One minor quibble. Marking a class as noncopyable is not a “refactoring” although it’s a sensible change to make here. 797720 6 dongseong.hwang 2012-12-27 18:19:53 -0800 (In reply to comment #5) > One minor quibble. Marking a class as noncopyable is not a “refactoring” although it’s a sensible change to make here. aha, you are right. I'll use more sensible word in next time :) 180771 2012-12-26 17:54:40 -0800 2012-12-27 09:58:16 -0800 Patch bug-105782-20121227105148.patch text/plain 3140 dongseong.hwang U3VidmVyc2lvbiBSZXZpc2lvbjogMTM4NDY1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzQxYTU3MjE0YzQwMmQ4 MmU5ODBiYmY4YjkxMDc1NDFkN2EzZjVjNC4uM2NjZWJiOWYwNjdlNzU4NzY2ZWQ4YTYyY2U5Mjhl NGUxY2YxYTNiNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI2IEBACiAyMDEyLTEyLTI2ICBIdWFu ZyBEb25nc3VuZyAgPGx1eHRlbGxhQGNvbXBhbnkxMDAubmV0PgogCisgICAgICAgIFtUZXhNYXBd IE1pbm9yIHJlZmFjdG9yaW5nIG9mIFRleHR1cmVNYXBwZXJMYXllci4KKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNTc4MgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgcGF0Y2ggaGFzIHR3byByZWZh Y3RvcmluZ3MuCisgICAgICAgIDEuIFJlcGxhY2UgVGV4dHVyZU1hcHBlclBhaW50T3B0aW9ucyBm cm9tIGhlYWRlciB0byBpbXBsZW1lbnRhdGlvbiBmaWxlLgorICAgICAgICAyLiBBZGQgbm9uIGNv cHlhYmxlIHByb3BlcnR5IHRvIFRleHR1cmVNYXBwZXJMYXllci4KKworICAgICAgICBObyBuZXcg dGVzdHMuIFJlZmFjdG9yaW5nIG9ubHkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy90 ZXhtYXAvVGV4dHVyZU1hcHBlckxheWVyLmNwcDoKKyAgICAgICAgKFRleHR1cmVNYXBwZXJQYWlu dE9wdGlvbnMpOgorICAgICAgICAoV2ViQ29yZTo6VGV4dHVyZU1hcHBlclBhaW50T3B0aW9uczo6 VGV4dHVyZU1hcHBlclBhaW50T3B0aW9ucyk6CisgICAgICAgIChXZWJDb3JlKToKKyAgICAgICAg KiBwbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvVGV4dHVyZU1hcHBlckxheWVyLmg6CisgICAgICAg IChXZWJDb3JlKToKKyAgICAgICAgKFRleHR1cmVNYXBwZXJMYXllcik6CisKKzIwMTItMTItMjYg IEh1YW5nIERvbmdzdW5nICA8bHV4dGVsbGFAY29tcGFueTEwMC5uZXQ+CisKICAgICAgICAgW1Rl eE1hcF0gUmVtb3ZlIG1fc2l6ZSBpbiBUZXh0dXJlTWFwcGVyTGF5ZXIuCiAgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDU3ODEKIApkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL1RleHR1cmVNYXBwZXJMYXll ci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvVGV4dHVyZU1h cHBlckxheWVyLmNwcAppbmRleCAwMDIwMzMwMWZlOTgwZGYxZTY3ODY5Y2UxOGJjNTBiNWU5OTkx MzUzLi4zMzQ2NzRlNDg0ZjUwZDRkY2ZjMDJkNGNlNjE1OTQxMDgxZDI4NmQ2IDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvVGV4dHVyZU1hcHBlckxh eWVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvVGV4 dHVyZU1hcHBlckxheWVyLmNwcApAQCAtMjYsNiArMjYsMjAgQEAKIAogbmFtZXNwYWNlIFdlYkNv cmUgewogCitjbGFzcyBUZXh0dXJlTWFwcGVyUGFpbnRPcHRpb25zIHsKK3B1YmxpYzoKKyAgICBS ZWZQdHI8Qml0bWFwVGV4dHVyZT4gc3VyZmFjZTsKKyAgICBSZWZQdHI8Qml0bWFwVGV4dHVyZT4g bWFzazsKKyAgICBmbG9hdCBvcGFjaXR5OworICAgIFRyYW5zZm9ybWF0aW9uTWF0cml4IHRyYW5z Zm9ybTsKKyAgICBJbnRTaXplIG9mZnNldDsKKyAgICBUZXh0dXJlTWFwcGVyKiB0ZXh0dXJlTWFw cGVyOworICAgIFRleHR1cmVNYXBwZXJQYWludE9wdGlvbnMoKQorICAgICAgICA6IG9wYWNpdHko MSkKKyAgICAgICAgLCB0ZXh0dXJlTWFwcGVyKDApCisgICAgeyB9Cit9OworCiBUZXh0dXJlTWFw cGVyTGF5ZXIqIHRvVGV4dHVyZU1hcHBlckxheWVyKEdyYXBoaWNzTGF5ZXIqIGxheWVyKQogewog ICAgIHJldHVybiBsYXllciA/IHRvR3JhcGhpY3NMYXllclRleHR1cmVNYXBwZXIobGF5ZXIpLT5s YXllcigpIDogMDsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L3RleG1hcC9UZXh0dXJlTWFwcGVyTGF5ZXIuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL3RleG1hcC9UZXh0dXJlTWFwcGVyTGF5ZXIuaAppbmRleCBmMjNiNjEyMGViYWJlNGRh OWExZWFlOTRmNmZiOTc0NTlmOWY4NWNmLi42MGRhM2UwMmFkZTI1MDBhMGRmYmI3OTM3NjNjZDNi NzlmMGExMDhhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy90 ZXhtYXAvVGV4dHVyZU1hcHBlckxheWVyLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3MvdGV4bWFwL1RleHR1cmVNYXBwZXJMYXllci5oCkBAIC0zMiwyNCArMzIsMTIgQEAK IAogbmFtZXNwYWNlIFdlYkNvcmUgewogCitjbGFzcyBUZXh0dXJlTWFwcGVyUGFpbnRPcHRpb25z OwogY2xhc3MgVGV4dHVyZU1hcHBlclBsYXRmb3JtTGF5ZXI7CiBjbGFzcyBHcmFwaGljc0xheWVy VGV4dHVyZU1hcHBlcjsKIAotY2xhc3MgVGV4dHVyZU1hcHBlclBhaW50T3B0aW9ucyB7Ci1wdWJs aWM6Ci0gICAgUmVmUHRyPEJpdG1hcFRleHR1cmU+IHN1cmZhY2U7Ci0gICAgUmVmUHRyPEJpdG1h cFRleHR1cmU+IG1hc2s7Ci0gICAgZmxvYXQgb3BhY2l0eTsKLSAgICBUcmFuc2Zvcm1hdGlvbk1h dHJpeCB0cmFuc2Zvcm07Ci0gICAgSW50U2l6ZSBvZmZzZXQ7Ci0gICAgVGV4dHVyZU1hcHBlciog dGV4dHVyZU1hcHBlcjsKLSAgICBUZXh0dXJlTWFwcGVyUGFpbnRPcHRpb25zKCkKLSAgICAgICAg OiBvcGFjaXR5KDEpCi0gICAgICAgICwgdGV4dHVyZU1hcHBlcigwKQotICAgIHsgfQotfTsKLQog Y2xhc3MgVGV4dHVyZU1hcHBlckxheWVyIDogcHVibGljIEdyYXBoaWNzTGF5ZXJBbmltYXRpb246 OkNsaWVudCB7CisgICAgV1RGX01BS0VfTk9OQ09QWUFCTEUoVGV4dHVyZU1hcHBlckxheWVyKTsK ICAgICBXVEZfTUFLRV9GQVNUX0FMTE9DQVRFRDsKIHB1YmxpYzoKICAgICAvLyBUaGlzIHNldCBv ZiBmbGFncyBoZWxwIHVzIGRlZmVyIHdoaWNoIHByb3BlcnRpZXMgb2YgdGhlIGxheWVyIGhhdmUg YmVlbgo=