105778 2012-12-26 15:21:23 -0800 REGRESSION(r138394): platform/mac/accessibility/file-upload-button-subrole.html is failing 2013-01-04 15:37:19 -0800 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 rniwa rniwa ap beidson cfleizach webkit-bug-importer webkit.review.bot oldest_to_newest 797392 0 rniwa 2012-12-26 15:21:23 -0800 http://trac.webkit.org/changeset/138394 @@ -621,5 +639,5 @@ /* accessibility role description for a file upload button */ -"file upload" = "file upload button"; +"file upload" = "file upload"; caused platform/mac/accessibility/file-upload-button-subrole.html to start failing. http://build.webkit.org/results/Apple%20Lion%20Release%20WK1%20(Tests)/r138484%20(7648)/platform/mac/accessibility/file-upload-button-subrole-pretty-diff.html 797394 1 rniwa 2012-12-26 15:23:18 -0800 Mountain Lion results: http://build.webkit.org/results/Apple%20MountainLion%20Release%20WK1%20(Tests)/r138484%20(5162)/results.html 797395 2 rniwa 2012-12-26 15:25:44 -0800 Added a test expectation in http://trac.webkit.org/changeset/138486. 797398 3 ap 2012-12-26 15:34:15 -0800 This part of the patch should be reverted. 797417 4 beidson 2012-12-26 16:44:49 -0800 From my comment over in 105592, https://bugs.webkit.org/show_bug.cgi?id=105592#c9 "That happened simply because I ran update-localizable-strings (or whatever it is actually called) which apparently nobody had done in awhile. If code changed that caused the generated string to be "file upload button" and that code was correct, then we should rebaseline. I have no idea how to explore that." Alexey, you say that part of the change should be reverted. How do you determine this? I ask because if someone reverted it then checked that in... then someone later came along and ran update-webkit-localizable-strings again, the same change would be generated. It seems if update-webkit-localizable-strings will always regenerate that change, yet that change is wrong, then either update-webkit-localizable-strings is broken or something in the code is broken. And whichever of those is broken should be fixed. 797639 5 ap 2012-12-27 12:06:46 -0800 > Alexey, you say that part of the change should be reverted. How do you determine this? Such a change would require review, not a rubber-stamp. Accessibility behavior changes should be discussed on their own merits, not be kept in the tree after an accidental commit by default. "file upload button" certainly sounds like a more appropriate plain English description for the button, if I were to guess about the rationale for existing behavior. I think that update-webkit-localizable-strings just always makes English key and value match, which wasn't the case before. You can use svn blame to determine when they were made different. Perhaps someone fixed the text in Localizable.strings without realizing that don't treat the file as authoritative. 800109 6 rniwa 2013-01-04 02:18:10 -0800 What are we going to do about this? 800647 7 cfleizach 2013-01-04 15:00:23 -0800 we should change the strings file to use "file upload button" = "file upload button"; 800673 8 181389 rniwa 2013-01-04 15:18:27 -0800 Created attachment 181389 Fixes the bug 800682 9 webkit.review.bot 2013-01-04 15:24:05 -0800 Attachment 181389 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/plat..." exit_code: 1 LayoutTests/ChangeLog:8: Line contains tab character. [whitespace/tab] [5] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 800684 10 181389 rniwa 2013-01-04 15:26:47 -0800 Comment on attachment 181389 Fixes the bug View in context: https://bugs.webkit.org/attachment.cgi?id=181389&action=review >> LayoutTests/ChangeLog:8 >> + Removed the old test expectations. > > Line contains tab character. [whitespace/tab] [5] Fixes this. Thanks for the review, Alexey. 800685 11 webkit-bug-importer 2013-01-04 15:27:54 -0800 <rdar://problem/12960393> 800692 12 rniwa 2013-01-04 15:37:19 -0800 Committed r138860: <http://trac.webkit.org/changeset/138860> 181389 2013-01-04 15:18:27 -0800 2013-01-04 15:26:47 -0800 Fixes the bug bug-105778-20130104151534.patch text/plain 3554 rniwa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEzODg1NykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDEzLTAxLTA0ICBSeW9zdWtl IE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIFJFR1JFU1NJT04ocjEzODM5NCk6 IHBsYXRmb3JtL21hYy9hY2Nlc3NpYmlsaXR5L2ZpbGUtdXBsb2FkLWJ1dHRvbi1zdWJyb2xlLmh0 bWwgaXMgZmFpbGluZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTA1Nzc4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgUmVuYW1lICJmaWxlIHVwbG9hZCIgdG8gImZpbGUgdXBsb2FkIGJ1dHRvbiIuCisKKyAg ICAgICAgKiBFbmdsaXNoLmxwcm9qL0xvY2FsaXphYmxlLnN0cmluZ3M6CisgICAgICAgICogcGxh dGZvcm0vTG9jYWxpemVkU3RyaW5ncy5jcHA6CisKIDIwMTMtMDEtMDQgIEFkYW0gQmFydGggIDxh YmFydGhAd2Via2l0Lm9yZz4KIAogICAgICAgICBIVE1MVHJlZUJ1aWxkZXIgc2hvdWxkIEFTU0VS VCB0aGF0IGl0IGlzIG9uIHRoZSBtYWluIHRocmVhZCBiZWZvcmUgdG91Y2hpbmcgZWxlbWVudHMK SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0VuZ2xpc2gubHByb2ovTG9jYWxpemFibGUuc3RyaW5ncwo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9FbmdsaXNoLmxwcm9qL0xvY2FsaXphYmxlLnN0 cmluZ3MJKHJldmlzaW9uIDEzODg1NCkKKysrIFNvdXJjZS9XZWJDb3JlL0VuZ2xpc2gubHByb2ov TG9jYWxpemFibGUuc3RyaW5ncwkod29ya2luZyBjb3B5KQpAQCAtNjM4LDcgKzYzOCw3IEBACiAA IgBmAGEAcwB0ACAAcgBlAHYAZQByAHMAZQAiACAAPQAgACIAZgBhAHMAdAAgAHIAZQB2AGUAcgBz AGUAIgA7AAogAAogAC8AKgAgAGEAYwBjAGUAcwBzAGkAYgBpAGwAaQB0AHkAIAByAG8AbABlACAA ZABlAHMAYwByAGkAcAB0AGkAbwBuACAAZgBvAHIAIABhACAAZgBpAGwAZQAgAHUAcABsAG8AYQBk ACAAYgB1AHQAdABvAG4AIAAqAC8ACi0AIgBmAGkAbABlACAAdQBwAGwAbwBhAGQAIgAgAD0AIAAi AGYAaQBsAGUAIAB1AHAAbABvAGEAZAAiADsACisAIgBmAGkAbABlACAAdQBwAGwAbwBhAGQAIABi AHUAdAB0AG8AbgAiACAAPQAgACIAZgBpAGwAZQAgAHUAcABsAG8AYQBkACAAYgB1AHQAdABvAG4A IgA7AAogAAogAC8AKgAgAGEAYwBjAGUAcwBzAGkAYgBpAGwAaQB0AHkAIAByAG8AbABlACAAZABl AHMAYwByAGkAcAB0AGkAbwBuACAAZgBvAHIAIABhACAAZgBvAG8AdABlAHIAIAAqAC8ACiAAIgBm AG8AbwB0AGUAcgAiACAAPQAgACIAZgBvAG8AdABlAHIAIgA7AApJbmRleDogU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vTG9jYWxpemVkU3RyaW5ncy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vTG9jYWxpemVkU3RyaW5ncy5jcHAJKHJldmlzaW9uIDEzODg1NCkKKysr IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL0xvY2FsaXplZFN0cmluZ3MuY3BwCSh3b3JraW5nIGNv cHkpCkBAIC01NzEsMTAgKzU3MSwxMCBAQCBTdHJpbmcgQVhGb290ZXJSb2xlRGVzY3JpcHRpb25U ZXh0KCkKIHsKICAgICByZXR1cm4gV0VCX1VJX1NUUklORygiZm9vdGVyIiwgImFjY2Vzc2liaWxp dHkgcm9sZSBkZXNjcmlwdGlvbiBmb3IgYSBmb290ZXIiKTsKIH0KLSAgICAKKwogU3RyaW5nIEFY RmlsZVVwbG9hZEJ1dHRvblRleHQoKQogewotICAgIHJldHVybiBXRUJfVUlfU1RSSU5HKCJmaWxl IHVwbG9hZCIsICJhY2Nlc3NpYmlsaXR5IHJvbGUgZGVzY3JpcHRpb24gZm9yIGEgZmlsZSB1cGxv YWQgYnV0dG9uIik7CisgICAgcmV0dXJuIFdFQl9VSV9TVFJJTkcoImZpbGUgdXBsb2FkIGJ1dHRv biIsICJhY2Nlc3NpYmlsaXR5IHJvbGUgZGVzY3JpcHRpb24gZm9yIGEgZmlsZSB1cGxvYWQgYnV0 dG9uIik7CiB9CiAKICNpZiBQTEFURk9STShNQUMpCkluZGV4OiBMYXlvdXRUZXN0cy9DaGFuZ2VM b2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiAxMzg4NTcp CisrKyBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNCBA QAorMjAxMy0wMS0wNCAgUnlvc3VrZSBOaXdhICA8cm5pd2FAd2Via2l0Lm9yZz4KKworICAgICAg ICBSRUdSRVNTSU9OKHIxMzgzOTQpOiBwbGF0Zm9ybS9tYWMvYWNjZXNzaWJpbGl0eS9maWxlLXVw bG9hZC1idXR0b24tc3Vicm9sZS5odG1sIGlzIGZhaWxpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNTc3OAorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisJUmVtb3ZlZCB0aGUgb2xkIHRlc3QgZXhwZWN0YXRpb25zLgor CisgICAgICAgICogcGxhdGZvcm0vbWFjL1Rlc3RFeHBlY3RhdGlvbnM6CisKIDIwMTMtMDEtMDQg IFJpY2sgQnllcnMgIDxyYnllcnNAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFVSTCBkdXBsaWNh dGlvbiBpbiBtb3VzZSBjdXJzb3IgdGVzdHMgbWVhbiBtaW5vciB0eXBvcyBjYW4gY2F1c2UgZmxh a2luZXNzCkluZGV4OiBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvVGVzdEV4cGVjdGF0aW9ucwo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvVGVzdEV4cGVjdGF0aW9ucwko cmV2aXNpb24gMTM4ODU0KQorKysgTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL1Rlc3RFeHBlY3Rh dGlvbnMJKHdvcmtpbmcgY29weSkKQEAgLTEyNjYsOCArMTI2Niw2IEBAIHdlYmtpdC5vcmcvYi8x MDU2MDMgaHR0cC90ZXN0cy9jb29raWVzL3MKIAogd2Via2l0Lm9yZy9iLzEwNTc3NyBwbGF0Zm9y bS9tYWMvZWRpdGluZy9zcGVsbGluZy9hdXRvY29ycmVjdGlvbi1pbi10ZXh0YXJlYS5odG1sIFsg RmFpbHVyZSBQYXNzIF0KIAotd2Via2l0Lm9yZy9iLzEwNTc3OCBwbGF0Zm9ybS9tYWMvYWNjZXNz aWJpbGl0eS9maWxlLXVwbG9hZC1idXR0b24tc3Vicm9sZS5odG1sIFsgRmFpbHVyZSBdCi0KIHdl YmtpdC5vcmcvYi8xMDU5MzIgWyBNb3VudGFpbkxpb24gRGVidWcgXSBodHRwL3Rlc3RzL2luc3Bl Y3Rvci9yZXNvdXJjZS1oYXItcGFnZXMuaHRtbCBbIENyYXNoIF0KIAogd2Via2l0Lm9yZy9iLzEw NTk4NiBbIERlYnVnIF0gdHJhbnNpdGlvbnMvaGFuZy13aXRoLWJhZC10cmFuc2l0aW9uLWxpc3Qu aHRtbCBbIFBhc3MgQ3Jhc2ggXQo=