105773 2012-12-26 10:53:24 -0800 [BlackBerry] Add support for JPEG image quality during encoding. 2013-04-24 07:09:42 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 staikos webkit-unassigned berto commit-queue rwlbuis oldest_to_newest 797350 0 staikos 2012-12-26 10:53:24 -0800 The quality flag was not being passed through for jpeg encoding of canvas to a data url. Add that. 878271 1 198814 berto 2013-04-19 00:01:24 -0700 Created attachment 198814 Patch You forgot to add the patch? 880467 2 198814 xan.lopez 2013-04-24 06:43:32 -0700 Comment on attachment 198814 Patch Berto and I had to look at https://bugs.webkit.org/show_bug.cgi?id=38492#c3 to figure why the parameter was a double* here, so perhaps it would be worth adding a comment or something. But looks sane otherwise. 880534 3 198814 commit-queue 2013-04-24 07:09:40 -0700 Comment on attachment 198814 Patch Clearing flags on attachment: 198814 Committed r149033: <http://trac.webkit.org/changeset/149033> 880535 4 commit-queue 2013-04-24 07:09:42 -0700 All reviewed patches have been landed. Closing bug. 198814 2013-04-19 00:01:24 -0700 2013-04-24 07:09:39 -0700 Patch 105773.diff text/plain 2856 berto ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBhOGI1NjFmLi42ZjcyYTFiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIg QEAKKzIwMTMtMDQtMTggIEdlb3JnZSBTdGFpa29zICA8Z3N0YWlrb3NAcmltLmNvbT4KKworICAg ICAgICBbQmxhY2tCZXJyeV0gQWRkIHN1cHBvcnQgZm9yIEpQRUcgaW1hZ2UgcXVhbGl0eSBkdXJp bmcgZW5jb2RpbmcuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xMDU3NzMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBQUiAyNzE2MTEKKyAgICAgICAgSW50ZXJuYWxseSByZXZpZXdlZCBieSBMaWFtIFF1aW5u LgorCisgICAgICAgIFBhc3MgdGhlIHF1YWxpdHkgZmxhZyBpbnRvIHRoZSBlbmNvZGVyLCB3aXRo IGEgZGVmYXVsdCBvZiA2NQorCisgICAgICAgIENvdmVyZWQgYnkgZXhpc3RpbmcgdGVzdHMuCisK KyAgICAgICAgKiBwbGF0Zm9ybS9pbWFnZS1lbmNvZGVycy9KUEVHSW1hZ2VFbmNvZGVyLmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OmNvbXByZXNzUkdCQUJpZ0VuZGlhblRvSlBFRyk6CisgICAgICAg ICogcGxhdGZvcm0vaW1hZ2UtZW5jb2RlcnMvSlBFR0ltYWdlRW5jb2Rlci5oOgorICAgICAgICAo V2ViQ29yZSk6CisKIDIwMTMtMDQtMTUgIEFsYmVydG8gR2FyY2lhICA8YWdhcmNpYUBpZ2FsaWEu Y29tPgogCiAgICAgICAgIFtCbGFja0JlcnJ5XSBVcHN0cmVhbSB0aGUgaW5wdXQgcG9wdXBzCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9pbWFnZS1lbmNvZGVycy9KUEVHSW1h Z2VFbmNvZGVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2ltYWdlLWVuY29kZXJzL0pQ RUdJbWFnZUVuY29kZXIuY3BwCmluZGV4IDc1MjY3ZWEuLmFjMTU3YjggMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2ltYWdlLWVuY29kZXJzL0pQRUdJbWFnZUVuY29kZXIuY3Bw CisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2ltYWdlLWVuY29kZXJzL0pQRUdJbWFnZUVu Y29kZXIuY3BwCkBAIC04Myw3ICs4Myw3IEBAIHN0YXRpYyB2b2lkIGpwZWdFcnJvckV4aXQoal9j b21tb25fcHRyIGNvbXByZXNzRGF0YSkKICAgICBsb25nam1wKGVyci0+bV9zZXRqbXBCdWZmZXIs IC0xKTsKIH0KIAotYm9vbCBjb21wcmVzc1JHQkFCaWdFbmRpYW5Ub0pQRUcodW5zaWduZWQgY2hh ciogcmdiYUJpZ0VuZGlhbkRhdGEsIGNvbnN0IEludFNpemUmIHNpemUsIFZlY3RvcjxjaGFyPiYg anBlZ0RhdGEpCitib29sIGNvbXByZXNzUkdCQUJpZ0VuZGlhblRvSlBFRyh1bnNpZ25lZCBjaGFy KiByZ2JhQmlnRW5kaWFuRGF0YSwgY29uc3QgSW50U2l6ZSYgc2l6ZSwgVmVjdG9yPGNoYXI+JiBq cGVnRGF0YSwgY29uc3QgZG91YmxlKiBxdWFsaXR5KQogewogICAgIHN0cnVjdCBqcGVnX2NvbXBy ZXNzX3N0cnVjdCBjb21wcmVzc0RhdGE7CiAgICAgSlBFR0NvbXByZXNzRXJyb3JNZ3IgZXJyOwpA QCAtMTAzLDcgKzEwMywxMCBAQCBib29sIGNvbXByZXNzUkdCQUJpZ0VuZGlhblRvSlBFRyh1bnNp Z25lZCBjaGFyKiByZ2JhQmlnRW5kaWFuRGF0YSwgY29uc3QgSW50U2l6ZQogICAgIGNvbXByZXNz RGF0YS5pbnB1dF9jb21wb25lbnRzID0gMzsKICAgICBjb21wcmVzc0RhdGEuaW5fY29sb3Jfc3Bh Y2UgPSBKQ1NfUkdCOwogICAgIGpwZWdfc2V0X2RlZmF1bHRzKCZjb21wcmVzc0RhdGEpOwotICAg IGpwZWdfc2V0X3F1YWxpdHkoJmNvbXByZXNzRGF0YSwgNjUsIEZBTFNFKTsKKyAgICBpbnQgY29t cHJlc3Npb25RdWFsaXR5ID0gNjU7CisgICAgaWYgKHF1YWxpdHkgJiYgKnF1YWxpdHkgPj0gMC4w ICYmICpxdWFsaXR5IDw9IDEuMCkKKyAgICAgICAgY29tcHJlc3Npb25RdWFsaXR5ID0gc3RhdGlj X2Nhc3Q8aW50PigqcXVhbGl0eSAqIDEwMCArIDAuNSk7CisgICAganBlZ19zZXRfcXVhbGl0eSgm Y29tcHJlc3NEYXRhLCBjb21wcmVzc2lvblF1YWxpdHksIEZBTFNFKTsKIAogICAgIC8vIHJvd0J1 ZmZlciBtdXN0IGJlIGRlZmluZWQgaGVyZSBzbyB0aGF0IGl0cyBkZXN0cnVjdG9yIGlzIGFsd2F5 cyBjYWxsZWQgZXZlbiB3aGVuICJzZXRqbXAiIGNhdGNoZXMgYW4gZXJyb3IuCiAgICAgVmVjdG9y PEpTQU1QTEUsIDYwMCAqIDM+IHJvd0J1ZmZlcjsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2ltYWdlLWVuY29kZXJzL0pQRUdJbWFnZUVuY29kZXIuaCBiL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2ltYWdlLWVuY29kZXJzL0pQRUdJbWFnZUVuY29kZXIuaAppbmRleCBhMzcz YzRmLi5iZjVhNjc2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9pbWFnZS1l bmNvZGVycy9KUEVHSW1hZ2VFbmNvZGVyLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v aW1hZ2UtZW5jb2RlcnMvSlBFR0ltYWdlRW5jb2Rlci5oCkBAIC0yNiw3ICsyNiw3IEBACiBuYW1l c3BhY2UgV2ViQ29yZSB7CiAKIGNsYXNzIEludFNpemU7Ci1ib29sIGNvbXByZXNzUkdCQUJpZ0Vu ZGlhblRvSlBFRyh1bnNpZ25lZCBjaGFyKiByZ2JhQmlnRW5kaWFuRGF0YSwgY29uc3QgSW50U2l6 ZSYgc2l6ZSwgVmVjdG9yPGNoYXI+JiBqcGVnRGF0YSk7Citib29sIGNvbXByZXNzUkdCQUJpZ0Vu ZGlhblRvSlBFRyh1bnNpZ25lZCBjaGFyKiByZ2JhQmlnRW5kaWFuRGF0YSwgY29uc3QgSW50U2l6 ZSYsIFZlY3RvcjxjaGFyPiYganBlZ0RhdGEsIGNvbnN0IGRvdWJsZSogcXVhbGl0eSA9IDApOwog CiB9CiAK