105770 2012-12-26 09:11:53 -0800 [AC] Memory leak in GraphicsSurfacePrivate::findFBConfigWithAlpha() 2013-01-02 03:26:11 -0800 1 1 1 Unclassified WebKit WebGL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 naginenis naginenis noam webkit.review.bot zeno oldest_to_newest 797324 0 naginenis 2012-12-26 09:11:53 -0800 Found a memory leak in GraphicsSurfacePrivate::findFBConfigWithAlpha(). ==21489== 14,720 bytes in 23 blocks are definitely lost in loss record 3,184 of 3,192 ==21489== at 0x4C2B6CD: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) ==21489== by 0xCB26915: XGetVisualInfo (in /usr/lib/x86_64-linux-gnu/libX11.so.6.3.0) ==21489== by 0xC8A72CE: glXGetVisualFromFBConfig (in /usr/lib/x86_64-linux-gnu/mesa/libGL.so.1.2) ==21489== by 0x9EF97F5: WebCore::GraphicsSurfacePrivate::findFBConfigWithAlpha(__GLXFBConfigRec**, int) (GraphicsSurfaceGLX.cpp:355) ==21489== by 0x9EF931E: WebCore::GraphicsSurfacePrivate::createPixmap(unsigned int) (GraphicsSurfaceGLX.cpp:249) ==21489== by 0x9EF970F: WebCore::GraphicsSurfacePrivate::glxPixmap() const (GraphicsSurfaceGLX.cpp:336) ==21489== by 0x9EF8382: WebCore::GraphicsSurface::platformGetTextureID() (GraphicsSurfaceGLX.cpp:419) ==21489== by 0x9EF85D0: WebCore::GraphicsSurface::platformSwapBuffers() (GraphicsSurfaceGLX.cpp:454) ==21489== by 0x9EF799B: WebCore::GraphicsSurface::swapBuffers() (GraphicsSurface.cpp:78) ==21489== by 0x9471B07: WebCore::TextureMapperSurfaceBackingStore::swapBuffersIfNeeded(unsigned int) (TextureMapperBackingStore.cpp:45) ==21489== by 0x56AC2C8: WebKit::LayerTreeRenderer::syncCanvas(unsigned int, unsigned int) (LayerTreeRenderer.cpp:252) We should free the XVisualInfo returned by glXGetVisualFromFBConfig() to avoid this leak. 797328 1 180753 naginenis 2012-12-26 09:34:15 -0800 Created attachment 180753 patch 798589 2 180753 webkit.review.bot 2013-01-02 02:45:55 -0800 Comment on attachment 180753 patch Rejecting attachment 180753 from commit-queue. Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', u'--status-host=queues.webkit.org', ..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue /mnt/git/webkit-commit-queue/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/15623657 798594 3 181019 naginenis 2013-01-02 03:04:14 -0800 Created attachment 181019 Patch for landing Updated the changelog. Thanks for reviewing! 798603 4 181019 webkit.review.bot 2013-01-02 03:26:07 -0800 Comment on attachment 181019 Patch for landing Clearing flags on attachment: 181019 Committed r138614: <http://trac.webkit.org/changeset/138614> 798604 5 webkit.review.bot 2013-01-02 03:26:11 -0800 All reviewed patches have been landed. Closing bug. 180753 2012-12-26 09:34:15 -0800 2013-01-02 03:04:14 -0800 patch 105770.patch text/plain 1446 naginenis ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAwODY4Yjg0Li42YmNiNWI3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTItMTItMjYgIFN1ZGFyc2FuYSBOYWdpbmVuaSAgPHN1ZGFyc2FuYS5uYWdpbmVuaUBp bnRlbC5jb20+CisKKyAgICAgICAgW0FDXSBNZW1vcnkgbGVhayBpbiBHcmFwaGljc1N1cmZhY2VQ cml2YXRlOjpmaW5kRkJDb25maWdXaXRoQWxwaGEoKQorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA1NzcwCisKKyAgICAgICAgRnJlZSB0aGUgbWVtb3J5 IHJldHVybmVkIGJ5IGdsWEdldFZpc3VhbEZyb21GQkNvbmZpZygpIHVzaW5nCisgICAgICAgIFhG cmVlIHRvIGF2b2lkIGEgbWVtb3J5IGxlYWsuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLiBObyBj aGFuZ2UgaW4gYmVoYXZpb3IuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9zdXJmYWNl cy9nbHgvR3JhcGhpY3NTdXJmYWNlR0xYLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkdyYXBoaWNz U3VyZmFjZVByaXZhdGU6OmZpbmRGQkNvbmZpZ1dpdGhBbHBoYSk6CisKIDIwMTItMTItMjYgIFl1 cnkgU2VtaWtoYXRza3kgIDx5dXJ5c0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgV2ViIEluc3Bl Y3RvcjogZXh0cmFjdCBKUyBoZWFwIHByb2ZpbGVyIHNwZWNpZmljcyBpbnRvIEpTSGVhcFNuYXBz aG90LmpzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9zdXJm YWNlcy9nbHgvR3JhcGhpY3NTdXJmYWNlR0xYLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL3N1cmZhY2VzL2dseC9HcmFwaGljc1N1cmZhY2VHTFguY3BwCmluZGV4IDM3MzIx OGMuLmZmY2Y4ODEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L3N1cmZhY2VzL2dseC9HcmFwaGljc1N1cmZhY2VHTFguY3BwCisrKyBiL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL3N1cmZhY2VzL2dseC9HcmFwaGljc1N1cmZhY2VHTFguY3BwCkBA IC0zNTcsNiArMzU3LDcgQEAgcHJpdmF0ZToKICAgICAgICAgICAgICAgICBjb250aW51ZTsKIAog ICAgICAgICAgICAgWFJlbmRlclBpY3RGb3JtYXQqIGZvcm1hdCA9IFhSZW5kZXJGaW5kVmlzdWFs Rm9ybWF0KG1fZGlzcGxheSwgdmlzdWFsSW5mby0+dmlzdWFsKTsKKyAgICAgICAgICAgIFhGcmVl KHZpc3VhbEluZm8pOwogICAgICAgICAgICAgaWYgKGZvcm1hdCAmJiBmb3JtYXQtPmRpcmVjdC5h bHBoYU1hc2sgPiAwKSB7CiAgICAgICAgICAgICAgICAgcmV0dXJuIGZiQ29uZmlnc1tpXTsKICAg ICAgICAgICAgICAgICBicmVhazsK 181019 2013-01-02 03:04:14 -0800 2013-01-02 03:26:07 -0800 Patch for landing 105770.patch text/plain 1466 naginenis ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA0ZWVkOTZjLi43MjcyNmRhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTgg QEAKKzIwMTMtMDEtMDIgIFN1ZGFyc2FuYSBOYWdpbmVuaSAgPHN1ZGFyc2FuYS5uYWdpbmVuaUBp bnRlbC5jb20+CisKKyAgICAgICAgW0FDXSBNZW1vcnkgbGVhayBpbiBHcmFwaGljc1N1cmZhY2VQ cml2YXRlOjpmaW5kRkJDb25maWdXaXRoQWxwaGEoKQorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA1NzcwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTm9h bSBSb3NlbnRoYWwuCisKKyAgICAgICAgRnJlZSB0aGUgbWVtb3J5IHJldHVybmVkIGJ5IGdsWEdl dFZpc3VhbEZyb21GQkNvbmZpZygpIHVzaW5nCisgICAgICAgIFhGcmVlIHRvIGF2b2lkIGEgbWVt b3J5IGxlYWsuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLiBObyBjaGFuZ2UgaW4gYmVoYXZpb3Iu CisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9zdXJmYWNlcy9nbHgvR3JhcGhpY3NTdXJm YWNlR0xYLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkdyYXBoaWNzU3VyZmFjZVByaXZhdGU6OmZp bmRGQkNvbmZpZ1dpdGhBbHBoYSk6CisKIDIwMTMtMDEtMDIgIE1pa2UgV2VzdCAgPG1rd3N0QGNo cm9taXVtLm9yZz4KIAogICAgICAgICBUaGUgJ2JvZHknIG9mIHNlYW1sZXNzIElGcmFtZXMgc2hv dWxkIGRlZmF1bHQgdG8gJ21hcmdpbjogMCcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL3N1cmZhY2VzL2dseC9HcmFwaGljc1N1cmZhY2VHTFguY3BwIGIvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvc3VyZmFjZXMvZ2x4L0dyYXBoaWNzU3VyZmFj ZUdMWC5jcHAKaW5kZXggMzczMjE4Yy4uZmZjZjg4MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3Mvc3VyZmFjZXMvZ2x4L0dyYXBoaWNzU3VyZmFjZUdMWC5jcHAK KysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvc3VyZmFjZXMvZ2x4L0dyYXBo aWNzU3VyZmFjZUdMWC5jcHAKQEAgLTM1Nyw2ICszNTcsNyBAQCBwcml2YXRlOgogICAgICAgICAg ICAgICAgIGNvbnRpbnVlOwogCiAgICAgICAgICAgICBYUmVuZGVyUGljdEZvcm1hdCogZm9ybWF0 ID0gWFJlbmRlckZpbmRWaXN1YWxGb3JtYXQobV9kaXNwbGF5LCB2aXN1YWxJbmZvLT52aXN1YWwp OworICAgICAgICAgICAgWEZyZWUodmlzdWFsSW5mbyk7CiAgICAgICAgICAgICBpZiAoZm9ybWF0 ICYmIGZvcm1hdC0+ZGlyZWN0LmFscGhhTWFzayA+IDApIHsKICAgICAgICAgICAgICAgICByZXR1 cm4gZmJDb25maWdzW2ldOwogICAgICAgICAgICAgICAgIGJyZWFrOwo=