105754 2012-12-25 22:09:18 -0800 Network item views for websocket is not consistent 2012-12-26 01:57:24 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 pan.deng webkit-unassigned apavlov keishi loislo pfeldman pmuellr toyoshim vsevik web-inspector-bugs webkit.review.bot yurys oldest_to_newest 797228 0 pan.deng 2012-12-25 22:09:18 -0800 (Originate from bug http://code.google.com/p/chromium/issues/detail?id=142280) Currently, network item views for websocket is not consistent, before receiving a websocket frame, there are " Headers, Preview, Response, and Cookies" after receiving a frame, typically there are "Headers, Frames", it is a little confusing. I agree that Preview and Response tab for websocket should be removed as they will be always blank. 797230 1 180728 pan.deng 2012-12-25 22:16:20 -0800 Created attachment 180728 Patch 797261 2 180728 webkit.review.bot 2012-12-26 01:57:20 -0800 Comment on attachment 180728 Patch Clearing flags on attachment: 180728 Committed r138473: <http://trac.webkit.org/changeset/138473> 797262 3 webkit.review.bot 2012-12-26 01:57:24 -0800 All reviewed patches have been landed. Closing bug. 180728 2012-12-25 22:16:20 -0800 2012-12-26 01:57:20 -0800 Patch bug-105754-20121226141934.patch text/plain 2640 pan.deng U3VidmVyc2lvbiBSZXZpc2lvbjogMTM4NDcxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjE4YjkxYTM5NTZkMmMx N2Y2NTVjZTNmZDI4NDRjM2QwZDdmMDI3ZS4uM2I1MzZiMWYyNzY5ZGNjMjc3YzE3MzIzOTc3MjMz YzQ0YzdlMjFhOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTEyLTI1ICBQYW4g RGVuZyAgPHBhbi5kZW5nQGludGVsLmNvbT4KKworICAgICAgICBbV2ViIEluc3BlY3Rvcl1SZW1v dmUgUHJldmlldyBhbmQgUmVzcG9uc2UgdGFiIGZyb20gbmV0d29yayBwYW5lbCBpbiBjYXNlIHdl YnNvY2tldC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTEwNTc1NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IE5ldHdvcmsgaXRlbSB2aWV3cyBmb3Igd2Vic29ja2V0IGlzIG5vdCBjb25zaXN0ZW50IGJlZm9y ZS9hZnRlciByZWNlaXZpbmcgYSBmcmFtZS4KKyAgICAgICAgVGhpcyBjaGFuZ2Uga2VlcHMgSGVh ZGVycywgRnJhbWVzIGFuZCBDb29raWVzIHRhYiBmb3Igd2Vic29ja2V0LgorCisgICAgICAgIE5v IG5ldyB0ZXN0cy4KKworICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQvTmV0d29ya0l0ZW1W aWV3LmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLk5ldHdvcmtJdGVtVmlldyk6CisKIDIwMTIt MTItMjUgIEpvaG4gR3JpZ2dzICA8amdyaWdnc0ByaW0uY29tPgogCiAgICAgICAgIFtCbGFja0Jl cnJ5XSBNZWRpYSBjb250cm9scyBhcmUgZHJhd24gb24gdG9wIG9mIG9uZSBhbm90aGVyIGZvciBt ZWRpYSB3aXRoIHVua25vd24gZHVyYXRpb24uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9p bnNwZWN0b3IvZnJvbnQtZW5kL05ldHdvcmtJdGVtVmlldy5qcyBiL1NvdXJjZS9XZWJDb3JlL2lu c3BlY3Rvci9mcm9udC1lbmQvTmV0d29ya0l0ZW1WaWV3LmpzCmluZGV4IDQ4ZDFiOGMyNzVhZTYy MTMwNGNlN2NmMTI0N2E5ZjVkOWI3NzEwMDUuLjBkYzc4M2IzMDNlMzVmYzUxODRkMjgwZDQ0YjUw ZmUwNTU5ZDI1MzQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1l bmQvTmV0d29ya0l0ZW1WaWV3LmpzCisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9u dC1lbmQvTmV0d29ya0l0ZW1WaWV3LmpzCkBAIC00MywxNyArNDMsMTYgQEAgV2ViSW5zcGVjdG9y Lk5ldHdvcmtJdGVtVmlldyA9IGZ1bmN0aW9uKHJlcXVlc3QpCiAKICAgICB0aGlzLmFkZEV2ZW50 TGlzdGVuZXIoV2ViSW5zcGVjdG9yLlRhYmJlZFBhbmUuRXZlbnRUeXBlcy5UYWJTZWxlY3RlZCwg dGhpcy5fdGFiU2VsZWN0ZWQsIHRoaXMpOwogCi0gICAgaWYgKHJlcXVlc3QuZnJhbWVzKCkubGVu Z3RoID4gMCkgeworICAgIGlmIChyZXF1ZXN0LnR5cGUgPT09IFdlYkluc3BlY3Rvci5yZXNvdXJj ZVR5cGVzLldlYlNvY2tldCkgewogICAgICAgICB2YXIgZnJhbWVWaWV3ID0gbmV3IFdlYkluc3Bl Y3Rvci5SZXNvdXJjZVdlYlNvY2tldEZyYW1lVmlldyhyZXF1ZXN0KTsKICAgICAgICAgdGhpcy5h cHBlbmRUYWIoIndlYlNvY2tldEZyYW1lcyIsIFdlYkluc3BlY3Rvci5VSVN0cmluZygiRnJhbWVz IiksIGZyYW1lVmlldyk7Ci0gICAgICAgIHJldHVybjsKKyAgICB9IGVsc2UgeworICAgICAgICB2 YXIgcmVzcG9uc2VWaWV3ID0gbmV3IFdlYkluc3BlY3Rvci5SZXF1ZXN0UmVzcG9uc2VWaWV3KHJl cXVlc3QpOworICAgICAgICB2YXIgcHJldmlld1ZpZXcgPSBuZXcgV2ViSW5zcGVjdG9yLlJlcXVl c3RQcmV2aWV3VmlldyhyZXF1ZXN0LCByZXNwb25zZVZpZXcpOworICAgICAgICB0aGlzLmFwcGVu ZFRhYigicHJldmlldyIsIFdlYkluc3BlY3Rvci5VSVN0cmluZygiUHJldmlldyIpLCBwcmV2aWV3 Vmlldyk7CisgICAgICAgIHRoaXMuYXBwZW5kVGFiKCJyZXNwb25zZSIsIFdlYkluc3BlY3Rvci5V SVN0cmluZygiUmVzcG9uc2UiKSwgcmVzcG9uc2VWaWV3KTsKICAgICB9CiAKLSAgICB2YXIgcmVz cG9uc2VWaWV3ID0gbmV3IFdlYkluc3BlY3Rvci5SZXF1ZXN0UmVzcG9uc2VWaWV3KHJlcXVlc3Qp OwotICAgIHZhciBwcmV2aWV3VmlldyA9IG5ldyBXZWJJbnNwZWN0b3IuUmVxdWVzdFByZXZpZXdW aWV3KHJlcXVlc3QsIHJlc3BvbnNlVmlldyk7Ci0gICAgdGhpcy5hcHBlbmRUYWIoInByZXZpZXci LCBXZWJJbnNwZWN0b3IuVUlTdHJpbmcoIlByZXZpZXciKSwgcHJldmlld1ZpZXcpOwotICAgIHRo aXMuYXBwZW5kVGFiKCJyZXNwb25zZSIsIFdlYkluc3BlY3Rvci5VSVN0cmluZygiUmVzcG9uc2Ui KSwgcmVzcG9uc2VWaWV3KTsKLQogICAgIGlmIChyZXF1ZXN0LnJlcXVlc3RDb29raWVzIHx8IHJl cXVlc3QucmVzcG9uc2VDb29raWVzKSB7CiAgICAgICAgIHRoaXMuX2Nvb2tpZXNWaWV3ID0gbmV3 IFdlYkluc3BlY3Rvci5SZXF1ZXN0Q29va2llc1ZpZXcocmVxdWVzdCk7CiAgICAgICAgIHRoaXMu YXBwZW5kVGFiKCJjb29raWVzIiwgV2ViSW5zcGVjdG9yLlVJU3RyaW5nKCJDb29raWVzIiksIHRo aXMuX2Nvb2tpZXNWaWV3KTsK