105753 2012-12-25 22:05:19 -0800 [CMAKE] Remove header files in JavaScriptCore/CMakeLists.txt 2012-12-25 23:26:02 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 gyuyoung.kim gyuyoung.kim laszlo.gombos paroga rakuco webkit.review.bot yong.li.webkit oldest_to_newest 797226 0 gyuyoung.kim 2012-12-25 22:05:19 -0800 CMakeLists.txt includes header files in source list. CMake doesn't need to include them. 797227 1 180727 gyuyoung.kim 2012-12-25 22:08:28 -0800 Created attachment 180727 Patch 797229 2 gyuyoung.kim 2012-12-25 22:10:01 -0800 CC'ing Laszlo, Patrick and Yong. 797231 3 laszlo.gombos 2012-12-25 22:20:11 -0800 Make sense, but I think there are more header files in the same file - e.g. profiler/ProfilerBytecode.h. Can you remove them all ? 797238 4 180730 gyuyoung.kim 2012-12-25 22:50:31 -0800 Created attachment 180730 Patch 797239 5 gyuyoung.kim 2012-12-25 22:51:13 -0800 (In reply to comment #3) > Make sense, but I think there are more header files in the same file - e.g. profiler/ProfilerBytecode.h. Can you remove them all ? Ah, I missed some header files. Patch is updated. 797240 6 180730 laszlo.gombos 2012-12-25 23:11:27 -0800 Comment on attachment 180730 Patch r=me. 797241 7 180730 webkit.review.bot 2012-12-25 23:25:57 -0800 Comment on attachment 180730 Patch Clearing flags on attachment: 180730 Committed r138472: <http://trac.webkit.org/changeset/138472> 797242 8 webkit.review.bot 2012-12-25 23:26:02 -0800 All reviewed patches have been landed. Closing bug. 180727 2012-12-25 22:08:28 -0800 2012-12-25 22:50:24 -0800 Patch bug-105753-20121226150540.patch text/plain 1352 gyuyoung.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMTM4NDcxCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAw ODJjMzM3MjA4YjBmMGMxZWU2ZTI5MWJmOGRjZThmYmM5ZjcwZDFjLi5mNDc3MjIxYjI4NTYyY2Nk NzE5NjlkNTliZDIwYzk3MTgxZmM5ZTM3IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMiBAQAorMjAxMi0xMi0yNSAgR3l1eW91bmcgS2ltICA8Z3l1eW91bmcua2ltQHNhbXN1 bmcuY29tPgorCisgICAgICAgIFtDTUFLRV0gUmVtb3ZlIGhlYWRlciBmaWxlcyBpbiBKYXZhU2Ny aXB0Q29yZS9DTWFrZUxpc3RzLnR4dAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTA1NzUzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgKiBDTWFrZUxpc3RzLnR4dDogUmVtb3ZlIGhlYWRlciBmaWxlcyBpbiBz b3VyY2UgbGlzdC4KKwogMjAxMi0xMi0yNSAgRmlsaXAgUGl6bG8gIDxmcGl6bG9AYXBwbGUuY29t PgogCiAgICAgICAgIEpJVFRodW5rcyBzaG91bGQgYmUgaW4gaXRzIG93biBmaWxlCmRpZmYgLS1n aXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ01ha2VMaXN0cy50eHQgYi9Tb3VyY2UvSmF2YVNj cmlwdENvcmUvQ01ha2VMaXN0cy50eHQKaW5kZXggNjllNGM3NzBkMTA5NGVmMzJkMzUzODRiYTRk NTJkOGFmOTMyODA0NC4uMTYxYzhlNTk2YTllODM2N2ZiMDRjZjFiMGY2YjhlZmJkNzJmYzExMCAx MDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0NNYWtlTGlzdHMudHh0CisrKyBiL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9DTWFrZUxpc3RzLnR4dApAQCAtMjY0LDExICsyNjQsOCBAQCBz ZXQoSmF2YVNjcmlwdENvcmVfU09VUkNFUwogICAgIHJ1bnRpbWUvTWF0aE9iamVjdC5jcHAKICAg ICBydW50aW1lL01lbW9yeVN0YXRpc3RpY3MuY3BwCiAgICAgcnVudGltZS9OYW1lQ29uc3RydWN0 b3IuY3BwCi0gICAgcnVudGltZS9OYW1lQ29uc3RydWN0b3IuaAogICAgIHJ1bnRpbWUvTmFtZUlu c3RhbmNlLmNwcAotICAgIHJ1bnRpbWUvTmFtZUluc3RhbmNlLmgKICAgICBydW50aW1lL05hbWVQ cm90b3R5cGUuY3BwCi0gICAgcnVudGltZS9OYW1lUHJvdG90eXBlLmgKICAgICBydW50aW1lL05h dGl2ZUVycm9yQ29uc3RydWN0b3IuY3BwCiAgICAgcnVudGltZS9OYXRpdmVFcnJvclByb3RvdHlw ZS5jcHAKICAgICBydW50aW1lL051bWJlckNvbnN0cnVjdG9yLmNwcAo= 180730 2012-12-25 22:50:31 -0800 2012-12-25 23:25:57 -0800 Patch bug-105753-20121226154742.patch text/plain 2223 gyuyoung.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMTM4NDcxCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAw ODJjMzM3MjA4YjBmMGMxZWU2ZTI5MWJmOGRjZThmYmM5ZjcwZDFjLi5mNDc3MjIxYjI4NTYyY2Nk NzE5NjlkNTliZDIwYzk3MTgxZmM5ZTM3IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMiBAQAorMjAxMi0xMi0yNSAgR3l1eW91bmcgS2ltICA8Z3l1eW91bmcua2ltQHNhbXN1 bmcuY29tPgorCisgICAgICAgIFtDTUFLRV0gUmVtb3ZlIGhlYWRlciBmaWxlcyBpbiBKYXZhU2Ny aXB0Q29yZS9DTWFrZUxpc3RzLnR4dAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTA1NzUzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgKiBDTWFrZUxpc3RzLnR4dDogUmVtb3ZlIGhlYWRlciBmaWxlcyBpbiBz b3VyY2UgbGlzdC4KKwogMjAxMi0xMi0yNSAgRmlsaXAgUGl6bG8gIDxmcGl6bG9AYXBwbGUuY29t PgogCiAgICAgICAgIEpJVFRodW5rcyBzaG91bGQgYmUgaW4gaXRzIG93biBmaWxlCmRpZmYgLS1n aXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ01ha2VMaXN0cy50eHQgYi9Tb3VyY2UvSmF2YVNj cmlwdENvcmUvQ01ha2VMaXN0cy50eHQKaW5kZXggNjllNGM3NzBkMTA5NGVmMzJkMzUzODRiYTRk NTJkOGFmOTMyODA0NC4uNjMyZTliNmU4NWMwNTBlMGIwYjBmNTZkMTJhMGE5Zjk1NjJkNThmYSAx MDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0NNYWtlTGlzdHMudHh0CisrKyBiL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9DTWFrZUxpc3RzLnR4dApAQCAtMTc3LDIzICsxNzcsMTQgQEAg c2V0KEphdmFTY3JpcHRDb3JlX1NPVVJDRVMKICAgICBwYXJzZXIvU291cmNlUHJvdmlkZXJDYWNo ZS5jcHAKIAogICAgIHByb2ZpbGVyL1Byb2ZpbGVyQnl0ZWNvZGUuY3BwCi0gICAgcHJvZmlsZXIv UHJvZmlsZXJCeXRlY29kZS5oCiAgICAgcHJvZmlsZXIvUHJvZmlsZXJCeXRlY29kZVNlcXVlbmNl LmNwcAogICAgIHByb2ZpbGVyL1Byb2ZpbGVyQnl0ZWNvZGVzLmNwcAotICAgIHByb2ZpbGVyL1By b2ZpbGVyQnl0ZWNvZGVzLmgKICAgICBwcm9maWxlci9Qcm9maWxlckNvbXBpbGF0aW9uLmNwcAot ICAgIHByb2ZpbGVyL1Byb2ZpbGVyQ29tcGlsYXRpb24uaAogICAgIHByb2ZpbGVyL1Byb2ZpbGVy Q29tcGlsYXRpb25LaW5kLmNwcAotICAgIHByb2ZpbGVyL1Byb2ZpbGVyQ29tcGlsYXRpb25LaW5k LmgKICAgICBwcm9maWxlci9Qcm9maWxlckNvbXBpbGVkQnl0ZWNvZGUuY3BwCi0gICAgcHJvZmls ZXIvUHJvZmlsZXJDb21waWxlZEJ5dGVjb2RlLmgKICAgICBwcm9maWxlci9Qcm9maWxlckRhdGFi YXNlLmNwcAotICAgIHByb2ZpbGVyL1Byb2ZpbGVyRGF0YWJhc2UuaAotICAgIHByb2ZpbGVyL1By b2ZpbGVyRXhlY3V0aW9uQ291bnRlci5oCiAgICAgcHJvZmlsZXIvUHJvZmlsZXJPcmlnaW4uY3Bw Ci0gICAgcHJvZmlsZXIvUHJvZmlsZXJPcmlnaW4uaAogICAgIHByb2ZpbGVyL1Byb2ZpbGVyT3Jp Z2luU3RhY2suY3BwCi0gICAgcHJvZmlsZXIvUHJvZmlsZXJPcmlnaW5TdGFjay5oCiAgICAgcHJv ZmlsZXIvUHJvZmlsZXJPU1JFeGl0LmNwcAogICAgIHByb2ZpbGVyL1Byb2ZpbGVyT1NSRXhpdFNp dGUuY3BwCiAgICAgcHJvZmlsZXIvUHJvZmlsZXJQcm9maWxlZEJ5dGVjb2Rlcy5jcHAKQEAgLTI2 NCwxMSArMjU1LDggQEAgc2V0KEphdmFTY3JpcHRDb3JlX1NPVVJDRVMKICAgICBydW50aW1lL01h dGhPYmplY3QuY3BwCiAgICAgcnVudGltZS9NZW1vcnlTdGF0aXN0aWNzLmNwcAogICAgIHJ1bnRp bWUvTmFtZUNvbnN0cnVjdG9yLmNwcAotICAgIHJ1bnRpbWUvTmFtZUNvbnN0cnVjdG9yLmgKICAg ICBydW50aW1lL05hbWVJbnN0YW5jZS5jcHAKLSAgICBydW50aW1lL05hbWVJbnN0YW5jZS5oCiAg ICAgcnVudGltZS9OYW1lUHJvdG90eXBlLmNwcAotICAgIHJ1bnRpbWUvTmFtZVByb3RvdHlwZS5o CiAgICAgcnVudGltZS9OYXRpdmVFcnJvckNvbnN0cnVjdG9yLmNwcAogICAgIHJ1bnRpbWUvTmF0 aXZlRXJyb3JQcm90b3R5cGUuY3BwCiAgICAgcnVudGltZS9OdW1iZXJDb25zdHJ1Y3Rvci5jcHAK