105745 2012-12-25 12:14:50 -0800 FindOptions exists in WebKit2 and WebCore with overlapping unrelated values 2012-12-25 12:14:50 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified NEW P2 Normal --- 1 thorton webkit-unassigned ap sam thorton oldest_to_newest 797172 0 thorton 2012-12-25 12:14:50 -0800 I'm also slightly concerned about the fact that we have WebKit::FindOptions and WebCore::FindOptions with overlapping unrelated values: In WebCore: enum FindOptionFlag { CaseInsensitive = 1 << 0, AtWordStarts = 1 << 1, // When combined with AtWordStarts, accepts a match in the middle of a word if the match begins with // an uppercase letter followed by a lowercase or non-letter. Accepts several other intra-word matches. TreatMedialCapitalAsWordStart = 1 << 2, Backwards = 1 << 3, WrapAround = 1 << 4, StartInSelection = 1 << 5 }; typedef unsigned FindOptions; In WebKit2: enum FindOptions { FindOptionsCaseInsensitive = 1 << 0, FindOptionsAtWordStarts = 1 << 1, FindOptionsTreatMedialCapitalAsWordStart = 1 << 2, FindOptionsBackwards = 1 << 3, FindOptionsWrapAround = 1 << 4, FindOptionsShowOverlay = 1 << 5, FindOptionsShowFindIndicator = 1 << 6, FindOptionsShowHighlight = 1 << 7 }; (Note that StartInSelection and ShowOverlay have the same value. A bit scary/unfortunate, probably not problematic.) Alexey thinks we should rename one of these -- I don't know which/what to use.