105743 2012-12-25 10:25:05 -0800 [GObject bindings] Wrap event target interface code in feature define guards if necessary 2013-05-07 01:45:52 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Gtk P2 Normal --- 1 zan zan abarth haraken japhet jdapena webkit.review.bot xan.lopez oldest_to_newest 797163 0 zan 2012-12-25 10:25:05 -0800 Like other binding method implementations, the event target interface code should be guarded by the feature define guards if present. This problem currently shows when building WebKitGTK+ with video track feature disabled. 797164 1 180714 zan 2012-12-25 10:35:47 -0800 Created attachment 180714 Patch 800100 2 xan.lopez 2013-01-04 02:02:47 -0800 Looks sane. No need to update the bindings tests after this? 800119 3 zan 2013-01-04 02:53:28 -0800 (In reply to comment #2) > Looks sane. No need to update the bindings tests after this? No, no tests are affected. I guess no event target behind a conditional is present in the bindings tests. 800139 4 180714 xan.lopez 2013-01-04 04:07:55 -0800 Comment on attachment 180714 Patch OK, let's do it. 800167 5 zan 2013-01-04 06:14:38 -0800 Committed r138793: <http://trac.webkit.org/changeset/138793> 885643 6 zan 2013-05-07 01:45:52 -0700 *** Bug 95937 has been marked as a duplicate of this bug. *** 180714 2012-12-25 10:35:47 -0800 2013-01-04 04:07:55 -0800 Patch bug-105743-20121225193301.patch text/plain 7400 zan U3VidmVyc2lvbiBSZXZpc2lvbjogMTM4NDQxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNWIyODIzYmI3OTk4YTk4 MWRhMDIxYjExNDc1M2M1NGJmZWRkZTg0Ny4uY2U5NGU4ZTEyMjRjNGEzMDY1Mzg1ZmI0NjU5N2Vi OThhNjM1YmE3NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEyLTEyLTI1ICBaYW4g RG9iZXJzZWsgIDx6YW5kb2JlcnNla0BnbWFpbC5jb20+CisKKyAgICAgICAgW0dPYmplY3QgYmlu ZGluZ3NdIFdyYXAgZXZlbnQgdGFyZ2V0IGludGVyZmFjZSBjb2RlIGluIGZlYXR1cmUgZGVmaW5l IGd1YXJkcyBpZiBuZWNlc3NhcnkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTEwNTc0MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIFdyYXAgdGhlIGV2ZW50IHRhcmdldCBpbnRlcmZhY2UgaW1wbGVtZW50YXRp b24gY29kZSBpbiBmZWF0dXJlIGRlZmluZSBndWFyZHMgaWYgdGhlIGludGVyZmFjZQorICAgICAg ICBpcyBndWFyZGVkIGJ5IGEgY29uZGl0aW9uYWwuIEEgd2FybmluZyBpcyByZXBvcnRlZCBpZiB0 aGVzZSBtZXRob2RzIGdldCBjYWxsZWQgd2l0aCB0aGUgc3BlY2lmaWMKKyAgICAgICAgZmVhdHVy ZSBiZWluZyBkaXNhYmxlZC4KKworICAgICAgICBUaGlzIHdhcyBzcG90dGVkIHdoZW4gYnVpbGRp bmcgd2l0aCB0aGUgdmlkZW8gdHJhY2sgZmVhdHVyZSBkaXNhYmxlZCB3YXMgY2F1c2luZyBidWls ZCBmYWlsdXJlcy4KKworICAgICAgICBObyBuZXcgdGVzdHMgLSBubyBuZXcgZnVuY3Rpb25hbGl0 eS4gVGhlIGJpbmRpbmdzIHRlc3RzIGRvbid0IHRlc3QgZXZlbnQgdGFyZ2V0cyB1bmRlciBjb25k aXRpb25hbHMuCisKKyAgICAgICAgKiBiaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JHT2Jq ZWN0LnBtOgorICAgICAgICAoR2VuZXJhdGVFdmVudFRhcmdldElmYWNlKToKKwogMjAxMi0xMi0y NCAgQW5kcmV5IEx1c2huaWtvdiAgPGx1c2huaWtvdkBjaHJvbWl1bS5jb20+CiAKICAgICAgICAg V2ViIEluc3BlY3RvcjogcmVmYWN0b3IgVGV4dEVkaXRvckhpZ2hsaWdodGVyJ3MgaGlnaGxpZ2h0 IGF0dHJpYnV0ZXMgdG8gZGVuc2UgYXJyYXkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Jp bmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvckdPYmplY3QucG0gYi9Tb3VyY2UvV2ViQ29yZS9i aW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JHT2JqZWN0LnBtCmluZGV4IDNkODQxMTU1ZDUw YzQxODAzNmUzY2MzYjc5Y2NkMmUwYmZjODMyNDIuLjFhODliOWU2Y2I5MDIxNDk4N2RkYjFkNzNk ZmRkYWFhMjY4Y2M3MDAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Njcmlw dHMvQ29kZUdlbmVyYXRvckdPYmplY3QucG0KKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mv c2NyaXB0cy9Db2RlR2VuZXJhdG9yR09iamVjdC5wbQpAQCAtMTI5NCw0NyArMTI5NCw0OCBAQCBz dWIgR2VuZXJhdGVFdmVudFRhcmdldElmYWNlIHsKIAogICAgIG15ICRpbnRlcmZhY2VOYW1lID0g JGludGVyZmFjZS0+bmFtZTsKICAgICBteSAkZGVjYW1lbGl6ZSA9IEZpeFVwRGVjYW1lbGl6ZWRO YW1lKGRlY2FtZWxpemUoJGludGVyZmFjZU5hbWUpKTsKKyAgICBteSAkY29uZGl0aW9uYWxTdHJp bmcgPSAkY29kZUdlbmVyYXRvci0+R2VuZXJhdGVDb25kaXRpb25hbFN0cmluZygkaW50ZXJmYWNl KTsKKyAgICBteSBAY29uZGl0aW9uYWxXYXJuID0gR2VuZXJhdGVDb25kaXRpb25hbFdhcm5pbmco JGludGVyZmFjZSk7CiAKICAgICAkaW1wbEluY2x1ZGVzeyJHT2JqZWN0RXZlbnRMaXN0ZW5lci5o In0gPSAxOwogICAgICRpbXBsSW5jbHVkZXN7IldlYktpdERPTUV2ZW50VGFyZ2V0LmgifSA9IDE7 CiAgICAgJGltcGxJbmNsdWRlc3siV2ViS2l0RE9NRXZlbnRQcml2YXRlLmgifSA9IDE7CiAKLSAg ICBteSAkaW1wbCA9IDw8ICJFT0YiOwotc3RhdGljIHZvaWQgd2Via2l0X2RvbV8ke2RlY2FtZWxp emV9X2Rpc3BhdGNoX2V2ZW50KFdlYktpdERPTUV2ZW50VGFyZ2V0KiB0YXJnZXQsIFdlYktpdERP TUV2ZW50KiBldmVudCwgR0Vycm9yKiogZXJyb3IpCi17Ci0gICAgV2ViQ29yZTo6RXZlbnQqIGNv cmVFdmVudCA9IFdlYktpdDo6Y29yZShldmVudCk7Ci0gICAgV2ViQ29yZTo6JHtpbnRlcmZhY2VO YW1lfSogY29yZVRhcmdldCA9IHN0YXRpY19jYXN0PFdlYkNvcmU6OiR7aW50ZXJmYWNlTmFtZX0q PihXRUJLSVRfRE9NX09CSkVDVCh0YXJnZXQpLT5jb3JlT2JqZWN0KTsKLQotICAgIFdlYkNvcmU6 OkV4Y2VwdGlvbkNvZGUgZWMgPSAwOwotICAgIGNvcmVUYXJnZXQtPmRpc3BhdGNoRXZlbnQoY29y ZUV2ZW50LCBlYyk7Ci0gICAgaWYgKGVjKSB7Ci0gICAgICAgIFdlYkNvcmU6OkV4Y2VwdGlvbkNv ZGVEZXNjcmlwdGlvbiBkZXNjcmlwdGlvbihlYyk7Ci0gICAgICAgIGdfc2V0X2Vycm9yX2xpdGVy YWwoZXJyb3IsIGdfcXVhcmtfZnJvbV9zdHJpbmcoIldFQktJVF9ET00iKSwgZGVzY3JpcHRpb24u Y29kZSwgZGVzY3JpcHRpb24ubmFtZSk7Ci0gICAgfQotfQotCi1zdGF0aWMgZ2Jvb2xlYW4gd2Vi a2l0X2RvbV8ke2RlY2FtZWxpemV9X2FkZF9ldmVudF9saXN0ZW5lcihXZWJLaXRET01FdmVudFRh cmdldCogdGFyZ2V0LCBjb25zdCBjaGFyKiBldmVudE5hbWUsIEdDYWxsYmFjayBoYW5kbGVyLCBn Ym9vbGVhbiBidWJibGUsIGdwb2ludGVyIHVzZXJEYXRhKQotewotICAgIFdlYkNvcmU6OiR7aW50 ZXJmYWNlTmFtZX0qIGNvcmVUYXJnZXQgPSBzdGF0aWNfY2FzdDxXZWJDb3JlOjoke2ludGVyZmFj ZU5hbWV9Kj4oV0VCS0lUX0RPTV9PQkpFQ1QodGFyZ2V0KS0+Y29yZU9iamVjdCk7Ci0gICAgcmV0 dXJuIFdlYkNvcmU6OkdPYmplY3RFdmVudExpc3RlbmVyOjphZGRFdmVudExpc3RlbmVyKEdfT0JK RUNUKHRhcmdldCksIGNvcmVUYXJnZXQsIGV2ZW50TmFtZSwgaGFuZGxlciwgYnViYmxlLCB1c2Vy RGF0YSk7Ci19Ci0KLXN0YXRpYyBnYm9vbGVhbiB3ZWJraXRfZG9tXyR7ZGVjYW1lbGl6ZX1fcmVt b3ZlX2V2ZW50X2xpc3RlbmVyKFdlYktpdERPTUV2ZW50VGFyZ2V0KiB0YXJnZXQsIGNvbnN0IGNo YXIqIGV2ZW50TmFtZSwgR0NhbGxiYWNrIGhhbmRsZXIsIGdib29sZWFuIGJ1YmJsZSkKLXsKLSAg ICBXZWJDb3JlOjoke2ludGVyZmFjZU5hbWV9KiBjb3JlVGFyZ2V0ID0gc3RhdGljX2Nhc3Q8V2Vi Q29yZTo6JHtpbnRlcmZhY2VOYW1lfSo+KFdFQktJVF9ET01fT0JKRUNUKHRhcmdldCktPmNvcmVP YmplY3QpOwotICAgIHJldHVybiBXZWJDb3JlOjpHT2JqZWN0RXZlbnRMaXN0ZW5lcjo6cmVtb3Zl RXZlbnRMaXN0ZW5lcihHX09CSkVDVCh0YXJnZXQpLCBjb3JlVGFyZ2V0LCBldmVudE5hbWUsIGhh bmRsZXIsIGJ1YmJsZSk7Ci19Ci0KLXN0YXRpYyB2b2lkIHdlYmtpdF9kb21fZXZlbnRfdGFyZ2V0 X2luaXQoV2ViS2l0RE9NRXZlbnRUYXJnZXRJZmFjZSogaWZhY2UpCi17Ci0gICAgaWZhY2UtPmRp c3BhdGNoX2V2ZW50ID0gd2Via2l0X2RvbV8ke2RlY2FtZWxpemV9X2Rpc3BhdGNoX2V2ZW50Owot ICAgIGlmYWNlLT5hZGRfZXZlbnRfbGlzdGVuZXIgPSB3ZWJraXRfZG9tXyR7ZGVjYW1lbGl6ZX1f YWRkX2V2ZW50X2xpc3RlbmVyOwotICAgIGlmYWNlLT5yZW1vdmVfZXZlbnRfbGlzdGVuZXIgPSB3 ZWJraXRfZG9tXyR7ZGVjYW1lbGl6ZX1fcmVtb3ZlX2V2ZW50X2xpc3RlbmVyOwotfQotCi1FT0YK LQotICAgIHB1c2goQGNCb2R5UHJvcGVydGllcywgJGltcGwpOworICAgIHB1c2goQGNCb2R5UHJv cGVydGllcywgInN0YXRpYyB2b2lkIHdlYmtpdF9kb21fJHtkZWNhbWVsaXplfV9kaXNwYXRjaF9l dmVudChXZWJLaXRET01FdmVudFRhcmdldCogdGFyZ2V0LCBXZWJLaXRET01FdmVudCogZXZlbnQs IEdFcnJvcioqIGVycm9yKVxue1xuIik7CisgICAgcHVzaChAY0JvZHlQcm9wZXJ0aWVzLCAiI2lm ICR7Y29uZGl0aW9uYWxTdHJpbmd9XG4iKSBpZiAkY29uZGl0aW9uYWxTdHJpbmc7CisgICAgcHVz aChAY0JvZHlQcm9wZXJ0aWVzLCAiICAgIFdlYkNvcmU6OkV2ZW50KiBjb3JlRXZlbnQgPSBXZWJL aXQ6OmNvcmUoZXZlbnQpO1xuIik7CisgICAgcHVzaChAY0JvZHlQcm9wZXJ0aWVzLCAiICAgIFdl YkNvcmU6OiR7aW50ZXJmYWNlTmFtZX0qIGNvcmVUYXJnZXQgPSBzdGF0aWNfY2FzdDxXZWJDb3Jl Ojoke2ludGVyZmFjZU5hbWV9Kj4oV0VCS0lUX0RPTV9PQkpFQ1QodGFyZ2V0KS0+Y29yZU9iamVj dCk7XG5cbiIpOworICAgIHB1c2goQGNCb2R5UHJvcGVydGllcywgIiAgICBXZWJDb3JlOjpFeGNl cHRpb25Db2RlIGVjID0gMDtcbiIpOworICAgIHB1c2goQGNCb2R5UHJvcGVydGllcywgIiAgICBj b3JlVGFyZ2V0LT5kaXNwYXRjaEV2ZW50KGNvcmVFdmVudCwgZWMpO1xuIik7CisgICAgcHVzaChA Y0JvZHlQcm9wZXJ0aWVzLCAiICAgIGlmIChlYykge1xuICAgICAgICBXZWJDb3JlOjpFeGNlcHRp b25Db2RlRGVzY3JpcHRpb24gZGVzY3JpcHRpb24oZWMpO1xuIik7CisgICAgcHVzaChAY0JvZHlQ cm9wZXJ0aWVzLCAiICAgICAgICBnX3NldF9lcnJvcl9saXRlcmFsKGVycm9yLCBnX3F1YXJrX2Zy b21fc3RyaW5nKFwiV0VCS0lUX0RPTVwiKSwgZGVzY3JpcHRpb24uY29kZSwgZGVzY3JpcHRpb24u bmFtZSk7XG4gICAgfVxuIik7CisgICAgcHVzaChAY0JvZHlQcm9wZXJ0aWVzLCAiI2Vsc2VcbiIp IGlmICRjb25kaXRpb25hbFN0cmluZzsKKyAgICBwdXNoKEBjQm9keVByb3BlcnRpZXMsIEBjb25k aXRpb25hbFdhcm4pIGlmIHNjYWxhcihAY29uZGl0aW9uYWxXYXJuKTsKKyAgICBwdXNoKEBjQm9k eVByb3BlcnRpZXMsICIjZW5kaWYgLy8gJHtjb25kaXRpb25hbFN0cmluZ31cbiIpIGlmICRjb25k aXRpb25hbFN0cmluZzsKKyAgICBwdXNoKEBjQm9keVByb3BlcnRpZXMsICJ9XG5cbiIpOworCisg ICAgcHVzaChAY0JvZHlQcm9wZXJ0aWVzLCAic3RhdGljIGdib29sZWFuIHdlYmtpdF9kb21fJHtk ZWNhbWVsaXplfV9hZGRfZXZlbnRfbGlzdGVuZXIoV2ViS2l0RE9NRXZlbnRUYXJnZXQqIHRhcmdl dCwgY29uc3QgY2hhciogZXZlbnROYW1lLCBHQ2FsbGJhY2sgaGFuZGxlciwgZ2Jvb2xlYW4gYnVi YmxlLCBncG9pbnRlciB1c2VyRGF0YSlcbntcbiIpOworICAgIHB1c2goQGNCb2R5UHJvcGVydGll cywgIiNpZiAke2NvbmRpdGlvbmFsU3RyaW5nfVxuIikgaWYgJGNvbmRpdGlvbmFsU3RyaW5nOwor ICAgIHB1c2goQGNCb2R5UHJvcGVydGllcywgIiAgICBXZWJDb3JlOjoke2ludGVyZmFjZU5hbWV9 KiBjb3JlVGFyZ2V0ID0gc3RhdGljX2Nhc3Q8V2ViQ29yZTo6JHtpbnRlcmZhY2VOYW1lfSo+KFdF QktJVF9ET01fT0JKRUNUKHRhcmdldCktPmNvcmVPYmplY3QpO1xuIik7CisgICAgcHVzaChAY0Jv ZHlQcm9wZXJ0aWVzLCAiICAgIHJldHVybiBXZWJDb3JlOjpHT2JqZWN0RXZlbnRMaXN0ZW5lcjo6 YWRkRXZlbnRMaXN0ZW5lcihHX09CSkVDVCh0YXJnZXQpLCBjb3JlVGFyZ2V0LCBldmVudE5hbWUs IGhhbmRsZXIsIGJ1YmJsZSwgdXNlckRhdGEpO1xuIik7CisgICAgcHVzaChAY0JvZHlQcm9wZXJ0 aWVzLCAiI2Vsc2VcbiIpIGlmICRjb25kaXRpb25hbFN0cmluZzsKKyAgICBwdXNoKEBjQm9keVBy b3BlcnRpZXMsIEBjb25kaXRpb25hbFdhcm4pIGlmIHNjYWxhcihAY29uZGl0aW9uYWxXYXJuKTsK KyAgICBwdXNoKEBjQm9keVByb3BlcnRpZXMsICIgICAgcmV0dXJuIGZhbHNlO1xuI2VuZGlmIC8v ICR7Y29uZGl0aW9uYWxTdHJpbmd9XG4iKSBpZiAkY29uZGl0aW9uYWxTdHJpbmc7CisgICAgcHVz aChAY0JvZHlQcm9wZXJ0aWVzLCAifVxuXG4iKTsKKworICAgIHB1c2goQGNCb2R5UHJvcGVydGll cywgInN0YXRpYyBnYm9vbGVhbiB3ZWJraXRfZG9tXyR7ZGVjYW1lbGl6ZX1fcmVtb3ZlX2V2ZW50 X2xpc3RlbmVyKFdlYktpdERPTUV2ZW50VGFyZ2V0KiB0YXJnZXQsIGNvbnN0IGNoYXIqIGV2ZW50 TmFtZSwgR0NhbGxiYWNrIGhhbmRsZXIsIGdib29sZWFuIGJ1YmJsZSlcbntcbiIpOworICAgIHB1 c2goQGNCb2R5UHJvcGVydGllcywgIiNpZiAke2NvbmRpdGlvbmFsU3RyaW5nfVxuIikgaWYgJGNv bmRpdGlvbmFsU3RyaW5nOworICAgIHB1c2goQGNCb2R5UHJvcGVydGllcywgIiAgICBXZWJDb3Jl Ojoke2ludGVyZmFjZU5hbWV9KiBjb3JlVGFyZ2V0ID0gc3RhdGljX2Nhc3Q8V2ViQ29yZTo6JHtp bnRlcmZhY2VOYW1lfSo+KFdFQktJVF9ET01fT0JKRUNUKHRhcmdldCktPmNvcmVPYmplY3QpO1xu Iik7CisgICAgcHVzaChAY0JvZHlQcm9wZXJ0aWVzLCAiICAgIHJldHVybiBXZWJDb3JlOjpHT2Jq ZWN0RXZlbnRMaXN0ZW5lcjo6cmVtb3ZlRXZlbnRMaXN0ZW5lcihHX09CSkVDVCh0YXJnZXQpLCBj b3JlVGFyZ2V0LCBldmVudE5hbWUsIGhhbmRsZXIsIGJ1YmJsZSk7XG4iKTsKKyAgICBwdXNoKEBj Qm9keVByb3BlcnRpZXMsICIjZWxzZVxuIikgaWYgJGNvbmRpdGlvbmFsU3RyaW5nOworICAgIHB1 c2goQGNCb2R5UHJvcGVydGllcywgQGNvbmRpdGlvbmFsV2FybikgaWYgc2NhbGFyKEBjb25kaXRp b25hbFdhcm4pOworICAgIHB1c2goQGNCb2R5UHJvcGVydGllcywgIiAgICByZXR1cm4gZmFsc2U7 XG4jZW5kaWYgLy8gJHtjb25kaXRpb25hbFN0cmluZ31cbiIpIGlmICRjb25kaXRpb25hbFN0cmlu ZzsKKyAgICBwdXNoKEBjQm9keVByb3BlcnRpZXMsICJ9XG5cbiIpOworCisgICAgcHVzaChAY0Jv ZHlQcm9wZXJ0aWVzLCAic3RhdGljIHZvaWQgd2Via2l0X2RvbV9ldmVudF90YXJnZXRfaW5pdChX ZWJLaXRET01FdmVudFRhcmdldElmYWNlKiBpZmFjZSlcbntcbiIpOworICAgIHB1c2goQGNCb2R5 UHJvcGVydGllcywgIiAgICBpZmFjZS0+ZGlzcGF0Y2hfZXZlbnQgPSB3ZWJraXRfZG9tXyR7ZGVj YW1lbGl6ZX1fZGlzcGF0Y2hfZXZlbnQ7XG4iKTsKKyAgICBwdXNoKEBjQm9keVByb3BlcnRpZXMs ICIgICAgaWZhY2UtPmFkZF9ldmVudF9saXN0ZW5lciA9IHdlYmtpdF9kb21fJHtkZWNhbWVsaXpl fV9hZGRfZXZlbnRfbGlzdGVuZXI7XG4iKTsKKyAgICBwdXNoKEBjQm9keVByb3BlcnRpZXMsICIg ICAgaWZhY2UtPnJlbW92ZV9ldmVudF9saXN0ZW5lciA9IHdlYmtpdF9kb21fJHtkZWNhbWVsaXpl fV9yZW1vdmVfZXZlbnRfbGlzdGVuZXI7XG59XG5cbiIpOwogCiAgICAgJGRlZmluZVR5cGVNYWNy byA9ICJHX0RFRklORV9UWVBFX1dJVEhfQ09ERSI7CiAgICAgJGRlZmluZVR5cGVJbnRlcmZhY2VJ bXBsZW1lbnRhdGlvbiA9ICIsIEdfSU1QTEVNRU5UX0lOVEVSRkFDRShXRUJLSVRfVFlQRV9ET01f RVZFTlRfVEFSR0VULCB3ZWJraXRfZG9tX2V2ZW50X3RhcmdldF9pbml0KSkiOwo=