105742 2012-12-25 10:20:18 -0800 Make the override-feature-defines script compatible with Python v3 2013-01-08 09:34:22 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 zan zan mrobinson oldest_to_newest 797161 0 zan 2012-12-25 10:20:18 -0800 Make the override-feature-defines script compatible with Python v3 797162 1 180713 zan 2012-12-25 10:22:42 -0800 Created attachment 180713 Patch 797436 2 180713 eric 2012-12-26 17:54:43 -0800 Comment on attachment 180713 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=180713&action=review > Tools/gtk/override-feature-defines:33 > + print("The following feature defines were overriden:\n{0}".format(', '.join(overriden_feature_defines))) Has the % operator been removed from py3? 797462 3 zan 2012-12-27 00:20:38 -0800 (In reply to comment #2) > (From update of attachment 180713 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=180713&action=review > > > Tools/gtk/override-feature-defines:33 > > + print("The following feature defines were overriden:\n{0}".format(', '.join(overriden_feature_defines))) > > Has the % operator been removed from py3? Not yet, but there were plans to deprecate and eventually remove it[1]. The plans might have changed since then, though[2]. The Advances String Formatting[3], supported since Python 2.6, is recommended (especially in Python 3). [1] http://docs.python.org/release/3.2.3/whatsnew/3.0.html#pep-3101-a-new-approach-to-string-formatting [2] http://www.mail-archive.com/django-developers@googlegroups.com/msg35057.html [3] http://www.python.org/dev/peps/pep-3101/ 802299 4 180713 zan 2013-01-08 09:34:15 -0800 Comment on attachment 180713 Patch Clearing flags on attachment: 180713 Committed r139065: <http://trac.webkit.org/changeset/139065> 802300 5 zan 2013-01-08 09:34:22 -0800 All reviewed patches have been landed. Closing bug. 180713 2012-12-25 10:22:42 -0800 2013-01-08 09:34:15 -0800 Patch bug-105742-20121225191955.patch text/plain 1456 zan SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDEzODQ2MykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE2IEBACisyMDEyLTEyLTI1ICBaYW4gRG9iZXJzZWsgIDx6YW5kb2JlcnNla0BnbWFpbC5j b20+CisKKyAgICAgICAgTWFrZSB0aGUgb3ZlcnJpZGUtZmVhdHVyZS1kZWZpbmVzIHNjcmlwdCBj b21wYXRpYmxlIHdpdGggUHl0aG9uIHYzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xMDU3NDIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBJbnN0ZWFkIG9mIHByaW50aW5nIG91dHB1dCB0aHJvdWdoIGEgc3Rh dGVtZW50LCB1c2UgdGhlIHByaW50IGZ1bmN0aW9uIGFuZCBmb3JtYXQKKyAgICAgICAgdGhlIG91 dHB1dCB1c2luZyB0aGUgc3RyLmZvcm1hdCBtZXRob2QuIFRoaXMgbWFrZXMgdGhlIHNjcmlwdCBy dW5uYWJsZSB3aXRoIFB5dGhvbiB2My4KKworICAgICAgICAqIGd0ay9vdmVycmlkZS1mZWF0dXJl LWRlZmluZXM6CisgICAgICAgIChhZGp1c3RfZmVhdHVyZV9kZWZpbmVzX21ha2VmaWxlKToKKwog MjAxMi0xMi0yNSAgQ2hyaXN0b3BoZSBEdW1leiAgPGNocmlzdG9waGUuZHVtZXpAaW50ZWwuY29t PgogCiAgICAgICAgIFtFRkxdW1dLMl0gUmVmYWN0b3Igc25hcHNob3QgdGFraW5nIGNvZGUKSW5k ZXg6IFRvb2xzL2d0ay9vdmVycmlkZS1mZWF0dXJlLWRlZmluZXMKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9v bHMvZ3RrL292ZXJyaWRlLWZlYXR1cmUtZGVmaW5lcwkocmV2aXNpb24gMTM4NDYzKQorKysgVG9v bHMvZ3RrL292ZXJyaWRlLWZlYXR1cmUtZGVmaW5lcwkod29ya2luZyBjb3B5KQpAQCAtMzAsNyAr MzAsNyBAQCBkZWYgYWRqdXN0X2ZlYXR1cmVfZGVmaW5lc19tYWtlZmlsZShidWlsCiAgICAgICAg IGYud3JpdGUoZmVhdHVyZV9kZWZpbmVzX21ha2VmaWxlKQogCiAgICAgaWYgb3ZlcnJpZGVuX2Zl YXR1cmVfZGVmaW5lczoKLSAgICAgICAgcHJpbnQgIlRoZSBmb2xsb3dpbmcgZmVhdHVyZSBkZWZp bmVzIHdlcmUgb3ZlcnJpZGVuOlxuJXMiICUgJywgJy5qb2luKG92ZXJyaWRlbl9mZWF0dXJlX2Rl ZmluZXMpCisgICAgICAgIHByaW50KCJUaGUgZm9sbG93aW5nIGZlYXR1cmUgZGVmaW5lcyB3ZXJl IG92ZXJyaWRlbjpcbnswfSIuZm9ybWF0KCcsICcuam9pbihvdmVycmlkZW5fZmVhdHVyZV9kZWZp bmVzKSkpCiAKIGRlZiBvdmVycmlkZV9mZWF0dXJlX2RlZmluZXMoYnVpbGRfZGlyKToKICAgICBj b3B5X2ZlYXR1cmVfZGVmaW5lc19tYWtlZmlsZSgpCg==