105737 2012-12-24 22:34:41 -0800 Memory instrumentation: provide a way to mark a node as a root 2012-12-24 23:42:23 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 yurys yurys apavlov benjamin keishi loislo ojan.autocc pfeldman pmuellr vsevik web-inspector-bugs webkit.review.bot yurys oldest_to_newest 797096 0 yurys 2012-12-24 22:34:41 -0800 Some objects are considered as roots while traversing native heap and there should be a way to mark them as such in the memory graph. 797098 1 180701 yurys 2012-12-24 22:48:50 -0800 Created attachment 180701 Patch 797099 2 180701 loislo 2012-12-24 22:58:53 -0800 Comment on attachment 180701 Patch looks good to me 797107 3 yurys 2012-12-24 23:42:23 -0800 Committed r138454: <http://trac.webkit.org/changeset/138454> 180701 2012-12-24 22:48:50 -0800 2012-12-24 23:03:39 -0800 Patch bug-105737-20121225104602.patch text/plain 7447 yurys U3VidmVyc2lvbiBSZXZpc2lvbjogMTM4NDQ5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDdmNjE0OWFiN2JlYTlkMmM3Y2Q0NjJk NjI1YjUwZTliMGQwMmFkNGMuLjU4YjAxZTc5OTAyOWM4YzRhOTVmYjJkOTViZWQ0OWJkMDljMTAx OWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMjUgQEAKKzIwMTItMTItMjQgIFl1cnkgU2VtaWtoYXRza3kgIDx5 dXJ5c0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgTWVtb3J5IGluc3RydW1lbnRhdGlvbjogcHJv dmlkZSBhIHdheSB0byBtYXJrIGEgbm9kZSBhcyBhIHJvb3QKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNTczNworCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE9iamVjdHMgYWRkZWQgdXNpbmcgTWVtb3J5SW5z dHJ1bWVudGF0aW9uOjphZGRSb290T2JqZWN0IHdpbGwgYmUgbWFya2VkIGFzIHJvb3RzLgorCisg ICAgICAgICogd3RmL01lbW9yeUluc3RydW1lbnRhdGlvbi5jcHA6CisgICAgICAgIChXVEY6Ok1l bW9yeUluc3RydW1lbnRhdGlvbjo6V3JhcHBlckJhc2U6OnByb2Nlc3MpOgorICAgICAgICAoV1RG KToKKyAgICAgICAgKFdURjo6TWVtb3J5SW5zdHJ1bWVudGF0aW9uOjpXcmFwcGVyQmFzZTo6cHJv Y2Vzc1BvaW50ZXIpOgorICAgICAgICAoV1RGOjpNZW1vcnlJbnN0cnVtZW50YXRpb246OldyYXBw ZXJCYXNlOjpwcm9jZXNzUm9vdE9iamVjdFJlZik6CisgICAgICAgICogd3RmL01lbW9yeUluc3Ry dW1lbnRhdGlvbi5oOgorICAgICAgICAoV3JhcHBlckJhc2UpOgorICAgICAgICAqIHd0Zi9NZW1v cnlPYmplY3RJbmZvLmg6IGFkZGVkIHJvb3QgbWFya2VyIHdoaWNoIGNhbiBiZSB1c2VkIGJ5IHRo ZSBoZWFwIGdyYXBoIGJ1aWxkZXIuCisgICAgICAgIChXVEY6Ok1lbW9yeU9iamVjdEluZm86Ok1l bW9yeU9iamVjdEluZm8pOgorICAgICAgICAoV1RGOjpNZW1vcnlPYmplY3RJbmZvOjppc1Jvb3Qp OgorICAgICAgICAoV1RGOjpNZW1vcnlPYmplY3RJbmZvOjptYXJrQXNSb290KToKKyAgICAgICAg KE1lbW9yeU9iamVjdEluZm8pOgorCiAyMDEyLTEyLTIxICBJbHlhIFRpa2hvbm92c2t5ICA8bG9p c2xvQGNocm9taXVtLm9yZz4KIAogICAgICAgICBVbnJldmlld2VkLiBBbm90aGVyIHRyeSB0byBm aXggQXBwbGUgV2luIFJlbGVhc2UgYnVpbGQuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggN2E5N2FiOTIwYTg2Nzhl YjUwMWUwYmQ5ZmM1ZGNmZGU3NmFjMTk3Yy4uZmIwYzlmOTE0YjNiOWVlYTIwMWJmOWFlZmJmMWFj YWEyZWFiYTgwMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEyLTEyLTI0ICBZdXJ5 IFNlbWlraGF0c2t5ICA8eXVyeXNAY2hyb21pdW0ub3JnPgorCisgICAgICAgIE1lbW9yeSBpbnN0 cnVtZW50YXRpb246IHByb3ZpZGUgYSB3YXkgdG8gbWFyayBhIG5vZGUgYXMgYSByb290CisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDU3MzcKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBFeHRlbmRlZCBIZWFw R3JhcGhTZXJpYWxpemVyIHRvIGFkZCBhIGZha2Ugcm9vdCBub2RlIHdpdGggZWRnZXMgdG8gYWxs CisgICAgICAgIHJlYWwgaW5zdHJ1bWVudGF0aW9uIHJvb3RzLgorCisgICAgICAgICogaW5zcGVj dG9yL0hlYXBHcmFwaFNlcmlhbGl6ZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SGVhcEdyYXBo U2VyaWFsaXplcjo6cmVwb3J0Tm9kZSk6CisgICAgICAgIChXZWJDb3JlOjpIZWFwR3JhcGhTZXJp YWxpemVyOjphZGRSb290Tm9kZSk6CisgICAgICAgIChXZWJDb3JlKToKKyAgICAgICAgKiBpbnNw ZWN0b3IvSGVhcEdyYXBoU2VyaWFsaXplci5oOgorICAgICAgICAoSGVhcEdyYXBoU2VyaWFsaXpl cik6CisKIDIwMTItMTItMjQgIExhc3psbyBHb21ib3MgIDxsLmdvbWJvc0BzYW1zdW5nLmNvbT4K IAogICAgICAgICBSZW1vdmUgd3RmL1BsYXRmb3JtLmggaW5jbHVkZXMgZnJvbSB7Y3xjcHB9IGZp bGVzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi9NZW1vcnlJbnN0cnVtZW50YXRpb24uY3Bw IGIvU291cmNlL1dURi93dGYvTWVtb3J5SW5zdHJ1bWVudGF0aW9uLmNwcAppbmRleCAzY2Y2YzAy YmZjODQ3NzA1Y2QzNzcxOTE4ZjMzMGE2MGUyODk3NmIyLi5iNTM4YTkxM2MzM2I4ZGFkMzkzNzA2 MTUzMzIxMGJiNzdiMWE2NTI3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi9NZW1vcnlJbnN0 cnVtZW50YXRpb24uY3BwCisrKyBiL1NvdXJjZS9XVEYvd3RmL01lbW9yeUluc3RydW1lbnRhdGlv bi5jcHAKQEAgLTg0LDcgKzg0LDE0IEBAIE1lbW9yeUluc3RydW1lbnRhdGlvbjo6V3JhcHBlckJh c2U6OldyYXBwZXJCYXNlKE1lbW9yeU9iamVjdFR5cGUgb2JqZWN0VHlwZSwgY29uCiAKIHZvaWQg TWVtb3J5SW5zdHJ1bWVudGF0aW9uOjpXcmFwcGVyQmFzZTo6cHJvY2VzcyhNZW1vcnlJbnN0cnVt ZW50YXRpb24qIG1lbW9yeUluc3RydW1lbnRhdGlvbikKIHsKKyAgICBwcm9jZXNzUG9pbnRlciht ZW1vcnlJbnN0cnVtZW50YXRpb24sIGZhbHNlKTsKK30KKwordm9pZCBNZW1vcnlJbnN0cnVtZW50 YXRpb246OldyYXBwZXJCYXNlOjpwcm9jZXNzUG9pbnRlcihNZW1vcnlJbnN0cnVtZW50YXRpb24q IG1lbW9yeUluc3RydW1lbnRhdGlvbiwgYm9vbCBpc1Jvb3QpCit7CiAgICAgTWVtb3J5T2JqZWN0 SW5mbyBtZW1vcnlPYmplY3RJbmZvKG1lbW9yeUluc3RydW1lbnRhdGlvbiwgbV9vd25lck9iamVj dFR5cGUsIG1fcG9pbnRlcik7CisgICAgaWYgKGlzUm9vdCkKKyAgICAgICAgbWVtb3J5T2JqZWN0 SW5mby5tYXJrQXNSb290KCk7CiAgICAgY2FsbFJlcG9ydE1lbW9yeVVzYWdlKCZtZW1vcnlPYmpl Y3RJbmZvKTsKIAogICAgIGNvbnN0IHZvaWQqIHJlYWxBZGRyZXNzID0gbWVtb3J5T2JqZWN0SW5m by5yZXBvcnRlZFBvaW50ZXIoKTsKQEAgLTEwNyw2ICsxMTQsNyBAQCB2b2lkIE1lbW9yeUluc3Ry dW1lbnRhdGlvbjo6V3JhcHBlckJhc2U6OnByb2Nlc3MoTWVtb3J5SW5zdHJ1bWVudGF0aW9uKiBt ZW1vcnlJbgogdm9pZCBNZW1vcnlJbnN0cnVtZW50YXRpb246OldyYXBwZXJCYXNlOjpwcm9jZXNz Um9vdE9iamVjdFJlZihNZW1vcnlJbnN0cnVtZW50YXRpb24qIG1lbW9yeUluc3RydW1lbnRhdGlv bikKIHsKICAgICBNZW1vcnlPYmplY3RJbmZvIG1lbW9yeU9iamVjdEluZm8obWVtb3J5SW5zdHJ1 bWVudGF0aW9uLCBtX293bmVyT2JqZWN0VHlwZSwgbV9wb2ludGVyKTsKKyAgICBtZW1vcnlPYmpl Y3RJbmZvLm1hcmtBc1Jvb3QoKTsKICAgICBjYWxsUmVwb3J0TWVtb3J5VXNhZ2UoJm1lbW9yeU9i amVjdEluZm8pOwogCiAgICAgQVNTRVJUKG1fcG9pbnRlciA9PSBtZW1vcnlPYmplY3RJbmZvLnJl cG9ydGVkUG9pbnRlcigpKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3RmL01lbW9yeUluc3Ry dW1lbnRhdGlvbi5oIGIvU291cmNlL1dURi93dGYvTWVtb3J5SW5zdHJ1bWVudGF0aW9uLmgKaW5k ZXggMGI5OTE1YjZmNTgwYmVlYjlhMWJkMDA2M2NmZmNiYTIzODlmNzFmMi4uZTAxYjViNWVlYjVk MzAxYTFlMGU1NjRjZTU3MjQ4NjY4OWRlOTZmZCAxMDA2NDQKLS0tIGEvU291cmNlL1dURi93dGYv TWVtb3J5SW5zdHJ1bWVudGF0aW9uLmgKKysrIGIvU291cmNlL1dURi93dGYvTWVtb3J5SW5zdHJ1 bWVudGF0aW9uLmgKQEAgLTg1LDYgKzg1LDcgQEAgcHJvdGVjdGVkOgogICAgICAgICBXVEZfRVhQ T1JUX1BSSVZBVEUgV3JhcHBlckJhc2UoTWVtb3J5T2JqZWN0VHlwZSwgY29uc3Qgdm9pZCogcG9p bnRlcik7CiAgICAgICAgIHZpcnR1YWwgfldyYXBwZXJCYXNlKCkgeyB9CiAgICAgICAgIFdURl9F WFBPUlRfUFJJVkFURSB2b2lkIHByb2Nlc3MoTWVtb3J5SW5zdHJ1bWVudGF0aW9uKik7CisgICAg ICAgIFdURl9FWFBPUlRfUFJJVkFURSB2b2lkIHByb2Nlc3NQb2ludGVyKE1lbW9yeUluc3RydW1l bnRhdGlvbiosIGJvb2wgaXNSb290KTsKICAgICAgICAgV1RGX0VYUE9SVF9QUklWQVRFIHZvaWQg cHJvY2Vzc1Jvb3RPYmplY3RSZWYoTWVtb3J5SW5zdHJ1bWVudGF0aW9uKik7CiAKICAgICBwcm90 ZWN0ZWQ6CkBAIC0xOTcsNyArMTk4LDcgQEAgcHJpdmF0ZToKICAgICAgICAgc3RhdGljIHZvaWQg YWRkUm9vdE9iamVjdChNZW1vcnlJbnN0cnVtZW50YXRpb24qIGluc3RydW1lbnRhdGlvbiwgY29u c3QgVCogY29uc3QmIHQsIE1lbW9yeU9iamVjdFR5cGUgb2JqZWN0VHlwZSkKICAgICAgICAgewog ICAgICAgICAgICAgaWYgKHQgJiYgIWluc3RydW1lbnRhdGlvbi0+dmlzaXRlZCh0KSkKLSAgICAg ICAgICAgICAgICBXcmFwcGVyPFQ+KHQsIG9iamVjdFR5cGUpLnByb2Nlc3MoaW5zdHJ1bWVudGF0 aW9uKTsKKyAgICAgICAgICAgICAgICBXcmFwcGVyPFQ+KHQsIG9iamVjdFR5cGUpLnByb2Nlc3NQ b2ludGVyKGluc3RydW1lbnRhdGlvbiwgdHJ1ZSk7CiAgICAgICAgIH0KICAgICB9OwogCmRpZmYg LS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi9NZW1vcnlPYmplY3RJbmZvLmggYi9Tb3VyY2UvV1RGL3d0 Zi9NZW1vcnlPYmplY3RJbmZvLmgKaW5kZXggY2YyNGI5YmRmZjI2ZWIxZmRhZGE0YzA5OWFlZWEz NTkyZDg3YjZlOS4uNWIxMzllN2M2ZjYyZGVhNjdmZDc0ODZlZDY0NGZhYzdiYzY3OGQ4NiAxMDA2 NDQKLS0tIGEvU291cmNlL1dURi93dGYvTWVtb3J5T2JqZWN0SW5mby5oCisrKyBiL1NvdXJjZS9X VEYvd3RmL01lbW9yeU9iamVjdEluZm8uaApAQCAtNTAsNiArNTAsNyBAQCBwdWJsaWM6CiAgICAg ICAgICwgbV9wb2ludGVyKHBvaW50ZXIpCiAgICAgICAgICwgbV9maXJzdFZpc2l0KHRydWUpCiAg ICAgICAgICwgbV9jdXN0b21BbGxvY2F0aW9uKGZhbHNlKQorICAgICAgICAsIG1faXNSb290KGZh bHNlKQogICAgIHsgfQogCiAgICAgdHlwZWRlZiBNZW1vcnlDbGFzc0luZm8gQ2xhc3NJbmZvOwpA QCAtNzMsNiArNzQsOCBAQCBwdWJsaWM6CiAgICAgICAgICAgICBtX25hbWUgPSBuYW1lOwogICAg IH0KICAgICBjb25zdCBTdHJpbmcmIG5hbWUoKSBjb25zdCB7IHJldHVybiBtX25hbWU7IH0KKyAg ICBib29sIGlzUm9vdCgpIGNvbnN0IHsgcmV0dXJuIG1faXNSb290OyB9CisgICAgdm9pZCBtYXJr QXNSb290KCkgeyBtX2lzUm9vdCA9IHRydWU7IH0KIAogICAgIE1lbW9yeUluc3RydW1lbnRhdGlv biogbWVtb3J5SW5zdHJ1bWVudGF0aW9uKCkgeyByZXR1cm4gbV9tZW1vcnlJbnN0cnVtZW50YXRp b247IH0KIApAQCAtOTgsNiArMTAxLDcgQEAgcHJpdmF0ZToKICAgICBjb25zdCB2b2lkKiBtX3Bv aW50ZXI7CiAgICAgYm9vbCBtX2ZpcnN0VmlzaXQ7CiAgICAgYm9vbCBtX2N1c3RvbUFsbG9jYXRp b247CisgICAgYm9vbCBtX2lzUm9vdDsKICAgICBTdHJpbmcgbV9jbGFzc05hbWU7CiAgICAgU3Ry aW5nIG1fbmFtZTsKIH07CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSGVh cEdyYXBoU2VyaWFsaXplci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSGVhcEdyYXBo U2VyaWFsaXplci5jcHAKaW5kZXggZTNlODBhNTdjNDY5OWNkMjk0ODQ0YjljODI2NmFmM2NlMzdk ZjA2Ny4uMWI0ZWY0YmMzYWE1ZGU1NzMxYTI3ODk3ODM5NzhlOTI2ZGRiNGU5NyAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0hlYXBHcmFwaFNlcmlhbGl6ZXIuY3BwCisrKyBi L1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9IZWFwR3JhcGhTZXJpYWxpemVyLmNwcApAQCAtMTAz LDYgKzEwMyw4IEBAIHZvaWQgSGVhcEdyYXBoU2VyaWFsaXplcjo6cmVwb3J0Tm9kZShjb25zdCBX VEY6Ok1lbW9yeU9iamVjdEluZm8mIGluZm8pCiAgICAgbV9sYXN0UmVwb3J0ZWRFZGdlSW5kZXgg PSBtX2VkZ2VzLnNpemUoKTsKIAogICAgIG1fb2JqZWN0VG9Ob2RlSW5kZXguc2V0KGluZm8ucmVw b3J0ZWRQb2ludGVyKCksIG1fbm9kZXMuc2l6ZSgpKTsKKyAgICBpZiAoaW5mby5pc1Jvb3QoKSkK KyAgICAgICAgbV9yb290cy5hcHBlbmQoaW5mby5yZXBvcnRlZFBvaW50ZXIoKSk7CiAgICAgbV9u b2Rlcy5hcHBlbmQobm9kZSk7CiB9CiAKQEAgLTE4OSw2ICsxOTEsMTcgQEAgaW50IEhlYXBHcmFw aFNlcmlhbGl6ZXI6OmFkZFN0cmluZyhjb25zdCBTdHJpbmcmIHN0cmluZykKICAgICByZXR1cm4g cmVzdWx0Lml0ZXJhdG9yLT52YWx1ZTsKIH0KIAordm9pZCBIZWFwR3JhcGhTZXJpYWxpemVyOjph ZGRSb290Tm9kZSgpCit7CisgICAgZm9yIChzaXplX3QgaSA9IDA7IGkgPCBtX3Jvb3RzLnNpemUo KTsgaSsrKQorICAgICAgICByZXBvcnRFZGdlKDAsIG1fcm9vdHNbaV0sIDApOworICAgIEhlYXBH cmFwaE5vZGUgbm9kZTsKKyAgICBub2RlLm1fbmFtZSA9IGFkZFN0cmluZygiUm9vdCIpOworICAg IG5vZGUubV9lZGdlQ291bnQgPSBtX2VkZ2VzLnNpemUoKSAtIG1fbGFzdFJlcG9ydGVkRWRnZUlu ZGV4OworICAgIG1fbGFzdFJlcG9ydGVkRWRnZUluZGV4ID0gbV9lZGdlcy5zaXplKCk7CisgICAg bV9ub2Rlcy5hcHBlbmQobm9kZSk7Cit9CisKIHZvaWQgSGVhcEdyYXBoU2VyaWFsaXplcjo6YWRq dXRFZGdlVGFyZ2V0cygpCiB7CiAgICAgZm9yIChzaXplX3QgaSA9IDA7IGkgPCBtX2VkZ2VzLnNp emUoKTsgaSsrKSB7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSGVhcEdy YXBoU2VyaWFsaXplci5oIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0hlYXBHcmFwaFNlcmlh bGl6ZXIuaAppbmRleCAzMTEwYTdmMzQ0YTliMTAwNWI2MzliYTZmYTkyY2RkNTE2NTY5OTFhLi5m MjNlODRjYTAyNWExMTc4MDMxMDAzZWIwOTE0MjJmMGU3Yjk5ZWFhIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9pbnNwZWN0b3IvSGVhcEdyYXBoU2VyaWFsaXplci5oCisrKyBiL1NvdXJjZS9X ZWJDb3JlL2luc3BlY3Rvci9IZWFwR3JhcGhTZXJpYWxpemVyLmgKQEAgLTYyLDYgKzYyLDcgQEAg cHVibGljOgogCiBwcml2YXRlOgogICAgIGludCBhZGRTdHJpbmcoY29uc3QgU3RyaW5nJik7Cisg ICAgdm9pZCBhZGRSb290Tm9kZSgpOwogICAgIHZvaWQgYWRqdXRFZGdlVGFyZ2V0cygpOwogCiAg ICAgdHlwZWRlZiBIYXNoTWFwPFN0cmluZywgaW50PiBTdHJpbmdNYXA7CkBAIC03Nyw2ICs3OCw3 IEBAIHByaXZhdGU6CiAKICAgICBWZWN0b3I8SGVhcEdyYXBoTm9kZT4gbV9ub2RlczsKICAgICBW ZWN0b3I8SGVhcEdyYXBoRWRnZT4gbV9lZGdlczsKKyAgICBWZWN0b3I8Y29uc3Qgdm9pZCo+IG1f cm9vdHM7CiB9OwogCiB9IC8vIG5hbWVzcGFjZSBXZWJDb3JlCg==