105732 2012-12-24 18:57:23 -0800 [chromium] DrawingBuffer initialization loop breaks if completely out of memory 2012-12-28 09:46:35 -0800 1 1 1 Unclassified WebKit WebGL 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 kbr bajones bajones dino gman ojan.autocc webkit.review.bot zmo oldest_to_newest 797074 0 kbr 2012-12-24 18:57:23 -0800 Brandon Jones discovered while debugging Issue 104733 and Issue 105367 that if s_currentResourceUsePixels is at the maximum, DrawingBuffer initialization will silently fail, and the WebGL context will silently display nothing. This behavior needs to be improved. At a minimum, context creation should probably report failure. 797635 1 180813 bajones 2012-12-27 11:54:10 -0800 Created attachment 180813 Patch 797925 2 180813 kbr 2012-12-28 09:21:10 -0800 Comment on attachment 180813 Patch Looks good, but how was this tested? 797926 3 bajones 2012-12-28 09:26:29 -0800 (In reply to comment #2) > (From update of attachment 180813 [details]) > Looks good, but how was this tested? Using a modification of the test page for Bug 105367. I'm working on a more straightforward test, but I wanted to make sure this patch was available before I took my parental leave. The biggest issue with creating a robust test is that javascript can't query s_maximumResourceUsePixels, so any test script we make will have to assume that the limit is 16Mb, etc. If we change that behavior at all (make the maximum a percentage of total VRAM, for example) then the test will fail. 797927 4 180813 kbr 2012-12-28 09:40:40 -0800 Comment on attachment 180813 Patch OK. Thanks for making this more robust. Let's continue to work on tests -- perhaps using window.internals or similar to do failure injection. r=me (I assume you wanted this committed.) 797928 5 180813 webkit.review.bot 2012-12-28 09:46:32 -0800 Comment on attachment 180813 Patch Clearing flags on attachment: 180813 Committed r138542: <http://trac.webkit.org/changeset/138542> 797929 6 webkit.review.bot 2012-12-28 09:46:35 -0800 All reviewed patches have been landed. Closing bug. 180813 2012-12-27 11:54:10 -0800 2012-12-28 09:46:32 -0800 Patch bug-105732-20121227115121.patch text/plain 2158 bajones U3VidmVyc2lvbiBSZXZpc2lvbjogMTM4NTA3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTI4MjRkZDI0YzAxNGI4 ODQ4N2RiMjE1NjcxYTQxMDEzNWVjOWQ4NC4uNjE1N2ZlM2YyZDM5Y2JiYmM3MDI0NDIwY2JmY2Ew YWU4NWQ5ZDZhOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTEyLTI3ICBCcmFu ZG9uIEpvbmVzICA8YmFqb25lc0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgW2Nocm9taXVtXSBE cmF3aW5nQnVmZmVyIGluaXRpYWxpemF0aW9uIGxvb3AgYnJlYWtzIGlmIGNvbXBsZXRlbHkgb3V0 IG9mIG1lbW9yeQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTA1NzMyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgV2hlbiBEcmF3aW5nQnVmZmVyIGFsbG9jYXRpb24gZmFpbHMgYmVjYXVzZSBzX2N1cnJlbnRS ZXNvdXJjZVVzZVBpeGVscyBpcyBtYXhlZCBvdXQKKyAgICAgICAgaXQgbm93IGZvcmNlcyBXZWJH TFJlbmRlcmluZ0NvbnRleHQgY3JlYXRpb24gdG8gZmFpbCBncmFjZWZ1bGx5LgorCisgICAgICAg ICogaHRtbC9jYW52YXMvV2ViR0xSZW5kZXJpbmdDb250ZXh0LmNwcDoKKyAgICAgICAgKFdlYkNv cmU6OldlYkdMUmVuZGVyaW5nQ29udGV4dDo6Y3JlYXRlKTogT24gQ2hyb21pdW0sIGNoZWNrIGZv ciBmYWlsdXJlIHRvIGFsbG9jYXRlIGEgRHJhd2luZ0J1ZmZlcgorCiAyMDEyLTEyLTI3ICBZdXJ5 IFNlbWlraGF0c2t5ICA8eXVyeXNAY2hyb21pdW0ub3JnPgogCiAgICAgICAgVW5yZXZpZXdlZC4g VXNlIHJlYWwgd29ya2VyIGluIGhlYXAgcHJvZmlsZXIgaW5zdGVhZCBvZiB0aGUgZmFrZSBvbmUK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvY2FudmFzL1dlYkdMUmVuZGVyaW5nQ29u dGV4dC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL2NhbnZhcy9XZWJHTFJlbmRlcmluZ0NvbnRl eHQuY3BwCmluZGV4IGRlMmUyMmUwODg4ODYyM2QxN2Y0NWJkODlkY2E4NTY3NmExZGMxNTAuLjJl MGU1MWIzMzllZjliN2QxNzkwNTAyMDU0ZmQyNDc5ZDcxOGM3YmYgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL2h0bWwvY2FudmFzL1dlYkdMUmVuZGVyaW5nQ29udGV4dC5jcHAKKysrIGIvU291 cmNlL1dlYkNvcmUvaHRtbC9jYW52YXMvV2ViR0xSZW5kZXJpbmdDb250ZXh0LmNwcApAQCAtNDM4 LDcgKzQzOCwxNiBAQCBQYXNzT3duUHRyPFdlYkdMUmVuZGVyaW5nQ29udGV4dD4gV2ViR0xSZW5k ZXJpbmdDb250ZXh0OjpjcmVhdGUoSFRNTENhbnZhc0VsZW1lbgogICAgIGlmIChleHRlbnNpb25z LT5zdXBwb3J0cygiR0xfRVhUX2RlYnVnX21hcmtlciIpKQogICAgICAgICBleHRlbnNpb25zLT5w dXNoR3JvdXBNYXJrZXJFWFQoIldlYkdMUmVuZGVyaW5nQ29udGV4dCIpOwogCi0gICAgcmV0dXJu IGFkb3B0UHRyKG5ldyBXZWJHTFJlbmRlcmluZ0NvbnRleHQoY2FudmFzLCBjb250ZXh0LCBhdHRy aWJ1dGVzKSk7CisgICAgT3duUHRyPFdlYkdMUmVuZGVyaW5nQ29udGV4dD4gcmVuZGVyaW5nQ29u dGV4dCA9IGFkb3B0UHRyKG5ldyBXZWJHTFJlbmRlcmluZ0NvbnRleHQoY2FudmFzLCBjb250ZXh0 LCBhdHRyaWJ1dGVzKSk7CisKKyNpZiBQTEFURk9STShDSFJPTUlVTSkKKyAgICBpZiAoIXJlbmRl cmluZ0NvbnRleHQtPm1fZHJhd2luZ0J1ZmZlcikgeworICAgICAgICBjYW52YXMtPmRpc3BhdGNo RXZlbnQoV2ViR0xDb250ZXh0RXZlbnQ6OmNyZWF0ZShldmVudE5hbWVzKCkud2ViZ2xjb250ZXh0 Y3JlYXRpb25lcnJvckV2ZW50LCBmYWxzZSwgdHJ1ZSwgIkNvdWxkIG5vdCBjcmVhdGUgYSBXZWJH TCBjb250ZXh0LiIpKTsKKyAgICAgICAgcmV0dXJuIG51bGxwdHI7CisgICAgfQorI2VuZGlmCisK KyAgICByZXR1cm4gcmVuZGVyaW5nQ29udGV4dC5yZWxlYXNlKCk7CiB9CiAKIFdlYkdMUmVuZGVy aW5nQ29udGV4dDo6V2ViR0xSZW5kZXJpbmdDb250ZXh0KEhUTUxDYW52YXNFbGVtZW50KiBwYXNz ZWRDYW52YXMsIFBhc3NSZWZQdHI8R3JhcGhpY3NDb250ZXh0M0Q+IGNvbnRleHQsCg==