105717 2012-12-24 05:44:19 -0800 [BlackBerry] Fix various RenderQueue bugs introduced by r138024 2012-12-24 06:04:27 -0800 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 staikos staikos jpetsovits mifenton rwlbuis tonikitoo webkit.review.bot yong.li.webkit oldest_to_newest 796961 0 staikos 2012-12-24 05:44:19 -0800 From Jakob: Scroll/zoom jobs were pretty solid, but I managed to leave some bugs in the region handling of RenderQueue's renderRegularRenderJobs() function, causing us to skip a desired blit or render operation in cases where the region and tile tracking did not match up. 796962 1 180666 staikos 2012-12-24 05:46:22 -0800 Created attachment 180666 Patch to delete a lot of the code and start unforking Jakob's patch, reviewed by me 796963 2 staikos 2012-12-24 05:51:18 -0800 (In reply to comment #1) > Created an attachment (id=180666) [details] > Patch to delete a lot of the code and start unforking > > Jakob's patch, reviewed by me lols to autocomplete.... 796964 3 180666 webkit.review.bot 2012-12-24 06:04:23 -0800 Comment on attachment 180666 Patch to delete a lot of the code and start unforking Clearing flags on attachment: 180666 Committed r138441: <http://trac.webkit.org/changeset/138441> 796965 4 webkit.review.bot 2012-12-24 06:04:27 -0800 All reviewed patches have been landed. Closing bug. 180666 2012-12-24 05:46:22 -0800 2012-12-24 06:04:22 -0800 Patch to delete a lot of the code and start unforking 105717.patch text/plain 3242 staikos SW5kZXg6IFNvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwkocmV2aXNpb24gMTM4NDQwKQorKysg U291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDIyIEBACisyMDEyLTEyLTIzICBKYWtvYiBQZXRzb3ZpdHMgIDxqcGV0c292aXRzQHJpbS5j b20+CisKKyAgICAgICAgW0JsYWNrQmVycnldIEZpeCB2YXJpb3VzIFJlbmRlclF1ZXVlIGJ1Z3Mg aW50cm9kdWNlZCBieSByMTM4MDI0LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTA1NzE3CisgICAgICAgIFJJTSBQUiAyNjkwMjkKKworICAgICAgICBS ZXZpZXdlZCBieSBHZW9yZ2UgU3RhaWtvcy4KKworICAgICAgICBTY3JvbGwvem9vbSBqb2JzIHdl cmUgcHJldHR5IHNvbGlkLCBidXQgSSBtYW5hZ2VkIHRvCisgICAgICAgIGxlYXZlIHNvbWUgYnVn cyBpbiB0aGUgcmVnaW9uIGhhbmRsaW5nIG9mIFJlbmRlclF1ZXVlJ3MKKyAgICAgICAgcmVuZGVy UmVndWxhclJlbmRlckpvYnMoKSBmdW5jdGlvbiwgY2F1c2luZyB1cyB0byBza2lwCisgICAgICAg IGEgZGVzaXJlZCBibGl0IG9yIHJlbmRlciBvcGVyYXRpb24gaW4gY2FzZXMgd2hlcmUgdGhlCisg ICAgICAgIHJlZ2lvbiBhbmQgdGlsZSB0cmFja2luZyBkaWQgbm90IG1hdGNoIHVwLgorCisgICAg ICAgIFRoaXMgY29tbWl0IGZpeGVzIHRoZXNlIGVycm9ycy4KKworICAgICAgICAqIFdlYktpdFN1 cHBvcnQvUmVuZGVyUXVldWUuY3BwOgorICAgICAgICAoQmxhY2tCZXJyeTo6V2ViS2l0OjpSZW5k ZXJRdWV1ZTo6cmVuZGVyUmVndWxhclJlbmRlckpvYnMpOgorCiAyMDEyLTEyLTI0ICBDaGFybGVz IFdlaSAgPGNoYXJsZXMud2VpQHRvcmNobW9iaWxlLmNvbS5jbj4KIAogICAgICAgICBbQmxhY2tC ZXJyeV0gQ2xvc2UgcGFnZSBwb3B1cCB3aGVuIGEgcGFnZSBiZWNvbWVzIGludmlzaWJsZS4KSW5k ZXg6IFNvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJLaXRTdXBwb3J0L1JlbmRlclF1ZXVlLmNw cAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViS2l0U3VwcG9ydC9S ZW5kZXJRdWV1ZS5jcHAJKHJldmlzaW9uIDEzODQ0MCkKKysrIFNvdXJjZS9XZWJLaXQvYmxhY2ti ZXJyeS9XZWJLaXRTdXBwb3J0L1JlbmRlclF1ZXVlLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNjI0 LDggKzYyNCwxMiBAQCB2b2lkIFJlbmRlclF1ZXVlOjpyZW5kZXJSZWd1bGFyUmVuZGVySm9iCiAg ICAgICAgIG1fcmVndWxhclJlbmRlckpvYnNSZWdpb24gPSBQbGF0Zm9ybTo6SW50UmVjdFJlZ2lv bjo6aW50ZXJzZWN0UmVnaW9ucyhtX3JlZ3VsYXJSZW5kZXJKb2JzUmVnaW9uLCBjb250ZW50c1Jl Y3QpOwogCiAgICAgICAgIC8vIFNwbGl0IHRoZSBjdXJyZW50IHJlZ3VsYXIgcmVuZGVyIGpvYiBy ZWdpb24gaW50byB0aWxlcy4KLSAgICAgICAgaWYgKCFzaG91bGREaXJlY3RSZW5kZXJpbmdUb1dp bmRvdykKKyAgICAgICAgaWYgKCFzaG91bGREaXJlY3RSZW5kZXJpbmdUb1dpbmRvdykgeworICAg ICAgICAgICAgLy8gRGlzY2FyZCByZWdpb25zIG91dHNpZGUgb2YgdGhlIHJlZ2lvbiBjb3ZlcmVk IGJ5IHRoZXNlIHRpbGVzLgorICAgICAgICAgICAgLy8gVGhleSdsbCBiZSByZW5kZXJlZCB3aGVu IHRoZSBnZW9tZXRyeSBjaGFuZ2VzLgorICAgICAgICAgICAgbV9yZWd1bGFyUmVuZGVySm9ic1Jl Z2lvbiA9IFBsYXRmb3JtOjpJbnRSZWN0UmVnaW9uOjppbnRlcnNlY3RSZWdpb25zKG1fcmVndWxh clJlbmRlckpvYnNSZWdpb24sIG1fcGFyZW50LT5mcm9udFN0YXRlKCktPmJhY2tpbmdTdG9yZVJl Y3QoKSk7CiAgICAgICAgICAgICBtX2N1cnJlbnRSZWd1bGFyUmVuZGVySm9ic0JhdGNoID0gdGls ZUluZGV4ZXNJbnRlcnNlY3RpbmdSZWdpb24obV9yZWd1bGFyUmVuZGVySm9ic1JlZ2lvbiwgbV9w YXJlbnQtPmZyb250U3RhdGUoKSk7CisgICAgICAgIH0KIAogICAgICAgICAvLyBDcmVhdGUgYSBy ZWdpb24gb2JqZWN0IHRoYXQgd2lsbCBiZSBjaGVja2VkIHdoZW4gYWRkaW5nIG5ldyByZWN0cyBi ZWZvcmUKICAgICAgICAgLy8gdGhpcyBiYXRjaCBoYXMgYmVlbiBjb21wbGV0ZWQuCkBAIC02ODks NyArNjkzLDcgQEAgdm9pZCBSZW5kZXJRdWV1ZTo6cmVuZGVyUmVndWxhclJlbmRlckpvYgogICAg ICAgICAgICAgICAgICAgICByZWdpb25Ob3RSZW5kZXJlZFRoaXNUaW1lID0gUGxhdGZvcm06Oklu dFJlY3RSZWdpb246OnVuaW9uUmVnaW9ucyhyZWdpb25Ob3RSZW5kZXJlZFRoaXNUaW1lLCB0aWxl UmVnaW9uTm90UmVuZGVyZWQpOwogICAgICAgICAgICAgICAgIH0KIAotICAgICAgICAgICAgICAg IGlmICghcmVnaW9uTm90UmVuZGVyZWRUaGlzVGltZS5pc0VtcHR5KCkpIHsKKyAgICAgICAgICAg ICAgICBpZiAoIXRpbGVSZWdpb25Ob3RSZW5kZXJlZC5pc0VtcHR5KCkpIHsKICNpZiBERUJVR19S RU5ERVJfUVVFVUUKICAgICAgICAgICAgICAgICAgICAgUGxhdGZvcm06OmxvZ0Fsd2F5cyhQbGF0 Zm9ybTo6TG9nTGV2ZWxDcml0aWNhbCwKICAgICAgICAgICAgICAgICAgICAgICAgICJSZW5kZXJR dWV1ZTo6cmVuZGVyUmVndWxhclJlbmRlckpvYnMgcmVnaW9uIHdpdGhpbiAlcyBub3QgY29tcGxl dGVseSByZW5kZXJlZCEiLApAQCAtNzQ2LDYgKzc1MCw3IEBAIHZvaWQgUmVuZGVyUXVldWU6OnJl bmRlclJlZ3VsYXJSZW5kZXJKb2IKICAgICB9CiAKICAgICBtX3JlZ3VsYXJSZW5kZXJKb2JzTm90 UmVuZGVyZWRSZWdpb24gPSBQbGF0Zm9ybTo6SW50UmVjdFJlZ2lvbjo6dW5pb25SZWdpb25zKG1f cmVndWxhclJlbmRlckpvYnNOb3RSZW5kZXJlZFJlZ2lvbiwgcmVnaW9uTm90UmVuZGVyZWRUaGlz VGltZSk7CisgICAgbV9jdXJyZW50UmVndWxhclJlbmRlckpvYnNCYXRjaFJlZ2lvbiA9IFBsYXRm b3JtOjpJbnRSZWN0UmVnaW9uOjpzdWJ0cmFjdFJlZ2lvbnMobV9jdXJyZW50UmVndWxhclJlbmRl ckpvYnNCYXRjaFJlZ2lvbiwgcmVnaW9uTm90UmVuZGVyZWRUaGlzVGltZSk7CiAKICNpZiBERUJV R19SRU5ERVJfUVVFVUUKICAgICAvLyBTdG9wIHRoZSB0aW1lIG1lYXN1cmVtZW50Lgo=