105708 2012-12-23 22:32:48 -0800 [BlackBerry] Set load state for popups manually in absence of a loader 2012-12-26 22:45:02 -0800 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 logingx jpetsovits jpetsovits manyoso mifenton rwlbuis staikos tonikitoo webkit.review.bot yong.li.webkit oldest_to_newest 796882 0 logingx 2012-12-23 22:32:48 -0800 as title 796883 1 180644 logingx 2012-12-23 22:42:46 -0800 Created attachment 180644 Patch 796886 2 180644 jpetsovits 2012-12-23 22:48:46 -0800 Comment on attachment 180644 Patch I understand that you came up with a similar patch, but if you take mine then please don't label the commit message under your name. Instead, add yourself underneath the reviewer line with "Internally reviewed by Chris Guan." 796972 3 180669 jpetsovits 2012-12-24 07:11:44 -0800 Created attachment 180669 Patch Merry Christmas! 797112 4 180669 charles.wei 2012-12-25 00:28:34 -0800 Comment on attachment 180669 Patch Looks good. Need a reviewer to approve it though. 797458 5 180669 webkit.review.bot 2012-12-26 22:44:59 -0800 Comment on attachment 180669 Patch Clearing flags on attachment: 180669 Committed r138490: <http://trac.webkit.org/changeset/138490> 797459 6 webkit.review.bot 2012-12-26 22:45:02 -0800 All reviewed patches have been landed. Closing bug. 180644 2012-12-23 22:42:46 -0800 2012-12-24 07:11:38 -0800 Patch bug-105708-20121224143958.patch text/plain 1992 logingx U3VidmVyc2lvbiBSZXZpc2lvbjogMTM4NDM0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpp bmRleCBhODdkZmI5ZmNjYzAxNDkwZWJkZDE0ODI3ZGY1Y2Y5YjQyYjg0ZjZiLi5kZWY2N2M0N2Nl ZmUwNWE5MTM2NWQ0MWU5YjllYjc0MDJlNDM5MGM3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwyNSBAQAorMjAxMi0xMi0yMyAgQ2hyaXMgR3VhbiAgPGNocmlzLmd1 YW5AdG9yY2htb2JpbGUuY29tLmNuPgorCisgICAgICAgIFtCbGFja0JlcnJ5XSBTZXQgbG9hZCBz dGF0ZSBmb3IgcG9wdXBzIG1hbnVhbGx5IGluIGFic2VuY2Ugb2YgYSBsb2FkZXIKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNTcwOAorICAgICAgICBS SU0gYnVnIyAyNTcyMTYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBUaGUgV2ViUGFnZSBjbGFzcyByZWxpZXMgb24gdGhlIGxvYWQgc3RhdGUgZm9yIHZh cmlvdXMgdGhpbmdzLAorICAgICAgICBhbW9uZyBvdGhlcnMgaXQgd2lsbCBvbmx5IGVtaXQgY29u dGVudHMgc2l6ZSBjaGFuZ2VzIGFmdGVyCisgICAgICAgIGxheW91dHMgaWYgYSBsb2FkIHN0YXRl IG90aGVyIHRoYW4gTm9uZSBpcyBzZXQuCisKKyAgICAgICAgR2l2ZW4gdGhhdCBwb3B1cHMgd3Jp dGUgdGhlIHdlYiBwYWdlIGNvbnRlbnQgaXRzZWxmIHdpdGggbm8KKyAgICAgICAgbG9hZGVyIHRo YXQgd291bGQgaXNzdWUgc3VjaCBub3RpZmljYXRpb25zLCB0aGUgbG9hZCBzdGF0ZQorICAgICAg ICBzaG91bGQgcHJvYmFibHkganVzdCBiZSBzZXQgbWFudWFsbHkgaW4gdGhpcyBjYXNlLgorCisg ICAgICAgIFRoaXMgcGF0Y2ggaXMgZnJvbSBKYWtvYiwgSSBhZ3JlZSB3aXRoIGhpbSBhbmQgSSBJ bnRlcm5hbGx5IAorICAgICAgICByZXZpZXdlZCBpdC4KKworICAgICAgICAqIFdlYkNvcmVTdXBw b3J0L1BhZ2VQb3B1cEJsYWNrQmVycnkuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UGFnZVBvcHVw QmxhY2tCZXJyeTo6aW5pdCk6CisKIDIwMTItMTItMjMgIE1hcnkgV3UgIDxtYXJ5Lnd1QHRvcmNo bW9iaWxlLmNvbS5jbj4KIAogICAgICAgICBbQmxhY2tCZXJyeV0gZ2l2ZSB1cmwgd2hlbiBjcmVh dGVXaW5kb3cKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJDb3JlU3Vw cG9ydC9QYWdlUG9wdXBCbGFja0JlcnJ5LmNwcCBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9X ZWJDb3JlU3VwcG9ydC9QYWdlUG9wdXBCbGFja0JlcnJ5LmNwcAppbmRleCA3OTkxMjkxY2VlYTY5 M2FkZjM0OWY1NDYyODFkMmRkYzljZmY4OGIxLi4wZGU0MTNkOTkyNzkxYzdkMmM3YzViNTcxMjEw OTlhY2NlMjIwYjhkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViQ29y ZVN1cHBvcnQvUGFnZVBvcHVwQmxhY2tCZXJyeS5jcHAKKysrIGIvU291cmNlL1dlYktpdC9ibGFj a2JlcnJ5L1dlYkNvcmVTdXBwb3J0L1BhZ2VQb3B1cEJsYWNrQmVycnkuY3BwCkBAIC02Nyw5ICs2 NywxMCBAQCBib29sIFBhZ2VQb3B1cEJsYWNrQmVycnk6OnNlbmRDcmVhdGVQb3B1cFdlYlZpZXdS ZXF1ZXN0KCkKIAogYm9vbCBQYWdlUG9wdXBCbGFja0JlcnJ5Ojppbml0KFdlYlBhZ2UqIHdlYnBh Z2UpCiB7CisgICAgd2VicGFnZS0+ZC0+c2V0TG9hZFN0YXRlKFdlYlBhZ2VQcml2YXRlOjpDb21t aXR0ZWQpOwogICAgIGdlbmVyYXRlSFRNTCh3ZWJwYWdlKTsKLQogICAgIGluc3RhbGxET01GdW5j dGlvbih3ZWJwYWdlLT5kLT5tYWluRnJhbWUoKSk7CisgICAgd2VicGFnZS0+ZC0+c2V0TG9hZFN0 YXRlKFdlYlBhZ2VQcml2YXRlOjpGaW5pc2hlZCk7CiAKICAgICByZXR1cm4gdHJ1ZTsKIH0K 180669 2012-12-24 07:11:44 -0800 2012-12-26 22:44:59 -0800 Patch bug-105708-20121224100857.patch text/plain 1992 jpetsovits U3VidmVyc2lvbiBSZXZpc2lvbjogMTM4NDQxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpp bmRleCBhNWUyOWNhMWQ1MGE1YWNmMjM3NTZmMThiZjg5ZTEyMTlkOTliZWRhLi4wYWY3ZjFlYWE1 NTVhNzg1YzdjMWJlMjU1ZTg3ZTQ2ZDg5Y2VlOGIxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwyMyBAQAorMjAxMi0xMi0yMyAgSmFrb2IgUGV0c292aXRzICA8anBl dHNvdml0c0ByaW0uY29tPgorCisgICAgICAgIFtCbGFja0JlcnJ5XSBTZXQgbG9hZCBzdGF0ZSBm b3IgcG9wdXBzIG1hbnVhbGx5LCBpbiBhYnNlbmNlIG9mIGEgbG9hZGVyLgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA1NzA4CisgICAgICAgIFJJTSBQ UiAyNTcyMTYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKyAgICAgICAg SW50ZXJuYWxseSByZXZpZXdlZCBieSBDaHJpcyBHdWFuLgorCisgICAgICAgIFRoZSBXZWJQYWdl IGNsYXNzIHJlbGllcyBvbiB0aGUgbG9hZCBzdGF0ZSBmb3IgdmFyaW91cyB0aGluZ3MsCisgICAg ICAgIGFtb25nIG90aGVycyBpdCB3aWxsIG9ubHkgZW1pdCBjb250ZW50cyBzaXplIGNoYW5nZXMg YWZ0ZXIKKyAgICAgICAgbGF5b3V0cyBpZiBhIGxvYWQgc3RhdGUgb3RoZXIgdGhhbiBOb25lIGlz IHNldC4KKworICAgICAgICBHaXZlbiB0aGF0IHBvcHVwcyB3cml0ZSB0aGUgd2ViIHBhZ2UgY29u dGVudCBpdHNlbGYgd2l0aCBubworICAgICAgICBsb2FkZXIgdGhhdCB3b3VsZCBpc3N1ZSBzdWNo IG5vdGlmaWNhdGlvbnMsIHRoZSBsb2FkIHN0YXRlCisgICAgICAgIHNob3VsZCBwcm9iYWJseSBq dXN0IGJlIHNldCBtYW51YWxseSBpbiB0aGlzIGNhc2UuCisKKyAgICAgICAgKiBXZWJDb3JlU3Vw cG9ydC9QYWdlUG9wdXBCbGFja0JlcnJ5LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlBhZ2VQb3B1 cEJsYWNrQmVycnk6OmluaXQpOgorCiAyMDEyLTEyLTI0ICBKYWtvYiBQZXRzb3ZpdHMgIDxqcGV0 c292aXRzQHJpbS5jb20+CiAKICAgICAgICAgW0JsYWNrQmVycnldIEZpeCB2YXJpb3VzIFJlbmRl clF1ZXVlIGJ1Z3MgaW50cm9kdWNlZCBieSByMTM4MDI0LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YktpdC9ibGFja2JlcnJ5L1dlYkNvcmVTdXBwb3J0L1BhZ2VQb3B1cEJsYWNrQmVycnkuY3BwIGIv U291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYkNvcmVTdXBwb3J0L1BhZ2VQb3B1cEJsYWNrQmVy cnkuY3BwCmluZGV4IDc5OTEyOTFjZWVhNjkzYWRmMzQ5ZjU0NjI4MWQyZGRjOWNmZjg4YjEuLjk3 YjFiYzlhNGViZmIwYzQ4OGEwMzg2MjA2ZWYwYjZiNzlkMTU0ZmUgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJDb3JlU3VwcG9ydC9QYWdlUG9wdXBCbGFja0JlcnJ5LmNw cAorKysgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViQ29yZVN1cHBvcnQvUGFnZVBvcHVw QmxhY2tCZXJyeS5jcHAKQEAgLTY3LDEwICs2NywxMiBAQCBib29sIFBhZ2VQb3B1cEJsYWNrQmVy cnk6OnNlbmRDcmVhdGVQb3B1cFdlYlZpZXdSZXF1ZXN0KCkKIAogYm9vbCBQYWdlUG9wdXBCbGFj a0JlcnJ5Ojppbml0KFdlYlBhZ2UqIHdlYnBhZ2UpCiB7Ci0gICAgZ2VuZXJhdGVIVE1MKHdlYnBh Z2UpOworICAgIHdlYnBhZ2UtPmQtPnNldExvYWRTdGF0ZShXZWJQYWdlUHJpdmF0ZTo6Q29tbWl0 dGVkKTsKIAorICAgIGdlbmVyYXRlSFRNTCh3ZWJwYWdlKTsKICAgICBpbnN0YWxsRE9NRnVuY3Rp b24od2VicGFnZS0+ZC0+bWFpbkZyYW1lKCkpOwogCisgICAgd2VicGFnZS0+ZC0+c2V0TG9hZFN0 YXRlKFdlYlBhZ2VQcml2YXRlOjpGaW5pc2hlZCk7CiAgICAgcmV0dXJuIHRydWU7CiB9CiAK