105683 2012-12-22 21:43:44 -0800 [Qt] Remove misspelled ENABLE(SPEECH_INPUT) guard 2013-01-29 03:33:48 -0800 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Qt P2 Normal --- 1 laszlo.gombos webkit-unassigned abecsi allan.jensen cmarcelo hausmann kbalazs menard ossy webkit.review.bot oldest_to_newest 796709 0 laszlo.gombos 2012-12-22 21:43:44 -0800 ENABLE(SPEECH_INPUT) is only used in one Qt specific file - ./WebKit2/WebProcess/qt/WebProcessQt.cpp:#if ENABLE(SPEECH_INPUT). The macros should be likely spelled ENABLE(INPUT_SPEECH) instead. 816847 1 184795 laszlo.gombos 2013-01-25 12:36:24 -0800 Created attachment 184795 proposed change After a second look I think it is better to remove the guard instead of renaming it. 818800 2 184795 webkit.review.bot 2013-01-29 03:33:44 -0800 Comment on attachment 184795 proposed change Clearing flags on attachment: 184795 Committed r141092: <http://trac.webkit.org/changeset/141092> 818801 3 webkit.review.bot 2013-01-29 03:33:48 -0800 All reviewed patches have been landed. Closing bug. 184795 2013-01-25 12:36:24 -0800 2013-01-29 03:33:44 -0800 proposed change 105683.patch text/plain 1486 laszlo.gombos SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE0MDg1OCkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDEzLTAxLTI1ICBMYXN6bG8g R29tYm9zICA8bC5nb21ib3NAc2Ftc3VuZy5jb20+CisKKyAgICAgICAgW1F0XSBSZW1vdmUgbWlz c3BlbGxlZCBFTkFCTEUoU1BFRUNIX0lOUFVUKSBndWFyZAorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA1NjgzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIEVOQUJMRShTUEVFQ0hfSU5QVVQpIGd1YXJk IGlzIG9ubHkgdXNlZCBpbiBvbmUgbG9jYXRpb24KKyAgICAgICAgaW4gdGhlIHNvdXJjZSB0cmVl IGFuZCBhcyBzdWNoIGl0IGlzIGFsd2F5cyAwLgorCisgICAgICAgIEkgYmVsaWV2ZSB0aGF0IHRo aXMgZ3VhcmQgaXMgYSBsZWZ0IG92ZXIgYW5kIGlzIG5vdCBuZWVkZWQgYW55IG1vcmUKKyAgICAg ICAgYXMgdGhlIGNvZGUgZ3VhcmRlZCBpcyBub3QgZ3VhcmRlZCBhbnl3aGVyZSBlbHNlLgorCisg ICAgICAgICogV2ViUHJvY2Vzcy9xdC9XZWJQcm9jZXNzUXQuY3BwOgorICAgICAgICAoV2ViS2l0 OjpXZWJQcm9jZXNzOjpwbGF0Zm9ybUluaXRpYWxpemVXZWJQcm9jZXNzKToKKwogMjAxMy0wMS0y NSAgQWxleGV5IFByb3NrdXJ5YWtvdiAgPGFwQGFwcGxlLmNvbT4KIAogICAgICAgICBSRUdSRVNT SU9OOiBTeXN0ZW0gZGlyZWN0b3J5IHByZWZpeCBkb2Vzbid0IGhhdmUgYSAiKyIKSW5kZXg6IFNv dXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvcXQvV2ViUHJvY2Vzc1F0LmNwcAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL3F0L1dlYlByb2Nlc3NRdC5jcHAJKHJldmlzaW9u IDE0MDg1NSkKKysrIFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvcXQvV2ViUHJvY2Vzc1F0LmNw cAkod29ya2luZyBjb3B5KQpAQCAtMTYwLDkgKzE2MCw3IEBAIHZvaWQgV2ViUHJvY2Vzczo6cGxh dGZvcm1Jbml0aWFsaXplV2ViUHIKICAgICB9CiAjZW5kaWYKIAotI2lmIEVOQUJMRShTUEVFQ0hf SU5QVVQpCiAgICAgV2ViQ29yZTo6UnVudGltZUVuYWJsZWRGZWF0dXJlczo6c2V0U3BlZWNoSW5w dXRFbmFibGVkKGZhbHNlKTsKLSNlbmRpZgogCiAgICAgLy8gV2UnbGwgb25seSBpbnN0YWxsIHRo ZSBRdCBidWlsdGluIGJ1bmRsZSBpZiB3ZSBkb24ndCBoYXZlIG9uZSBnaXZlbiBieSB0aGUgVUkg cHJvY2Vzcy4KICAgICAvLyBDdXJyZW50bHkgb25seSBXVFIgcHJvdmlkZXMgaXRzIG93biBidW5k bGUuCg==