105679 2012-12-22 13:03:34 -0800 [Blackberry] Static code analysis warning fixes 2013-01-04 09:17:30 -0800 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 afscian webkit-unassigned mifenton rwlbuis tonikitoo webkit.review.bot yong.li.webkit oldest_to_newest 796681 0 afscian 2012-12-22 13:03:34 -0800 Klocwork issues: 959,1855, 4084 796682 1 180607 afscian 2012-12-22 13:36:08 -0800 Created attachment 180607 patch for klocwork issues: 959, 1855 796683 2 afscian 2012-12-22 13:37:11 -0800 klocwork issue 4084 withdrawn. 798662 3 afscian 2013-01-02 07:32:44 -0800 patch has passed EWS, needs review still. 798689 4 180607 rwlbuis 2013-01-02 09:02:23 -0800 Comment on attachment 180607 patch for klocwork issues: 959, 1855 View in context: https://bugs.webkit.org/attachment.cgi?id=180607&action=review Looks good, please fix the style nit before landing. > Source/WebCore/platform/blackberry/RenderThemeBlackBerry.cpp:171 > + if (page) { It is Webkit style to combine above two lines. 798690 5 180607 rwlbuis 2013-01-02 09:03:09 -0800 Comment on attachment 180607 patch for klocwork issues: 959, 1855 View in context: https://bugs.webkit.org/attachment.cgi?id=180607&action=review Looks good, please fix the style nit before landing. > Source/WebCore/platform/blackberry/RenderThemeBlackBerry.cpp:171 > + if (page) { It is Webkit style to combine above two lines. 798702 6 afscian 2013-01-02 10:00:02 -0800 There are two accesses to the var 'page' in the if-stmt so combining the lines wouldn't have the same semantics. The other access is the line further down: float scaleFactorFudge = 1 / page->deviceScaleFactor(); 799321 7 rwlbuis 2013-01-03 02:26:21 -0800 (In reply to comment #6) > There are two accesses to the var 'page' in the if-stmt so combining the lines wouldn't have the same semantics. > > The other access is the line further down: > > float scaleFactorFudge = 1 / page->deviceScaleFactor(); I don't think that matters, page is visible in the entire scope of the if block. Can you recheck? 799385 8 181177 afscian 2013-01-03 08:02:08 -0800 Created attachment 181177 updated patch Sorry, I misunderstood which lines you wanted merged together, this patch moves the initialization of the variable into the if-expr. 799958 9 181177 rwlbuis 2013-01-03 23:03:46 -0800 Comment on attachment 181177 updated patch LGTM 799959 10 181177 webkit.review.bot 2013-01-03 23:04:24 -0800 Comment on attachment 181177 updated patch Rejecting attachment 181177 from review queue. ascian@rim.com does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py. - If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have reviewer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your reviewer rights. 799979 11 180607 eric 2013-01-04 00:40:48 -0800 Comment on attachment 180607 patch for klocwork issues: 959, 1855 Cleared Rob Buis's review+ from obsolete attachment 180607 so that this bug does not appear in http://webkit.org/pending-commit. 800253 12 181177 webkit.review.bot 2013-01-04 09:17:26 -0800 Comment on attachment 181177 updated patch Clearing flags on attachment: 181177 Committed r138804: <http://trac.webkit.org/changeset/138804> 800254 13 webkit.review.bot 2013-01-04 09:17:30 -0800 All reviewed patches have been landed. Closing bug. 180607 2012-12-22 13:36:08 -0800 2013-01-04 00:40:48 -0800 patch for klocwork issues: 959, 1855 0001-Blackberry-Static-code-analysis-warning-fixes.patch text/plain 5948 afscian RnJvbSA5OGFiNTU5NDBmYTMzNzg2ZGI1OTdkMGUyMWZiMzg3NDBkMzI4YjExIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbnRob255IFNjaWFuIDxhc2NpYW5AcmltLmNvbT4KRGF0ZTog U2F0LCAyMiBEZWMgMjAxMiAxNjozMDo1OSAtMDUwMApTdWJqZWN0OiBbUEFUQ0hdIFtCbGFja2Jl cnJ5XSBTdGF0aWMgY29kZSBhbmFseXNpcyB3YXJuaW5nIGZpeGVzCiBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA1Njc5CgpSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KClNvdXJjZS9XZWJDb3JlOgoKa2xvY3dvcmsgMTg1NTogZml4ZWQgYnkgY2FjaGluZyBwYWdl LCBjaGVjayBhZ2FpbnN0IE5VTEwgYW5kIHVzZSBjYWNoZWQgdmFsdWUKCiogcGxhdGZvcm0vYmxh Y2tiZXJyeS9SZW5kZXJUaGVtZUJsYWNrQmVycnkuY3BwOgooV2ViQ29yZTo6ZGV0ZXJtaW5lRnVs bFNjcmVlbk11bHRpcGxpZXIpOgoKU291cmNlL1dlYktpdC9ibGFja2JlcnJ5OgoKS2xvY3dvcmsg aXNzdWUgOTU5OiBjaGVjayBsYXllciBhZ2FpbnN0IE5VTEwgc2luY2UgaXQgaXMgdXNlZCBpbiBi b3RoIGNhc2VzCm9mIHRoZSBzdWJzZXF1ZW50IGlmLXN0bXQKCiogQXBpL0luUmVnaW9uU2Nyb2xs ZXIuY3BwOgooQmxhY2tCZXJyeTo6V2ViS2l0OjpJblJlZ2lvblNjcm9sbGVyUHJpdmF0ZTo6Y2Fs Y3VsYXRlSW5SZWdpb25TY3JvbGxhYmxlQXJlYXNGb3JQb2ludCk6Ci0tLQogU291cmNlL1dlYkNv cmUvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAgICAgICAgICAgfCAxMiArKysrKysrKysrKwog Li4uL3BsYXRmb3JtL2JsYWNrYmVycnkvUmVuZGVyVGhlbWVCbGFja0JlcnJ5LmNwcCAgfCAyNSAr KysrKysrKysrKystLS0tLS0tLS0tCiBTb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL0luUmVn aW9uU2Nyb2xsZXIuY3BwICB8ICA0ICsrKy0KIFNvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu Z2VMb2cgICAgICAgICAgICAgICAgIHwgMTMgKysrKysrKysrKysKIDQgZmlsZXMgY2hhbmdlZCwg NDIgaW5zZXJ0aW9ucygrKSwgMTIgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IDFmNDhjOTYu LmYyMDI1ZjggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3Vy Y2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMi0xMi0yMiAgQW50aG9u eSBTY2lhbiAgPGFzY2lhbkByaW0uY29tPgorCisgICAgICAgIFtCbGFja2JlcnJ5XSBTdGF0aWMg Y29kZSBhbmFseXNpcyB3YXJuaW5nIGZpeGVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xMDU2NzkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBrbG9jd29yayAxODU1OiBmaXhlZCBieSBjYWNoaW5nIHBhZ2Us IGNoZWNrIGFnYWluc3QgTlVMTCBhbmQgdXNlIGNhY2hlZCB2YWx1ZQorCisgICAgICAgICogcGxh dGZvcm0vYmxhY2tiZXJyeS9SZW5kZXJUaGVtZUJsYWNrQmVycnkuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6ZGV0ZXJtaW5lRnVsbFNjcmVlbk11bHRpcGxpZXIpOgorCiAyMDEyLTEyLTIxICBKYW4g S2Vyb21uZXMgIDxqYW54QGxpbnV4LmNvbT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBVcGRh dGUgQ29kZU1pcnJvciB0byBzdGFibGUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2JsYWNrYmVycnkvUmVuZGVyVGhlbWVCbGFja0JlcnJ5LmNwcCBiL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2JsYWNrYmVycnkvUmVuZGVyVGhlbWVCbGFja0JlcnJ5LmNwcAppbmRleCBiOGY5 Njk1Li5iZDI3NzY1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ibGFja2Jl cnJ5L1JlbmRlclRoZW1lQmxhY2tCZXJyeS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vYmxhY2tiZXJyeS9SZW5kZXJUaGVtZUJsYWNrQmVycnkuY3BwCkBAIC0xNjcsMTcgKzE2Nywy MCBAQCBzdGF0aWMgZmxvYXQgZGV0ZXJtaW5lRnVsbFNjcmVlbk11bHRpcGxpZXIoRWxlbWVudCog ZWxlbWVudCkKICAgICBmbG9hdCBmdWxsU2NyZWVuTXVsdGlwbGllciA9IDEuMDsKICNpZiBFTkFC TEUoRlVMTFNDUkVFTl9BUEkpICYmIEVOQUJMRShWSURFTykKICAgICBpZiAoZWxlbWVudCAmJiBl bGVtZW50LT5kb2N1bWVudCgpLT53ZWJraXRJc0Z1bGxTY3JlZW4oKSAmJiBlbGVtZW50LT5kb2N1 bWVudCgpLT53ZWJraXRDdXJyZW50RnVsbFNjcmVlbkVsZW1lbnQoKSA9PSB0b1BhcmVudE1lZGlh RWxlbWVudChlbGVtZW50KSkgewotICAgICAgICBpZiAoZWxlbWVudC0+ZG9jdW1lbnQoKS0+cGFn ZSgpLT5kZXZpY2VTY2FsZUZhY3RvcigpIDwgc2NhbGVGYWN0b3JUaHJlc2hvbGQpCi0gICAgICAg ICAgICBmdWxsU2NyZWVuTXVsdGlwbGllciA9IGZ1bGxTY3JlZW5FbmxhcmdlbWVudEZhY3RvcjsK LQotICAgICAgICAvLyBUaGUgd2F5IHRoZSBCbGFja0JlcnJ5IHBvcnQgaW1wbGVtZW50cyB0aGUg RlVMTFNDUkVFTl9BUEkgZm9yIG1lZGlhIGVsZW1lbnRzCi0gICAgICAgIC8vIG1pZ2h0IHJlc3Vs dCBpbiB0aGUgY29udHJvbHMgYmVpbmcgb3ZlcnNpemVkLCBwcm9wb3J0aW9uYWxseSB0byB0aGUg Y3VycmVudCBwYWdlCi0gICAgICAgIC8vIHNjYWxlLiBUaGF0IGhhcHBlbnMgYmVjYXVzZSB0aGUg ZnVsbHNjcmVlbiBlbGVtZW50IGdldHMgc2l6ZWQgdG8gYmUgYXMgYmlnIGFzIHRoZQotICAgICAg ICAvLyB2aWV3cG9ydCBzaXplLCBhbmQgdGhlIHZpZXdwb3J0IHNpemUgbWlnaHQgZ2V0IG91dHN0 cmV0Y2hlZCB0byBmaXQgdG8gdGhlIHNjcmVlbiBkaW1lbnNpb25zLgotICAgICAgICAvLyBUbyBm aXggdGhhdCwgbGV0cyBzdHJpcHMgb3V0IHRoZSBQYWdlIHNjYWxlIGZhY3RvciBmcm9tIHRoZSBt ZWRpYSBjb250cm9scyBtdWx0aXBsaWVyLgotICAgICAgICBmbG9hdCBzY2FsZUZhY3RvciA9IGVs ZW1lbnQtPmRvY3VtZW50KCktPnZpZXcoKS0+aG9zdFdpbmRvdygpLT5wbGF0Zm9ybVBhZ2VDbGll bnQoKS0+Y3VycmVudFpvb21GYWN0b3IoKTsKLSAgICAgICAgZmxvYXQgc2NhbGVGYWN0b3JGdWRn ZSA9IDEgLyBlbGVtZW50LT5kb2N1bWVudCgpLT5wYWdlKCktPmRldmljZVNjYWxlRmFjdG9yKCk7 Ci0gICAgICAgIGZ1bGxTY3JlZW5NdWx0aXBsaWVyIC89IHNjYWxlRmFjdG9yICogc2NhbGVGYWN0 b3JGdWRnZTsKKyAgICAgICAgUGFnZSogcGFnZSA9IGVsZW1lbnQtPmRvY3VtZW50KCktPnBhZ2Uo KTsKKyAgICAgICAgaWYgKHBhZ2UpIHsKKyAgICAgICAgICAgIGlmIChwYWdlLT5kZXZpY2VTY2Fs ZUZhY3RvcigpIDwgc2NhbGVGYWN0b3JUaHJlc2hvbGQpCisgICAgICAgICAgICAgICAgZnVsbFNj cmVlbk11bHRpcGxpZXIgPSBmdWxsU2NyZWVuRW5sYXJnZW1lbnRGYWN0b3I7CisKKyAgICAgICAg ICAgIC8vIFRoZSB3YXkgdGhlIEJsYWNrQmVycnkgcG9ydCBpbXBsZW1lbnRzIHRoZSBGVUxMU0NS RUVOX0FQSSBmb3IgbWVkaWEgZWxlbWVudHMKKyAgICAgICAgICAgIC8vIG1pZ2h0IHJlc3VsdCBp biB0aGUgY29udHJvbHMgYmVpbmcgb3ZlcnNpemVkLCBwcm9wb3J0aW9uYWxseSB0byB0aGUgY3Vy cmVudCBwYWdlCisgICAgICAgICAgICAvLyBzY2FsZS4gVGhhdCBoYXBwZW5zIGJlY2F1c2UgdGhl IGZ1bGxzY3JlZW4gZWxlbWVudCBnZXRzIHNpemVkIHRvIGJlIGFzIGJpZyBhcyB0aGUKKyAgICAg ICAgICAgIC8vIHZpZXdwb3J0IHNpemUsIGFuZCB0aGUgdmlld3BvcnQgc2l6ZSBtaWdodCBnZXQg b3V0c3RyZXRjaGVkIHRvIGZpdCB0byB0aGUgc2NyZWVuIGRpbWVuc2lvbnMuCisgICAgICAgICAg ICAvLyBUbyBmaXggdGhhdCwgbGV0cyBzdHJpcHMgb3V0IHRoZSBQYWdlIHNjYWxlIGZhY3RvciBm cm9tIHRoZSBtZWRpYSBjb250cm9scyBtdWx0aXBsaWVyLgorICAgICAgICAgICAgZmxvYXQgc2Nh bGVGYWN0b3IgPSBlbGVtZW50LT5kb2N1bWVudCgpLT52aWV3KCktPmhvc3RXaW5kb3coKS0+cGxh dGZvcm1QYWdlQ2xpZW50KCktPmN1cnJlbnRab29tRmFjdG9yKCk7CisgICAgICAgICAgICBmbG9h dCBzY2FsZUZhY3RvckZ1ZGdlID0gMSAvIHBhZ2UtPmRldmljZVNjYWxlRmFjdG9yKCk7CisgICAg ICAgICAgICBmdWxsU2NyZWVuTXVsdGlwbGllciAvPSBzY2FsZUZhY3RvciAqIHNjYWxlRmFjdG9y RnVkZ2U7CisgICAgICAgIH0KICAgICB9CiAjZW5kaWYKICAgICByZXR1cm4gZnVsbFNjcmVlbk11 bHRpcGxpZXI7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL0luUmVn aW9uU2Nyb2xsZXIuY3BwIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9JblJlZ2lvblNj cm9sbGVyLmNwcAppbmRleCA3YmJjNTc2Li5lYjliMDgzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi S2l0L2JsYWNrYmVycnkvQXBpL0luUmVnaW9uU2Nyb2xsZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJL aXQvYmxhY2tiZXJyeS9BcGkvSW5SZWdpb25TY3JvbGxlci5jcHAKQEAgLTI1OSw4ICsyNTksMTAg QEAgdm9pZCBJblJlZ2lvblNjcm9sbGVyUHJpdmF0ZTo6Y2FsY3VsYXRlSW5SZWdpb25TY3JvbGxh YmxlQXJlYXNGb3JQb2ludChjb25zdCBXZWIKIAogICAgICAgICBJblJlZ2lvblNjcm9sbGFibGVB cmVhKiBjdXJyID0gc3RhdGljX2Nhc3Q8SW5SZWdpb25TY3JvbGxhYmxlQXJlYSo+KCpyaXQpOwog ICAgICAgICBSZW5kZXJMYXllciogbGF5ZXIgPSBjdXJyLT5sYXllcigpOworICAgICAgICBpZiAo IWxheWVyKQorICAgICAgICAgICAgY29udGludWU7CiAKLSAgICAgICAgaWYgKGxheWVyICYmIGxh eWVyLT5yZW5kZXJlcigpLT5pc1JlbmRlclZpZXcoKSkgeyAvLyAjZG9jdW1lbnQgY2FzZQorICAg ICAgICBpZiAobGF5ZXItPnJlbmRlcmVyKCktPmlzUmVuZGVyVmlldygpKSB7IC8vICNkb2N1bWVu dCBjYXNlCiAgICAgICAgICAgICBGcmFtZVZpZXcqIHZpZXcgPSB0b1JlbmRlclZpZXcobGF5ZXIt PnJlbmRlcmVyKCkpLT5mcmFtZVZpZXcoKTsKICAgICAgICAgICAgIEFTU0VSVCh2aWV3KTsKICAg ICAgICAgICAgIEFTU0VSVChjYW5TY3JvbGxJbm5lckZyYW1lKHZpZXctPmZyYW1lKCkpKTsKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi S2l0L2JsYWNrYmVycnkvQ2hhbmdlTG9nCmluZGV4IGVmMjEwOTMuLmZkY2VhZmQgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktp dC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTEyLTIyICBBbnRo b255IFNjaWFuICA8YXNjaWFuQHJpbS5jb20+CisKKyAgICAgICAgW0JsYWNrYmVycnldIFN0YXRp YyBjb2RlIGFuYWx5c2lzIHdhcm5pbmcgZml4ZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNTY3OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIEtsb2N3b3JrIGlzc3VlIDk1OTogY2hlY2sgbGF5ZXIgYWdh aW5zdCBOVUxMIHNpbmNlIGl0IGlzIHVzZWQgaW4gYm90aCBjYXNlcworICAgICAgICBvZiB0aGUg c3Vic2VxdWVudCBpZi1zdG10CisKKyAgICAgICAgKiBBcGkvSW5SZWdpb25TY3JvbGxlci5jcHA6 CisgICAgICAgIChCbGFja0JlcnJ5OjpXZWJLaXQ6OkluUmVnaW9uU2Nyb2xsZXJQcml2YXRlOjpj YWxjdWxhdGVJblJlZ2lvblNjcm9sbGFibGVBcmVhc0ZvclBvaW50KToKKwogMjAxMi0xMi0yMSAg TWF4IEZlaWwgIDxtZmVpbEByaW0uY29tPgogCiAgICAgICAgIFtCbGFja0JlcnJ5XSBGdWxsc2Ny ZWVuIHZpZGVvIGZpeGVkIHBvc2l0aW9uIGNvbnRhaW5lciBob3Jpem9udGFsIHBvc2l0aW9uIGlz IHdyb25nCi0tIAoxLjguMC4xCgo= 181177 2013-01-03 08:02:08 -0800 2013-01-04 09:17:26 -0800 updated patch 0001-Blackberry-Static-code-analysis-warning-fixes.patch text/plain 5932 afscian RnJvbSA1ODg3YzQ0OWJlOWI0YWFjMWYzMzlmMmMyZTg2YThmZmEzYjZiYTY5IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbnRob255IFNjaWFuIDxhc2NpYW5AcmltLmNvbT4KRGF0ZTog U2F0LCAyMiBEZWMgMjAxMiAxNjozMDo1OSAtMDUwMApTdWJqZWN0OiBbUEFUQ0hdIFtCbGFja2Jl cnJ5XSBTdGF0aWMgY29kZSBhbmFseXNpcyB3YXJuaW5nIGZpeGVzCiBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA1Njc5CgpSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KClNvdXJjZS9XZWJDb3JlOgoKa2xvY3dvcmsgMTg1NTogZml4ZWQgYnkgY2FjaGluZyBwYWdl LCBjaGVjayBhZ2FpbnN0IE5VTEwgYW5kIHVzZSBjYWNoZWQgdmFsdWUKCiogcGxhdGZvcm0vYmxh Y2tiZXJyeS9SZW5kZXJUaGVtZUJsYWNrQmVycnkuY3BwOgooV2ViQ29yZTo6ZGV0ZXJtaW5lRnVs bFNjcmVlbk11bHRpcGxpZXIpOgoKU291cmNlL1dlYktpdC9ibGFja2JlcnJ5OgoKS2xvY3dvcmsg aXNzdWUgOTU5OiBjaGVjayBsYXllciBhZ2FpbnN0IE5VTEwgc2luY2UgaXQgaXMgdXNlZCBpbiBi b3RoIGNhc2VzCm9mIHRoZSBzdWJzZXF1ZW50IGlmLXN0bXQKCiogQXBpL0luUmVnaW9uU2Nyb2xs ZXIuY3BwOgooQmxhY2tCZXJyeTo6V2ViS2l0OjpJblJlZ2lvblNjcm9sbGVyUHJpdmF0ZTo6Y2Fs Y3VsYXRlSW5SZWdpb25TY3JvbGxhYmxlQXJlYXNGb3JQb2ludCk6Ci0tLQogU291cmNlL1dlYkNv cmUvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAgICAgICAgICAgfCAxMiArKysrKysrKysrKwog Li4uL3BsYXRmb3JtL2JsYWNrYmVycnkvUmVuZGVyVGhlbWVCbGFja0JlcnJ5LmNwcCAgfCAyNCAr KysrKysrKysrKystLS0tLS0tLS0tCiBTb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL0luUmVn aW9uU2Nyb2xsZXIuY3BwICB8ICA0ICsrKy0KIFNvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu Z2VMb2cgICAgICAgICAgICAgICAgIHwgMTMgKysrKysrKysrKysrCiA0IGZpbGVzIGNoYW5nZWQs IDQxIGluc2VydGlvbnMoKyksIDEyIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAxZjQ4Yzk2 Li5mMjAyNWY4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTItMTItMjIgIEFudGhv bnkgU2NpYW4gIDxhc2NpYW5AcmltLmNvbT4KKworICAgICAgICBbQmxhY2tiZXJyeV0gU3RhdGlj IGNvZGUgYW5hbHlzaXMgd2FybmluZyBmaXhlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA1Njc5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAga2xvY3dvcmsgMTg1NTogZml4ZWQgYnkgY2FjaGluZyBwYWdl LCBjaGVjayBhZ2FpbnN0IE5VTEwgYW5kIHVzZSBjYWNoZWQgdmFsdWUKKworICAgICAgICAqIHBs YXRmb3JtL2JsYWNrYmVycnkvUmVuZGVyVGhlbWVCbGFja0JlcnJ5LmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OmRldGVybWluZUZ1bGxTY3JlZW5NdWx0aXBsaWVyKToKKwogMjAxMi0xMi0yMSAgSmFu IEtlcm9tbmVzICA8amFueEBsaW51eC5jb20+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogVXBk YXRlIENvZGVNaXJyb3IgdG8gc3RhYmxlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ibGFja2JlcnJ5L1JlbmRlclRoZW1lQmxhY2tCZXJyeS5jcHAgYi9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9ibGFja2JlcnJ5L1JlbmRlclRoZW1lQmxhY2tCZXJyeS5jcHAKaW5kZXggYjhm OTY5NS4uYjRlZTBjNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vYmxhY2ti ZXJyeS9SZW5kZXJUaGVtZUJsYWNrQmVycnkuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2JsYWNrYmVycnkvUmVuZGVyVGhlbWVCbGFja0JlcnJ5LmNwcApAQCAtMTY3LDE3ICsxNjcs MTkgQEAgc3RhdGljIGZsb2F0IGRldGVybWluZUZ1bGxTY3JlZW5NdWx0aXBsaWVyKEVsZW1lbnQq IGVsZW1lbnQpCiAgICAgZmxvYXQgZnVsbFNjcmVlbk11bHRpcGxpZXIgPSAxLjA7CiAjaWYgRU5B QkxFKEZVTExTQ1JFRU5fQVBJKSAmJiBFTkFCTEUoVklERU8pCiAgICAgaWYgKGVsZW1lbnQgJiYg ZWxlbWVudC0+ZG9jdW1lbnQoKS0+d2Via2l0SXNGdWxsU2NyZWVuKCkgJiYgZWxlbWVudC0+ZG9j dW1lbnQoKS0+d2Via2l0Q3VycmVudEZ1bGxTY3JlZW5FbGVtZW50KCkgPT0gdG9QYXJlbnRNZWRp YUVsZW1lbnQoZWxlbWVudCkpIHsKLSAgICAgICAgaWYgKGVsZW1lbnQtPmRvY3VtZW50KCktPnBh Z2UoKS0+ZGV2aWNlU2NhbGVGYWN0b3IoKSA8IHNjYWxlRmFjdG9yVGhyZXNob2xkKQotICAgICAg ICAgICAgZnVsbFNjcmVlbk11bHRpcGxpZXIgPSBmdWxsU2NyZWVuRW5sYXJnZW1lbnRGYWN0b3I7 Ci0KLSAgICAgICAgLy8gVGhlIHdheSB0aGUgQmxhY2tCZXJyeSBwb3J0IGltcGxlbWVudHMgdGhl IEZVTExTQ1JFRU5fQVBJIGZvciBtZWRpYSBlbGVtZW50cwotICAgICAgICAvLyBtaWdodCByZXN1 bHQgaW4gdGhlIGNvbnRyb2xzIGJlaW5nIG92ZXJzaXplZCwgcHJvcG9ydGlvbmFsbHkgdG8gdGhl IGN1cnJlbnQgcGFnZQotICAgICAgICAvLyBzY2FsZS4gVGhhdCBoYXBwZW5zIGJlY2F1c2UgdGhl IGZ1bGxzY3JlZW4gZWxlbWVudCBnZXRzIHNpemVkIHRvIGJlIGFzIGJpZyBhcyB0aGUKLSAgICAg ICAgLy8gdmlld3BvcnQgc2l6ZSwgYW5kIHRoZSB2aWV3cG9ydCBzaXplIG1pZ2h0IGdldCBvdXRz dHJldGNoZWQgdG8gZml0IHRvIHRoZSBzY3JlZW4gZGltZW5zaW9ucy4KLSAgICAgICAgLy8gVG8g Zml4IHRoYXQsIGxldHMgc3RyaXBzIG91dCB0aGUgUGFnZSBzY2FsZSBmYWN0b3IgZnJvbSB0aGUg bWVkaWEgY29udHJvbHMgbXVsdGlwbGllci4KLSAgICAgICAgZmxvYXQgc2NhbGVGYWN0b3IgPSBl bGVtZW50LT5kb2N1bWVudCgpLT52aWV3KCktPmhvc3RXaW5kb3coKS0+cGxhdGZvcm1QYWdlQ2xp ZW50KCktPmN1cnJlbnRab29tRmFjdG9yKCk7Ci0gICAgICAgIGZsb2F0IHNjYWxlRmFjdG9yRnVk Z2UgPSAxIC8gZWxlbWVudC0+ZG9jdW1lbnQoKS0+cGFnZSgpLT5kZXZpY2VTY2FsZUZhY3Rvcigp OwotICAgICAgICBmdWxsU2NyZWVuTXVsdGlwbGllciAvPSBzY2FsZUZhY3RvciAqIHNjYWxlRmFj dG9yRnVkZ2U7CisgICAgICAgIGlmIChQYWdlKiBwYWdlID0gZWxlbWVudC0+ZG9jdW1lbnQoKS0+ cGFnZSgpKSB7CisgICAgICAgICAgICBpZiAocGFnZS0+ZGV2aWNlU2NhbGVGYWN0b3IoKSA8IHNj YWxlRmFjdG9yVGhyZXNob2xkKQorICAgICAgICAgICAgICAgIGZ1bGxTY3JlZW5NdWx0aXBsaWVy ID0gZnVsbFNjcmVlbkVubGFyZ2VtZW50RmFjdG9yOworCisgICAgICAgICAgICAvLyBUaGUgd2F5 IHRoZSBCbGFja0JlcnJ5IHBvcnQgaW1wbGVtZW50cyB0aGUgRlVMTFNDUkVFTl9BUEkgZm9yIG1l ZGlhIGVsZW1lbnRzCisgICAgICAgICAgICAvLyBtaWdodCByZXN1bHQgaW4gdGhlIGNvbnRyb2xz IGJlaW5nIG92ZXJzaXplZCwgcHJvcG9ydGlvbmFsbHkgdG8gdGhlIGN1cnJlbnQgcGFnZQorICAg ICAgICAgICAgLy8gc2NhbGUuIFRoYXQgaGFwcGVucyBiZWNhdXNlIHRoZSBmdWxsc2NyZWVuIGVs ZW1lbnQgZ2V0cyBzaXplZCB0byBiZSBhcyBiaWcgYXMgdGhlCisgICAgICAgICAgICAvLyB2aWV3 cG9ydCBzaXplLCBhbmQgdGhlIHZpZXdwb3J0IHNpemUgbWlnaHQgZ2V0IG91dHN0cmV0Y2hlZCB0 byBmaXQgdG8gdGhlIHNjcmVlbiBkaW1lbnNpb25zLgorICAgICAgICAgICAgLy8gVG8gZml4IHRo YXQsIGxldHMgc3RyaXBzIG91dCB0aGUgUGFnZSBzY2FsZSBmYWN0b3IgZnJvbSB0aGUgbWVkaWEg Y29udHJvbHMgbXVsdGlwbGllci4KKyAgICAgICAgICAgIGZsb2F0IHNjYWxlRmFjdG9yID0gZWxl bWVudC0+ZG9jdW1lbnQoKS0+dmlldygpLT5ob3N0V2luZG93KCktPnBsYXRmb3JtUGFnZUNsaWVu dCgpLT5jdXJyZW50Wm9vbUZhY3RvcigpOworICAgICAgICAgICAgZmxvYXQgc2NhbGVGYWN0b3JG dWRnZSA9IDEgLyBwYWdlLT5kZXZpY2VTY2FsZUZhY3RvcigpOworICAgICAgICAgICAgZnVsbFNj cmVlbk11bHRpcGxpZXIgLz0gc2NhbGVGYWN0b3IgKiBzY2FsZUZhY3RvckZ1ZGdlOworICAgICAg ICB9CiAgICAgfQogI2VuZGlmCiAgICAgcmV0dXJuIGZ1bGxTY3JlZW5NdWx0aXBsaWVyOwpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9JblJlZ2lvblNjcm9sbGVyLmNw cCBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvSW5SZWdpb25TY3JvbGxlci5jcHAKaW5k ZXggN2JiYzU3Ni4uZWI5YjA4MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5 L0FwaS9JblJlZ2lvblNjcm9sbGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkv QXBpL0luUmVnaW9uU2Nyb2xsZXIuY3BwCkBAIC0yNTksOCArMjU5LDEwIEBAIHZvaWQgSW5SZWdp b25TY3JvbGxlclByaXZhdGU6OmNhbGN1bGF0ZUluUmVnaW9uU2Nyb2xsYWJsZUFyZWFzRm9yUG9p bnQoY29uc3QgV2ViCiAKICAgICAgICAgSW5SZWdpb25TY3JvbGxhYmxlQXJlYSogY3VyciA9IHN0 YXRpY19jYXN0PEluUmVnaW9uU2Nyb2xsYWJsZUFyZWEqPigqcml0KTsKICAgICAgICAgUmVuZGVy TGF5ZXIqIGxheWVyID0gY3Vyci0+bGF5ZXIoKTsKKyAgICAgICAgaWYgKCFsYXllcikKKyAgICAg ICAgICAgIGNvbnRpbnVlOwogCi0gICAgICAgIGlmIChsYXllciAmJiBsYXllci0+cmVuZGVyZXIo KS0+aXNSZW5kZXJWaWV3KCkpIHsgLy8gI2RvY3VtZW50IGNhc2UKKyAgICAgICAgaWYgKGxheWVy LT5yZW5kZXJlcigpLT5pc1JlbmRlclZpZXcoKSkgeyAvLyAjZG9jdW1lbnQgY2FzZQogICAgICAg ICAgICAgRnJhbWVWaWV3KiB2aWV3ID0gdG9SZW5kZXJWaWV3KGxheWVyLT5yZW5kZXJlcigpKS0+ ZnJhbWVWaWV3KCk7CiAgICAgICAgICAgICBBU1NFUlQodmlldyk7CiAgICAgICAgICAgICBBU1NF UlQoY2FuU2Nyb2xsSW5uZXJGcmFtZSh2aWV3LT5mcmFtZSgpKSk7CmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViS2l0L2JsYWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5 L0NoYW5nZUxvZwppbmRleCBlZjIxMDkzLi5mZGNlYWZkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi S2l0L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9D aGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMi0xMi0yMiAgQW50aG9ueSBTY2lhbiAgPGFz Y2lhbkByaW0uY29tPgorCisgICAgICAgIFtCbGFja2JlcnJ5XSBTdGF0aWMgY29kZSBhbmFseXNp cyB3YXJuaW5nIGZpeGVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xMDU2NzkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBLbG9jd29yayBpc3N1ZSA5NTk6IGNoZWNrIGxheWVyIGFnYWluc3QgTlVMTCBzaW5j ZSBpdCBpcyB1c2VkIGluIGJvdGggY2FzZXMKKyAgICAgICAgb2YgdGhlIHN1YnNlcXVlbnQgaWYt c3RtdAorCisgICAgICAgICogQXBpL0luUmVnaW9uU2Nyb2xsZXIuY3BwOgorICAgICAgICAoQmxh Y2tCZXJyeTo6V2ViS2l0OjpJblJlZ2lvblNjcm9sbGVyUHJpdmF0ZTo6Y2FsY3VsYXRlSW5SZWdp b25TY3JvbGxhYmxlQXJlYXNGb3JQb2ludCk6CisKIDIwMTItMTItMjEgIE1heCBGZWlsICA8bWZl aWxAcmltLmNvbT4KIAogICAgICAgICBbQmxhY2tCZXJyeV0gRnVsbHNjcmVlbiB2aWRlbyBmaXhl ZCBwb3NpdGlvbiBjb250YWluZXIgaG9yaXpvbnRhbCBwb3NpdGlvbiBpcyB3cm9uZwotLSAKMS44 LjEKCg==