105651 2012-12-21 12:40:22 -0800 Invalid assert in GeolocationClientBlackBerry.cpp 2013-01-16 14:32:47 -0800 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Other Other RESOLVED FIXED P2 Normal --- 1 joenotcharles joenotcharles mifenton rwlbuis tonikitoo webkit.review.bot yong.li.webkit oldest_to_newest 796424 0 joenotcharles 2012-12-21 12:40:22 -0800 GeolocationClientBlackBerry::cancelPermissionRequest contains an ASSERT that the origin is in m_geolocationRequestMap. But it's perfectly valid for the location to not be in the map - for instance, if GeolocationClientBlackBerry::requestPermission returned immediately, without putting it in the map, because geolocation was disabled. In this case the correct thing to do is just return - there is nothing to be done to cancel the permission. 796435 1 180547 joenotcharles 2012-12-21 13:21:18 -0800 Created attachment 180547 fix 808725 2 180547 webkit.review.bot 2013-01-16 14:32:43 -0800 Comment on attachment 180547 fix Clearing flags on attachment: 180547 Committed r139925: <http://trac.webkit.org/changeset/139925> 808726 3 webkit.review.bot 2013-01-16 14:32:47 -0800 All reviewed patches have been landed. Closing bug. 180547 2012-12-21 13:21:18 -0800 2013-01-16 14:32:43 -0800 fix 0001-BlackBerry-Remove-bogus-assert-in-GeolocationClientB.patch text/plain 2960 joenotcharles RnJvbSBlZTdhM2ZmODJjMGQ4ZTAxYjAzYTJjNWVhYmVkNzZmOGI4MTYwYmE0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKb2UgTWFzb24gPGptYXNvbkByaW0uY29tPgpEYXRlOiBGcmks IDIxIERlYyAyMDEyIDE2OjE2OjM4IC0wNTAwClN1YmplY3Q6IFtQQVRDSF0gW0JsYWNrQmVycnld IFJlbW92ZSBib2d1cyBhc3NlcnQgaW4KIEdlb2xvY2F0aW9uQ2xpZW50QmxhY2tCZXJyeQogaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNTY1MQoKUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCgpHZW9sb2NhdGlvbkNsaWVudEJsYWNrQmVycnk6OmNhbmNlbFBlcm1p c3Npb25SZXF1ZXN0IGNvbnRhaW5zIGFuIEFTU0VSVCB0aGF0IHRoZSBvcmlnaW4gaXMKaW4gbV9n ZW9sb2NhdGlvblJlcXVlc3RNYXAuIEJ1dCBpdCdzIHBlcmZlY3RseSB2YWxpZCBmb3IgdGhlIG9y aWdpbiB0byBub3QgYmUgaW4gdGhlIG1hcCAtCmZvciBpbnN0YW5jZSwgaWYgR2VvbG9jYXRpb25D bGllbnRCbGFja0JlcnJ5OjpyZXF1ZXN0UGVybWlzc2lvbiByZXR1cm5lZCBpbW1lZGlhdGVseSwK d2l0aG91dCBwdXR0aW5nIGl0IGluIHRoZSBtYXAsIGJlY2F1c2UgZ2VvbG9jYXRpb24gd2FzIGRp c2FibGVkLiBJbiB0aGlzIGNhc2UgdGhlIGNvcnJlY3QKdGhpbmcgdG8gZG8gaXMganVzdCByZXR1 cm4gLSB0aGVyZSBpcyBub3RoaW5nIHRvIGJlIGRvbmUgdG8gY2FuY2VsIHRoZSBwZXJtaXNzaW9u LgoKKiBXZWJDb3JlU3VwcG9ydC9HZW9sb2NhdGlvbkNsaWVudEJsYWNrQmVycnkuY3BwOgooR2Vv bG9jYXRpb25DbGllbnRCbGFja0JlcnJ5OjpjYW5jZWxQZXJtaXNzaW9uUmVxdWVzdCk6Ci0tLQog U291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgfCAgIDE2 ICsrKysrKysrKysrKysrKysKIC4uLi9XZWJDb3JlU3VwcG9ydC9HZW9sb2NhdGlvbkNsaWVudEJs YWNrQmVycnkuY3BwIHwgICAgMiAtLQogMiBmaWxlcyBjaGFuZ2VkLCAxNiBpbnNlcnRpb25zKCsp LCAyIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQ2hhbmdlTG9nCmluZGV4IGJlYmMy YjguLjIzNzQ2ZTAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VM b2cKKysrIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5 IEBACisyMDEyLTEyLTIxICBKb2UgTWFzb24gIDxqbWFzb25AcmltLmNvbT4KKworICAgICAgICBb QmxhY2tCZXJyeV0gUmVtb3ZlIGJvZ3VzIGFzc2VydCBpbiBHZW9sb2NhdGlvbkNsaWVudEJsYWNr QmVycnkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEw NTY1MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEdl b2xvY2F0aW9uQ2xpZW50QmxhY2tCZXJyeTo6Y2FuY2VsUGVybWlzc2lvblJlcXVlc3QgY29udGFp bnMgYW4gQVNTRVJUIHRoYXQgdGhlIG9yaWdpbiBpcworICAgICAgICBpbiBtX2dlb2xvY2F0aW9u UmVxdWVzdE1hcC4gQnV0IGl0J3MgcGVyZmVjdGx5IHZhbGlkIGZvciB0aGUgb3JpZ2luIHRvIG5v dCBiZSBpbiB0aGUgbWFwIC0KKyAgICAgICAgZm9yIGluc3RhbmNlLCBpZiBHZW9sb2NhdGlvbkNs aWVudEJsYWNrQmVycnk6OnJlcXVlc3RQZXJtaXNzaW9uIHJldHVybmVkIGltbWVkaWF0ZWx5LAor ICAgICAgICB3aXRob3V0IHB1dHRpbmcgaXQgaW4gdGhlIG1hcCwgYmVjYXVzZSBnZW9sb2NhdGlv biB3YXMgZGlzYWJsZWQuIEluIHRoaXMgY2FzZSB0aGUgY29ycmVjdAorICAgICAgICB0aGluZyB0 byBkbyBpcyBqdXN0IHJldHVybiAtIHRoZXJlIGlzIG5vdGhpbmcgdG8gYmUgZG9uZSB0byBjYW5j ZWwgdGhlIHBlcm1pc3Npb24uCisKKyAgICAgICAgKiBXZWJDb3JlU3VwcG9ydC9HZW9sb2NhdGlv bkNsaWVudEJsYWNrQmVycnkuY3BwOgorICAgICAgICAoR2VvbG9jYXRpb25DbGllbnRCbGFja0Jl cnJ5OjpjYW5jZWxQZXJtaXNzaW9uUmVxdWVzdCk6CisKIDIwMTItMTItMTggIE5pbWEgR2hhbmF2 YXRpYW4gIDxuZ2hhbmF2YXRpYW5AcmltLmNvbT4KIAogICAgICAgICBbQmxhY2tCZXJyeV0gQ2Fs Y3VsYXRlIGNvcnJlY3Qgd29yZCBvZmZzZXRzIGZvciBmb3JtIGVsZW1lbnRzLgpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYkNvcmVTdXBwb3J0L0dlb2xvY2F0aW9uQ2xp ZW50QmxhY2tCZXJyeS5jcHAgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViQ29yZVN1cHBv cnQvR2VvbG9jYXRpb25DbGllbnRCbGFja0JlcnJ5LmNwcAppbmRleCA5MTFlMDg5Li5mMjNkMzA2 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViQ29yZVN1cHBvcnQvR2Vv bG9jYXRpb25DbGllbnRCbGFja0JlcnJ5LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVy cnkvV2ViQ29yZVN1cHBvcnQvR2VvbG9jYXRpb25DbGllbnRCbGFja0JlcnJ5LmNwcApAQCAtMTMz LDggKzEzMyw2IEBAIHZvaWQgR2VvbG9jYXRpb25DbGllbnRCbGFja0JlcnJ5OjpjYW5jZWxQZXJt aXNzaW9uUmVxdWVzdChHZW9sb2NhdGlvbiogbG9jYXRpb24pCiAKICAgICAvLyBSZW1vdmUgdGhl IGdlb2xvY2F0aW9uIGZyb20gdGhlIHBlbmRpbmcgcGVybWlzc2lvbiBtYXAuCiAgICAgSGFzaE1h cDxTdHJpbmcsIFZlY3RvcjxSZWZQdHI8R2VvbG9jYXRpb24+ID4gPjo6aXRlcmF0b3IgaXQgPSBt X2dlb2xvY2F0aW9uUmVxdWVzdE1hcC5maW5kKG9yaWdpbik7Ci0KLSAgICBBU1NFUlQoaXQgIT0g bV9nZW9sb2NhdGlvblJlcXVlc3RNYXAuZW5kKCkpOwogICAgIGlmIChpdCA9PSBtX2dlb2xvY2F0 aW9uUmVxdWVzdE1hcC5lbmQoKSkKICAgICAgICAgcmV0dXJuOwogCi0tIAoxLjcuNS40Cgo=