105648 2012-12-21 12:04:56 -0800 Change RenderLayerBacking::nameForLayer() to RenderLayer::name() 2013-01-04 10:00:52 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 wangxianzhu wangxianzhu eric ojan.autocc simon.fraser webkit.review.bot oldest_to_newest 796409 0 wangxianzhu 2012-12-21 12:04:56 -0800 Sometimes I need to print the name of a layer when it is not composited, e.g. to print the name of the layers that causing main thread scrolling in ScrollingCoordinator. This would be easy if RenderLayer::name() is available. 796410 1 180541 wangxianzhu 2012-12-21 12:10:13 -0800 Created attachment 180541 Patch 800310 2 180541 webkit.review.bot 2013-01-04 10:00:48 -0800 Comment on attachment 180541 Patch Clearing flags on attachment: 180541 Committed r138809: <http://trac.webkit.org/changeset/138809> 800311 3 webkit.review.bot 2013-01-04 10:00:52 -0800 All reviewed patches have been landed. Closing bug. 180541 2012-12-21 12:10:13 -0800 2013-01-04 10:00:48 -0800 Patch bug-105648-20121221200728.patch text/plain 7031 wangxianzhu U3VidmVyc2lvbiBSZXZpc2lvbjogMTM4MzkzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDZiNTY5NDFkYjk3NTNk MTA1YzJiNGEzNWYxNjhiYjA5YWRiYjc4Zi4uNTFhZDQ4OTQ4NTk0NjNjZGYyMWYzNjhlOTVlYjc4 NWU0OTdmNjA1NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDEyLTEyLTIxICBYaWFu emh1IFdhbmcgIDx3YW5neGlhbnpodUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgQ2hhbmdlIFJl bmRlckxheWVyQmFja2luZzo6bmFtZUZvckxheWVyKCkgdG8gUmVuZGVyTGF5ZXI6Om5hbWUoKQor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA1NjQ4CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRl c3RzLiBGb3IgZGVidWdnaW5nIG9ubHkuCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyTGF5 ZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyTGF5ZXI6Om5hbWUpOgorICAgICAgICAo V2ViQ29yZSk6CisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlckxheWVyLmg6CisgICAgICAgIChS ZW5kZXJMYXllcik6CisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlckxheWVyQmFja2luZy5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJMYXllckJhY2tpbmc6OmNyZWF0ZVByaW1hcnlHcmFw aGljc0xheWVyKToKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckxheWVyQmFja2luZzo6dXBkYXRl Rm9yZWdyb3VuZExheWVyKToKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyTGF5ZXJCYWNraW5n Lmg6CisgICAgICAgIChSZW5kZXJMYXllckJhY2tpbmcpOgorICAgICAgICAqIHJlbmRlcmluZy9S ZW5kZXJMYXllckNvbXBvc2l0b3IuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyTGF5ZXJD b21wb3NpdG9yOjpsb2dMYXllckluZm8pOgorCiAyMDEyLTEyLTIxICBLZW5uZXRoIFJ1c3NlbGwg IDxrYnJAZ29vZ2xlLmNvbT4KIAogICAgICAgICBFeHBvc2UgQXJyYXlCdWZmZXJWaWV3IGNvbnN0 cnVjdG9yIG9uIERPTVdpbmRvdwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5n L1JlbmRlckxheWVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllci5j cHAKaW5kZXggYzBjZTgyNDBhYjlmOGU5ZmM5NmI0NGQwNjVkMjhmMjlkYWQ5OTA3Yi4uMDNiODkx ZWNiZTE1YTA2N2NiYjU5NTg4NmJkZTdhNThmZmQ3NGMzMCAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5k ZXJpbmcvUmVuZGVyTGF5ZXIuY3BwCkBAIC0yNTcsNiArMjU3LDM5IEBAIFJlbmRlckxheWVyOjp+ UmVuZGVyTGF5ZXIoKQogICAgICAgICBtX3Jlc2l6ZXItPmRlc3Ryb3koKTsKIH0KIAorU3RyaW5n IFJlbmRlckxheWVyOjpuYW1lKCkgY29uc3QKK3sKKyAgICBTdHJpbmdCdWlsZGVyIG5hbWU7Cisg ICAgbmFtZS5hcHBlbmQocmVuZGVyZXIoKS0+cmVuZGVyTmFtZSgpKTsKKyAgICBpZiAoTm9kZSog bm9kZSA9IHJlbmRlcmVyKCktPm5vZGUoKSkgeworICAgICAgICBpZiAobm9kZS0+aXNFbGVtZW50 Tm9kZSgpKSB7CisgICAgICAgICAgICBuYW1lLmFwcGVuZCgnICcpOworICAgICAgICAgICAgbmFt ZS5hcHBlbmQoc3RhdGljX2Nhc3Q8RWxlbWVudCo+KG5vZGUpLT50YWdOYW1lKCkpOworICAgICAg ICB9CisgICAgICAgIGlmIChub2RlLT5oYXNJRCgpKSB7CisgICAgICAgICAgICBuYW1lLmFwcGVu ZExpdGVyYWwoIiBpZD1cJyIpOworICAgICAgICAgICAgbmFtZS5hcHBlbmQoc3RhdGljX2Nhc3Q8 RWxlbWVudCo+KG5vZGUpLT5nZXRJZEF0dHJpYnV0ZSgpKTsKKyAgICAgICAgICAgIG5hbWUuYXBw ZW5kKCdcJycpOworICAgICAgICB9CisKKyAgICAgICAgaWYgKG5vZGUtPmhhc0NsYXNzKCkpIHsK KyAgICAgICAgICAgIG5hbWUuYXBwZW5kTGl0ZXJhbCgiIGNsYXNzPVwnIik7CisgICAgICAgICAg ICBTdHlsZWRFbGVtZW50KiBzdHlsZWRFbGVtZW50ID0gc3RhdGljX2Nhc3Q8U3R5bGVkRWxlbWVu dCo+KG5vZGUpOworICAgICAgICAgICAgZm9yIChzaXplX3QgaSA9IDA7IGkgPCBzdHlsZWRFbGVt ZW50LT5jbGFzc05hbWVzKCkuc2l6ZSgpOyArK2kpIHsKKyAgICAgICAgICAgICAgICBpZiAoaSA+ IDApCisgICAgICAgICAgICAgICAgICAgIG5hbWUuYXBwZW5kKCcgJyk7CisgICAgICAgICAgICAg ICAgbmFtZS5hcHBlbmQoc3R5bGVkRWxlbWVudC0+Y2xhc3NOYW1lcygpW2ldKTsKKyAgICAgICAg ICAgIH0KKyAgICAgICAgICAgIG5hbWUuYXBwZW5kKCdcJycpOworICAgICAgICB9CisgICAgfQor CisgICAgaWYgKGlzUmVmbGVjdGlvbigpKQorICAgICAgICBuYW1lLmFwcGVuZExpdGVyYWwoIiAo cmVmbGVjdGlvbikiKTsKKworICAgIHJldHVybiBuYW1lLnRvU3RyaW5nKCk7Cit9CisKICNpZiBV U0UoQUNDRUxFUkFURURfQ09NUE9TSVRJTkcpCiBSZW5kZXJMYXllckNvbXBvc2l0b3IqIFJlbmRl ckxheWVyOjpjb21wb3NpdG9yKCkgY29uc3QKIHsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L3JlbmRlcmluZy9SZW5kZXJMYXllci5oIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRl ckxheWVyLmgKaW5kZXggOGNhNGQwMDk0ZDQ5NGY5YzY1YWNhNGNjNGQ2MDNlYmM3YWY2NGIyNy4u NjE3OTg4MDc2NTE3NTQ3MjQ2MDVmODYzZGI4YWRiNWFhNzljZjYyNSAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyLmgKKysrIGIvU291cmNlL1dlYkNvcmUv cmVuZGVyaW5nL1JlbmRlckxheWVyLmgKQEAgLTI1OCw2ICsyNTgsOCBAQCBwdWJsaWM6CiAgICAg UmVuZGVyTGF5ZXIoUmVuZGVyTGF5ZXJNb2RlbE9iamVjdCopOwogICAgIH5SZW5kZXJMYXllcigp OwogCisgICAgU3RyaW5nIG5hbWUoKSBjb25zdDsKKwogICAgIFJlbmRlckxheWVyTW9kZWxPYmpl Y3QqIHJlbmRlcmVyKCkgY29uc3QgeyByZXR1cm4gbV9yZW5kZXJlcjsgfQogICAgIFJlbmRlckJv eCogcmVuZGVyQm94KCkgY29uc3QgeyByZXR1cm4gbV9yZW5kZXJlciAmJiBtX3JlbmRlcmVyLT5p c0JveCgpID8gdG9SZW5kZXJCb3gobV9yZW5kZXJlcikgOiAwOyB9CiAgICAgUmVuZGVyTGF5ZXIq IHBhcmVudCgpIGNvbnN0IHsgcmV0dXJuIG1fcGFyZW50OyB9CmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXJCYWNraW5nLmNwcCBiL1NvdXJjZS9XZWJDb3Jl L3JlbmRlcmluZy9SZW5kZXJMYXllckJhY2tpbmcuY3BwCmluZGV4IGJjOTZjMWYyZGYzNTRjZTZi MWJiMGE3ZjU2MDAzMjFlYmI4NjZmODAuLmI0NzViMWIyYzA2YTRmNDQxMzU5MjgwZTNmYzRjNGFm MTUxYjIxMWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXll ckJhY2tpbmcuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllckJh Y2tpbmcuY3BwCkBAIC0yNDUsNyArMjQ1LDcgQEAgdm9pZCBSZW5kZXJMYXllckJhY2tpbmc6OmNy ZWF0ZVByaW1hcnlHcmFwaGljc0xheWVyKCkKIHsKICAgICBTdHJpbmcgbGF5ZXJOYW1lOwogI2lm bmRlZiBOREVCVUcKLSAgICBsYXllck5hbWUgPSBuYW1lRm9yTGF5ZXIoKTsKKyAgICBsYXllck5h bWUgPSBtX293bmluZ0xheWVyLT5uYW1lKCk7CiAjZW5kaWYKICAgICAKICAgICAvLyBUaGUgY2Fs bCB0byBjcmVhdGVHcmFwaGljc0xheWVyIGVuZHMgY2FsbGluZyBiYWNrIGludG8gaGVyZSBhcwpA QCAtOTkwLDcgKzk5MCw3IEBAIGJvb2wgUmVuZGVyTGF5ZXJCYWNraW5nOjp1cGRhdGVGb3JlZ3Jv dW5kTGF5ZXIoYm9vbCBuZWVkc0ZvcmVncm91bmRMYXllcikKICAgICAgICAgaWYgKCFtX2ZvcmVn cm91bmRMYXllcikgewogICAgICAgICAgICAgU3RyaW5nIGxheWVyTmFtZTsKICNpZm5kZWYgTkRF QlVHCi0gICAgICAgICAgICBsYXllck5hbWUgPSBuYW1lRm9yTGF5ZXIoKSArICIgKGZvcmVncm91 bmQpIjsKKyAgICAgICAgICAgIGxheWVyTmFtZSA9IG1fb3duaW5nTGF5ZXItPm5hbWUoKSArICIg KGZvcmVncm91bmQpIjsKICNlbmRpZgogICAgICAgICAgICAgbV9mb3JlZ3JvdW5kTGF5ZXIgPSBj cmVhdGVHcmFwaGljc0xheWVyKGxheWVyTmFtZSk7CiAgICAgICAgICAgICBtX2ZvcmVncm91bmRM YXllci0+c2V0RHJhd3NDb250ZW50KHRydWUpOwpAQCAtMTk4NywzOSArMTk4Nyw2IEBAIEFuaW1h dGVkUHJvcGVydHlJRCBSZW5kZXJMYXllckJhY2tpbmc6OmNzc1RvR3JhcGhpY3NMYXllclByb3Bl cnR5KENTU1Byb3BlcnR5SUQKICAgICByZXR1cm4gQW5pbWF0ZWRQcm9wZXJ0eUludmFsaWQ7CiB9 CiAKLVN0cmluZyBSZW5kZXJMYXllckJhY2tpbmc6Om5hbWVGb3JMYXllcigpIGNvbnN0Ci17Ci0g ICAgU3RyaW5nQnVpbGRlciBuYW1lOwotICAgIG5hbWUuYXBwZW5kKHJlbmRlcmVyKCktPnJlbmRl ck5hbWUoKSk7Ci0gICAgaWYgKE5vZGUqIG5vZGUgPSByZW5kZXJlcigpLT5ub2RlKCkpIHsKLSAg ICAgICAgaWYgKG5vZGUtPmlzRWxlbWVudE5vZGUoKSkgewotICAgICAgICAgICAgbmFtZS5hcHBl bmQoJyAnKTsKLSAgICAgICAgICAgIG5hbWUuYXBwZW5kKHN0YXRpY19jYXN0PEVsZW1lbnQqPihu b2RlKS0+dGFnTmFtZSgpKTsKLSAgICAgICAgfQotICAgICAgICBpZiAobm9kZS0+aGFzSUQoKSkg ewotICAgICAgICAgICAgbmFtZS5hcHBlbmRMaXRlcmFsKCIgaWQ9XCciKTsKLSAgICAgICAgICAg IG5hbWUuYXBwZW5kKHN0YXRpY19jYXN0PEVsZW1lbnQqPihub2RlKS0+Z2V0SWRBdHRyaWJ1dGUo KSk7Ci0gICAgICAgICAgICBuYW1lLmFwcGVuZCgnXCcnKTsKLSAgICAgICAgfQotCi0gICAgICAg IGlmIChub2RlLT5oYXNDbGFzcygpKSB7Ci0gICAgICAgICAgICBuYW1lLmFwcGVuZExpdGVyYWwo IiBjbGFzcz1cJyIpOwotICAgICAgICAgICAgU3R5bGVkRWxlbWVudCogc3R5bGVkRWxlbWVudCA9 IHN0YXRpY19jYXN0PFN0eWxlZEVsZW1lbnQqPihub2RlKTsKLSAgICAgICAgICAgIGZvciAoc2l6 ZV90IGkgPSAwOyBpIDwgc3R5bGVkRWxlbWVudC0+Y2xhc3NOYW1lcygpLnNpemUoKTsgKytpKSB7 Ci0gICAgICAgICAgICAgICAgaWYgKGkgPiAwKQotICAgICAgICAgICAgICAgICAgICBuYW1lLmFw cGVuZCgnICcpOwotICAgICAgICAgICAgICAgIG5hbWUuYXBwZW5kKHN0eWxlZEVsZW1lbnQtPmNs YXNzTmFtZXMoKVtpXSk7Ci0gICAgICAgICAgICB9Ci0gICAgICAgICAgICBuYW1lLmFwcGVuZCgn XCcnKTsKLSAgICAgICAgfQotICAgIH0KLQotICAgIGlmIChtX293bmluZ0xheWVyLT5pc1JlZmxl Y3Rpb24oKSkKLSAgICAgICAgbmFtZS5hcHBlbmRMaXRlcmFsKCIgKHJlZmxlY3Rpb24pIik7Ci0K LSAgICByZXR1cm4gbmFtZS50b1N0cmluZygpOwotfQotCiBDb21wb3NpdGluZ0xheWVyVHlwZSBS ZW5kZXJMYXllckJhY2tpbmc6OmNvbXBvc2l0aW5nTGF5ZXJUeXBlKCkgY29uc3QKIHsKICAgICBp ZiAobV9ncmFwaGljc0xheWVyLT5oYXNDb250ZW50c0xheWVyKCkpCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXJCYWNraW5nLmggYi9Tb3VyY2UvV2ViQ29y ZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXJCYWNraW5nLmgKaW5kZXggZWFkZTBjZjNkMzkzZWM2YmMw ZWQ5Y2MzOWRhZjMzODhhNWJiNDg4Zi4uNDEwZWM3ZDFkYzEzZjZkZjEwNjllMmQ1MTBhMzk1OTAw MzViOWNmYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVy QmFja2luZy5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllckJhY2tp bmcuaApAQCAtMTg2LDggKzE4Niw2IEBAIHB1YmxpYzoKICAgICAvLyBSZXR1cm4gYW4gZXN0aW1h dGUgb2YgdGhlIGJhY2tpbmcgc3RvcmUgYXJlYSAoaW4gcGl4ZWxzKSBhbGxvY2F0ZWQgYnkgdGhp cyBvYmplY3QncyBHcmFwaGljc0xheWVycy4KICAgICBkb3VibGUgYmFja2luZ1N0b3JlTWVtb3J5 RXN0aW1hdGUoKSBjb25zdDsKIAotICAgIFN0cmluZyBuYW1lRm9yTGF5ZXIoKSBjb25zdDsKLSAg ICAKICNpZiBFTkFCTEUoQ1NTX0NPTVBPU0lUSU5HKQogICAgIHZvaWQgc2V0QmxlbmRNb2RlKEJs ZW5kTW9kZSk7CiAjZW5kaWYKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9S ZW5kZXJMYXllckNvbXBvc2l0b3IuY3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRl ckxheWVyQ29tcG9zaXRvci5jcHAKaW5kZXggZjBkNTNlMmU5NWUzOGM2MDY5NzVmMzI5OGVlNjBi NjA1NTdmODVkMC4uMzI1NWUwZWJkYzY2MmQ2NTRiNWM3ZGZlMmVmNmEwMjMxMTM1OTE1NiAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyQ29tcG9zaXRvci5j cHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyQ29tcG9zaXRvci5j cHAKQEAgLTU0Myw3ICs1NDMsNyBAQCB2b2lkIFJlbmRlckxheWVyQ29tcG9zaXRvcjo6bG9nTGF5 ZXJJbmZvKGNvbnN0IFJlbmRlckxheWVyKiBsYXllciwgaW50IGRlcHRoKQogCiAgICAgTE9HKENv bXBvc2l0aW5nLCAiJSpwICVkeCVkICUuMmZLQiAoJXMpICVzXG4iLCAxMiArIGRlcHRoICogMiwg bGF5ZXIsIGJhY2tpbmctPmNvbXBvc2l0ZWRCb3VuZHMoKS53aWR0aCgpLCBiYWNraW5nLT5jb21w b3NpdGVkQm91bmRzKCkuaGVpZ2h0KCksCiAgICAgICAgIGJhY2tpbmctPmJhY2tpbmdTdG9yZU1l bW9yeUVzdGltYXRlKCkgLyAxMDI0LAotICAgICAgICByZWFzb25Gb3JDb21wb3NpdGluZyhsYXll ciksIGxheWVyLT5iYWNraW5nKCktPm5hbWVGb3JMYXllcigpLnV0ZjgoKS5kYXRhKCkpOworICAg ICAgICByZWFzb25Gb3JDb21wb3NpdGluZyhsYXllciksIGxheWVyLT5uYW1lKCkudXRmOCgpLmRh dGEoKSk7CiB9CiAjZW5kaWYKIAo=