105635 2012-12-21 07:56:49 -0800 Invalidation of some SVG filter attributes on HTML content doesn't work 2013-01-04 12:41:47 -0800 1 1 1 Unclassified WebKit SVG 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 senorblanco senorblanco dino d-r eric fmalita krit ojan.autocc pdr schenney webkit.review.bot zimmermann oldest_to_newest 796306 0 180523 senorblanco 2012-12-21 07:56:49 -0800 Created attachment 180523 Test case (click on the red box) Invalidation of some SVG filter attributes on HTML content doesn't work (see attachment -- clicking on the red box should turn it green). This is because the HTML RenderLayer invalidation happens only in RenderSVGResourceContainer::markAllClientsForInvalidation() (the bottom section which invalidates m_clientLayers), but attribute changes sometimes go through RenderSVGResourceContainer::markClientForInvalidation(), called by RenderSVGResourceFilter::primitiveAttributeChanged(). 796339 1 180528 senorblanco 2012-12-21 09:12:34 -0800 Created attachment 180528 Patch 800462 2 180528 krit 2013-01-04 11:50:05 -0800 Comment on attachment 180528 Patch Sounds reasonable for me. r=me. 800526 3 180528 webkit.review.bot 2013-01-04 12:41:43 -0800 Comment on attachment 180528 Patch Clearing flags on attachment: 180528 Committed r138835: <http://trac.webkit.org/changeset/138835> 800527 4 webkit.review.bot 2013-01-04 12:41:47 -0800 All reviewed patches have been landed. Closing bug. 180523 2012-12-21 07:56:49 -0800 2012-12-21 07:56:49 -0800 Test case (click on the red box) filter-invalidation.html text/html 514 senorblanco PGhlYWQ+CiAgPHNjcmlwdD4KICAgIGZ1bmN0aW9uIHJ1bigpIHsKICAgICAgZG9jdW1lbnQuZ2V0 RWxlbWVudEJ5SWQoJ2NvbG9yJykuc2V0QXR0cmlidXRlKCd2YWx1ZXMnLCAnOTAnKTsKICAgfQog PC9zY3JpcHQ+CjwvaGVhZD4KPGJvZHk+CiAgIDxzdmcgeG1sbnM9Imh0dHA6Ly93d3cudzMub3Jn LzIwMDAvc3ZnIiB3aWR0aD0iMCIgaGVpZ2h0PSIwIiB2ZXJzaW9uPSIxLjEiPgogICAgPGRlZnM+ CiAgICAgIDxmaWx0ZXIgaWQ9Ik15RmlsdGVyIj4KICAgICAgICA8ZmVjb2xvcm1hdHJpeCBpZD0i Y29sb3IiIHR5cGU9Imh1ZVJvdGF0ZSI+PC9mZWNvbG9ybWF0cml4PgogICAgICA8L2ZpbHRlcj4K ICAgIDwvZGVmcz4KICA8L3N2Zz4KICA8ZGl2IHN0eWxlPSItd2Via2l0LWZpbHRlcjogdXJsKCNN eUZpbHRlcik7IGZpbHRlcjogdXJsKCNNeUZpbHRlcik7IHdpZHRoOjEwMHB4OyBoZWlnaHQ6MTAw cHg7IGJhY2tncm91bmQtY29sb3I6cmVkOyIgb25jbGljaz0icnVuKCkiPjwvZGl2Pgo8L2JvZHk+ Cg== 180528 2012-12-21 09:12:34 -0800 2013-01-04 12:41:43 -0800 Patch bug-105635-20121221120949.patch text/plain 6624 senorblanco U3VidmVyc2lvbiBSZXZpc2lvbjogMTM4MjgwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTYxZDgzNTA5YmYzNDFi YjVlNzliZmJiYWJmMDhlOWFiY2UxYzAwOC4uYTNmNjQ5ZGZjMDk2MWEzNmEyNDgxYWRjYzBlNzBk NmJkM2Q2YjRiMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI5IEBACisyMDEyLTEyLTIxICBTdGVw aGVuIFdoaXRlICA8c2Vub3JibGFuY29AY2hyb21pdW0ub3JnPgorCisgICAgICAgIEludmFsaWRh dGlvbiBvZiBzb21lIFNWRyBmaWx0ZXIgYXR0cmlidXRlcyBvbiBIVE1MIGNvbnRlbnQgZG9lc24n dCB3b3JrIAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTA1NjM1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg U2luY2UgSFRNTCBlbGVtZW50cyB3aXRoIGZpbHRlcnMgYXJlIG9ubHkgYWRkZWQgdG8gbV9jbGll bnRMYXllcnMsIG5vdAorICAgICAgICBtX2NsaWVudHMsIGFuZCBkbyBub3QgdXNlIHRoZSBGaWx0 ZXJJbmZvIHVzZWQgYnkgU1ZHIGZpbHRlcnMgb24gU1ZHCisgICAgICAgIGVsZW1lbnRzLCB0aGV5 IG11c3QgYmUgaW52YWxpZGF0ZWQgc2VwYXJhdGVseS4gIFNvbWUgZmlsdGVyIGF0dHJpYnV0ZQor ICAgICAgICBpbnZhbGlkYXRpb25zIGNhbGwgbWFya0FsbENsaWVudHNGb3JJbnZhbGlkYXRpb24o KSwgYnV0IHNvbWUgY2FsbAorICAgICAgICBtYXJrQ2xpZW50Rm9ySW52YWxpZGF0aW9uKCkgZGly ZWN0bHkuICBUaGVzZSBpbnZhbGRhdGlvbnMgbXVzdCBhbHNvIAorICAgICAgICBpbnZhbGlkYXRl IG1fY2xpZW50TGF5ZXJzLgorCisgICAgICAgIFRlc3Q6IGNzczMvZmlsdGVycy9yZWZlcmVuY2Ut ZmlsdGVyLXVwZGF0ZS1vbi1hdHRyaWJ1dGUtY2hhbmdlLmh0bWwKKworICAgICAgICAqIHJlbmRl cmluZy9zdmcvUmVuZGVyU1ZHUmVzb3VyY2VDb250YWluZXIuY3BwOgorICAgICAgICAoV2ViQ29y ZTo6UmVuZGVyU1ZHUmVzb3VyY2VDb250YWluZXI6Om1hcmtBbGxDbGllbnRzRm9ySW52YWxpZGF0 aW9uKToKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlclNWR1Jlc291cmNlQ29udGFpbmVyOjptYXJr QWxsQ2xpZW50TGF5ZXJzRm9ySW52YWxpZGF0aW9uKToKKyAgICAgICAgKiByZW5kZXJpbmcvc3Zn L1JlbmRlclNWR1Jlc291cmNlQ29udGFpbmVyLmg6CisgICAgICAgIFJlZmFjdG9yIGNsaWVudCBs YXllciBpbnZhbGlkYXRpb24gb3V0IGludG8gaXRzIG93biBmdW5jdGlvbi4KKyAgICAgICAgKiBy ZW5kZXJpbmcvc3ZnL1JlbmRlclNWR1Jlc291cmNlRmlsdGVyLmNwcDoKKyAgICAgICAgKFdlYkNv cmU6OlJlbmRlclNWR1Jlc291cmNlRmlsdGVyOjpwcmltaXRpdmVBdHRyaWJ1dGVDaGFuZ2VkKToK KyAgICAgICAgTWFyayBhbGwgY2xpZW50IGxheWVycyBmb3IgaW52YWxpZGF0aW9uIHdoZW4gYSBm aWx0ZXIgcHJpbWl0dmUgYXR0cmlidXRlIGlzCisgICAgICAgIGNoYW5nZWQuCisKIDIwMTItMTIt MTkgIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CiAKICAgICAgICAgTG90 cyBvZiBzdGlja3kgdGVzdHMgZmFpbGluZyBpbiBXSzIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL3JlbmRlcmluZy9zdmcvUmVuZGVyU1ZHUmVzb3VyY2VDb250YWluZXIuY3BwIGIvU291cmNl L1dlYkNvcmUvcmVuZGVyaW5nL3N2Zy9SZW5kZXJTVkdSZXNvdXJjZUNvbnRhaW5lci5jcHAKaW5k ZXggZTMxMWMxYzIxMWE3MjRiNzVlMzIxNWU2NGZlNGQ0ZmUxMjBkMDI4OS4uYjFkNDdhZmQ5OGQz YTQ0MTk5NzlkOWNkMTBhOWI3YjhkODYwYmJlNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv cmVuZGVyaW5nL3N2Zy9SZW5kZXJTVkdSZXNvdXJjZUNvbnRhaW5lci5jcHAKKysrIGIvU291cmNl L1dlYkNvcmUvcmVuZGVyaW5nL3N2Zy9SZW5kZXJTVkdSZXNvdXJjZUNvbnRhaW5lci5jcHAKQEAg LTExNCwxMyArMTE0LDE4IEBAIHZvaWQgUmVuZGVyU1ZHUmVzb3VyY2VDb250YWluZXI6Om1hcmtB bGxDbGllbnRzRm9ySW52YWxpZGF0aW9uKEludmFsaWRhdGlvbk1vZGUKICAgICAgICAgUmVuZGVy U1ZHUmVzb3VyY2U6Om1hcmtGb3JMYXlvdXRBbmRQYXJlbnRSZXNvdXJjZUludmFsaWRhdGlvbihj bGllbnQsIG5lZWRzTGF5b3V0KTsKICAgICB9CiAKKyAgICBtYXJrQWxsQ2xpZW50TGF5ZXJzRm9y SW52YWxpZGF0aW9uKCk7CisKKyAgICBtX2lzSW52YWxpZGF0aW5nID0gZmFsc2U7Cit9CisKK3Zv aWQgUmVuZGVyU1ZHUmVzb3VyY2VDb250YWluZXI6Om1hcmtBbGxDbGllbnRMYXllcnNGb3JJbnZh bGlkYXRpb24oKQorewogI2lmIEVOQUJMRShDU1NfRklMVEVSUykKICAgICBIYXNoU2V0PFJlbmRl ckxheWVyKj46Oml0ZXJhdG9yIGxheWVyRW5kID0gbV9jbGllbnRMYXllcnMuZW5kKCk7CiAgICAg Zm9yIChIYXNoU2V0PFJlbmRlckxheWVyKj46Oml0ZXJhdG9yIGl0ID0gbV9jbGllbnRMYXllcnMu YmVnaW4oKTsgaXQgIT0gbGF5ZXJFbmQ7ICsraXQpCiAgICAgICAgICgqaXQpLT5maWx0ZXJOZWVk c1JlcGFpbnQoKTsKICNlbmRpZgotCi0gICAgbV9pc0ludmFsaWRhdGluZyA9IGZhbHNlOwogfQog CiB2b2lkIFJlbmRlclNWR1Jlc291cmNlQ29udGFpbmVyOjptYXJrQ2xpZW50Rm9ySW52YWxpZGF0 aW9uKFJlbmRlck9iamVjdCogY2xpZW50LCBJbnZhbGlkYXRpb25Nb2RlIG1vZGUpCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvc3ZnL1JlbmRlclNWR1Jlc291cmNlQ29udGFp bmVyLmggYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvc3ZnL1JlbmRlclNWR1Jlc291cmNlQ29u dGFpbmVyLmgKaW5kZXggMGYwNzQ4NjNiOGNkZTEzYjI3ZGIzNGU4NzY0NzViZGM2YzNhODNmOS4u MGY0MjVjZDQ1YWRmNjc0MzMxZDg4NDVkMzZjOGI1YWIzNzM0NjliYSAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3N2Zy9SZW5kZXJTVkdSZXNvdXJjZUNvbnRhaW5lci5oCisr KyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9zdmcvUmVuZGVyU1ZHUmVzb3VyY2VDb250YWlu ZXIuaApAQCAtNTcsNiArNTcsNyBAQCBwcm90ZWN0ZWQ6CiAKICAgICAvLyBVc2VkIGZyb20gdGhl IGludmFsaWRhdGVDbGllbnQvaW52YWxpZGF0ZUNsaWVudHMgbWV0aG9kcyBmcm9tIGNsYXNzZXMs IGluaGVyaXRpbmcgZnJvbSB1cy4KICAgICB2b2lkIG1hcmtBbGxDbGllbnRzRm9ySW52YWxpZGF0 aW9uKEludmFsaWRhdGlvbk1vZGUpOworICAgIHZvaWQgbWFya0FsbENsaWVudExheWVyc0Zvcklu dmFsaWRhdGlvbigpOwogICAgIHZvaWQgbWFya0NsaWVudEZvckludmFsaWRhdGlvbihSZW5kZXJP YmplY3QqLCBJbnZhbGlkYXRpb25Nb2RlKTsKIAogcHJpdmF0ZToKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL3JlbmRlcmluZy9zdmcvUmVuZGVyU1ZHUmVzb3VyY2VGaWx0ZXIuY3BwIGIvU291 cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3N2Zy9SZW5kZXJTVkdSZXNvdXJjZUZpbHRlci5jcHAKaW5k ZXggODQ0NWY1ZDc2OTJjOTBjZDhiOTA0ODQ1MGJjOTVhMDFkNzcyMTc1Zi4uMjk4M2M0ZjEyNTcy MDY1ZDYzZjEyYmQzMjI5NGQxMjAzNDdiZTRiMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv cmVuZGVyaW5nL3N2Zy9SZW5kZXJTVkdSZXNvdXJjZUZpbHRlci5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvcmVuZGVyaW5nL3N2Zy9SZW5kZXJTVkdSZXNvdXJjZUZpbHRlci5jcHAKQEAgLTM2MSw2 ICszNjEsNyBAQCB2b2lkIFJlbmRlclNWR1Jlc291cmNlRmlsdGVyOjpwcmltaXRpdmVBdHRyaWJ1 dGVDaGFuZ2VkKFJlbmRlck9iamVjdCogb2JqZWN0LCBjbwogICAgICAgICAvLyBSZXBhaW50IHRo ZSBpbWFnZSBvbiB0aGUgc2NyZWVuLgogICAgICAgICBtYXJrQ2xpZW50Rm9ySW52YWxpZGF0aW9u KGl0LT5rZXksIFJlcGFpbnRJbnZhbGlkYXRpb24pOwogICAgIH0KKyAgICBtYXJrQWxsQ2xpZW50 TGF5ZXJzRm9ySW52YWxpZGF0aW9uKCk7CiB9CiAKIH0KZGlmZiAtLWdpdCBhL0xheW91dFRlc3Rz L0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCBjMWVmNzBlMmYxYmQ5NjJi ZmZhZjY1MjE0NDIwZjY3N2NkNjE4ZmMzLi45OTk4NTgxNjZiZjRjNjE4YzhlYWIyZTc1MTQ4MWNj NmU4NTVlMWM3IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0 VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTItMTItMjEgIFN0ZXBoZW4gV2hp dGUgIDxzZW5vcmJsYW5jb0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgSW52YWxpZGF0aW9uIG9m IHNvbWUgU1ZHIGZpbHRlciBhdHRyaWJ1dGVzIG9uIEhUTUwgY29udGVudCBkb2Vzbid0IHdvcmsg CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDU2MzUK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBOZXcgcmVm dGVzdCB0byB2ZXJpZnkgZmlsdGVyIGF0dHJpYnV0ZSBjaGFuZ2UgaW52YWxpZGF0aW9ucy4KKwor ICAgICAgICAqIGNzczMvZmlsdGVycy9yZWZlcmVuY2UtZmlsdGVyLXVwZGF0ZS1vbi1hdHRyaWJ1 dGUtY2hhbmdlLWV4cGVjdGVkLmh0bWw6IEFkZGVkLgorICAgICAgICAqIGNzczMvZmlsdGVycy9y ZWZlcmVuY2UtZmlsdGVyLXVwZGF0ZS1vbi1hdHRyaWJ1dGUtY2hhbmdlLmh0bWw6IEFkZGVkLgor CiAyMDEyLTEyLTIwICBFbGxpb3R0IFNwcmVobiAgPGVzcHJlaG5AZ21haWwuY29tPgogCiAgICAg ICAgIEJsb2NrIGxldmVsIHBzZXVkbyBlbGVtZW50cyBibGVlZCBiYWNrZ3JvdW5kIGNvbG9yIHRv IDxodG1sPgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvY3NzMy9maWx0ZXJzL3JlZmVyZW5jZS1m aWx0ZXItdXBkYXRlLW9uLWF0dHJpYnV0ZS1jaGFuZ2UtZXhwZWN0ZWQuaHRtbCBiL0xheW91dFRl c3RzL2NzczMvZmlsdGVycy9yZWZlcmVuY2UtZmlsdGVyLXVwZGF0ZS1vbi1hdHRyaWJ1dGUtY2hh bmdlLWV4cGVjdGVkLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uMWM1NTI0ZDM4NTcxMDBmNzJlMWFjZTZjOGE2 MmU0ZjkzZWM4ZDg5MAotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2NzczMvZmlsdGVy cy9yZWZlcmVuY2UtZmlsdGVyLXVwZGF0ZS1vbi1hdHRyaWJ1dGUtY2hhbmdlLWV4cGVjdGVkLmh0 bWwKQEAgLTAsMCArMSwxMCBAQAorPGJvZHk+CisgICA8c3ZnIHhtbG5zPSJodHRwOi8vd3d3Lncz Lm9yZy8yMDAwL3N2ZyIgd2lkdGg9IjAiIGhlaWdodD0iMCIgdmVyc2lvbj0iMS4xIj4KKyAgICA8 ZGVmcz4KKyAgICAgIDxmaWx0ZXIgaWQ9Ik15RmlsdGVyIj4KKyAgICAgICAgPGZlY29sb3JtYXRy aXggaWQ9ImNvbG9yIiB0eXBlPSJodWVSb3RhdGUiIHZhbHVlcz0iOTAiPjwvZmVjb2xvcm1hdHJp eD4KKyAgICAgIDwvZmlsdGVyPgorICAgIDwvZGVmcz4KKyAgPC9zdmc+CisgIDxkaXYgc3R5bGU9 Ii13ZWJraXQtZmlsdGVyOiB1cmwoI015RmlsdGVyKTsgZmlsdGVyOiB1cmwoI015RmlsdGVyKTsg d2lkdGg6MTAwcHg7IGhlaWdodDoxMDBweDsgYmFja2dyb3VuZC1jb2xvcjpyZWQ7Ij48L2Rpdj4K KzwvYm9keT4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2NzczMvZmlsdGVycy9yZWZlcmVuY2Ut ZmlsdGVyLXVwZGF0ZS1vbi1hdHRyaWJ1dGUtY2hhbmdlLmh0bWwgYi9MYXlvdXRUZXN0cy9jc3Mz L2ZpbHRlcnMvcmVmZXJlbmNlLWZpbHRlci11cGRhdGUtb24tYXR0cmlidXRlLWNoYW5nZS5odG1s Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAuLmU4YzJhMGI5NTE0NmZiNzQwOGU4YzVjY2UyMmI5MzM5MjNhYWFhZjYKLS0t IC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9jc3MzL2ZpbHRlcnMvcmVmZXJlbmNlLWZpbHRl ci11cGRhdGUtb24tYXR0cmlidXRlLWNoYW5nZS5odG1sCkBAIC0wLDAgKzEsMTcgQEAKKzxoZWFk PgorICA8c2NyaXB0PgorICAgIGZ1bmN0aW9uIHJ1bigpIHsKKyAgICAgIGRvY3VtZW50LmdldEVs ZW1lbnRCeUlkKCdjb2xvcicpLnNldEF0dHJpYnV0ZSgndmFsdWVzJywgJzkwJyk7CisgICAgfQor IDwvc2NyaXB0PgorPC9oZWFkPgorPGJvZHkgb25sb2FkPSJydW4oKSI+CisgICA8c3ZnIHhtbG5z PSJodHRwOi8vd3d3LnczLm9yZy8yMDAwL3N2ZyIgd2lkdGg9IjAiIGhlaWdodD0iMCIgdmVyc2lv bj0iMS4xIj4KKyAgICA8ZGVmcz4KKyAgICAgIDxmaWx0ZXIgaWQ9Ik15RmlsdGVyIj4KKyAgICAg ICAgPGZlY29sb3JtYXRyaXggaWQ9ImNvbG9yIiB0eXBlPSJodWVSb3RhdGUiPjwvZmVjb2xvcm1h dHJpeD4KKyAgICAgIDwvZmlsdGVyPgorICAgIDwvZGVmcz4KKyAgPC9zdmc+CisgIDxkaXYgc3R5 bGU9Ii13ZWJraXQtZmlsdGVyOiB1cmwoI015RmlsdGVyKTsgZmlsdGVyOiB1cmwoI015RmlsdGVy KTsgd2lkdGg6MTAwcHg7IGhlaWdodDoxMDBweDsgYmFja2dyb3VuZC1jb2xvcjpyZWQ7Ij48L2Rp dj4KKzwvYm9keT4K