105632 2012-12-21 05:41:28 -0800 [EFL][WK2] Never create WebCore scrollbars for EFL/WK2 2017-03-11 10:48:01 -0800 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED WONTFIX P2 Normal --- 119484 1 kenneth kenneth allan.jensen lucas.de.marchi mcatanzaro mikhail.pozdnyakov ossy tonikitoo webkit.review.bot oldest_to_newest 796256 0 kenneth 2012-12-21 05:41:28 -0800 SSIA 796261 1 180507 kenneth 2012-12-21 05:48:08 -0800 Created attachment 180507 Patch 796285 2 180507 tonikitoo 2012-12-21 06:57:57 -0800 Comment on attachment 180507 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=180507&action=review > Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:1238 > + m_frame->coreFrame()->createView(webPage->size(), backgroundColor, /* transparent */ false, IntSize(), currentFixedVisibleContentRect, shouldUseFixedLayout, ScrollbarAlwaysOff, true, ScrollbarAlwaysOff, true); would be nice to have true /*comment*/ here > Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:1246 > + m_frame->coreFrame()->view()->setTransparent(!webPage->drawsBackground()); can not you pass this as one of the parameter of createView? 796287 3 180515 kenneth 2012-12-21 07:08:12 -0800 Created attachment 180515 Patch 796307 4 180515 webkit.review.bot 2012-12-21 07:56:54 -0800 Comment on attachment 180515 Patch Clearing flags on attachment: 180515 Committed r138378: <http://trac.webkit.org/changeset/138378> 796308 5 webkit.review.bot 2012-12-21 07:56:58 -0800 All reviewed patches have been landed. Closing bug. 796416 6 ossy 2012-12-21 12:19:09 -0800 (In reply to comment #4) > (From update of attachment 180515 [details]) > Clearing flags on attachment: 180515 > > Committed r138378: <http://trac.webkit.org/changeset/138378> It made zillion tests fail on EFL-WK2 and Qt-WK2: - http://build.webkit.org/builders/EFL%20Linux%2064-bit%20Release%20WK2/builds/2026 - http://build.webkit.sed.hu/builders/x86-64%20Linux%20Qt%20Release%20WebKit2%20%28Amazon%20EC2%29/builds/12024 Could you check it, please? 796431 7 kenneth 2012-12-21 12:56:59 -0800 (In reply to comment #6) > (In reply to comment #4) > > (From update of attachment 180515 [details] [details]) > > Clearing flags on attachment: 180515 > > > > Committed r138378: <http://trac.webkit.org/changeset/138378> > > It made zillion tests fail on EFL-WK2 and Qt-WK2: > - http://build.webkit.org/builders/EFL%20Linux%2064-bit%20Release%20WK2/builds/2026 > - http://build.webkit.sed.hu/builders/x86-64%20Linux%20Qt%20Release%20WebKit2%20%28Amazon%20EC2%29/builds/12024 > > Could you check it, please? Sure, I will land potential fix. 796433 8 kenneth 2012-12-21 13:00:04 -0800 Landed potential fix in 138395 796740 9 ossy 2012-12-23 06:23:31 -0800 (In reply to comment #8) > Landed potential fix in 138395 Thanks, it fixed the bug I mentioned. 914542 10 allan.jensen 2013-08-05 04:04:02 -0700 This patch broke keyboard scrolling. The scrollbars are required for keyboard scrolling since information about linestep and pagestep is calculated in them. Therefore we should let delegated scrolling have scrollbars but just choose not to render them. 914544 11 allan.jensen 2013-08-05 04:05:02 -0700 Reopening since this needs to be solved differently. What was the problem with having ScrollBar objects in the first place? 914553 12 tonikitoo 2013-08-05 05:38:16 -0700 (In reply to comment #10) > This patch broke keyboard scrolling. The scrollbars are required for keyboard scrolling since information about linestep and pagestep is calculated in them. Therefore we should let delegated scrolling have scrollbars but just choose not to render them. Patch was inspired on BlackBerry port, when scrollbars are not created either. Keyboard scrolling used to fine there, as far as I can tell. It is not a path very explored, though.. 914554 13 tonikitoo 2013-08-05 05:39:13 -0700 (In reply to comment #12) > (In reply to comment #10) > > This patch broke keyboard scrolling. The scrollbars are required for keyboard scrolling since information about linestep and pagestep is calculated in them. Therefore we should let delegated scrolling have scrollbars but just choose not to render them. > > Patch was inspired on BlackBerry port, when scrollbars are not created either. > > Keyboard scrolling used to fine there, as far as I can tell. It is not a path very explored, though.. It's been 8 month since patch landed. Are there tests covering keyboard scrolling that EFL does not run? 914559 14 allan.jensen 2013-08-05 06:00:10 -0700 (In reply to comment #13) > (In reply to comment #12) > > (In reply to comment #10) > > > This patch broke keyboard scrolling. The scrollbars are required for keyboard scrolling since information about linestep and pagestep is calculated in them. Therefore we should let delegated scrolling have scrollbars but just choose not to render them. > > > > Patch was inspired on BlackBerry port, when scrollbars are not created either. > > > > Keyboard scrolling used to fine there, as far as I can tell. It is not a path very explored, though.. > > It's been 8 month since patch landed. Are there tests covering keyboard scrolling that EFL does not run? Back when I implemented it I solved wheel-events and keyboard scrolling together. I think only wheel events were tested. Btw, you can see the problem is ScrollableArea::scroll(), where it exists if no scrollbar is found. This only happens with delegated scrolling btw. For Qt WK2 we can run in either delegated or non-delated (touch or desktop mode). The desktop mode still works. 914567 15 tonikitoo 2013-08-05 06:25:36 -0700 > Btw, you can see the problem is ScrollableArea::scroll(), where it exists if no scrollbar is found. > > This only happens with delegated scrolling btw. For Qt WK2 we can run in either delegated or non-delated (touch or desktop mode). The desktop mode still works. That might be a deeper problem to solve: back at the time, I made a set of change decoupling scrolling from scrollbars. Maybe it has regressed. I remember kenneth testing both wheels and keyboard, but 'll let him to speak up. 1286670 16 mcatanzaro 2017-03-11 10:48:01 -0800 Closing this bug because the EFL port has been removed from trunk. If you feel this bug applies to a different upstream WebKit port and was closed in error, please either update the title and reopen the bug, or leave a comment to request this. 180507 2012-12-21 05:48:08 -0800 2012-12-21 07:08:07 -0800 Patch bug-105632-20121221144521.patch text/plain 4387 kenneth U3VidmVyc2lvbiBSZXZpc2lvbjogMTM4MzY1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzgzZDRkMjE2ODQ1ODU5 NDhjODU2NjdkMDEzYjY5MDJmY2RhZTg4My4uMGQ2ZTZmYjc5OGJmNWMxODc0YjQ0MjljNjJjNzhl ZDM1Nzc0ZWNmMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTEyLTIxICBLZW5u ZXRoIFJvaGRlIENocmlzdGlhbnNlbiAgPGtlbm5ldGhAd2Via2l0Lm9yZz4KKworICAgICAgICBb RUZMXVtXSzJdIE5ldmVyIGNyZWF0ZSBXZWJDb3JlIHNjcm9sbGJhcnMgZm9yIEVGTC9XSzIKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNTYzMgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZvciBkZWxlZ2F0 ZXMgc2Nyb2xsIHdlIG11c3Qgbm90IHVzZSB0aGUgc2Nyb2xsIGFuaW1hdG9yLAorICAgICAgICBv ciBzaW1pbGFyIGFzIHRob3NlIGRlcGVuZHMgb24gY3JlYXRpbmcgV2ViQ29yZSBzY3JvbGxiYXJz LgorCisgICAgICAgIEhhbmRsZSB0aGUgd2hlZWwgZXZlbnQgbWFudWFsbHkgZm9yIGRlbGVnYXRl cyBzY3JvbGxpbmcuCisKKyAgICAgICAgKiBwYWdlL0ZyYW1lVmlldy5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpGcmFtZVZpZXc6OndoZWVsRXZlbnQpOgorCiAyMDEyLTEyLTIxICBLZWlzaGkgSGF0 dG9yaSAgPGtlaXNoaUB3ZWJraXQub3JnPgogCiAgICAgICAgIEZpeCB0eXBpbmcgemVybyBpbnRv IG11bHRpcGxlIGZpZWxkIGlucHV0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VM b2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMTNjMDRjMzg3OGQ0ZWFiMTc5MzU4 NDE2MmY3MTUxZWRmY2UzOWRjYi4uY2RjNDJmMzYxYmQ1ZmYyMjJiNWZlOTEwMzM4MGNlYmYxNWUw Njk0NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9X ZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTEyLTIxICBLZW5uZXRoIFJv aGRlIENocmlzdGlhbnNlbiAgPGtlbm5ldGhAd2Via2l0Lm9yZz4KKworICAgICAgICBbRUZMXVtX SzJdIE5ldmVyIGNyZWF0ZSBXZWJDb3JlIHNjcm9sbGJhcnMgZm9yIEVGTC9XSzIKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNTYzMgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZW4gY3JlYXRpbmcgdGhl IGZyYW1lIGFzayB0byBub3QgY3JlYXRlIHNjcm9sbGJhcnMgYW5kCisgICAgICAgIGxvY2sgaXQg c28gdGhleSB3b24ndCBiZSBjcmVhdGVkIGF0IGFueSBsYXRlciB0aW1lLgorCisgICAgICAgICog V2ViUHJvY2Vzcy9XZWJDb3JlU3VwcG9ydC9XZWJGcmFtZUxvYWRlckNsaWVudC5jcHA6CisgICAg ICAgIChXZWJLaXQ6OldlYkZyYW1lTG9hZGVyQ2xpZW50Ojp0cmFuc2l0aW9uVG9Db21taXR0ZWRG b3JOZXdQYWdlKToKKwogMjAxMi0xMi0yMSAgVGltIEhvcnRvbiAgPHRpbW90aHlfaG9ydG9uQGFw cGxlLmNvbT4KIAogICAgICAgICBQREZQbHVnaW46IENhbm5vdCBkcm9wIGZpbGVzL1VSTHMgb24g UERGUGx1Z2luCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1lVmlldy5jcHAg Yi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1lVmlldy5jcHAKaW5kZXggMmRkMjFjNGJlYmQwODIy MDU2NzM0Y2I1YzkwZGUyOGFmZThkZDA2Ni4uYTg0OGRlYjkxZDQ3ZjgxYjY4NWMyYTFlZDQyOGJj ZTYyYmIwNWZjZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9GcmFtZVZpZXcuY3Bw CisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRnJhbWVWaWV3LmNwcApAQCAtMzc0OCw2ICszNzQ4 LDIwIEBAIHZvaWQgRnJhbWVWaWV3OjpyZW1vdmVDaGlsZChXaWRnZXQqIHdpZGdldCkKIAogYm9v bCBGcmFtZVZpZXc6OndoZWVsRXZlbnQoY29uc3QgUGxhdGZvcm1XaGVlbEV2ZW50JiB3aGVlbEV2 ZW50KQogeworICAgIGlmICghaXNTY3JvbGxhYmxlKCkpCisgICAgICAgIHJldHVybiBmYWxzZTsK KworICAgIGlmIChkZWxlZ2F0ZXNTY3JvbGxpbmcoKSkgeworICAgICAgICBJbnRTaXplIG9mZnNl dCA9IHNjcm9sbE9mZnNldCgpOworICAgICAgICBJbnRTaXplIG5ld09mZnNldCA9IEludFNpemUo b2Zmc2V0LndpZHRoKCkgLSB3aGVlbEV2ZW50LmRlbHRhWCgpLCBvZmZzZXQuaGVpZ2h0KCkgLSB3 aGVlbEV2ZW50LmRlbHRhWSgpKTsKKyAgICAgICAgaWYgKG9mZnNldCAhPSBuZXdPZmZzZXQpIHsK KyAgICAgICAgICAgIFNjcm9sbFZpZXc6OnNjcm9sbFRvKG5ld09mZnNldCk7CisgICAgICAgICAg ICBzY3JvbGxQb3NpdGlvbkNoYW5nZWQoKTsKKyAgICAgICAgICAgIGZyYW1lKCktPmxvYWRlcigp LT5jbGllbnQoKS0+ZGlkQ2hhbmdlU2Nyb2xsT2Zmc2V0KCk7CisgICAgICAgIH0KKyAgICAgICAg cmV0dXJuIHRydWU7CisgICAgfQorCiAgICAgLy8gV2UgZG9uJ3QgYWxsb3cgbW91c2Ugd2hlZWxp bmcgdG8gaGFwcGVuIGluIGEgU2Nyb2xsVmlldyB0aGF0IGhhcyBoYWQgaXRzIHNjcm9sbGJhcnMg ZXhwbGljaXRseSBkaXNhYmxlZC4KICAgICBpZiAoIWNhbkhhdmVTY3JvbGxiYXJzKCkpCiAgICAg ICAgIHJldHVybiBmYWxzZTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3Mv V2ViQ29yZVN1cHBvcnQvV2ViRnJhbWVMb2FkZXJDbGllbnQuY3BwIGIvU291cmNlL1dlYktpdDIv V2ViUHJvY2Vzcy9XZWJDb3JlU3VwcG9ydC9XZWJGcmFtZUxvYWRlckNsaWVudC5jcHAKaW5kZXgg ZWYzNWJiNjMwYTE4Y2Q1Y2E2ZTE5MDYwNGUwYzk2ODNlODc2MmJlMS4uOGIwM2I2M2JjMGI0M2Zj ODk5ZWQyMGQyMjc1ODhlNDNiMjVmZGNjMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvV2Vi UHJvY2Vzcy9XZWJDb3JlU3VwcG9ydC9XZWJGcmFtZUxvYWRlckNsaWVudC5jcHAKKysrIGIvU291 cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJDb3JlU3VwcG9ydC9XZWJGcmFtZUxvYWRlckNsaWVu dC5jcHAKQEAgLTEyMzMsMTMgKzEyMzMsMTcgQEAgdm9pZCBXZWJGcmFtZUxvYWRlckNsaWVudDo6 dHJhbnNpdGlvblRvQ29tbWl0dGVkRm9yTmV3UGFnZSgpCiAgICAgbV9mcmFtZUhhc0N1c3RvbVJl cHJlc2VudGF0aW9uID0gaXNNYWluRnJhbWUgJiYgd2ViUGFnZS0+c2hvdWxkVXNlQ3VzdG9tUmVw cmVzZW50YXRpb25Gb3JSZXNwb25zZShyZXNwb25zZSk7CiAgICAgbV9mcmFtZUNhbWVGcm9tUGFn ZUNhY2hlID0gZmFsc2U7CiAKLSAgICBtX2ZyYW1lLT5jb3JlRnJhbWUoKS0+Y3JlYXRlVmlldyh3 ZWJQYWdlLT5zaXplKCksIGJhY2tncm91bmRDb2xvciwgLyogdHJhbnNwYXJlbnQgKi8gZmFsc2Us IEludFNpemUoKSwgY3VycmVudEZpeGVkVmlzaWJsZUNvbnRlbnRSZWN0LCBzaG91bGRVc2VGaXhl ZExheW91dCk7Ci0gICAgbV9mcmFtZS0+Y29yZUZyYW1lKCktPnZpZXcoKS0+c2V0VHJhbnNwYXJl bnQoIXdlYlBhZ2UtPmRyYXdzQmFja2dyb3VuZCgpKTsKLQogI2lmIFVTRShUSUxFRF9CQUNLSU5H X1NUT1JFKQorICAgIC8vIFR1cm4gb2ZmIHNjcm9sbGJhcnMgZm9yIGdvb2QuCisgICAgbV9mcmFt ZS0+Y29yZUZyYW1lKCktPmNyZWF0ZVZpZXcod2ViUGFnZS0+c2l6ZSgpLCBiYWNrZ3JvdW5kQ29s b3IsIC8qIHRyYW5zcGFyZW50ICovIGZhbHNlLCBJbnRTaXplKCksIGN1cnJlbnRGaXhlZFZpc2li bGVDb250ZW50UmVjdCwgc2hvdWxkVXNlRml4ZWRMYXlvdXQsIFNjcm9sbGJhckFsd2F5c09mZiwg dHJ1ZSwgU2Nyb2xsYmFyQWx3YXlzT2ZmLCB0cnVlKTsKKwogICAgIG1fZnJhbWUtPmNvcmVGcmFt ZSgpLT52aWV3KCktPnNldERlbGVnYXRlc1Njcm9sbGluZyhzaG91bGRVc2VGaXhlZExheW91dCk7 CiAgICAgbV9mcmFtZS0+Y29yZUZyYW1lKCktPnZpZXcoKS0+c2V0UGFpbnRzRW50aXJlQ29udGVu dHMoc2hvdWxkVXNlRml4ZWRMYXlvdXQpOworI2Vsc2UKKyAgICBtX2ZyYW1lLT5jb3JlRnJhbWUo KS0+Y3JlYXRlVmlldyh3ZWJQYWdlLT5zaXplKCksIGJhY2tncm91bmRDb2xvciwgLyogdHJhbnNw YXJlbnQgKi8gZmFsc2UsIEludFNpemUoKSwgY3VycmVudEZpeGVkVmlzaWJsZUNvbnRlbnRSZWN0 LCBzaG91bGRVc2VGaXhlZExheW91dCk7CiAjZW5kaWYKKworICAgIG1fZnJhbWUtPmNvcmVGcmFt ZSgpLT52aWV3KCktPnNldFRyYW5zcGFyZW50KCF3ZWJQYWdlLT5kcmF3c0JhY2tncm91bmQoKSk7 CiB9CiAKIHZvaWQgV2ViRnJhbWVMb2FkZXJDbGllbnQ6OmRpZFNhdmVUb1BhZ2VDYWNoZSgpCg== 180515 2012-12-21 07:08:12 -0800 2012-12-21 07:56:54 -0800 Patch bug-105632-20121221160525.patch text/plain 4817 kenneth U3VidmVyc2lvbiBSZXZpc2lvbjogMTM4MzY4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzgzZDRkMjE2ODQ1ODU5 NDhjODU2NjdkMDEzYjY5MDJmY2RhZTg4My4uMGQ2ZTZmYjc5OGJmNWMxODc0YjQ0MjljNjJjNzhl ZDM1Nzc0ZWNmMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTEyLTIxICBLZW5u ZXRoIFJvaGRlIENocmlzdGlhbnNlbiAgPGtlbm5ldGhAd2Via2l0Lm9yZz4KKworICAgICAgICBb RUZMXVtXSzJdIE5ldmVyIGNyZWF0ZSBXZWJDb3JlIHNjcm9sbGJhcnMgZm9yIEVGTC9XSzIKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNTYzMgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZvciBkZWxlZ2F0 ZXMgc2Nyb2xsIHdlIG11c3Qgbm90IHVzZSB0aGUgc2Nyb2xsIGFuaW1hdG9yLAorICAgICAgICBv ciBzaW1pbGFyIGFzIHRob3NlIGRlcGVuZHMgb24gY3JlYXRpbmcgV2ViQ29yZSBzY3JvbGxiYXJz LgorCisgICAgICAgIEhhbmRsZSB0aGUgd2hlZWwgZXZlbnQgbWFudWFsbHkgZm9yIGRlbGVnYXRl cyBzY3JvbGxpbmcuCisKKyAgICAgICAgKiBwYWdlL0ZyYW1lVmlldy5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpGcmFtZVZpZXc6OndoZWVsRXZlbnQpOgorCiAyMDEyLTEyLTIxICBLZWlzaGkgSGF0 dG9yaSAgPGtlaXNoaUB3ZWJraXQub3JnPgogCiAgICAgICAgIEZpeCB0eXBpbmcgemVybyBpbnRv IG11bHRpcGxlIGZpZWxkIGlucHV0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VM b2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNzkzYzdiODc1MjQ3MTUwM2NlMGZm NWI1NWJkYzUyYTYzYmVmMDc3Yy4uNWZjMzg0ZmYyMDJjOTI3ZGU4M2IwMTllZTE0ODg0ZTdkNTRh MDliYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9X ZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTEyLTIxICBLZW5uZXRoIFJv aGRlIENocmlzdGlhbnNlbiAgPGtlbm5ldGhAd2Via2l0Lm9yZz4KKworICAgICAgICBbRUZMXVtX SzJdIE5ldmVyIGNyZWF0ZSBXZWJDb3JlIHNjcm9sbGJhcnMgZm9yIEVGTC9XSzIKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNTYzMgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZW4gY3JlYXRpbmcgdGhl IGZyYW1lIGFzayB0byBub3QgY3JlYXRlIHNjcm9sbGJhcnMgYW5kCisgICAgICAgIGxvY2sgaXQg c28gdGhleSB3b24ndCBiZSBjcmVhdGVkIGF0IGFueSBsYXRlciB0aW1lLgorCisgICAgICAgICog V2ViUHJvY2Vzcy9XZWJDb3JlU3VwcG9ydC9XZWJGcmFtZUxvYWRlckNsaWVudC5jcHA6CisgICAg ICAgIChXZWJLaXQ6OldlYkZyYW1lTG9hZGVyQ2xpZW50Ojp0cmFuc2l0aW9uVG9Db21taXR0ZWRG b3JOZXdQYWdlKToKKwogMjAxMi0xMi0yMSAgTWlraGFpbCBQb3pkbnlha292ICA8bWlraGFpbC5w b3pkbnlha292QGludGVsLmNvbT4KIAogICAgICAgICBbV0syXSBUaWxlZEJhY2tpbmdTdG9yZTog U2Nyb2xsIHBvc2l0aW9uIGlzIG5vdCByZXNldCB3aGVuIG5ldyBwYWdlIGlzIGxvYWRlZApkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGFnZS9GcmFtZVZpZXcuY3BwIGIvU291cmNlL1dlYkNv cmUvcGFnZS9GcmFtZVZpZXcuY3BwCmluZGV4IDJkZDIxYzRiZWJkMDgyMjA1NjczNGNiNWM5MGRl MjhhZmU4ZGQwNjYuLmE4NDhkZWI5MWQ0N2Y4MWI2ODVjMmExZWQ0MjhiY2U2MmJiMDVmY2YgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRnJhbWVWaWV3LmNwcAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9wYWdlL0ZyYW1lVmlldy5jcHAKQEAgLTM3NDgsNiArMzc0OCwyMCBAQCB2b2lkIEZy YW1lVmlldzo6cmVtb3ZlQ2hpbGQoV2lkZ2V0KiB3aWRnZXQpCiAKIGJvb2wgRnJhbWVWaWV3Ojp3 aGVlbEV2ZW50KGNvbnN0IFBsYXRmb3JtV2hlZWxFdmVudCYgd2hlZWxFdmVudCkKIHsKKyAgICBp ZiAoIWlzU2Nyb2xsYWJsZSgpKQorICAgICAgICByZXR1cm4gZmFsc2U7CisKKyAgICBpZiAoZGVs ZWdhdGVzU2Nyb2xsaW5nKCkpIHsKKyAgICAgICAgSW50U2l6ZSBvZmZzZXQgPSBzY3JvbGxPZmZz ZXQoKTsKKyAgICAgICAgSW50U2l6ZSBuZXdPZmZzZXQgPSBJbnRTaXplKG9mZnNldC53aWR0aCgp IC0gd2hlZWxFdmVudC5kZWx0YVgoKSwgb2Zmc2V0LmhlaWdodCgpIC0gd2hlZWxFdmVudC5kZWx0 YVkoKSk7CisgICAgICAgIGlmIChvZmZzZXQgIT0gbmV3T2Zmc2V0KSB7CisgICAgICAgICAgICBT Y3JvbGxWaWV3OjpzY3JvbGxUbyhuZXdPZmZzZXQpOworICAgICAgICAgICAgc2Nyb2xsUG9zaXRp b25DaGFuZ2VkKCk7CisgICAgICAgICAgICBmcmFtZSgpLT5sb2FkZXIoKS0+Y2xpZW50KCktPmRp ZENoYW5nZVNjcm9sbE9mZnNldCgpOworICAgICAgICB9CisgICAgICAgIHJldHVybiB0cnVlOwor ICAgIH0KKwogICAgIC8vIFdlIGRvbid0IGFsbG93IG1vdXNlIHdoZWVsaW5nIHRvIGhhcHBlbiBp biBhIFNjcm9sbFZpZXcgdGhhdCBoYXMgaGFkIGl0cyBzY3JvbGxiYXJzIGV4cGxpY2l0bHkgZGlz YWJsZWQuCiAgICAgaWYgKCFjYW5IYXZlU2Nyb2xsYmFycygpKQogICAgICAgICByZXR1cm4gZmFs c2U7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYkNvcmVTdXBwb3J0 L1dlYkZyYW1lTG9hZGVyQ2xpZW50LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2Vi Q29yZVN1cHBvcnQvV2ViRnJhbWVMb2FkZXJDbGllbnQuY3BwCmluZGV4IGVmMzViYjYzMGExOGNk NWNhNmUxOTA2MDRlMGM5NjgzZTg3NjJiZTEuLmJmMDkzZGU0MmE5YTgxNWUzNjk2ZTRlOWIxZmM5 NTQzZDIwOGRhNGUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViQ29y ZVN1cHBvcnQvV2ViRnJhbWVMb2FkZXJDbGllbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1dl YlByb2Nlc3MvV2ViQ29yZVN1cHBvcnQvV2ViRnJhbWVMb2FkZXJDbGllbnQuY3BwCkBAIC0xMjI2 LDYgKzEyMjYsNyBAQCB2b2lkIFdlYkZyYW1lTG9hZGVyQ2xpZW50Ojp0cmFuc2l0aW9uVG9Db21t aXR0ZWRGb3JOZXdQYWdlKCkKIAogICAgIENvbG9yIGJhY2tncm91bmRDb2xvciA9IHdlYlBhZ2Ut PmRyYXdzVHJhbnNwYXJlbnRCYWNrZ3JvdW5kKCkgPyBDb2xvcjo6dHJhbnNwYXJlbnQgOiBDb2xv cjo6d2hpdGU7CiAgICAgYm9vbCBpc01haW5GcmFtZSA9IHdlYlBhZ2UtPm1haW5XZWJGcmFtZSgp ID09IG1fZnJhbWU7CisgICAgYm9vbCBpc1RyYW5zcGFyZW50ID0gIXdlYlBhZ2UtPmRyYXdzQmFj a2dyb3VuZCgpOwogICAgIGJvb2wgc2hvdWxkVXNlRml4ZWRMYXlvdXQgPSBpc01haW5GcmFtZSAm JiB3ZWJQYWdlLT51c2VGaXhlZExheW91dCgpOwogICAgIEludFJlY3QgY3VycmVudEZpeGVkVmlz aWJsZUNvbnRlbnRSZWN0ID0gbV9mcmFtZS0+Y29yZUZyYW1lKCktPnZpZXcoKSA/IG1fZnJhbWUt PmNvcmVGcmFtZSgpLT52aWV3KCktPmZpeGVkVmlzaWJsZUNvbnRlbnRSZWN0KCkgOiBJbnRSZWN0 KCk7CiAKQEAgLTEyMzMsMTIgKzEyMzQsMTYgQEAgdm9pZCBXZWJGcmFtZUxvYWRlckNsaWVudDo6 dHJhbnNpdGlvblRvQ29tbWl0dGVkRm9yTmV3UGFnZSgpCiAgICAgbV9mcmFtZUhhc0N1c3RvbVJl cHJlc2VudGF0aW9uID0gaXNNYWluRnJhbWUgJiYgd2ViUGFnZS0+c2hvdWxkVXNlQ3VzdG9tUmVw cmVzZW50YXRpb25Gb3JSZXNwb25zZShyZXNwb25zZSk7CiAgICAgbV9mcmFtZUNhbWVGcm9tUGFn ZUNhY2hlID0gZmFsc2U7CiAKLSAgICBtX2ZyYW1lLT5jb3JlRnJhbWUoKS0+Y3JlYXRlVmlldyh3 ZWJQYWdlLT5zaXplKCksIGJhY2tncm91bmRDb2xvciwgLyogdHJhbnNwYXJlbnQgKi8gZmFsc2Us IEludFNpemUoKSwgY3VycmVudEZpeGVkVmlzaWJsZUNvbnRlbnRSZWN0LCBzaG91bGRVc2VGaXhl ZExheW91dCk7Ci0gICAgbV9mcmFtZS0+Y29yZUZyYW1lKCktPnZpZXcoKS0+c2V0VHJhbnNwYXJl bnQoIXdlYlBhZ2UtPmRyYXdzQmFja2dyb3VuZCgpKTsKLQogI2lmIFVTRShUSUxFRF9CQUNLSU5H X1NUT1JFKQorICAgIG1fZnJhbWUtPmNvcmVGcmFtZSgpLT5jcmVhdGVWaWV3KHdlYlBhZ2UtPnNp emUoKSwgYmFja2dyb3VuZENvbG9yLCBpc1RyYW5zcGFyZW50LAorICAgICAgICBJbnRTaXplKCks IGN1cnJlbnRGaXhlZFZpc2libGVDb250ZW50UmVjdCwgc2hvdWxkVXNlRml4ZWRMYXlvdXQsCisg ICAgICAgIFNjcm9sbGJhckFsd2F5c09mZiwgLyogbG9jayAqLyB0cnVlLCBTY3JvbGxiYXJBbHdh eXNPZmYsIC8qIGxvY2sgKi8gdHJ1ZSk7CisKICAgICBtX2ZyYW1lLT5jb3JlRnJhbWUoKS0+dmll dygpLT5zZXREZWxlZ2F0ZXNTY3JvbGxpbmcoc2hvdWxkVXNlRml4ZWRMYXlvdXQpOwogICAgIG1f ZnJhbWUtPmNvcmVGcmFtZSgpLT52aWV3KCktPnNldFBhaW50c0VudGlyZUNvbnRlbnRzKHNob3Vs ZFVzZUZpeGVkTGF5b3V0KTsKKyNlbHNlCisgICAgbV9mcmFtZS0+Y29yZUZyYW1lKCktPmNyZWF0 ZVZpZXcod2ViUGFnZS0+c2l6ZSgpLCBiYWNrZ3JvdW5kQ29sb3IsIGlzVHJhbnNwYXJlbnQsCisg ICAgICAgIEludFNpemUoKSwgY3VycmVudEZpeGVkVmlzaWJsZUNvbnRlbnRSZWN0LCBzaG91bGRV c2VGaXhlZExheW91dCk7CiAjZW5kaWYKIH0KIAo=