105614 2012-12-20 21:13:50 -0800 Fix build warnings related with gstreamer 2012-12-20 22:45:58 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ktf.kim ktf.kim eric.carlson feature-media-reviews haraken webkit.review.bot oldest_to_newest 796124 0 ktf.kim 2012-12-20 21:13:50 -0800 Source/WebCore/platform/audio/gstreamer/AudioDestinationGStreamer.cpp:49:13: warning: unused parameter ‘element’ [-Wunused-parameter] Source/WebCore/platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:103:10: warning: unused parameter ‘bus’ [-Wunused-parameter] Source/WebCore/platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:108:13: warning: unused parameter ‘element’ [-Wunused-parameter] Source/WebCore/platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:113:13: warning: unused parameter ‘element’ [-Wunused-parameter] Source/WebCore/platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:118:13: warning: unused parameter ‘element’ [-Wunused-parameter] 796125 1 180478 ktf.kim 2012-12-20 21:17:27 -0800 Created attachment 180478 Patch 796126 2 180478 haraken 2012-12-20 21:22:03 -0800 Comment on attachment 180478 Patch ok 796127 3 180478 webkit.review.bot 2012-12-20 21:27:05 -0800 Comment on attachment 180478 Patch Rejecting attachment 180478 from commit-queue. Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', u'--status-host=queues.webkit.org', ..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue /mnt/git/webkit-commit-queue/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/15451302 796133 4 180480 ktf.kim 2012-12-20 21:53:24 -0800 Created attachment 180480 Patch for landing 796148 5 180480 webkit.review.bot 2012-12-20 22:45:54 -0800 Comment on attachment 180480 Patch for landing Clearing flags on attachment: 180480 Committed r138349: <http://trac.webkit.org/changeset/138349> 796149 6 webkit.review.bot 2012-12-20 22:45:58 -0800 All reviewed patches have been landed. Closing bug. 180478 2012-12-20 21:17:27 -0800 2012-12-20 21:53:18 -0800 Patch bug-105614-20121221141448.patch text/plain 3450 ktf.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMTM4MzQzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTUwMDFmMTQ4MTQyNjg0 ZGM0YmEyNGU0NzRhYTgzYjE2YmU1ZDEyMS4uZjI1MTg1YzllNDg2NjZhOTA2OWI3ZTkyNWNjOTZi MmE5ZTNhZWM2YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTEyLTIwICBLeXVu Z1RhZSBLaW0gIDxrdGYua2ltQHNhbXN1bmcuY29tPgorCisgICAgICAgIEZpeCBidWlsZCB3YXJu aW5ncyByZWxhdGVkIHdpdGggZ3N0cmVhbWVyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xMDU2MTQKKworICAgICAgICBUaGUgYmVsb3cgZnVuY3Rpb25z IGhhdmUgdW51c2VkIHBhcmFtZXRlcnMuCisgICAgICAgIFJlbW92ZSB0aGUgcGFyYW1ldGVyIG5h bWVzIHRvIGZpeCAndW51c2VkIHBhcmFtZXRlcicgYnVpbGQgd2FybmluZ3MuCisKKyAgICAgICAg KiBwbGF0Zm9ybS9hdWRpby9nc3RyZWFtZXIvQXVkaW9EZXN0aW5hdGlvbkdTdHJlYW1lci5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpvbkdTdHJlYW1lcldhdnBhcnNlUGFkQWRkZWRDYWxsYmFjayk6 CisgICAgICAgICogcGxhdGZvcm0vYXVkaW8vZ3N0cmVhbWVyL0F1ZGlvRmlsZVJlYWRlckdTdHJl YW1lci5jcHA6CisgICAgICAgIChXZWJDb3JlOjptZXNzYWdlQ2FsbGJhY2spOgorICAgICAgICAo V2ViQ29yZTo6b25HU3RyZWFtZXJEZWludGVybGVhdmVQYWRBZGRlZENhbGxiYWNrKToKKyAgICAg ICAgKFdlYkNvcmU6Om9uR1N0cmVhbWVyRGVpbnRlcmxlYXZlUmVhZHlDYWxsYmFjayk6CisgICAg ICAgIChXZWJDb3JlOjpvbkdTdHJlYW1lckRlY29kZWJpblBhZEFkZGVkQ2FsbGJhY2spOgorCiAy MDEyLTEyLTIwICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CiAKICAgICAgICAgQ3Jl YXRlIGEgdmFyaWFibGUgbmFtZSBmb3IgYSBSQUlJIHNjb3BlIHNvIGl0IGRvZXNuJ3QgZGllIGlt bWVkaWF0ZWx5LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vYXVkaW8vZ3N0 cmVhbWVyL0F1ZGlvRGVzdGluYXRpb25HU3RyZWFtZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vYXVkaW8vZ3N0cmVhbWVyL0F1ZGlvRGVzdGluYXRpb25HU3RyZWFtZXIuY3BwCmluZGV4 IDU0MWIyNmQ5Y2E4ZDFkMjM0ZWIxYmFiNzU3ODQwMTlkMTI1MmE2M2UuLjFkZWZlZmJjNTBkZjgz NDE0YjdmYmNlMjZhOGQyNjkyMjliZmU5ODUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2F1ZGlvL2dzdHJlYW1lci9BdWRpb0Rlc3RpbmF0aW9uR1N0cmVhbWVyLmNwcAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9hdWRpby9nc3RyZWFtZXIvQXVkaW9EZXN0aW5hdGlv bkdTdHJlYW1lci5jcHAKQEAgLTQ2LDcgKzQ2LDcgQEAgZmxvYXQgQXVkaW9EZXN0aW5hdGlvbjo6 aGFyZHdhcmVTYW1wbGVSYXRlKCkKICAgICByZXR1cm4gNDQxMDA7CiB9CiAKLXN0YXRpYyB2b2lk IG9uR1N0cmVhbWVyV2F2cGFyc2VQYWRBZGRlZENhbGxiYWNrKEdzdEVsZW1lbnQqIGVsZW1lbnQs IEdzdFBhZCogcGFkLCBBdWRpb0Rlc3RpbmF0aW9uR1N0cmVhbWVyKiBkZXN0aW5hdGlvbikKK3N0 YXRpYyB2b2lkIG9uR1N0cmVhbWVyV2F2cGFyc2VQYWRBZGRlZENhbGxiYWNrKEdzdEVsZW1lbnQq LCBHc3RQYWQqIHBhZCwgQXVkaW9EZXN0aW5hdGlvbkdTdHJlYW1lciogZGVzdGluYXRpb24pCiB7 CiAgICAgZGVzdGluYXRpb24tPmZpbmlzaEJ1aWxkaW5nUGlwZWxpbmVBZnRlcldhdlBhcnNlclBh ZFJlYWR5KHBhZCk7CiB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9hdWRp by9nc3RyZWFtZXIvQXVkaW9GaWxlUmVhZGVyR1N0cmVhbWVyLmNwcCBiL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2F1ZGlvL2dzdHJlYW1lci9BdWRpb0ZpbGVSZWFkZXJHU3RyZWFtZXIuY3BwCmlu ZGV4IDNlYWI4NWIyOWQxNTlhYzg5YjZkNGM4ZjYxNzYxYzU0ZmVlNGM5MjYuLmFkM2VmYjA5NTZl MDdhZmRkMzYxZDdhYmY5YmNmZmQxYmU0MGJkZjUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2F1ZGlvL2dzdHJlYW1lci9BdWRpb0ZpbGVSZWFkZXJHU3RyZWFtZXIuY3BwCisr KyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2F1ZGlvL2dzdHJlYW1lci9BdWRpb0ZpbGVSZWFk ZXJHU3RyZWFtZXIuY3BwCkBAIC0xMDAsMjIgKzEwMCwyMiBAQCBzdGF0aWMgR3N0Rmxvd1JldHVy biBvbkFwcHNpbmtOZXdCdWZmZXJDYWxsYmFjayhHc3RBcHBTaW5rKiBzaW5rLCBncG9pbnRlciB1 c2VyRAogICAgIHJldHVybiBzdGF0aWNfY2FzdDxBdWRpb0ZpbGVSZWFkZXIqPih1c2VyRGF0YSkt PmhhbmRsZUJ1ZmZlcihzaW5rKTsKIH0KIAotZ2Jvb2xlYW4gbWVzc2FnZUNhbGxiYWNrKEdzdEJ1 cyogYnVzLCBHc3RNZXNzYWdlKiBtZXNzYWdlLCBBdWRpb0ZpbGVSZWFkZXIqIHJlYWRlcikKK2di b29sZWFuIG1lc3NhZ2VDYWxsYmFjayhHc3RCdXMqLCBHc3RNZXNzYWdlKiBtZXNzYWdlLCBBdWRp b0ZpbGVSZWFkZXIqIHJlYWRlcikKIHsKICAgICByZXR1cm4gcmVhZGVyLT5oYW5kbGVNZXNzYWdl KG1lc3NhZ2UpOwogfQogCi1zdGF0aWMgdm9pZCBvbkdTdHJlYW1lckRlaW50ZXJsZWF2ZVBhZEFk ZGVkQ2FsbGJhY2soR3N0RWxlbWVudCogZWxlbWVudCwgR3N0UGFkKiBwYWQsIEF1ZGlvRmlsZVJl YWRlciogcmVhZGVyKQorc3RhdGljIHZvaWQgb25HU3RyZWFtZXJEZWludGVybGVhdmVQYWRBZGRl ZENhbGxiYWNrKEdzdEVsZW1lbnQqLCBHc3RQYWQqIHBhZCwgQXVkaW9GaWxlUmVhZGVyKiByZWFk ZXIpCiB7CiAgICAgcmVhZGVyLT5oYW5kbGVOZXdEZWludGVybGVhdmVQYWQocGFkKTsKIH0KIAot c3RhdGljIHZvaWQgb25HU3RyZWFtZXJEZWludGVybGVhdmVSZWFkeUNhbGxiYWNrKEdzdEVsZW1l bnQqIGVsZW1lbnQsIEF1ZGlvRmlsZVJlYWRlciogcmVhZGVyKQorc3RhdGljIHZvaWQgb25HU3Ry ZWFtZXJEZWludGVybGVhdmVSZWFkeUNhbGxiYWNrKEdzdEVsZW1lbnQqLCBBdWRpb0ZpbGVSZWFk ZXIqIHJlYWRlcikKIHsKICAgICByZWFkZXItPmRlaW50ZXJsZWF2ZVBhZHNDb25maWd1cmVkKCk7 CiB9CiAKLXN0YXRpYyB2b2lkIG9uR1N0cmVhbWVyRGVjb2RlYmluUGFkQWRkZWRDYWxsYmFjayhH c3RFbGVtZW50KiBlbGVtZW50LCBHc3RQYWQqIHBhZCwgQXVkaW9GaWxlUmVhZGVyKiByZWFkZXIp CitzdGF0aWMgdm9pZCBvbkdTdHJlYW1lckRlY29kZWJpblBhZEFkZGVkQ2FsbGJhY2soR3N0RWxl bWVudCosIEdzdFBhZCogcGFkLCBBdWRpb0ZpbGVSZWFkZXIqIHJlYWRlcikKIHsKICAgICByZWFk ZXItPnBsdWdEZWludGVybGVhdmUocGFkKTsKIH0K 180480 2012-12-20 21:53:24 -0800 2012-12-20 22:45:54 -0800 Patch for landing bug-105614-20121221145045.patch text/plain 3491 ktf.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMTM4MzQ3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzc0ZTRiYTBjOGI3ZTc3 YTVhY2Q0ZjkyZTA3NjI4NGZlNTg3NTA3ZS4uM2RhYTY4MzkyNGYxYmMxYWYwNTZmM2E0MTYwZmI0 ZDRjODM3ZmE1MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEyLTEyLTIwICBLeXVu Z1RhZSBLaW0gIDxrdGYua2ltQHNhbXN1bmcuY29tPgorCisgICAgICAgIEZpeCBidWlsZCB3YXJu aW5ncyByZWxhdGVkIHdpdGggZ3N0cmVhbWVyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xMDU2MTQKKworICAgICAgICBSZXZpZXdlZCBieSBLZW50YXJv IEhhcmEuCisKKyAgICAgICAgVGhlIGJlbG93IGZ1bmN0aW9ucyBoYXZlIHVudXNlZCBwYXJhbWV0 ZXJzLgorICAgICAgICBSZW1vdmUgdGhlIHBhcmFtZXRlciBuYW1lcyB0byBmaXggJ3VudXNlZCBw YXJhbWV0ZXInIGJ1aWxkIHdhcm5pbmdzLgorCisgICAgICAgICogcGxhdGZvcm0vYXVkaW8vZ3N0 cmVhbWVyL0F1ZGlvRGVzdGluYXRpb25HU3RyZWFtZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6 b25HU3RyZWFtZXJXYXZwYXJzZVBhZEFkZGVkQ2FsbGJhY2spOgorICAgICAgICAqIHBsYXRmb3Jt L2F1ZGlvL2dzdHJlYW1lci9BdWRpb0ZpbGVSZWFkZXJHU3RyZWFtZXIuY3BwOgorICAgICAgICAo V2ViQ29yZTo6bWVzc2FnZUNhbGxiYWNrKToKKyAgICAgICAgKFdlYkNvcmU6Om9uR1N0cmVhbWVy RGVpbnRlcmxlYXZlUGFkQWRkZWRDYWxsYmFjayk6CisgICAgICAgIChXZWJDb3JlOjpvbkdTdHJl YW1lckRlaW50ZXJsZWF2ZVJlYWR5Q2FsbGJhY2spOgorICAgICAgICAoV2ViQ29yZTo6b25HU3Ry ZWFtZXJEZWNvZGViaW5QYWRBZGRlZENhbGxiYWNrKToKKwogMjAxMi0xMi0yMCAgSHVhbmcgRG9u Z3N1bmcgIDxsdXh0ZWxsYUBjb21wYW55MTAwLm5ldD4KIAogICAgICAgICBbV2ViR0xdW0VGTF1b UXRdW0dUS10gSmVsbHkgZmlzaGVzIGxlYXZlIHRyYWlscyBvbiB3ZWJnbCBjYW52YXMuCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9hdWRpby9nc3RyZWFtZXIvQXVkaW9EZXN0 aW5hdGlvbkdTdHJlYW1lci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9hdWRpby9nc3Ry ZWFtZXIvQXVkaW9EZXN0aW5hdGlvbkdTdHJlYW1lci5jcHAKaW5kZXggNTQxYjI2ZDljYThkMWQy MzRlYjFiYWI3NTc4NDAxOWQxMjUyYTYzZS4uMWRlZmVmYmM1MGRmODM0MTRiN2ZiY2UyNmE4ZDI2 OTIyOWJmZTk4NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vYXVkaW8vZ3N0 cmVhbWVyL0F1ZGlvRGVzdGluYXRpb25HU3RyZWFtZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2F1ZGlvL2dzdHJlYW1lci9BdWRpb0Rlc3RpbmF0aW9uR1N0cmVhbWVyLmNwcApA QCAtNDYsNyArNDYsNyBAQCBmbG9hdCBBdWRpb0Rlc3RpbmF0aW9uOjpoYXJkd2FyZVNhbXBsZVJh dGUoKQogICAgIHJldHVybiA0NDEwMDsKIH0KIAotc3RhdGljIHZvaWQgb25HU3RyZWFtZXJXYXZw YXJzZVBhZEFkZGVkQ2FsbGJhY2soR3N0RWxlbWVudCogZWxlbWVudCwgR3N0UGFkKiBwYWQsIEF1 ZGlvRGVzdGluYXRpb25HU3RyZWFtZXIqIGRlc3RpbmF0aW9uKQorc3RhdGljIHZvaWQgb25HU3Ry ZWFtZXJXYXZwYXJzZVBhZEFkZGVkQ2FsbGJhY2soR3N0RWxlbWVudCosIEdzdFBhZCogcGFkLCBB dWRpb0Rlc3RpbmF0aW9uR1N0cmVhbWVyKiBkZXN0aW5hdGlvbikKIHsKICAgICBkZXN0aW5hdGlv bi0+ZmluaXNoQnVpbGRpbmdQaXBlbGluZUFmdGVyV2F2UGFyc2VyUGFkUmVhZHkocGFkKTsKIH0K ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2F1ZGlvL2dzdHJlYW1lci9BdWRp b0ZpbGVSZWFkZXJHU3RyZWFtZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vYXVkaW8v Z3N0cmVhbWVyL0F1ZGlvRmlsZVJlYWRlckdTdHJlYW1lci5jcHAKaW5kZXggM2VhYjg1YjI5ZDE1 OWFjODliNmQ0YzhmNjE3NjFjNTRmZWU0YzkyNi4uYWQzZWZiMDk1NmUwN2FmZGQzNjFkN2FiZjli Y2ZmZDFiZTQwYmRmNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vYXVkaW8v Z3N0cmVhbWVyL0F1ZGlvRmlsZVJlYWRlckdTdHJlYW1lci5jcHAKKysrIGIvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vYXVkaW8vZ3N0cmVhbWVyL0F1ZGlvRmlsZVJlYWRlckdTdHJlYW1lci5jcHAK QEAgLTEwMCwyMiArMTAwLDIyIEBAIHN0YXRpYyBHc3RGbG93UmV0dXJuIG9uQXBwc2lua05ld0J1 ZmZlckNhbGxiYWNrKEdzdEFwcFNpbmsqIHNpbmssIGdwb2ludGVyIHVzZXJECiAgICAgcmV0dXJu IHN0YXRpY19jYXN0PEF1ZGlvRmlsZVJlYWRlcio+KHVzZXJEYXRhKS0+aGFuZGxlQnVmZmVyKHNp bmspOwogfQogCi1nYm9vbGVhbiBtZXNzYWdlQ2FsbGJhY2soR3N0QnVzKiBidXMsIEdzdE1lc3Nh Z2UqIG1lc3NhZ2UsIEF1ZGlvRmlsZVJlYWRlciogcmVhZGVyKQorZ2Jvb2xlYW4gbWVzc2FnZUNh bGxiYWNrKEdzdEJ1cyosIEdzdE1lc3NhZ2UqIG1lc3NhZ2UsIEF1ZGlvRmlsZVJlYWRlciogcmVh ZGVyKQogewogICAgIHJldHVybiByZWFkZXItPmhhbmRsZU1lc3NhZ2UobWVzc2FnZSk7CiB9CiAK LXN0YXRpYyB2b2lkIG9uR1N0cmVhbWVyRGVpbnRlcmxlYXZlUGFkQWRkZWRDYWxsYmFjayhHc3RF bGVtZW50KiBlbGVtZW50LCBHc3RQYWQqIHBhZCwgQXVkaW9GaWxlUmVhZGVyKiByZWFkZXIpCitz dGF0aWMgdm9pZCBvbkdTdHJlYW1lckRlaW50ZXJsZWF2ZVBhZEFkZGVkQ2FsbGJhY2soR3N0RWxl bWVudCosIEdzdFBhZCogcGFkLCBBdWRpb0ZpbGVSZWFkZXIqIHJlYWRlcikKIHsKICAgICByZWFk ZXItPmhhbmRsZU5ld0RlaW50ZXJsZWF2ZVBhZChwYWQpOwogfQogCi1zdGF0aWMgdm9pZCBvbkdT dHJlYW1lckRlaW50ZXJsZWF2ZVJlYWR5Q2FsbGJhY2soR3N0RWxlbWVudCogZWxlbWVudCwgQXVk aW9GaWxlUmVhZGVyKiByZWFkZXIpCitzdGF0aWMgdm9pZCBvbkdTdHJlYW1lckRlaW50ZXJsZWF2 ZVJlYWR5Q2FsbGJhY2soR3N0RWxlbWVudCosIEF1ZGlvRmlsZVJlYWRlciogcmVhZGVyKQogewog ICAgIHJlYWRlci0+ZGVpbnRlcmxlYXZlUGFkc0NvbmZpZ3VyZWQoKTsKIH0KIAotc3RhdGljIHZv aWQgb25HU3RyZWFtZXJEZWNvZGViaW5QYWRBZGRlZENhbGxiYWNrKEdzdEVsZW1lbnQqIGVsZW1l bnQsIEdzdFBhZCogcGFkLCBBdWRpb0ZpbGVSZWFkZXIqIHJlYWRlcikKK3N0YXRpYyB2b2lkIG9u R1N0cmVhbWVyRGVjb2RlYmluUGFkQWRkZWRDYWxsYmFjayhHc3RFbGVtZW50KiwgR3N0UGFkKiBw YWQsIEF1ZGlvRmlsZVJlYWRlciogcmVhZGVyKQogewogICAgIHJlYWRlci0+cGx1Z0RlaW50ZXJs ZWF2ZShwYWQpOwogfQo=