105597 2012-12-20 18:04:06 -0800 nrwt/chromium: Don't prefer chromium over webkit build directories 2013-01-13 10:08:59 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 106737 1 thakis thakis abarth dpranke webkit.review.bot oldest_to_newest 796007 0 thakis 2012-12-20 18:04:06 -0800 nrwt/chromium: Don't prefer chromium over webkit build directories 796009 1 180449 thakis 2012-12-20 18:04:59 -0800 Created attachment 180449 Patch 796010 2 thakis 2012-12-20 18:05:15 -0800 As promised. 796030 3 180449 dpranke 2012-12-20 18:32:15 -0800 Comment on attachment 180449 Patch yay for deleting code :) 805943 4 180449 webkit.review.bot 2013-01-13 00:01:07 -0800 Comment on attachment 180449 Patch Clearing flags on attachment: 180449 Committed r139560: <http://trac.webkit.org/changeset/139560> 805944 5 webkit.review.bot 2013-01-13 00:01:11 -0800 All reviewed patches have been landed. Closing bug. 180449 2012-12-20 18:04:59 -0800 2013-01-13 00:01:07 -0800 Patch bug-105597-20121220180222.patch text/plain 6046 thakis U3VidmVyc2lvbiBSZXZpc2lvbjogMTM4MzMyCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNGE5N2NjYWI1ZWVkN2VmOGJmOTZjNWVlODU4ZTM0MDM3 Mjk2MmY0NS4uYTk2MGM2OTIwY2IzYjExMjQ0OTc5ZWI3MDdmYzMxN2ZiNjZjZDg2NCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIy IEBACisyMDEyLTEyLTIwICBOaWNvIFdlYmVyICA8dGhha2lzQGNocm9taXVtLm9yZz4KKworICAg ICAgICBucnd0L2Nocm9taXVtOiBEb24ndCBwcmVmZXIgY2hyb21pdW0gb3ZlciB3ZWJraXQgYnVp bGQgZGlyZWN0b3JpZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTEwNTU5NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFJlbHkgb24gdGhlIG5ldyB0aW1lc3RhbXAgbG9naWMgaW5zdGVhZC4gUmVxdWVzdGVk IGJ5IGRwcmFua2UgaW4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTEwNTQ5OAorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMv cG9ydC9jaHJvbWl1bS5weToKKyAgICAgICAgKENocm9taXVtUG9ydC5fc3RhdGljX2J1aWxkX3Bh dGgpOgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvY2hyb21p dW1fbGludXhfdW5pdHRlc3QucHk6CisgICAgICAgIChDaHJvbWl1bUxpbnV4UG9ydFRlc3QudGVz dF9idWlsZF9wYXRoKToKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9w b3J0L2Nocm9taXVtX21hY191bml0dGVzdC5weToKKyAgICAgICAgKENocm9taXVtTWFjUG9ydFRl c3QudGVzdF9idWlsZF9wYXRoKToKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2xheW91dF90 ZXN0cy9wb3J0L2Nocm9taXVtX3dpbl91bml0dGVzdC5weToKKyAgICAgICAgKENocm9taXVtV2lu VGVzdC50ZXN0X2J1aWxkX3BhdGgpOgorCiAyMDEyLTEyLTIwICBSeXVhbiBDaG9pICA8cnl1YW4u Y2hvaUBzYW1zdW5nLmNvbT4KIAogICAgICAgICBbRUZMXSBCdWlsZCBicmVhayB3aXRoIGxhdGVz dCBFRkwgbGlicmFyaWVzLgpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlv dXRfdGVzdHMvcG9ydC9jaHJvbWl1bS5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0 X3Rlc3RzL3BvcnQvY2hyb21pdW0ucHkKaW5kZXggNjE1YTVlYjQ2YTBkMTFkODZkOGE0N2ZkZjc0 ZDkyOGU3Yjg0ZjEyMy4uYzVkNDNhODc2YzNkMjAxMGRiZTViMThiNjZlNzQzOTg3YmVmZWUwZCAx MDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9jaHJv bWl1bS5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2No cm9taXVtLnB5CkBAIC05MCw5ICs5MCw2IEBAIGNsYXNzIENocm9taXVtUG9ydChQb3J0KToKICAg ICAgICAgICAgIHBhdGggPSBmaWxlc3lzdGVtLmpvaW4oYmFzZV9kaXIsICpjb21wcykKICAgICAg ICAgICAgIGlmIGZpbGVzeXN0ZW0uZXhpc3RzKHBhdGgpOgogICAgICAgICAgICAgICAgIGhpdHMu YXBwZW5kKChmaWxlc3lzdGVtLm10aW1lKHBhdGgpLCBwYXRoKSkKLSAgICAgICAgaWYgaGl0czoK LSAgICAgICAgICAgIGhpdHMuc29ydChyZXZlcnNlPVRydWUpCi0gICAgICAgICAgICByZXR1cm4g aGl0c1swXVsxXSAgIyBSZXR1cm4gdGhlIG5ld2VzdCBmaWxlIGZvdW5kLgogCiAgICAgICAgIGZv ciBkaXJlY3RvcnkgaW4gY2xzLkRFRkFVTFRfQlVJTERfRElSRUNUT1JJRVM6CiAgICAgICAgICAg ICBiYXNlX2RpciA9IGZpbGVzeXN0ZW0uam9pbih3ZWJraXRfYmFzZSwgZGlyZWN0b3J5LCBjb25m aWd1cmF0aW9uKQpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVz dHMvcG9ydC9jaHJvbWl1bV9saW51eF91bml0dGVzdC5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0 cHkvbGF5b3V0X3Rlc3RzL3BvcnQvY2hyb21pdW1fbGludXhfdW5pdHRlc3QucHkKaW5kZXggOWQ5 MTc5ZDYxNjFmMGUwNGNlNWI5MWYyZDg1YjVjOTcwNzYzODU4My4uZWRiMWU2Mjk4OGQ1ZWNkOTUz ODIwM2UwNDMzNzVmZmMxNTRjOGMyNCAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRw eS9sYXlvdXRfdGVzdHMvcG9ydC9jaHJvbWl1bV9saW51eF91bml0dGVzdC5weQorKysgYi9Ub29s cy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2Nocm9taXVtX2xpbnV4X3VuaXR0 ZXN0LnB5CkBAIC05OSwxMCArOTksNiBAQCBjbGFzcyBDaHJvbWl1bUxpbnV4UG9ydFRlc3QoY2hy b21pdW1fcG9ydF90ZXN0Y2FzZS5DaHJvbWl1bVBvcnRUZXN0Q2FzZSk6CiAgICAgICAgIG9wdGlv bnMgPSBNb2NrT3B0aW9ucyhjb25maWd1cmF0aW9uPSdSZWxlYXNlJywgYnVpbGRfZGlyZWN0b3J5 PSdmb28nKQogICAgICAgICBzZWxmLmFzc2VydF9idWlsZF9wYXRoKG9wdGlvbnMsIFsnL21vY2st Y2hlY2tvdXQvU291cmNlL1dlYktpdC9jaHJvbWl1bS9vdXQvUmVsZWFzZSddLCAnZm9vL1JlbGVh c2UnKQogCi0gICAgICAgICMgVGVzdCB0aGF0IHdlIGxvb2sgaW4gYSBjaHJvbWl1bSBkaXJlY3Rv cnkgYmVmb3JlIHRoZSB3ZWJraXQgZGlyZWN0b3J5LgotICAgICAgICBvcHRpb25zID0gTW9ja09w dGlvbnMoY29uZmlndXJhdGlvbj0nUmVsZWFzZScsIGJ1aWxkX2RpcmVjdG9yeT1Ob25lKQotICAg ICAgICBzZWxmLmFzc2VydF9idWlsZF9wYXRoKG9wdGlvbnMsIFsnL21vY2stY2hlY2tvdXQvU291 cmNlL1dlYktpdC9jaHJvbWl1bS9vdXQvUmVsZWFzZScsICcvbW9jay1jaGVja291dC9vdXQvUmVs ZWFzZSddLCAnL21vY2stY2hlY2tvdXQvU291cmNlL1dlYktpdC9jaHJvbWl1bS9vdXQvUmVsZWFz ZScpCi0KICAgICAgICAgIyBUZXN0IHRoYXQgd2UgcHJlZmVyIHRoZSBsZWdhY3kgZGlyIG92ZXIg dGhlIG5ldyBkaXIuCiAgICAgICAgIG9wdGlvbnMgPSBNb2NrT3B0aW9ucyhjb25maWd1cmF0aW9u PSdSZWxlYXNlJywgYnVpbGRfZGlyZWN0b3J5PU5vbmUpCiAgICAgICAgIHNlbGYuYXNzZXJ0X2J1 aWxkX3BhdGgob3B0aW9ucywgWycvbW9jay1jaGVja291dC9Tb3VyY2UvV2ViS2l0L2Nocm9taXVt L3Njb25zYnVpbGQvUmVsZWFzZScsICcvbW9jay1jaGVja291dC9Tb3VyY2UvV2ViS2l0L2Nocm9t aXVtL291dC9SZWxlYXNlJ10sICcvbW9jay1jaGVja291dC9Tb3VyY2UvV2ViS2l0L2Nocm9taXVt L3Njb25zYnVpbGQvUmVsZWFzZScpCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5 L2xheW91dF90ZXN0cy9wb3J0L2Nocm9taXVtX21hY191bml0dGVzdC5weSBiL1Rvb2xzL1Njcmlw dHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvY2hyb21pdW1fbWFjX3VuaXR0ZXN0LnB5Cmlu ZGV4IDIwMThlYTg3NWFiODMwODgxYmRjYTJhYzFkZDhlZmY5ZWJjZDk5YzUuLmFmZjM3NDFkMmZi MTI5NmM3NTJkNWEyNjE0ZjI4YzEzMzFjZjAwODEgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMv d2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvY2hyb21pdW1fbWFjX3VuaXR0ZXN0LnB5CisrKyBi L1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvY2hyb21pdW1fbWFjX3Vu aXR0ZXN0LnB5CkBAIC04NywxMCArODcsNiBAQCBjbGFzcyBDaHJvbWl1bU1hY1BvcnRUZXN0KGNo cm9taXVtX3BvcnRfdGVzdGNhc2UuQ2hyb21pdW1Qb3J0VGVzdENhc2UpOgogICAgICAgICBvcHRp b25zID0gTW9ja09wdGlvbnMoY29uZmlndXJhdGlvbj0nUmVsZWFzZScsIGJ1aWxkX2RpcmVjdG9y eT0nZm9vJykKICAgICAgICAgc2VsZi5hc3NlcnRfYnVpbGRfcGF0aChvcHRpb25zLCBbJy9tb2Nr LWNoZWNrb3V0L1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vb3V0L1JlbGVhc2UnXSwgJ2Zvby9SZWxl YXNlJykKIAotICAgICAgICAjIFRlc3QgdGhhdCB3ZSBsb29rIGluIGEgY2hyb21pdW0gZGlyZWN0 b3J5IGJlZm9yZSB0aGUgd2Via2l0IGRpcmVjdG9yeS4KLSAgICAgICAgb3B0aW9ucyA9IE1vY2tP cHRpb25zKGNvbmZpZ3VyYXRpb249J1JlbGVhc2UnLCBidWlsZF9kaXJlY3Rvcnk9Tm9uZSkKLSAg ICAgICAgc2VsZi5hc3NlcnRfYnVpbGRfcGF0aChvcHRpb25zLCBbJy9tb2NrLWNoZWNrb3V0L1Nv dXJjZS9XZWJLaXQvY2hyb21pdW0vb3V0L1JlbGVhc2UnLCAnL21vY2stY2hlY2tvdXQvb3V0L1Jl bGVhc2UnXSwgJy9tb2NrLWNoZWNrb3V0L1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vb3V0L1JlbGVh c2UnKQotCiAgICAgICAgICMgVGVzdCB0aGF0IHdlIHByZWZlciB0aGUgbGVnYWN5IGRpciBvdmVy IHRoZSBuZXcgZGlyLgogICAgICAgICBvcHRpb25zID0gTW9ja09wdGlvbnMoY29uZmlndXJhdGlv bj0nUmVsZWFzZScsIGJ1aWxkX2RpcmVjdG9yeT1Ob25lKQogICAgICAgICBzZWxmLmFzc2VydF9i dWlsZF9wYXRoKG9wdGlvbnMsIFsnL21vY2stY2hlY2tvdXQvU291cmNlL1dlYktpdC9jaHJvbWl1 bS94Y29kZWJ1aWxkL1JlbGVhc2UnLCAnL21vY2stY2hlY2tvdXQvU291cmNlL1dlYktpdC9jaHJv bWl1bS9vdXQvUmVsZWFzZSddLCAnL21vY2stY2hlY2tvdXQvU291cmNlL1dlYktpdC9jaHJvbWl1 bS94Y29kZWJ1aWxkL1JlbGVhc2UnKQpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRw eS9sYXlvdXRfdGVzdHMvcG9ydC9jaHJvbWl1bV93aW5fdW5pdHRlc3QucHkgYi9Ub29scy9TY3Jp cHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2Nocm9taXVtX3dpbl91bml0dGVzdC5weQpp bmRleCBmZGM3MGUyYTk2N2FlYTc0ZDBjOTQwMzhjMGIwOWZkYWUwNWYzMDAxLi45OWVjNTU5MThm NWE2NzRmNzE2ODI1ZjE2Y2RmMzJhMzE1NDM0ZTVkIDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRz L3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2Nocm9taXVtX3dpbl91bml0dGVzdC5weQorKysg Yi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2Nocm9taXVtX3dpbl91 bml0dGVzdC5weQpAQCAtMTA2LDEwICsxMDYsNiBAQCBjbGFzcyBDaHJvbWl1bVdpblRlc3QoY2hy b21pdW1fcG9ydF90ZXN0Y2FzZS5DaHJvbWl1bVBvcnRUZXN0Q2FzZSk6CiAgICAgICAgIG9wdGlv bnMgPSBNb2NrT3B0aW9ucyhjb25maWd1cmF0aW9uPSdSZWxlYXNlJywgYnVpbGRfZGlyZWN0b3J5 PSdmb28nKQogICAgICAgICBzZWxmLmFzc2VydF9idWlsZF9wYXRoKG9wdGlvbnMsIFsnL21vY2st Y2hlY2tvdXQvU291cmNlL1dlYktpdC9jaHJvbWl1bS9vdXQvUmVsZWFzZSddLCAnZm9vL1JlbGVh c2UnKQogCi0gICAgICAgICMgVGVzdCB0aGF0IHdlIGxvb2sgaW4gYSBjaHJvbWl1bSBkaXJlY3Rv cnkgYmVmb3JlIHRoZSB3ZWJraXQgZGlyZWN0b3J5LgotICAgICAgICBvcHRpb25zID0gTW9ja09w dGlvbnMoY29uZmlndXJhdGlvbj0nUmVsZWFzZScsIGJ1aWxkX2RpcmVjdG9yeT1Ob25lKQotICAg ICAgICBzZWxmLmFzc2VydF9idWlsZF9wYXRoKG9wdGlvbnMsIFsnL21vY2stY2hlY2tvdXQvU291 cmNlL1dlYktpdC9jaHJvbWl1bS9vdXQvUmVsZWFzZScsICcvbW9jay1jaGVja291dC9vdXQvUmVs ZWFzZSddLCAnL21vY2stY2hlY2tvdXQvU291cmNlL1dlYktpdC9jaHJvbWl1bS9vdXQvUmVsZWFz ZScpCi0KICAgICAgICAgIyBUZXN0IHRoYXQgd2UgcHJlZmVyIHRoZSBsZWdhY3kgZGlyIG92ZXIg dGhlIG5ldyBkaXIuCiAgICAgICAgIG9wdGlvbnMgPSBNb2NrT3B0aW9ucyhjb25maWd1cmF0aW9u PSdSZWxlYXNlJywgYnVpbGRfZGlyZWN0b3J5PU5vbmUpCiAgICAgICAgIHNlbGYuYXNzZXJ0X2J1 aWxkX3BhdGgob3B0aW9ucywgWycvbW9jay1jaGVja291dC9Tb3VyY2UvV2ViS2l0L2Nocm9taXVt L2J1aWxkL1JlbGVhc2UnLCAnL21vY2stY2hlY2tvdXQvU291cmNlL1dlYktpdC9jaHJvbWl1bS9v dXQnXSwgJy9tb2NrLWNoZWNrb3V0L1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vYnVpbGQvUmVsZWFz ZScpCg==