105591 2012-12-20 17:17:12 -0800 REGRESSION (r138222?): Assertion failure on appcache/main-resource-redirect.html 2022-02-28 03:43:33 -0800 1 1 1 Unclassified WebKit Page Loading 528+ (Nightly build) Mac Unspecified RESOLVED FIXED Regression P2 Normal --- 106123 1 ap japhet beidson cdumez cgarcia eric.carlson japhet rniwa zan oldest_to_newest 795976 0 ap 2012-12-20 17:17:12 -0800 Looks like <http://trac.webkit.org/r138222> made it so that a delegate is called for a resource with 0 identifier on this test, so a crash happens when accessing a HashMap. Nate, can you please take a look? Note the test is currently also affected by an unrelated regression, tracked as bug 105563. 795983 1 beidson 2012-12-20 17:24:54 -0800 Resources need to always have an identifier. 796385 2 180537 japhet 2012-12-21 11:03:37 -0800 Created attachment 180537 patch 796795 3 ap 2012-12-23 11:56:12 -0800 *** Bug 105691 has been marked as a duplicate of this bug. *** 797641 4 ap 2012-12-27 12:08:15 -0800 *** Bug 105788 has been marked as a duplicate of this bug. *** 797796 5 180537 cgarcia 2012-12-28 00:48:46 -0800 Comment on attachment 180537 patch View in context: https://bugs.webkit.org/attachment.cgi?id=180537&action=review > Source/WebCore/loader/MainResourceLoader.cpp:594 > + m_substituteDataLoadIdentifier = m_documentLoader->frame()->page()->progress()->createUniqueIdentifier(); > + frameLoader()->notifier()->assignIdentifierToInitialRequest(m_substituteDataLoadIdentifier, documentLoader(), m_initialRequest); > + frameLoader()->notifier()->dispatchWillSendRequest(documentLoader(), m_substituteDataLoadIdentifier, m_initialRequest, ResourceResponse()); In case of redirection a new identifier will be created, and assignIdentifierToInitialRequest() will be called twice, this request is not the initial one, but the redirected one, shouldn't we consider it like the same resource and keep the identifier? See the patch I attached to bug #105788 797801 6 180851 cgarcia 2012-12-28 01:00:34 -0800 Created attachment 180851 Different approach In case of redirect, assignIdentifierToInitialRequest has already been called for the resource, if the redirect is going to be loaded from the app cache reuse the identifier and continue the load. 799447 7 180851 beidson 2013-01-03 10:14:46 -0800 Comment on attachment 180851 Different approach I prefer this one over Nate's, though both are acceptable if tests pass, etc etc... 799449 8 180851 japhet 2013-01-03 10:17:42 -0800 Comment on attachment 180851 Different approach View in context: https://bugs.webkit.org/attachment.cgi?id=180851&action=review > Source/WebCore/loader/MainResourceLoader.cpp:273 > + if (m_substituteData.isValid()) > + m_substituteDataLoadIdentifier = identifier(); I don't know if this was tested in debug, but it's possible that this will assert when identifier() is called later, since it asserts that either m_substituteDataLoadIdentifer or ResourceLoader::identiifer() will be 0. Please verify before landing if you haven't already done so. 799491 9 180851 cdumez 2013-01-03 10:58:16 -0800 Comment on attachment 180851 Different approach View in context: https://bugs.webkit.org/attachment.cgi?id=180851&action=review >> Source/WebCore/loader/MainResourceLoader.cpp:273 >> + m_substituteDataLoadIdentifier = identifier(); > > I don't know if this was tested in debug, but it's possible that this will assert when identifier() is called later, since it asserts that either m_substituteDataLoadIdentifer or ResourceLoader::identiifer() will be 0. Please verify before landing if you haven't already done so. Yes, I verified that this patch fixed http/tests/appcache/main-resource-redirect.html for a debug build of WebKit2 EFL. I'll do a layout tests run though to make sure there are no regressions. 799570 10 cdumez 2013-01-03 12:34:09 -0800 (In reply to comment #9) > (From update of attachment 180851 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=180851&action=review > > >> Source/WebCore/loader/MainResourceLoader.cpp:273 > >> + m_substituteDataLoadIdentifier = identifier(); > > > > I don't know if this was tested in debug, but it's possible that this will assert when identifier() is called later, since it asserts that either m_substituteDataLoadIdentifer or ResourceLoader::identiifer() will be 0. Please verify before landing if you haven't already done so. > > Yes, I verified that this patch fixed http/tests/appcache/main-resource-redirect.html for a debug build of WebKit2 EFL. I'll do a layout tests run though to make sure there are no regressions. I did a full layout tests run with a debug build. The patch does not seem to cause regressions on EFL WK2. 800067 11 cgarcia 2013-01-04 01:05:18 -0800 Committed r138782: <http://trac.webkit.org/changeset/138782> 800492 12 rniwa 2013-01-04 12:10:14 -0800 Apparently this crash hasn’t been fixed. See https://bugs.webkit.org/show_bug.cgi?id=106123. 180537 2012-12-21 11:03:37 -0800 2022-02-28 03:43:33 -0800 patch redirect.txt text/plain 3834 japhet SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDEzODM4NykKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBACisyMDEyLTEyLTIxICBOYXRlIENoYXBpbiAgPGph cGhldEBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUkVHUkVTU0lPTihyMTM4MjIyKTogQXNzZXJ0 aW9uIGZhaWx1cmUgb24gYXBwY2FjaGUvbWFpbi1yZXNvdXJjZS1yZWRpcmVjdC5odG1sCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDU1OTEKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBsYXRmb3JtL21h Yy9UZXN0RXhwZWN0YXRpb25zOiBSZW1vdmUgdGhlIG5vIGxvbmdlciBhc3NlcnRpbmcgdGVzdC4K KwogMjAxMi0xMi0yMSAgRGltaXRyaSBHbGF6a292ICA8ZGdsYXprb3ZAY2hyb21pdW0ub3JnPgog CiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHIxMzgzNzYuCkluZGV4OiBMYXlvdXRU ZXN0cy9wbGF0Zm9ybS9tYWMvVGVzdEV4cGVjdGF0aW9ucwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRU ZXN0cy9wbGF0Zm9ybS9tYWMvVGVzdEV4cGVjdGF0aW9ucwkocmV2aXNpb24gMTM4Mzg0KQorKysg TGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL1Rlc3RFeHBlY3RhdGlvbnMJKHdvcmtpbmcgY29weSkK QEAgLTEyNjcsOSArMTI2Nyw2IEBACiB3ZWJraXQub3JnL2IvMTA0ODQ4IGZhc3QvZnJhbWVzL3Nh bmRib3hlZC1pZnJhbWUtYXR0cmlidXRlLXBhcnNpbmcuaHRtbCBbIEZhaWx1cmUgUGFzcyBdCiB3 ZWJraXQub3JnL2IvMTA0ODQ4IGZhc3QvZnJhbWVzL3NhbmRib3hlZC1pZnJhbWUtcGFyc2luZy1z cGFjZS1jaGFyYWN0ZXJzLmh0bWwgWyBGYWlsdXJlIFBhc3MgXQogCi0jIGFwIGlzIGxvb2tpbmcg aW50byB0aGlzIGNyYXNoLgotQnVnKHJuaXdhKSBodHRwL3Rlc3RzL2FwcGNhY2hlL21haW4tcmVz b3VyY2UtcmVkaXJlY3QuaHRtbCBbIENyYXNoIF0KLQogd2Via2l0Lm9yZy9iLzEwNTYwMSBzdmcv em9vbS9wYWdlL3pvb20tcmVwbGFjZWQtaW50cmluc2ljLXJhdGlvLTAwMS5odG0gWyBDcmFzaCBQ YXNzIF0KIAogd2Via2l0Lm9yZy9iLzEwNTYwMyBodHRwL3Rlc3RzL2Nvb2tpZXMvc2luZ2xlLXF1 b3RlZC12YWx1ZS5odG1sIFsgRmFpbHVyZSBQYXNzIF0KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2xv YWRlci9NYWluUmVzb3VyY2VMb2FkZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3Jl L2xvYWRlci9NYWluUmVzb3VyY2VMb2FkZXIuY3BwCShyZXZpc2lvbiAxMzgzODQpCisrKyBTb3Vy Y2UvV2ViQ29yZS9sb2FkZXIvTWFpblJlc291cmNlTG9hZGVyLmNwcAkod29ya2luZyBjb3B5KQpA QCAtNTg5LDYgKzU4OSwxMCBAQAogICAgIGlmICh1cmwuaXNFbXB0eSgpKQogICAgICAgICB1cmwg PSBtX2luaXRpYWxSZXF1ZXN0LnVybCgpOwogCisgICAgbV9zdWJzdGl0dXRlRGF0YUxvYWRJZGVu dGlmaWVyID0gbV9kb2N1bWVudExvYWRlci0+ZnJhbWUoKS0+cGFnZSgpLT5wcm9ncmVzcygpLT5j cmVhdGVVbmlxdWVJZGVudGlmaWVyKCk7CisgICAgZnJhbWVMb2FkZXIoKS0+bm90aWZpZXIoKS0+ YXNzaWduSWRlbnRpZmllclRvSW5pdGlhbFJlcXVlc3QobV9zdWJzdGl0dXRlRGF0YUxvYWRJZGVu dGlmaWVyLCBkb2N1bWVudExvYWRlcigpLCBtX2luaXRpYWxSZXF1ZXN0KTsKKyAgICBmcmFtZUxv YWRlcigpLT5ub3RpZmllcigpLT5kaXNwYXRjaFdpbGxTZW5kUmVxdWVzdChkb2N1bWVudExvYWRl cigpLCBtX3N1YnN0aXR1dGVEYXRhTG9hZElkZW50aWZpZXIsIG1faW5pdGlhbFJlcXVlc3QsIFJl c291cmNlUmVzcG9uc2UoKSk7CisKICAgICAvLyBDbGVhciB0aGUgaW5pdGlhbCByZXF1ZXN0IGhl cmUgc28gdGhhdCBzdWJzZXF1ZW50IGVudHJpZXMgaW50byB0aGUKICAgICAvLyBsb2FkZXIgd2ls bCBub3QgdGhpbmsgdGhlcmUncyBzdGlsbCBhIGRlZmVycmVkIGxvYWQgbGVmdCB0byBkby4KICAg ICBtX2luaXRpYWxSZXF1ZXN0ID0gUmVzb3VyY2VSZXF1ZXN0KCk7CkBAIC02NDMsOSArNjQ3LDYg QEAKICAgICBkb2N1bWVudExvYWRlcigpLT5hcHBsaWNhdGlvbkNhY2hlSG9zdCgpLT5tYXliZUxv YWRNYWluUmVzb3VyY2UocmVxdWVzdCwgbV9zdWJzdGl0dXRlRGF0YSk7CiAKICAgICBpZiAobV9z dWJzdGl0dXRlRGF0YS5pc1ZhbGlkKCkpIHsKLSAgICAgICAgbV9zdWJzdGl0dXRlRGF0YUxvYWRJ ZGVudGlmaWVyID0gbV9kb2N1bWVudExvYWRlci0+ZnJhbWUoKS0+cGFnZSgpLT5wcm9ncmVzcygp LT5jcmVhdGVVbmlxdWVJZGVudGlmaWVyKCk7Ci0gICAgICAgIGZyYW1lTG9hZGVyKCktPm5vdGlm aWVyKCktPmFzc2lnbklkZW50aWZpZXJUb0luaXRpYWxSZXF1ZXN0KG1fc3Vic3RpdHV0ZURhdGFM b2FkSWRlbnRpZmllciwgZG9jdW1lbnRMb2FkZXIoKSwgcmVxdWVzdCk7Ci0gICAgICAgIGZyYW1l TG9hZGVyKCktPm5vdGlmaWVyKCktPmRpc3BhdGNoV2lsbFNlbmRSZXF1ZXN0KGRvY3VtZW50TG9h ZGVyKCksIG1fc3Vic3RpdHV0ZURhdGFMb2FkSWRlbnRpZmllciwgcmVxdWVzdCwgUmVzb3VyY2VS ZXNwb25zZSgpKTsKICAgICAgICAgaGFuZGxlU3Vic3RpdHV0ZURhdGFMb2FkU29vbihyZXF1ZXN0 KTsKICAgICAgICAgcmV0dXJuOwogICAgIH0KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxv Zwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEzODM4 NykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsx LDE4IEBACisyMDEyLTEyLTIxICBOYXRlIENoYXBpbiAgPGphcGhldEBjaHJvbWl1bS5vcmc+CisK KyAgICAgICAgUkVHUkVTU0lPTihyMTM4MjIyKTogQXNzZXJ0aW9uIGZhaWx1cmUgb24gYXBwY2Fj aGUvbWFpbi1yZXNvdXJjZS1yZWRpcmVjdC5odG1sCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDU1OTEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdHMsIGZpeGluZyBodHRwL3Rlc3RzL2Fw cGNhY2hlL21haW4tcmVzb3VyY2UtcmVkaXJlY3QuaHRtbAorCisgICAgICAgICogbG9hZGVyL01h aW5SZXNvdXJjZUxvYWRlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpNYWluUmVzb3VyY2VMb2Fk ZXI6OmhhbmRsZVN1YnN0aXR1dGVEYXRhTG9hZE5vdyk6CisgICAgICAgIChXZWJDb3JlOjpNYWlu UmVzb3VyY2VMb2FkZXI6OmxvYWQpOiBNb3ZlIHJlc291cmNlIGlkZW50aWZpZXIgY3JlYXRpb24g dG8KKyAgICAgICAgICAgIGhhbmRsZVN1YnN0aXR1dGVEYXRhTG9hZE5vdygpLCBzbyB0aGF0IHdl IGNyZWF0ZSBhbiBpZGVudGlmaWVyIGZvcgorICAgICAgICAgICAgc3Vic3RpdHV0ZSBkYXRhIGxv YWRzIHN0YXJ0ZWQgZHVyaW5nIHJlZGlyZWN0LgorCiAyMDEyLTEyLTIxICBEaW1pdHJpIEdsYXpr b3YgIDxkZ2xhemtvdkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGlu ZyBvdXQgcjEzODM3Ni4K 180851 2012-12-28 01:00:34 -0800 2013-01-03 10:58:16 -0800 Different approach wcore-loader-id.diff text/plain 4056 cgarcia ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA5NGViM2QzLi4yODEyZTM4IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTItMTIt MjggIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgorCisgICAgICAg IFJFR1JFU1NJT04gKHIxMzgyMjI/KTogQXNzZXJ0aW9uIGZhaWx1cmUgb24gYXBwY2FjaGUvbWFp bi1yZXNvdXJjZS1yZWRpcmVjdC5odG1sCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xMDU1OTEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBVbnNraXAgaHR0cC90ZXN0cy9hcHBjYWNoZS9tYWluLXJlc291cmNl LXJlZGlyZWN0Lmh0bWwuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9lZmwtd2syL1Rlc3RFeHBlY3Rh dGlvbnM6CisgICAgICAgICogcGxhdGZvcm0vbWFjL1Rlc3RFeHBlY3RhdGlvbnM6CisKIDIwMTIt MTItMjggIENzYWJhIE9zenRyb2dvbsOhYyAgPG9zc3lAd2Via2l0Lm9yZz4KIAogICAgICAgICBV bnJldmlld2VkIGhvbGlkYXkgZ2FyZGVuaW5nLCBza2lwIG5ldyBmYWlsaW5nIHRlc3RzIHRvIHBh aW50IHRoZSBib3RzIGdyZWVuLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZWZs LXdrMi9UZXN0RXhwZWN0YXRpb25zIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZWZsLXdrMi9UZXN0 RXhwZWN0YXRpb25zCmluZGV4IDc1NTg3NjEuLjY3ZGUzNGYgMTAwNjQ0Ci0tLSBhL0xheW91dFRl c3RzL3BsYXRmb3JtL2VmbC13azIvVGVzdEV4cGVjdGF0aW9ucworKysgYi9MYXlvdXRUZXN0cy9w bGF0Zm9ybS9lZmwtd2syL1Rlc3RFeHBlY3RhdGlvbnMKQEAgLTU5LDkgKzU5LDYgQEAgd2Via2l0 Lm9yZy9iLzEwMjY1MSBbIERlYnVnIF0gbmV0d29ya2luZm9ybWF0aW9uL3VwZGF0ZXMuaHRtbCBb IENyYXNoIF0KIHdlYmtpdC5vcmcvYi8xMDI2NTEgWyBEZWJ1ZyBdIG5ldHdvcmtpbmZvcm1hdGlv bi9hZGQtbGlzdGVuZXItZnJvbS1jYWxsYmFjay5odG1sIFsgQ3Jhc2ggXQogd2Via2l0Lm9yZy9i LzEwMjY1MSBbIERlYnVnIF0gbmV0d29ya2luZm9ybWF0aW9uL2Jhc2ljLW9wZXJhdGlvbi5odG1s IFsgQ3Jhc2ggXQogCi0jIFJlc291cmNlQ2xpZW50IGlzIHBhc3NlZCBhbiBpbnZhbGlkIGlkZW50 aWZpZXIgdmFsdWUgKDApLgotd2Via2l0Lm9yZy9iLzEwNTc4OCBbIERlYnVnIF0gaHR0cC90ZXN0 cy9hcHBjYWNoZS9tYWluLXJlc291cmNlLXJlZGlyZWN0Lmh0bWwgWyBDcmFzaCBdCi0KICMvLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vCiAjIEZMQUtZIFRFU1RTCiAjLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFj L1Rlc3RFeHBlY3RhdGlvbnMgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvVGVzdEV4cGVjdGF0 aW9ucwppbmRleCBmMzAxOWY4Li4zZmQwN2YwIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0 Zm9ybS9tYWMvVGVzdEV4cGVjdGF0aW9ucworKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMv VGVzdEV4cGVjdGF0aW9ucwpAQCAtMTI3Myw5ICsxMjczLDYgQEAgd2Via2l0Lm9yZy9iLzEwNTU2 NyBodHRwL3Rlc3RzL3NlY3VyaXR5L2RhdGEtdXJsLWlubGluZS5jc3MuaHRtbCBbIENyYXNoIFBh c3MgXQogd2Via2l0Lm9yZy9iLzEwNDg0OCBmYXN0L2ZyYW1lcy9zYW5kYm94ZWQtaWZyYW1lLWF0 dHJpYnV0ZS1wYXJzaW5nLmh0bWwgWyBGYWlsdXJlIFBhc3MgXQogd2Via2l0Lm9yZy9iLzEwNDg0 OCBmYXN0L2ZyYW1lcy9zYW5kYm94ZWQtaWZyYW1lLXBhcnNpbmctc3BhY2UtY2hhcmFjdGVycy5o dG1sIFsgRmFpbHVyZSBQYXNzIF0KIAotIyBhcCBpcyBsb29raW5nIGludG8gdGhpcyBjcmFzaC4K LUJ1Zyhybml3YSkgaHR0cC90ZXN0cy9hcHBjYWNoZS9tYWluLXJlc291cmNlLXJlZGlyZWN0Lmh0 bWwgWyBDcmFzaCBdCi0KIHdlYmtpdC5vcmcvYi8xMDU2MDEgc3ZnL3pvb20vcGFnZS96b29tLXJl cGxhY2VkLWludHJpbnNpYy1yYXRpby0wMDEuaHRtIFsgQ3Jhc2ggUGFzcyBdCiAKIHdlYmtpdC5v cmcvYi8xMDU2MDMgaHR0cC90ZXN0cy9jb29raWVzL3NpbmdsZS1xdW90ZWQtdmFsdWUuaHRtbCBb IEZhaWx1cmUgUGFzcyBdCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9T b3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDVhMmFhYi4uMWUyZjJiMiAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTEyLTI4ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNn YXJjaWFAaWdhbGlhLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OIChyMTM4MjIyPyk6IEFzc2Vy dGlvbiBmYWlsdXJlIG9uIGFwcGNhY2hlL21haW4tcmVzb3VyY2UtcmVkaXJlY3QuaHRtbAorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA1NTkxCisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRml4ZXMgY3Jhc2gg aW4gdGVzdCBodHRwL3Rlc3RzL2FwcGNhY2hlL21haW4tcmVzb3VyY2UtcmVkaXJlY3QuaHRtbC4K KworICAgICAgICAqIGxvYWRlci9NYWluUmVzb3VyY2VMb2FkZXIuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6TWFpblJlc291cmNlTG9hZGVyOjp3aWxsU2VuZFJlcXVlc3QpOiBJbiBjYXNlIG9mIGxv YWRpbmcKKyAgICAgICAgc3Vic3RpdHV0ZSBkYXRhIGZyb20gYXBwbGljYXRpb24gY2FjaGUgaG9z dCBkdWUgdG8gYSByZWRpcmVjdCwKKyAgICAgICAgbWFrZSBzdXJlIHRoZSBzdWJzdGl0dXRlIGRh dGEgaWRlbnRpZmllciBpcyBpbml0aWFsaXplZC4KKwogMjAxMi0xMi0yNyAgRGltaXRyaSBHbGF6 a292ICA8ZGdsYXprb3ZAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIEZpeCBzdHlsaW5nL2Zvcm1h dHRpbmcgZXJyb3JzLCBwb2ludGVkIG91dCBieSBEYXJpbiBBZGxlciB3aGlsZSByZXZpZXdpbmcK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9NYWluUmVzb3VyY2VMb2FkZXIuY3Bw IGIvU291cmNlL1dlYkNvcmUvbG9hZGVyL01haW5SZXNvdXJjZUxvYWRlci5jcHAKaW5kZXggMzUw ZWIwZC4uOWUwNjExZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvbG9hZGVyL01haW5SZXNv dXJjZUxvYWRlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvbG9hZGVyL01haW5SZXNvdXJjZUxv YWRlci5jcHAKQEAgLTI2OSw2ICsyNjksOCBAQCB2b2lkIE1haW5SZXNvdXJjZUxvYWRlcjo6d2ls bFNlbmRSZXF1ZXN0KFJlc291cmNlUmVxdWVzdCYgbmV3UmVxdWVzdCwgY29uc3QgUmVzbwogICAg ICAgICAvLyBXZSBjaGVja2VkIGFwcGxpY2F0aW9uIGNhY2hlIGZvciBpbml0aWFsIFVSTCwgbm93 IHdlIG5lZWQgdG8gY2hlY2sgaXQgZm9yIHJlZGlyZWN0ZWQgb25lLgogICAgICAgICBBU1NFUlQo IW1fc3Vic3RpdHV0ZURhdGEuaXNWYWxpZCgpKTsKICAgICAgICAgZG9jdW1lbnRMb2FkZXIoKS0+ YXBwbGljYXRpb25DYWNoZUhvc3QoKS0+bWF5YmVMb2FkTWFpblJlc291cmNlRm9yUmVkaXJlY3Qo bmV3UmVxdWVzdCwgbV9zdWJzdGl0dXRlRGF0YSk7CisgICAgICAgIGlmIChtX3N1YnN0aXR1dGVE YXRhLmlzVmFsaWQoKSkKKyAgICAgICAgICAgIG1fc3Vic3RpdHV0ZURhdGFMb2FkSWRlbnRpZmll ciA9IGlkZW50aWZpZXIoKTsKICAgICB9CiAKICAgICAvLyBGSVhNRTogSWRlYWxseSB3ZSdkIHN0 b3AgdGhlIEkvTyB1bnRpbCB3ZSBoZWFyIGJhY2sgZnJvbSB0aGUgbmF2aWdhdGlvbiBwb2xpY3kg ZGVsZWdhdGUK