105581 2012-12-20 15:00:34 -0800 [WK2] LocalTerminationDisabler is not needed in WebCookieManager.cpp 2012-12-20 15:12:01 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ap ap andersca beidson sam oldest_to_newest 795840 0 ap 2012-12-20 15:00:34 -0800 All WebCookieManager functions are synchronous, and all LocalTerminationDisabler does enable/disable a timer that cannot fire inside the function anyway. 795846 1 180419 ap 2012-12-20 15:04:43 -0800 Created attachment 180419 proposed patch In fact, most uses can be removed. Are we doing this just for consistency? I can be convinced to keep it if so. But posting to stir discussion. 795854 2 ap 2012-12-20 15:12:01 -0800 OK, landed as <http://trac.webkit.org/changeset/138306>. I'll need to go over other "managers" later anyway. 180419 2012-12-20 15:04:43 -0800 2012-12-20 15:05:42 -0800 proposed patch LocalTerminationDisabler.txt text/plain 3002 ap SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDEzODMwNCkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBACisyMDEyLTEyLTIwICBBbGV4ZXkg UHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29tPgorCisgICAgICAgIExvY2FsVGVybWluYXRpb25E aXNhYmxlciBpcyBub3QgbmVlZGVkIGluIFdlYkNvb2tpZU1hbmFnZXIuY3BwCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDU1ODEKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBbGwgV2ViQ29va2llTWFuYWdl ciBmdW5jdGlvbnMgYXJlIHN5bmNocm9ub3VzLCBhbmQgYWxsIExvY2FsVGVybWluYXRpb25EaXNh YmxlciBkb2VzCisgICAgICAgIGlzIGVuYWJsZS9kaXNhYmxlIGEgdGltZXIgdGhhdCBjYW5ub3Qg ZmlyZSBpbnNpZGUgdGhlIGZ1bmN0aW9uIGFueXdheS4KKworICAgICAgICAqIFdlYlByb2Nlc3Mv Q29va2llcy9XZWJDb29raWVNYW5hZ2VyLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViQ29va2ll TWFuYWdlcjo6Z2V0SG9zdG5hbWVzV2l0aENvb2tpZXMpOgorICAgICAgICAoV2ViS2l0OjpXZWJD b29raWVNYW5hZ2VyOjpkZWxldGVDb29raWVzRm9ySG9zdG5hbWUpOgorICAgICAgICAoV2ViS2l0 OjpXZWJDb29raWVNYW5hZ2VyOjpkZWxldGVBbGxDb29raWVzKToKKyAgICAgICAgKFdlYktpdDo6 V2ViQ29va2llTWFuYWdlcjo6c3RhcnRPYnNlcnZpbmdDb29raWVDaGFuZ2VzKToKKyAgICAgICAg KFdlYktpdDo6V2ViQ29va2llTWFuYWdlcjo6c2V0SFRUUENvb2tpZUFjY2VwdFBvbGljeSk6Cisg ICAgICAgIChXZWJLaXQ6OldlYkNvb2tpZU1hbmFnZXI6OmdldEhUVFBDb29raWVBY2NlcHRQb2xp Y3kpOgorCiAyMDEyLTEyLTIwICBCcmFkeSBFaWRzb24gIDxiZWlkc29uQGFwcGxlLmNvbT4KIAog ICAgICAgICBOZXR3b3JrUHJvY2VzcyBoYXMgbm8gbmVlZCBmb3Igc3VzcGVuZC9yZXN1bWVQZW5k aW5nUmVxdWVzdHMuCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL0Nvb2tpZXMvV2Vi Q29va2llTWFuYWdlci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvV2ViUHJvY2Vz cy9Db29raWVzL1dlYkNvb2tpZU1hbmFnZXIuY3BwCShyZXZpc2lvbiAxMzgxNzMpCisrKyBTb3Vy Y2UvV2ViS2l0Mi9XZWJQcm9jZXNzL0Nvb2tpZXMvV2ViQ29va2llTWFuYWdlci5jcHAJKHdvcmtp bmcgY29weSkKQEAgLTUzLDggKzUzLDYgQEAgdm9pZCBXZWJDb29raWVNYW5hZ2VyOjpkaWRSZWNl aXZlTWVzc2FnZQogCiB2b2lkIFdlYkNvb2tpZU1hbmFnZXI6OmdldEhvc3RuYW1lc1dpdGhDb29r aWVzKHVpbnQ2NF90IGNhbGxiYWNrSUQpCiB7Ci0gICAgV2ViUHJvY2Vzczo6TG9jYWxUZXJtaW5h dGlvbkRpc2FibGVyIHRlcm1pbmF0aW9uRGlzYWJsZXIoV2ViUHJvY2Vzczo6c2hhcmVkKCkpOwot CiAgICAgSGFzaFNldDxTdHJpbmc+IGhvc3RuYW1lczsKIAogICAgIFdlYkNvcmU6OmdldEhvc3Ru YW1lc1dpdGhDb29raWVzKDAsIGhvc3RuYW1lcyk7CkBAIC02NywyMiArNjUsMTYgQEAgdm9pZCBX ZWJDb29raWVNYW5hZ2VyOjpnZXRIb3N0bmFtZXNXaXRoQwogCiB2b2lkIFdlYkNvb2tpZU1hbmFn ZXI6OmRlbGV0ZUNvb2tpZXNGb3JIb3N0bmFtZShjb25zdCBTdHJpbmcmIGhvc3RuYW1lKQogewot ICAgIFdlYlByb2Nlc3M6OkxvY2FsVGVybWluYXRpb25EaXNhYmxlciB0ZXJtaW5hdGlvbkRpc2Fi bGVyKFdlYlByb2Nlc3M6OnNoYXJlZCgpKTsKLQogICAgIFdlYkNvcmU6OmRlbGV0ZUNvb2tpZXNG b3JIb3N0bmFtZSgwLCBob3N0bmFtZSk7CiB9CiAKIHZvaWQgV2ViQ29va2llTWFuYWdlcjo6ZGVs ZXRlQWxsQ29va2llcygpCiB7Ci0gICAgV2ViUHJvY2Vzczo6TG9jYWxUZXJtaW5hdGlvbkRpc2Fi bGVyIHRlcm1pbmF0aW9uRGlzYWJsZXIoV2ViUHJvY2Vzczo6c2hhcmVkKCkpOwotCiAgICAgV2Vi Q29yZTo6ZGVsZXRlQWxsQ29va2llcygwKTsKIH0KIAogdm9pZCBXZWJDb29raWVNYW5hZ2VyOjpz dGFydE9ic2VydmluZ0Nvb2tpZUNoYW5nZXMoKQogewotICAgIFdlYlByb2Nlc3M6OkxvY2FsVGVy bWluYXRpb25EaXNhYmxlciB0ZXJtaW5hdGlvbkRpc2FibGVyKFdlYlByb2Nlc3M6OnNoYXJlZCgp KTsKLQogICAgIFdlYkNvcmU6OnN0YXJ0T2JzZXJ2aW5nQ29va2llQ2hhbmdlcygpOwogfQogCkBA IC05OCwxMyArOTAsMTEgQEAgdm9pZCBXZWJDb29raWVNYW5hZ2VyOjpkaXNwYXRjaENvb2tpZXNE aQogCiB2b2lkIFdlYkNvb2tpZU1hbmFnZXI6OnNldEhUVFBDb29raWVBY2NlcHRQb2xpY3koSFRU UENvb2tpZUFjY2VwdFBvbGljeSBwb2xpY3kpCiB7Ci0gICAgV2ViUHJvY2Vzczo6TG9jYWxUZXJt aW5hdGlvbkRpc2FibGVyIHRlcm1pbmF0aW9uRGlzYWJsZXIoV2ViUHJvY2Vzczo6c2hhcmVkKCkp OwogICAgIHBsYXRmb3JtU2V0SFRUUENvb2tpZUFjY2VwdFBvbGljeShwb2xpY3kpOwogfQogCiB2 b2lkIFdlYkNvb2tpZU1hbmFnZXI6OmdldEhUVFBDb29raWVBY2NlcHRQb2xpY3kodWludDY0X3Qg Y2FsbGJhY2tJRCkKIHsKLSAgICBXZWJQcm9jZXNzOjpMb2NhbFRlcm1pbmF0aW9uRGlzYWJsZXIg dGVybWluYXRpb25EaXNhYmxlcihXZWJQcm9jZXNzOjpzaGFyZWQoKSk7CiAgICAgV2ViUHJvY2Vz czo6c2hhcmVkKCkuY29ubmVjdGlvbigpLT5zZW5kKE1lc3NhZ2VzOjpXZWJDb29raWVNYW5hZ2Vy UHJveHk6OkRpZEdldEhUVFBDb29raWVBY2NlcHRQb2xpY3kocGxhdGZvcm1HZXRIVFRQQ29va2ll QWNjZXB0UG9saWN5KCksIGNhbGxiYWNrSUQpLCAwKTsKIH0KIAo=