105573 2012-12-20 13:48:04 -0800 Introduce a compositing trigger for scrollable inner frames 2013-01-08 07:28:51 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 105558 1 tonikitoo tonikitoo eric jamesr kenneth ojan.autocc simon.fraser vangelis webkit.review.bot oldest_to_newest 795761 0 tonikitoo 2012-12-20 13:48:04 -0800 +++ This bug was initially created as a clone of Bug #105558 +++ After https://bugs.webkit.org/show_bug.cgi?id=105558#c3 , bug 105558 became INVALID. This bug then has a more limited scope of introducing a compositing trigger for scrollable frames, as a first step to add support for fast scrolling inner frames (similar to how overflow scrolling works). 795772 1 180404 tonikitoo 2012-12-20 13:59:49 -0800 Created attachment 180404 patch 798870 2 180404 jamesr 2013-01-02 14:04:39 -0800 Comment on attachment 180404 patch This seems fine. In chromium, we're currently only using this trigger when we're using force compositing mode, but that's just a policy choice and not something inherent to the code itself. Having it be a separate trigger seems perfectly reasonable. 802241 3 tonikitoo 2013-01-08 07:28:51 -0800 Committed https://trac.webkit.org/changeset/139053 180404 2012-12-20 13:59:49 -0800 2013-01-02 14:04:39 -0800 patch 0001-Introduce-a-compositing-trigger-for-scrollable-frame.patch text/plain 5913 tonikitoo RnJvbSAxOTIyMGZmYjdlMjFlNmUyOGI5MzUyMGM3ZjA1ZjY5OWMxMjgxY2EwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbnRvbmlvIEdvbWVzIDxhMS5nb21lc0BzaXNhLnNhbXN1bmcu Y29tPgpEYXRlOiBUaHUsIDIwIERlYyAyMDEyIDE3OjU1OjAyIC0wNDAwClN1YmplY3Q6IFtQQVRD SF0gSW50cm9kdWNlIGEgY29tcG9zaXRpbmcgdHJpZ2dlciBmb3Igc2Nyb2xsYWJsZSBmcmFtZXMK IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDU1NzMKClJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgpQYXRjaCBieSBBbnRvbmlvIEdvbWVzIDxhMS5nb21lc0BzaXNh LnNhbXN1bmcuY29tPgoKU291cmNlL1dlYkNvcmU6CgpNYWtlIHJlcXVpcmVzQ29tcG9zaXRpbmdG b3JTY3JvbGxhYmxlRnJhbWUgdG8gY2hlY2sgdGhlCm5ld2x5IGFkZGVkIGNvbXBvc2l0aW5nIHRy aWdnZXIgaW5zdGVhZCBvZiB0aGUgYXNzb2NpYXRlZCBzZXR0aW5nLgoKSXQgaW50cm9kdWNlcyBu byBoYXZlIGJlaGF2aW9yIGNoYW5nZSwgc28gbm8gbmV3IHRlc3RzLiBQYXRjaCBiYXNpY2FsbHkK ZG9lcyBzb21lIHByZXBhcmF0aW9uIHdvcmsgZm9yIGFkZGluZyBzdXBwb3J0IHRvIGNvbXBvc2l0 ZSBzY3JvbGxhYmxlIGlubmVyCmZyYW1lcyBpbmRlcGVuZGVudGx5IGZyb20gImZvcmNlIGNvbXBv c2l0aW5nIG1vZGUiIGJpdC4KCiogcGFnZS9DaHJvbWVDbGllbnQuaDoKKiByZW5kZXJpbmcvUmVu ZGVyTGF5ZXJDb21wb3NpdG9yLmNwcDoKKFdlYkNvcmU6OlJlbmRlckxheWVyQ29tcG9zaXRvcjo6 Y2FjaGVBY2NlbGVyYXRlZENvbXBvc2l0aW5nRmxhZ3MpOgooV2ViQ29yZTo6UmVuZGVyTGF5ZXJD b21wb3NpdG9yOjpyZXF1aXJlc0NvbXBvc2l0aW5nRm9yU2Nyb2xsYWJsZUZyYW1lKToKClNvdXJj ZS9XZWJLaXQvY2hyb21pdW06CgpTZXQgdGhlIG5ld2x5IGFkZGVkIHNjcm9sbGFibGUtaW5uZXIt ZnJhbWVzIGJpdCB0byBjb21wb3NpdGluZy10cmlnZ2VyCmJpdHNldCBpbiBhY2NvcmRhbmNlIHRv IHRoZSByZXNwZWN0aXZlIHNldHRpbmcgdmFsdWUuCgoqIHNyYy9DaHJvbWVDbGllbnRJbXBsLmNw cDoKKFdlYktpdDo6Q2hyb21lQ2xpZW50SW1wbDo6YWxsb3dlZENvbXBvc2l0aW5nVHJpZ2dlcnMp OgotLS0KIFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgICAgICAgICAg IHwgICAxOSArKysrKysrKysrKysrKysrKysrCiBTb3VyY2UvV2ViQ29yZS9wYWdlL0Nocm9tZUNs aWVudC5oICAgICAgICAgICAgICAgICB8ICAgIDEgKwogU291cmNlL1dlYkNvcmUvcmVuZGVyaW5n L1JlbmRlckxheWVyQ29tcG9zaXRvci5jcHAgfCAgICA4ICsrKysrKystCiBTb3VyY2UvV2ViS2l0 L2Nocm9taXVtL0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgICB8ICAgMTMgKysrKysrKysrKysr KwogU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvQ2hyb21lQ2xpZW50SW1wbC5jcHAgICAgfCAg ICAyICsrCiA1IGZpbGVzIGNoYW5nZWQsIDQyIGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkK CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cKaW5kZXggNzc5NjU0My4uZmQ3NmQ4OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIy IEBACisyMDEyLTEyLTIwICBBbnRvbmlvIEdvbWVzICA8YTEuZ29tZXNAc2lzYS5zYW1zdW5nLmNv bT4KKworICAgICAgICBJbnRyb2R1Y2UgYSBjb21wb3NpdGluZyB0cmlnZ2VyIGZvciBzY3JvbGxh YmxlIGZyYW1lcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTA1NTczCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgTWFrZSByZXF1aXJlc0NvbXBvc2l0aW5nRm9yU2Nyb2xsYWJsZUZyYW1lIHRvIGNoZWNrIHRo ZQorICAgICAgICBuZXdseSBhZGRlZCBjb21wb3NpdGluZyB0cmlnZ2VyIGluc3RlYWQgb2YgdGhl IGFzc29jaWF0ZWQgc2V0dGluZy4KKworICAgICAgICBJdCBpbnRyb2R1Y2VzIG5vIGhhdmUgYmVo YXZpb3IgY2hhbmdlLCBzbyBubyBuZXcgdGVzdHMuIFBhdGNoIGJhc2ljYWxseQorICAgICAgICBk b2VzIHNvbWUgcHJlcGFyYXRpb24gd29yayBmb3IgYWRkaW5nIHN1cHBvcnQgdG8gY29tcG9zaXRl IHNjcm9sbGFibGUgaW5uZXIKKyAgICAgICAgZnJhbWVzIGluZGVwZW5kZW50bHkgZnJvbSAiZm9y Y2UgY29tcG9zaXRpbmcgbW9kZSIgYml0LgorCisgICAgICAgICogcGFnZS9DaHJvbWVDbGllbnQu aDoKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyTGF5ZXJDb21wb3NpdG9yLmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6OlJlbmRlckxheWVyQ29tcG9zaXRvcjo6Y2FjaGVBY2NlbGVyYXRlZENvbXBv c2l0aW5nRmxhZ3MpOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyTGF5ZXJDb21wb3NpdG9yOjpy ZXF1aXJlc0NvbXBvc2l0aW5nRm9yU2Nyb2xsYWJsZUZyYW1lKToKKwogMjAxMi0xMi0xMiAgQW50 b25pbyBHb21lcyAgPGExLmdvbWVzQHNpc2Euc2Ftc3VuZy5jb20+CiAKICAgICAgICAgTWFrZSBS ZW5kZXJMYXllcjo6dXBkYXRlTmVlZHNDb21wb3NpdGVkU2Nyb2xsaW5nIHNjcm9sbGJhcnMgYWdu b3N0aWMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvQ2hyb21lQ2xpZW50LmggYi9T b3VyY2UvV2ViQ29yZS9wYWdlL0Nocm9tZUNsaWVudC5oCmluZGV4IGYxYzMzZGUuLjQ0NWM3NTcg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvQ2hyb21lQ2xpZW50LmgKKysrIGIvU291 cmNlL1dlYkNvcmUvcGFnZS9DaHJvbWVDbGllbnQuaApAQCAtMjcxLDYgKzI3MSw3IEBAIHB1Ymxp YzoKICAgICAgICAgQ2FudmFzVHJpZ2dlciA9IDEgPDwgMywKICAgICAgICAgQW5pbWF0aW9uVHJp Z2dlciA9IDEgPDwgNCwKICAgICAgICAgRmlsdGVyVHJpZ2dlciA9IDEgPDwgNSwKKyAgICAgICAg U2Nyb2xsYWJsZUlubmVyRnJhbWVUcmlnZ2VyID0gMSA8PCA2LAogICAgICAgICBBbGxUcmlnZ2Vy cyA9IDB4RkZGRkZGRkYKICAgICB9OwogICAgIHR5cGVkZWYgdW5zaWduZWQgQ29tcG9zaXRpbmdU cmlnZ2VyRmxhZ3M7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVy TGF5ZXJDb21wb3NpdG9yLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXll ckNvbXBvc2l0b3IuY3BwCmluZGV4IGYwZDUzZTIuLjQ3NDYxZDAgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllckNvbXBvc2l0b3IuY3BwCisrKyBiL1NvdXJj ZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllckNvbXBvc2l0b3IuY3BwCkBAIC0yNTUsNyAr MjU1LDcgQEAgdm9pZCBSZW5kZXJMYXllckNvbXBvc2l0b3I6OmNhY2hlQWNjZWxlcmF0ZWRDb21w b3NpdGluZ0ZsYWdzKCkKICAgICAgICAgZm9yY2VDb21wb3NpdGluZ01vZGUgPSBzZXR0aW5ncy0+ Zm9yY2VDb21wb3NpdGluZ01vZGUoKSAmJiBoYXNBY2NlbGVyYXRlZENvbXBvc2l0aW5nOwogCiAg ICAgICAgIGlmIChmb3JjZUNvbXBvc2l0aW5nTW9kZSAmJiBtX3JlbmRlclZpZXctPmRvY3VtZW50 KCktPm93bmVyRWxlbWVudCgpKQotICAgICAgICAgICAgZm9yY2VDb21wb3NpdGluZ01vZGUgPSBz ZXR0aW5ncy0+YWNjZWxlcmF0ZWRDb21wb3NpdGluZ0ZvclNjcm9sbGFibGVGcmFtZXNFbmFibGVk KCkgJiYgcmVxdWlyZXNDb21wb3NpdGluZ0ZvclNjcm9sbGFibGVGcmFtZSgpOworICAgICAgICAg ICAgZm9yY2VDb21wb3NpdGluZ01vZGUgPSByZXF1aXJlc0NvbXBvc2l0aW5nRm9yU2Nyb2xsYWJs ZUZyYW1lKCk7CiAKICAgICAgICAgYWNjZWxlcmF0ZWREcmF3aW5nRW5hYmxlZCA9IHNldHRpbmdz LT5hY2NlbGVyYXRlZERyYXdpbmdFbmFibGVkKCk7CiAgICAgfQpAQCAtMTc5Niw2ICsxNzk2LDEy IEBAIGJvb2wgUmVuZGVyTGF5ZXJDb21wb3NpdG9yOjpyZXF1aXJlc0NvbXBvc2l0aW5nRm9yU2Ny b2xsYWJsZUZyYW1lKCkgY29uc3QKIHsKICAgICAvLyBOZWVkIHRoaXMgZG9uZSBmaXJzdCB0byBk ZXRlcm1pbmUgb3ZlcmZsb3cuCiAgICAgQVNTRVJUKCFtX3JlbmRlclZpZXctPm5lZWRzTGF5b3V0 KCkpOworICAgIEhUTUxGcmFtZU93bmVyRWxlbWVudCogb3duZXJFbGVtZW50ID0gbV9yZW5kZXJW aWV3LT5kb2N1bWVudCgpLT5vd25lckVsZW1lbnQoKTsKKyAgICBpZiAoIW93bmVyRWxlbWVudCkK KyAgICAgICAgcmV0dXJuIGZhbHNlOworCisgICAgaWYgKCEobV9jb21wb3NpdGluZ1RyaWdnZXJz ICYgQ2hyb21lQ2xpZW50OjpTY3JvbGxhYmxlSW5uZXJGcmFtZVRyaWdnZXIpKQorICAgICAgICBy ZXR1cm4gZmFsc2U7CiAKICAgICBGcmFtZVZpZXcqIGZyYW1lVmlldyA9IG1fcmVuZGVyVmlldy0+ ZnJhbWVWaWV3KCk7CiAgICAgcmV0dXJuIGZyYW1lVmlldy0+aXNTY3JvbGxhYmxlKCk7CmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv Y2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4IGI5YTA5N2MuLjM5ODM1ZDMgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21p dW0vQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTItMTItMjAgIEFudG9uaW8gR29tZXMg IDxhMS5nb21lc0BzaXNhLnNhbXN1bmcuY29tPgorCisgICAgICAgIEludHJvZHVjZSBhIGNvbXBv c2l0aW5nIHRyaWdnZXIgZm9yIHNjcm9sbGFibGUgZnJhbWVzCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDU1NzMKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTZXQgdGhlIG5ld2x5IGFkZGVkIHNjcm9sbGFi bGUtaW5uZXItZnJhbWVzIGJpdCB0byBjb21wb3NpdGluZy10cmlnZ2VyCisgICAgICAgIGJpdHNl dCBpbiBhY2NvcmRhbmNlIHRvIHRoZSByZXNwZWN0aXZlIHNldHRpbmcgdmFsdWUuCisKKyAgICAg ICAgKiBzcmMvQ2hyb21lQ2xpZW50SW1wbC5jcHA6CisgICAgICAgIChXZWJLaXQ6OkNocm9tZUNs aWVudEltcGw6OmFsbG93ZWRDb21wb3NpdGluZ1RyaWdnZXJzKToKKwogMjAxMi0xMi0yMCAgRG9t aW5pYyBNYXp6b25pICA8ZG1henpvbmlAZ29vZ2xlLmNvbT4KIAogICAgICAgICBBWDogc3VwcG9y dCBjbGlja1BvaW50IGluIERSVCBmb3IgY2hyb21pdW0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJL aXQvY2hyb21pdW0vc3JjL0Nocm9tZUNsaWVudEltcGwuY3BwIGIvU291cmNlL1dlYktpdC9jaHJv bWl1bS9zcmMvQ2hyb21lQ2xpZW50SW1wbC5jcHAKaW5kZXggMjFkYmY0MC4uMTlhOGQ4ZCAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvQ2hyb21lQ2xpZW50SW1wbC5jcHAK KysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvQ2hyb21lQ2xpZW50SW1wbC5jcHAKQEAg LTk0NSw2ICs5NDUsOCBAQCBDaHJvbWVDbGllbnQ6OkNvbXBvc2l0aW5nVHJpZ2dlckZsYWdzIENo cm9tZUNsaWVudEltcGw6OmFsbG93ZWRDb21wb3NpdGluZ1RyaWdnZQogICAgICAgICBmbGFncyB8 PSBBbmltYXRpb25UcmlnZ2VyOwogICAgIGlmIChzZXR0aW5ncy0+YWNjZWxlcmF0ZWRDb21wb3Np dGluZ0ZvckNhbnZhc0VuYWJsZWQoKSkKICAgICAgICAgZmxhZ3MgfD0gQ2FudmFzVHJpZ2dlcjsK KyAgICBpZiAoc2V0dGluZ3MtPmFjY2VsZXJhdGVkQ29tcG9zaXRpbmdGb3JTY3JvbGxhYmxlRnJh bWVzRW5hYmxlZCgpKQorICAgICAgICBmbGFncyB8PSBTY3JvbGxhYmxlSW5uZXJGcmFtZVRyaWdn ZXI7CiAKICAgICByZXR1cm4gZmxhZ3M7CiB9Ci0tIAoxLjcuMTAuNAoK