105571 2012-12-20 13:15:55 -0800 Harden pointers in FastMalloc's singly linked list implementation 2012-12-20 13:36:56 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 oliver oliver benjamin ojan.autocc webkit.review.bot oldest_to_newest 795721 0 oliver 2012-12-20 13:15:55 -0800 Harden pointers in FastMalloc's singly linked list implementation 795724 1 180397 oliver 2012-12-20 13:19:05 -0800 Created attachment 180397 Patch 795728 2 webkit.review.bot 2012-12-20 13:23:11 -0800 Attachment 180397 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/Fa..." exit_code: 1 Source/WTF/wtf/FastMalloc.cpp:687: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/FastMalloc.cpp:691: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 2 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 795740 3 180397 barraclough 2012-12-20 13:34:07 -0800 Comment on attachment 180397 Patch r+, assuming you're performance tested this one something. 795743 4 oliver 2012-12-20 13:36:56 -0800 Committed r138293: <http://trac.webkit.org/changeset/138293> 180397 2012-12-20 13:19:05 -0800 2012-12-20 13:34:07 -0800 Patch bug-105571-20121220131621.patch text/plain 2992 oliver U3VidmVyc2lvbiBSZXZpc2lvbjogMTM4Mjg3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDAxYTI1NzMyZWI0ZWIyNzQ1OTEzMDY4 MDQzOGNlNzhkNjJlMWM4ZjUuLjY2MTgxZGUzZDE5NTY5OTcxY2YyMTUwNzZlMGIyZTFkODEwNWNi ZDYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTItMTItMjAgIE9saXZlciBIdW50ICA8b2xpdmVy QGFwcGxlLmNvbT4KKworICAgICAgICBIYXJkZW4gcG9pbnRlcnMgaW4gRmFzdE1hbGxvYydzIHNp bmdseSBsaW5rZWQgbGlzdCBpbXBsZW1lbnRhdGlvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA1NTcxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIHNpbXBsZSB4b3IgYmFzZWQgaGFyZGVuaW5nIG9m IHRoZSBuZXh0IHBvaW50ZXIgaW4gdGhlCisgICAgICAgIGZhc3QgbWFsbG9jIHNpbmdseSBsaW5r ZWQgbGlzdCBpbXBsZW1lbnRhdGlvbi4gIFdlIHJlbHkgb24KKyAgICAgICAgQVNMUiB0byBpbnRy b2R1Y2UgdGhlIGFkZHJlc3MgcmFuZG9tbmVzcyB3ZSB3YW50IGZvciB0aGUgbWFzay4KKyAgICAg ICAgSGFwcGlseSB0aGlzIHByb2R1Y2VzIGEgdmVyeSBsb3cgY29zdCByYW5kb20gdmFsdWUgdG8g dXNlLgorCisgICAgICAgICogd3RmL0Zhc3RNYWxsb2MuY3BwOgorICAgICAgICAoV1RGKToKKyAg ICAgICAgKFdURjo6U0xMX05leHQpOgorICAgICAgICAoV1RGOjpTTExfU2V0TmV4dCk6CisKIDIw MTItMTItMTkgIE9saXZlciBIdW50ICA8b2xpdmVyQGFwcGxlLmNvbT4KIAogICAgICAgICBTdHJp bmdJbXBsIGlzb2xhdGVkQ29weSB1bm5lY2Vzc2FyaWx5IGNvcGllcyB0ZXh0LXNlZ21lbnQgY2hh cmFjdGVyIGRhdGEKZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3RmL0Zhc3RNYWxsb2MuY3BwIGIv U291cmNlL1dURi93dGYvRmFzdE1hbGxvYy5jcHAKaW5kZXggZjJlMzRjN2FkZmNmYjMyMjczOWY1 YjRmZWY4NWVjZTkxOTA1YTFhOC4uZTRjOTc4YTE2YzU5N2MwNDIyYjQwNzg3YjRlMGJmOTg2MDE3 OWRhOCAxMDA2NDQKLS0tIGEvU291cmNlL1dURi93dGYvRmFzdE1hbGxvYy5jcHAKKysrIGIvU291 cmNlL1dURi93dGYvRmFzdE1hbGxvYy5jcHAKQEAgLTEwMCw2ICsxMDAsMTEgQEAKICNkZWZpbmUg Rk9SQ0VfU1lTVEVNX01BTExPQyAxCiAjZW5kaWYKIAorLy8gSGFyZGVuIHRoZSBwb2ludGVycyBz dG9yZWQgaW4gdGhlIFRDTWFsbG9jIGxpbmtlZCBsaXN0cworI2lmIENPTVBJTEVSKEdDQykKKyNk ZWZpbmUgRU5BQkxFX1RDTUFMTE9DX0hBUkRFTklORyAxCisjZW5kaWYKKwogLy8gVXNlIGEgYmFj a2dyb3VuZCB0aHJlYWQgdG8gcGVyaW9kaWNhbGx5IHNjYXZlbmdlIG1lbW9yeSB0byByZWxlYXNl IGJhY2sgdG8gdGhlIHN5c3RlbQogI2lmIFBMQVRGT1JNKElPUykKICNkZWZpbmUgVVNFX0JBQ0tH Uk9VTkRfVEhSRUFEX1RPX1NDQVZFTkdFX01FTU9SWSAwCkBAIC00OTYsNiArNTAxLDIzIEBAIG5h bWVzcGFjZSBXVEYgewogI2RlZmluZSBNRVNTQUdFIExPR19FUlJPUgogI2RlZmluZSBDSEVDS19D T05ESVRJT04gQVNTRVJUCiAKKyNpZiBFTkFCTEUoVENNQUxMT0NfSEFSREVOSU5HKQorLyoKKyAq IFRvIG1ha2UgaXQgaGFyZGVyIHRvIGV4cGxvaXQgdXNlLWFmdGVyIGZyZWUgc3R5bGUgZXhwbG9p dHMKKyAqIHdlIG1hc2sgdGhlIGFkZHJlc3NlcyB3ZSBwdXQgaW50byBvdXIgbGlua2VkIGxpc3Rz IHdpdGggdGhlCisgKiBhZGRyZXNzIG9mIGtMTEhhcmRlbmluZ01hc2suICBEdWUgdG8gQVNMUiB0 aGUgYWRkcmVzcyBvZgorICoga0xMSGFyZGVuaW5nTWFzayBzaG91bGQgYmUgc3VmZmljaWVudGx5 IHJhbmRvbWl6ZWQgdG8gbWFrZSBkaXJlY3QKKyAqIGZyZWVsaXN0IG1hbmlwdWxhdGlvbiBtdWNo IG1vcmUgZGlmZmljdWx0LgorICovCitzdGF0aWMgY29uc3QgY2hhciBrTExIYXJkZW5pbmdNYXNr ID0gMDsKKyNkZWZpbmUgTUFTS19QVFIocHRyKSAocmVpbnRlcnByZXRfY2FzdDx0eXBlb2YocHRy KT4ocmVpbnRlcnByZXRfY2FzdDx1aW50cHRyX3Q+KHB0cilecmVpbnRlcnByZXRfY2FzdDx1aW50 cHRyX3Q+KCZrTExIYXJkZW5pbmdNYXNrKSkpCisjZGVmaW5lIFVOTUFTS19QVFIocHRyKSAocmVp bnRlcnByZXRfY2FzdDx0eXBlb2YocHRyKT4ocmVpbnRlcnByZXRfY2FzdDx1aW50cHRyX3Q+KHB0 cilecmVpbnRlcnByZXRfY2FzdDx1aW50cHRyX3Q+KCZrTExIYXJkZW5pbmdNYXNrKSkpCisjZWxz ZQorI2RlZmluZSBNQVNLX1BUUihwdHIpIChwdHIpCisjZGVmaW5lIFVOTUFTS19QVFIocHRyKSAo cHRyKQorI2VuZGlmCisKKwogLy8tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCiAvLyBDb25maWd1cmF0aW9uCiAvLy0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0KQEAgLTY2MiwxMSArNjg0LDExIEBAIHN0YXRpYyBpbmxpbmUgaW50IExnRmxvb3Ioc2l6 ZV90IG4pIHsKIC8vIHN0b3JhZ2UuCiAKIHN0YXRpYyBpbmxpbmUgdm9pZCAqU0xMX05leHQodm9p ZCAqdCkgewotICByZXR1cm4gKihyZWludGVycHJldF9jYXN0PHZvaWQqKj4odCkpOworICByZXR1 cm4gVU5NQVNLX1BUUigqKHJlaW50ZXJwcmV0X2Nhc3Q8dm9pZCoqPih0KSkpOwogfQogCiBzdGF0 aWMgaW5saW5lIHZvaWQgU0xMX1NldE5leHQodm9pZCAqdCwgdm9pZCAqbikgewotICAqKHJlaW50 ZXJwcmV0X2Nhc3Q8dm9pZCoqPih0KSkgPSBuOworICAqKHJlaW50ZXJwcmV0X2Nhc3Q8dm9pZCoq Pih0KSkgPSBNQVNLX1BUUihuKTsKIH0KIAogc3RhdGljIGlubGluZSB2b2lkIFNMTF9QdXNoKHZv aWQgKipsaXN0LCB2b2lkICplbGVtZW50KSB7Cg==