105550 2012-12-20 10:31:01 -0800 NetworkProcess has no need for suspend/resumePendingRequests 2012-12-20 14:21:46 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 beidson beidson ap koivisto sam oldest_to_newest 795548 0 beidson 2012-12-20 10:31:01 -0800 NetworkProcess has no need for suspend/resumePendingRequests Discussion in https://bugs.webkit.org/show_bug.cgi?id=100479 Most importantly for WebKit2 with the NetworkProcess: "I think the suppression mechanism here exists to prevent resource loads from completing synchronously in the middle of style recalc and resulting in re-entry bugs. All loads through network process should be asynchronous so the problems shouldn't exist at all. I think these can be safely removed." We want to remove these because they are surprisingly hot code and the messaging is showing up on profiles. In radar as <rdar://problem/12866005> 795552 1 180363 beidson 2012-12-20 10:36:55 -0800 Created attachment 180363 Patch v1 795605 2 180363 ap 2012-12-20 11:42:11 -0800 Comment on attachment 180363 Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=180363&action=review > Source/WebKit2/WebProcess/Network/WebResourceLoadScheduler.cpp:166 > + // If this WebProcess has a request suspension count then we shouldn't bother > + // messaging the NetworkProcess. I think that a more detailed explanation would help here. What breaks if this check is removed? 795798 3 beidson 2012-12-20 14:21:46 -0800 http://trac.webkit.org/changeset/138301 180363 2012-12-20 10:36:55 -0800 2012-12-20 11:42:11 -0800 Patch v1 patch text/plain 7368 beidson ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBjNDczNmExLi4xYzRjZTZhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjgg QEAKKzIwMTItMTItMjAgIEJyYWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUuY29tPgorCisgICAg ICAgIE5ldHdvcmtQcm9jZXNzIGhhcyBubyBuZWVkIGZvciBzdXNwZW5kL3Jlc3VtZVBlbmRpbmdS ZXF1ZXN0cy4KKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzEyODY2MDA1PiBhbmQgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNTU1MAorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIHN1c3BlbmQvcmVzdW1lUGVuZGluZ1JlcXVl c3RzIHdlcmUgaW1wb3J0YW50IGluIGEgc2luZ2xlLXByb2Nlc3MsIFdlYktpdDEgQVBJIHdvcmxk IHRvIGhlbHAgcHJldmVudAorICAgICAgICBjbGllbnQgY2FsbGJhY2tzIGZyb20gb2NjdXJyaW5n IGR1cmluZyBsYXlvdXQvcGFpbnRpbmcuCisKKyAgICAgICAgSW4gYSBXZWJLaXQyICsgTmV0d29y a1Byb2Nlc3Mgd29ybGQsIHRoZXkgYXJlbid0IGltcG9ydGFudC4KKworICAgICAgICBSZW1vdmUg dGhlIFdlYi0+TmV0d29yayBwcm9jZXNzIG1lc3NhZ2VzOgorICAgICAgICAqIE5ldHdvcmtQcm9j ZXNzL05ldHdvcmtDb25uZWN0aW9uVG9XZWJQcm9jZXNzLmNwcDoKKyAgICAgICAgKiBOZXR3b3Jr UHJvY2Vzcy9OZXR3b3JrQ29ubmVjdGlvblRvV2ViUHJvY2Vzcy5oOgorICAgICAgICAqIE5ldHdv cmtQcm9jZXNzL05ldHdvcmtDb25uZWN0aW9uVG9XZWJQcm9jZXNzLm1lc3NhZ2VzLmluOgorICAg ICAgICAqIE5ldHdvcmtQcm9jZXNzL05ldHdvcmtSZXNvdXJjZUxvYWRTY2hlZHVsZXIuY3BwOgor ICAgICAgICAqIE5ldHdvcmtQcm9jZXNzL05ldHdvcmtSZXNvdXJjZUxvYWRTY2hlZHVsZXIuaDoK KworICAgICAgICBGb3Igbm93LCBzdGlsbCBrZWVwIHRoZSBwZXItV2ViUHJvY2VzcyBjb3VudCB0 byBoZWxwIGtlZXAgc2VydmVQZW5kaW5nUmVxdWVzdCB3b3JraW5nIGFzIFdlYkNvcmUgaW50ZW5k czoKKyAgICAgICAgKiBXZWJQcm9jZXNzL05ldHdvcmsvV2ViUmVzb3VyY2VMb2FkU2NoZWR1bGVy LmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViUmVzb3VyY2VMb2FkU2NoZWR1bGVyOjpzZXJ2ZVBl bmRpbmdSZXF1ZXN0cyk6CisgICAgICAgIChXZWJLaXQ6OldlYlJlc291cmNlTG9hZFNjaGVkdWxl cjo6c3VzcGVuZFBlbmRpbmdSZXF1ZXN0cyk6CisgICAgICAgIChXZWJLaXQ6OldlYlJlc291cmNl TG9hZFNjaGVkdWxlcjo6cmVzdW1lUGVuZGluZ1JlcXVlc3RzKToKKwogMjAxMi0xMi0xOCAgSm9u IExlZSAgPGpvbmxlZUBhcHBsZS5jb20+CiAKICAgICAgICAgTm90aWZ5IGNvbnRleHQgY2xpZW50 IG9mIGNoYW5nZSB0byB0YWJsZSwgYW5kIGFsbG93IGNsaWVudCB0byBnZXQgYSBjb3B5IG9mIGl0 CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJvY2Vzcy9OZXR3b3JrQ29ubmVj dGlvblRvV2ViUHJvY2Vzcy5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJvY2Vzcy9OZXR3 b3JrQ29ubmVjdGlvblRvV2ViUHJvY2Vzcy5jcHAKaW5kZXggZmE5MjE0NS4uOGUwNjQ0MyAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYktpdDIvTmV0d29ya1Byb2Nlc3MvTmV0d29ya0Nvbm5lY3Rpb25U b1dlYlByb2Nlc3MuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL05ldHdvcmtQcm9jZXNzL05ldHdv cmtDb25uZWN0aW9uVG9XZWJQcm9jZXNzLmNwcApAQCAtMTM5LDE2ICsxMzksNiBAQCB2b2lkIE5l dHdvcmtDb25uZWN0aW9uVG9XZWJQcm9jZXNzOjpzZXJ2ZVBlbmRpbmdSZXF1ZXN0cyh1aW50MzJf dCByZXNvdXJjZUxvYWRQcgogICAgIE5ldHdvcmtQcm9jZXNzOjpzaGFyZWQoKS5uZXR3b3JrUmVz b3VyY2VMb2FkU2NoZWR1bGVyKCkuc2VydmVQZW5kaW5nUmVxdWVzdHMoc3RhdGljX2Nhc3Q8UmVz b3VyY2VMb2FkUHJpb3JpdHk+KHJlc291cmNlTG9hZFByaW9yaXR5KSk7CiB9CiAKLXZvaWQgTmV0 d29ya0Nvbm5lY3Rpb25Ub1dlYlByb2Nlc3M6OnN1c3BlbmRQZW5kaW5nUmVxdWVzdHMoKQotewot ICAgIE5ldHdvcmtQcm9jZXNzOjpzaGFyZWQoKS5uZXR3b3JrUmVzb3VyY2VMb2FkU2NoZWR1bGVy KCkuc3VzcGVuZFBlbmRpbmdSZXF1ZXN0cygpOwotfQotCi12b2lkIE5ldHdvcmtDb25uZWN0aW9u VG9XZWJQcm9jZXNzOjpyZXN1bWVQZW5kaW5nUmVxdWVzdHMoKQotewotICAgIE5ldHdvcmtQcm9j ZXNzOjpzaGFyZWQoKS5uZXR3b3JrUmVzb3VyY2VMb2FkU2NoZWR1bGVyKCkucmVzdW1lUGVuZGlu Z1JlcXVlc3RzKCk7Ci19Ci0KIHZvaWQgTmV0d29ya0Nvbm5lY3Rpb25Ub1dlYlByb2Nlc3M6OnNl dFNlcmlhbExvYWRpbmdFbmFibGVkKGJvb2wgZW5hYmxlZCkKIHsKICAgICBtX3NlcmlhbExvYWRp bmdFbmFibGVkID0gZW5hYmxlZDsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL05ldHdvcmtQ cm9jZXNzL05ldHdvcmtDb25uZWN0aW9uVG9XZWJQcm9jZXNzLmggYi9Tb3VyY2UvV2ViS2l0Mi9O ZXR3b3JrUHJvY2Vzcy9OZXR3b3JrQ29ubmVjdGlvblRvV2ViUHJvY2Vzcy5oCmluZGV4IDQyZGU1 NzMuLjcxYWZhM2EgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL05ldHdvcmtQcm9jZXNzL05l dHdvcmtDb25uZWN0aW9uVG9XZWJQcm9jZXNzLmgKKysrIGIvU291cmNlL1dlYktpdDIvTmV0d29y a1Byb2Nlc3MvTmV0d29ya0Nvbm5lY3Rpb25Ub1dlYlByb2Nlc3MuaApAQCAtODMsOCArODMsNiBA QCBwcml2YXRlOgogICAgIHZvaWQgcmVtb3ZlTG9hZElkZW50aWZpZXIoUmVzb3VyY2VMb2FkSWRl bnRpZmllcik7CiAgICAgdm9pZCBjcm9zc09yaWdpblJlZGlyZWN0UmVjZWl2ZWQoUmVzb3VyY2VM b2FkSWRlbnRpZmllciwgY29uc3QgV2ViQ29yZTo6S1VSTCYgcmVkaXJlY3RVUkwpOwogICAgIHZv aWQgc2VydmVQZW5kaW5nUmVxdWVzdHModWludDMyX3QgcmVzb3VyY2VMb2FkUHJpb3JpdHkpOwot ICAgIHZvaWQgc3VzcGVuZFBlbmRpbmdSZXF1ZXN0cygpOwotICAgIHZvaWQgcmVzdW1lUGVuZGlu Z1JlcXVlc3RzKCk7CiAgICAgdm9pZCBzZXRTZXJpYWxMb2FkaW5nRW5hYmxlZChib29sKTsKICAg ICB2b2lkIHN0YXJ0RG93bmxvYWQoYm9vbCBwcml2YXRlQnJvd3NpbmdFbmFibGVkLCB1aW50NjRf dCBkb3dubG9hZElELCBjb25zdCBXZWJDb3JlOjpSZXNvdXJjZVJlcXVlc3QmKTsKICAgICB2b2lk IGNvb2tpZXNGb3JET00oYm9vbCBwcml2YXRlQnJvd3NpbmdFbmFibGVkLCBjb25zdCBXZWJDb3Jl OjpLVVJMJiBmaXJzdFBhcnR5LCBjb25zdCBXZWJDb3JlOjpLVVJMJiwgU3RyaW5nJiByZXN1bHQp OwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvTmV0d29ya1Byb2Nlc3MvTmV0d29ya0Nvbm5l Y3Rpb25Ub1dlYlByb2Nlc3MubWVzc2FnZXMuaW4gYi9Tb3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJv Y2Vzcy9OZXR3b3JrQ29ubmVjdGlvblRvV2ViUHJvY2Vzcy5tZXNzYWdlcy5pbgppbmRleCBkNTlh ZThkLi5mNTc2YzllIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJvY2Vzcy9O ZXR3b3JrQ29ubmVjdGlvblRvV2ViUHJvY2Vzcy5tZXNzYWdlcy5pbgorKysgYi9Tb3VyY2UvV2Vi S2l0Mi9OZXR3b3JrUHJvY2Vzcy9OZXR3b3JrQ29ubmVjdGlvblRvV2ViUHJvY2Vzcy5tZXNzYWdl cy5pbgpAQCAtMzMsOSArMzMsNiBAQCBtZXNzYWdlcyAtPiBOZXR3b3JrQ29ubmVjdGlvblRvV2Vi UHJvY2VzcyB7CiAgICAgUmVtb3ZlTG9hZElkZW50aWZpZXIodWludDY0X3QgcmVzb3VyY2VMb2Fk SWRlbnRpZmllcikKICAgICAKICAgICBTZXJ2ZVBlbmRpbmdSZXF1ZXN0cyh1aW50MzJfdCByZXNv dXJjZUxvYWRQcmlvcml0eSkKLQotICAgIFN1c3BlbmRQZW5kaW5nUmVxdWVzdHMoKSAtPiAoKQot ICAgIFJlc3VtZVBlbmRpbmdSZXF1ZXN0cygpIC0+ICgpCiAgICAgCiAgICAgU2V0U2VyaWFsTG9h ZGluZ0VuYWJsZWQoYm9vbCBlbmFibGVkKSAtPiAoKQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi S2l0Mi9OZXR3b3JrUHJvY2Vzcy9OZXR3b3JrUmVzb3VyY2VMb2FkU2NoZWR1bGVyLmNwcCBiL1Nv dXJjZS9XZWJLaXQyL05ldHdvcmtQcm9jZXNzL05ldHdvcmtSZXNvdXJjZUxvYWRTY2hlZHVsZXIu Y3BwCmluZGV4IGZjYjk1Y2UuLjBiYmQ3Y2EgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL05l dHdvcmtQcm9jZXNzL05ldHdvcmtSZXNvdXJjZUxvYWRTY2hlZHVsZXIuY3BwCisrKyBiL1NvdXJj ZS9XZWJLaXQyL05ldHdvcmtQcm9jZXNzL05ldHdvcmtSZXNvdXJjZUxvYWRTY2hlZHVsZXIuY3Bw CkBAIC0yMDksMjIgKzIwOSw2IEBAIHZvaWQgTmV0d29ya1Jlc291cmNlTG9hZFNjaGVkdWxlcjo6 c2VydmVQZW5kaW5nUmVxdWVzdHNGb3JIb3N0KEhvc3RSZWNvcmQqIGhvc3QsCiAgICAgfQogfQog Ci12b2lkIE5ldHdvcmtSZXNvdXJjZUxvYWRTY2hlZHVsZXI6OnN1c3BlbmRQZW5kaW5nUmVxdWVz dHMoKQotewotICAgICsrbV9zdXNwZW5kUGVuZGluZ1JlcXVlc3RzQ291bnQ7Ci19Ci0KLXZvaWQg TmV0d29ya1Jlc291cmNlTG9hZFNjaGVkdWxlcjo6cmVzdW1lUGVuZGluZ1JlcXVlc3RzKCkKLXsK LSAgICBBU1NFUlQobV9zdXNwZW5kUGVuZGluZ1JlcXVlc3RzQ291bnQpOwotICAgIC0tbV9zdXNw ZW5kUGVuZGluZ1JlcXVlc3RzQ291bnQ7Ci0gICAgaWYgKG1fc3VzcGVuZFBlbmRpbmdSZXF1ZXN0 c0NvdW50KQotICAgICAgICByZXR1cm47Ci0KLSAgICBpZiAoIW1faG9zdHMuaXNFbXB0eSgpIHx8 IG1fbm9uSFRUUFByb3RvY29sSG9zdC0+aGFzUmVxdWVzdHMoKSkKLSAgICAgICAgc2NoZWR1bGVT ZXJ2ZVBlbmRpbmdSZXF1ZXN0cygpOwotfQotCiBzdGF0aWMgYm9vbCByZW1vdmVTY2hlZHVsZWRM b2FkSWRlbnRpZmllcnNDYWxsZWQgPSBmYWxzZTsKIAogdm9pZCBOZXR3b3JrUmVzb3VyY2VMb2Fk U2NoZWR1bGVyOjpyZW1vdmVTY2hlZHVsZWRMb2FkSWRlbnRpZmllcnModm9pZCogY29udGV4dCkK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL05ldHdvcmtQcm9jZXNzL05ldHdvcmtSZXNvdXJj ZUxvYWRTY2hlZHVsZXIuaCBiL1NvdXJjZS9XZWJLaXQyL05ldHdvcmtQcm9jZXNzL05ldHdvcmtS ZXNvdXJjZUxvYWRTY2hlZHVsZXIuaAppbmRleCA4NWExOWNkLi5iNjEwYzAxIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJvY2Vzcy9OZXR3b3JrUmVzb3VyY2VMb2FkU2NoZWR1 bGVyLmgKKysrIGIvU291cmNlL1dlYktpdDIvTmV0d29ya1Byb2Nlc3MvTmV0d29ya1Jlc291cmNl TG9hZFNjaGVkdWxlci5oCkBAIC02MSw4ICs2MSw2IEBAIHB1YmxpYzoKIAogICAgIHZvaWQgcmVj ZWl2ZWRSZWRpcmVjdChSZXNvdXJjZUxvYWRJZGVudGlmaWVyLCBjb25zdCBXZWJDb3JlOjpLVVJM JiByZWRpcmVjdFVSTCk7CiAgICAgdm9pZCBzZXJ2ZVBlbmRpbmdSZXF1ZXN0cyhXZWJDb3JlOjpS ZXNvdXJjZUxvYWRQcmlvcml0eSA9IFdlYkNvcmU6OlJlc291cmNlTG9hZFByaW9yaXR5VmVyeUxv dyk7Ci0gICAgdm9pZCBzdXNwZW5kUGVuZGluZ1JlcXVlc3RzKCk7Ci0gICAgdm9pZCByZXN1bWVQ ZW5kaW5nUmVxdWVzdHMoKTsKICAgICAKICAgICBOZXR3b3JrUmVzb3VyY2VMb2FkZXIqIG5ldHdv cmtSZXNvdXJjZUxvYWRlckZvcklkZW50aWZpZXIoUmVzb3VyY2VMb2FkSWRlbnRpZmllcik7CiAK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvTmV0d29yay9XZWJSZXNvdXJj ZUxvYWRTY2hlZHVsZXIuY3BwIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9OZXR3b3JrL1dl YlJlc291cmNlTG9hZFNjaGVkdWxlci5jcHAKaW5kZXggYWVkOWJjMi4uYzFkN2U0MiAxMDA2NDQK LS0tIGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9OZXR3b3JrL1dlYlJlc291cmNlTG9hZFNj aGVkdWxlci5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9OZXR3b3JrL1dlYlJl c291cmNlTG9hZFNjaGVkdWxlci5jcHAKQEAgLTE2Miw4ICsxNjIsOCBAQCB2b2lkIFdlYlJlc291 cmNlTG9hZFNjaGVkdWxlcjo6c2VydmVQZW5kaW5nUmVxdWVzdHMoUmVzb3VyY2VMb2FkUHJpb3Jp dHkgbWluaW11bQogewogICAgIExPRyhOZXR3b3JrU2NoZWR1bGluZywgIihXZWJQcm9jZXNzKSBX ZWJSZXNvdXJjZUxvYWRTY2hlZHVsZXI6OnNlcnZlUGVuZGluZ1JlcXVlc3RzIik7CiAgICAgCi0g ICAgLy8gSWYgdGhpcyBXZWJQcm9jZXNzIGhhcyBpdHMgb3duIHJlcXVlc3Qgc3VzcGVuc2lvbiBj b3VudCB0aGVuIHdlIGRvbid0IGV2ZW4KLSAgICAvLyBoYXZlIHRvIGJvdGhlciBtZXNzYWdpbmcg dGhlIE5ldHdvcmtQcm9jZXNzLgorICAgIC8vIElmIHRoaXMgV2ViUHJvY2VzcyBoYXMgYSByZXF1 ZXN0IHN1c3BlbnNpb24gY291bnQgdGhlbiB3ZSBzaG91bGRuJ3QgYm90aGVyCisgICAgLy8gbWVz c2FnaW5nIHRoZSBOZXR3b3JrUHJvY2Vzcy4KICAgICBpZiAobV9zdXNwZW5kUGVuZGluZ1JlcXVl c3RzQ291bnQpCiAgICAgICAgIHJldHVybjsKIApAQCAtMTcyLDE1ICsxNzIsMTEgQEAgdm9pZCBX ZWJSZXNvdXJjZUxvYWRTY2hlZHVsZXI6OnNlcnZlUGVuZGluZ1JlcXVlc3RzKFJlc291cmNlTG9h ZFByaW9yaXR5IG1pbmltdW0KIAogdm9pZCBXZWJSZXNvdXJjZUxvYWRTY2hlZHVsZXI6OnN1c3Bl bmRQZW5kaW5nUmVxdWVzdHMoKQogewotICAgIFdlYlByb2Nlc3M6OnNoYXJlZCgpLm5ldHdvcmtD b25uZWN0aW9uKCktPmNvbm5lY3Rpb24oKS0+c2VuZFN5bmMoTWVzc2FnZXM6Ok5ldHdvcmtDb25u ZWN0aW9uVG9XZWJQcm9jZXNzOjpTdXNwZW5kUGVuZGluZ1JlcXVlc3RzKCksIE1lc3NhZ2VzOjpO ZXR3b3JrQ29ubmVjdGlvblRvV2ViUHJvY2Vzczo6U3VzcGVuZFBlbmRpbmdSZXF1ZXN0czo6UmVw bHkoKSwgMCk7Ci0KICAgICArK21fc3VzcGVuZFBlbmRpbmdSZXF1ZXN0c0NvdW50OwogfQogCiB2 b2lkIFdlYlJlc291cmNlTG9hZFNjaGVkdWxlcjo6cmVzdW1lUGVuZGluZ1JlcXVlc3RzKCkKIHsK LSAgICBXZWJQcm9jZXNzOjpzaGFyZWQoKS5uZXR3b3JrQ29ubmVjdGlvbigpLT5jb25uZWN0aW9u KCktPnNlbmRTeW5jKE1lc3NhZ2VzOjpOZXR3b3JrQ29ubmVjdGlvblRvV2ViUHJvY2Vzczo6UmVz dW1lUGVuZGluZ1JlcXVlc3RzKCksIE1lc3NhZ2VzOjpOZXR3b3JrQ29ubmVjdGlvblRvV2ViUHJv Y2Vzczo6UmVzdW1lUGVuZGluZ1JlcXVlc3RzOjpSZXBseSgpLCAwKTsKLQogICAgIEFTU0VSVCht X3N1c3BlbmRQZW5kaW5nUmVxdWVzdHNDb3VudCk7CiAgICAgLS1tX3N1c3BlbmRQZW5kaW5nUmVx dWVzdHNDb3VudDsKIH0K