105549 2012-12-20 10:12:08 -0800 CodeGen: Make [Reflect] use getIdAttribute and getNameAttribute 2012-12-20 14:00:41 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 arv arv abarth haraken japhet kling webkit.review.bot oldest_to_newest 795534 0 arv 2012-12-20 10:12:08 -0800 CodeGen: Make [Reflect] use getIdAttribute and getNameAttribute 795539 1 180360 arv 2012-12-20 10:19:04 -0800 Created attachment 180360 Patch 795541 2 arv 2012-12-20 10:22:41 -0800 Master Branch Bindings/id-getter runs/s 486.83 ± 9.88% 510.55 ± 3.42% Bindings/undefined-id-getter runs/s 913.57 ± 2.63% 939.54 ± 2.03% 2.84% Better Dromaeo/dom-attr runs/s 135.81 ± 1.47% 143.38 ± 1.46% 5.57% Better 795735 3 180360 kling 2012-12-20 13:28:50 -0800 Comment on attachment 180360 Patch Sweet! 795773 4 180360 webkit.review.bot 2012-12-20 14:00:37 -0800 Comment on attachment 180360 Patch Clearing flags on attachment: 180360 Committed r138297: <http://trac.webkit.org/changeset/138297> 795774 5 webkit.review.bot 2012-12-20 14:00:41 -0800 All reviewed patches have been landed. Closing bug. 180360 2012-12-20 10:19:04 -0800 2012-12-20 14:00:37 -0800 Patch bug-105549-20121220131620.patch text/plain 2267 arv U3VidmVyc2lvbiBSZXZpc2lvbjogMTM4MjYzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMGNkNTIxZWRjN2Y4ZTNm NDBhZGYxNTA3NmY5NDFkMGI4MTliZjM5Ni4uNjFhYjA2ODAwMTM4OWQ2NTkwMDIzNTJkNTU1Mjcz MTQzYTI1M2UwMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIzIEBACiAyMDEyLTEyLTIwICBFcmlr IEFydmlkc3NvbiAgPGFydkBjaHJvbWl1bS5vcmc+CiAKKyAgICAgICAgQ29kZUdlbjogTWFrZSBb UmVmbGVjdF0gdXNlIGdldElkQXR0cmlidXRlIGFuZCBnZXROYW1lQXR0cmlidXRlCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDU1NDkKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBMZXQgdGhlIGNvZGVnZW4g dXNlIGdldElkQXR0cmlidXRlIGFuZCBnZXROYW1lQXR0cmlidXRlIHdoZW4gd2Uga25vdyB0aGUg YXR0cmlidXRlCisgICAgICAgIGlzIEhUTUxOYW1lczo6aWRBdHRyIG9yIEhUTUxOYW1lczo6bmFt ZUF0dHIgcmVzcGVjdGl2ZWx5LiBUaGUgbW9yZSBzcGVjaWFsaXplZCBmdW5jdGlvbnMKKyAgICAg ICAgZG8gbm90IHNlYXJjaCBmb3IgdGhlIGF0dHJpYnV0ZSBpZiBpdCBrbm93cyB0aGF0IHRoZSBl bGVtZW50IGRvZXMgbm90IGhhdmUgdGhhdCBhdHRyaWJ1dGUKKyAgICAgICAgc3BlZWRpbmcgdXAg dGhlIGNhc2Ugd2hlcmUgaWQgb3IgbmFtZSBhcmUgbm90IHByZXNlbnQuCisKKyAgICAgICAgVGhp cyBpbXByb3ZlcyBEcm9tYWVvL2RvbS1hdHRyIGJ5IDUlIGFuZCBCaW5kaW5ncy91bmRlZmluZWQt aWQtZ2V0dGVyIGJ5IDIlIAorCisgICAgICAgIE5vIG5ldyB0ZXN0cy4gTm8gY2hhbmdlIGluIGJl aGF2aW9yCisKKyAgICAgICAgKiBiaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3IucG06CisK KzIwMTItMTItMjAgIEVyaWsgQXJ2aWRzc29uICA8YXJ2QGNocm9taXVtLm9yZz4KKwogICAgICAg ICBDb2RlR2VuOiBNYWtlIFtSZWZsZWN0XSB1c2UgZmFzdEdldEF0dHJpYnV0ZSBhbmQgZmFzdEhh c0F0dHJpYnV0ZQogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTA1NTQwCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMv Q29kZUdlbmVyYXRvci5wbSBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdl bmVyYXRvci5wbQppbmRleCA2OGIzMTE1MGY1ODFhZGM0YThkMGZjNTVkNzRmZWRiNmIzYjgzMWVh Li44NjczM2U3M2RlZTE0MTQ1NDNkNDZlNjJmMjUzM2IzZDQwYjc3YmI0IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3IucG0KKysrIGIvU291 cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yLnBtCkBAIC01OTksNyAr NTk5LDEzIEBAIHN1YiBHZXR0ZXJFeHByZXNzaW9uCiAgICAgfSBlbHNpZiAoJGF0dHJpYnV0ZS0+ c2lnbmF0dXJlLT50eXBlIGVxICJ1bnNpZ25lZCBsb25nIikgewogICAgICAgICAkZnVuY3Rpb25O YW1lID0gImdldFVuc2lnbmVkSW50ZWdyYWxBdHRyaWJ1dGUiOwogICAgIH0gZWxzZSB7Ci0gICAg ICAgIGlmICgkZ2VuZXJhdG9yLT5DYW5Vc2VGYXN0QXR0cmlidXRlKCRhdHRyaWJ1dGUpKSB7Cisg ICAgICAgIGlmICgkY29udGVudEF0dHJpYnV0ZU5hbWUgZXEgIldlYkNvcmU6OkhUTUxOYW1lczo6 aWRBdHRyIikgeworICAgICAgICAgICAgJGZ1bmN0aW9uTmFtZSA9ICJnZXRJZEF0dHJpYnV0ZSI7 CisgICAgICAgICAgICAkY29udGVudEF0dHJpYnV0ZU5hbWUgPSAiIjsKKyAgICAgICAgfSBlbHNp ZiAoJGNvbnRlbnRBdHRyaWJ1dGVOYW1lIGVxICJXZWJDb3JlOjpIVE1MTmFtZXM6Om5hbWVBdHRy IikgeworICAgICAgICAgICAgJGZ1bmN0aW9uTmFtZSA9ICJnZXROYW1lQXR0cmlidXRlIjsKKyAg ICAgICAgICAgICRjb250ZW50QXR0cmlidXRlTmFtZSA9ICIiOworICAgICAgICB9IGVsc2lmICgk Z2VuZXJhdG9yLT5DYW5Vc2VGYXN0QXR0cmlidXRlKCRhdHRyaWJ1dGUpKSB7CiAgICAgICAgICAg ICAkZnVuY3Rpb25OYW1lID0gImZhc3RHZXRBdHRyaWJ1dGUiOwogICAgICAgICB9IGVsc2Ugewog ICAgICAgICAgICAgJGZ1bmN0aW9uTmFtZSA9ICJnZXRBdHRyaWJ1dGUiOwo=