105545 2012-12-20 09:35:15 -0800 RenderBlock and RenderBox hit testing should ignore PseudoElements 2012-12-20 16:16:33 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mihnea esprehn eric esprehn jchaffraix koivisto ojan.autocc webkit.review.bot oldest_to_newest 795496 0 mihnea 2012-12-20 09:35:15 -0800 The assertion was added in http://trac.webkit.org/changeset/137336 for WebKitBug https://bugs.webkit.org/show_bug.cgi?id=104462 Load the following HTML snippet in a debug version of WebKit on Mac: <!doctype html> <html> <head> <style> #div1:before { display: inline-block; content: "BBB"; border: 1px solid red; } #div1 { border: 1px solid green; } </style> </head> <body> <div id="div1">AAAA</div> </body> </html> Click inside the red border of the :before element and you get: ASSERTION FAILED: !m_anchorNode || !m_anchorNode->isPseudoElement() /Users/mihnea/WebKit/Source/WebCore/dom/Position.cpp(90) : WebCore::Position::Position(PassRefPtr<WebCore::Node>, WebCore::Position::LegacyEditingOffset) 1 0x10686cdc9 WebCore::Position::Position(WTF::PassRefPtr<WebCore::Node>, WebCore::Position::LegacyEditingOffset) 2 0x10686cc8b WebCore::Position::Position(WTF::PassRefPtr<WebCore::Node>, WebCore::Position::LegacyEditingOffset) 3 0x105616a9e WebCore::createLegacyEditingPosition(WTF::PassRefPtr<WebCore::Node>, int) 4 0x1068c275d WebCore::RenderBlock::positionForBox(WebCore::InlineBox*, bool) const 5 0x1068c2f38 WebCore::RenderBlock::positionForPointWithInlineChildren(WebCore::LayoutPoint const&) 6 0x1068c36b5 WebCore::RenderBlock::positionForPoint(WebCore::LayoutPoint const&) 7 0x1068c32af WebCore::positionForPointRespectingEditingBoundaries(WebCore::RenderBlock*, WebCore::RenderBox*, WebCore::LayoutPoint const&) 8 0x1068c302e WebCore::RenderBlock::positionForPointWithInlineChildren(WebCore::LayoutPoint const&) 9 0x1068c36b5 WebCore::RenderBlock::positionForPoint(WebCore::LayoutPoint const&) 10 0x105c71f9c WebCore::EventHandler::handleMousePressEventSingleClick(WebCore::MouseEventWithHitTestResults const&) 11 0x105c7290b WebCore::EventHandler::handleMousePressEvent(WebCore::MouseEventWithHitTestResults const&) 12 0x105c773c5 WebCore::EventHandler::handleMousePressEvent(WebCore::PlatformMouseEvent const&) 13 0x103525e30 WebKit::handleMouseEvent(WebKit::WebMouseEvent const&, WebKit::WebPage*, bool) 14 0x103525cf5 WebKit::WebPage::mouseEvent(WebKit::WebMouseEvent const&) 15 0x103566a97 void CoreIPC::callMemberFunction<WebKit::WebPage, void (WebKit::WebPage::*)(WebKit::WebMouseEvent const&), WebKit::WebMouseEvent>(CoreIPC::Arguments1<WebKit::WebMouseEvent> const&, WebKit::WebPage*, void (WebKit::WebPage::*)(WebKit::WebMouseEvent const&)) 16 0x103559e65 void CoreIPC::handleMessage<Messages::WebPage::MouseEvent, WebKit::WebPage, void (WebKit::WebPage::*)(WebKit::WebMouseEvent const&)>(CoreIPC::MessageDecoder&, WebKit::WebPage*, void (WebKit::WebPage::*)(WebKit::WebMouseEvent const&)) 17 0x103554a62 WebKit::WebPage::didReceiveWebPageMessage(CoreIPC::Connection*, CoreIPC::MessageID, CoreIPC::MessageDecoder&) 18 0x103529abd WebKit::WebPage::didReceiveMessage(CoreIPC::Connection*, CoreIPC::MessageID, CoreIPC::MessageDecoder&) 19 0x103529b0d non-virtual thunk to WebKit::WebPage::didReceiveMessage(CoreIPC::Connection*, CoreIPC::MessageID, CoreIPC::MessageDecoder&) 20 0x10369ab8a CoreIPC::MessageReceiverMap::dispatchMessage(CoreIPC::Connection*, CoreIPC::MessageID, CoreIPC::MessageDecoder&) 21 0x1035ff179 WebKit::WebProcess::didReceiveMessage(CoreIPC::Connection*, CoreIPC::MessageID, CoreIPC::MessageDecoder&) 22 0x1032fbc48 CoreIPC::Connection::dispatchMessage(CoreIPC::MessageID, CoreIPC::MessageDecoder&) 23 0x1032f910e CoreIPC::Connection::dispatchMessage(CoreIPC::Connection::Message<CoreIPC::MessageDecoder>&) 24 0x1032fbbeb CoreIPC::Connection::dispatchOneMessage() 25 0x103303482 WTF::FunctionWrapper<void (CoreIPC::Connection::*)()>::operator()(CoreIPC::Connection*) 26 0x103303405 WTF::BoundFunctionImpl<WTF::FunctionWrapper<void (CoreIPC::Connection::*)()>, void (CoreIPC::Connection*)>::operator()() 27 0x106bc9529 WTF::Function<void ()>::operator()() const 28 0x106bc916f WebCore::RunLoop::performWork() 29 0x106bca67e WebCore::RunLoop::performWork(void*) 30 0x7fff886a0101 __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ 31 0x7fff8869fa25 __CFRunLoopDoSources0 795803 1 180411 esprehn 2012-12-20 14:28:14 -0800 Created attachment 180411 Patch 795807 2 eric 2012-12-20 14:31:55 -0800 I'm curious what our behavior was prior to your grand patch? 795823 3 esprehn 2012-12-20 14:44:52 -0800 (In reply to comment #2) > I'm curious what our behavior was prior to your grand patch? Good question! With the old generated content impl node() would return null for generated content nodes since they were anonymous. I've replicated that behavior with nonPseudoNode() which also returns null when the renderer is for a pseudo element. This patch switches to use nonPseudoNode() bringing back the old behavior from before my patch where editing thinks pseudo element renderers have no associated node. I specifically added the assert to catch places where I may have missed us assuming generated content was anonymous... which Mihnea has exposed one of. 795825 4 esprehn 2012-12-20 14:45:52 -0800 (In reply to comment #3) > (In reply to comment #2) > > I'm curious what our behavior was prior to your grand patch? > > Good question! With the old generated content impl node() would return null for generated content nodes _generated content renderers_, they didn't have their own node before. 795839 5 180411 eric 2012-12-20 14:59:50 -0800 Comment on attachment 180411 Patch In some of these we're just using nonPseudoNode as a bool instead of a pointer. Is there a nicer function for htat? 795853 6 esprehn 2012-12-20 15:11:10 -0800 (In reply to comment #5) > (From update of attachment 180411 [details]) > In some of these we're just using nonPseudoNode as a bool instead of a pointer. Is there a nicer function for htat? Hmm, not that exists yet. You're asking the question: "Is this renderer not anonymous AND also not a pseudo element" which editing code just did if (renderer->node()) before. We could have isAnonymousOrPseudoElement() { return isAnonymous() || isPseudoElement(); } if you think that's more clear. It seemed less error prone to make all editing code use nonPseudoNode() and not worry about having isAnonymousOrPseudoElement() checks all over. I suppose we could rename nonPseudoNode to nodeForEditing() too. 795909 7 180411 eric 2012-12-20 16:09:07 -0800 Comment on attachment 180411 Patch This seems OK. It's a bit unclear to me when to use nonPseudoNode and when to use node() however. 795914 8 esprehn 2012-12-20 16:12:04 -0800 (In reply to comment #7) > (From update of attachment 180411 [details]) > This seems OK. It's a bit unclear to me when to use nonPseudoNode and when to use node() however. Hmm yeah. I'll rename it nodeForEditing() or something in a different patch to make it's uses more clear. 795923 9 180411 webkit.review.bot 2012-12-20 16:16:29 -0800 Comment on attachment 180411 Patch Clearing flags on attachment: 180411 Committed r138317: <http://trac.webkit.org/changeset/138317> 795924 10 webkit.review.bot 2012-12-20 16:16:33 -0800 All reviewed patches have been landed. Closing bug. 180411 2012-12-20 14:28:14 -0800 2012-12-20 16:16:29 -0800 Patch bug-105545-20121220142530.patch text/plain 8489 esprehn U3VidmVyc2lvbiBSZXZpc2lvbjogMTM4Mjg2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNmRkYTdiMjY1OWI1ZTEy OTI0YmEzZTM2MzE1MmRiYzMzMTdjN2VlMy4uOGJjZjQ3MmMwZTdiMTExODFkZDdhODYwZjRjNGJj NTg0MGNkMjQ2OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDEyLTEyLTIwICBFbGxp b3R0IFNwcmVobiAgPGVzcHJlaG5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJlbmRlckJsb2Nr IGhpdCB0ZXN0aW5nIHNob3VsZCBpZ25vcmUgUHNldWRvRWxlbWVudHMKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNTU0NQorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFVzZSBub25Qc2V1ZG9Ob2RlKCkgaW4g aGl0IHRlc3RpbmcgY29kZSBpbiBSZW5kZXJCbG9jayBhbmQgUmVuZGVyQm94IHNvCisgICAgICAg IHRoYXQgd2hlbiBjbGlja2luZyBvbiB0aGUgYm94IGdlbmVyYXRlZCBieSBhIHBzZXVkbyBlbGVt ZW50IHdlIG5ldmVyCisgICAgICAgIGdlbmVyYXRlIGEgUG9zaXRpb24gZm9yIHRoZSBQc2V1ZG9F bGVtZW50LCBidXQgaW5zdGVhZCBmb3IgdGhlCisgICAgICAgIGdlbmVyYXRpbmcgbm9kZS4KKwor ICAgICAgICBUZXN0OiBmYXN0L2Nzcy1nZW5lcmF0ZWQtY29udGVudC9ibG9jay1hbmQtYm94LWhp dC10ZXN0aW5nLmh0bWwKKworICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJCbG9jay5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpSZW5kZXJCbG9jazo6cG9zaXRpb25Gb3JCb3gpOgorICAgICAgICAo V2ViQ29yZTo6aXNFZGl0aW5nQm91bmRhcnkpOgorICAgICAgICAoV2ViQ29yZTo6cG9zaXRpb25G b3JQb2ludFJlc3BlY3RpbmdFZGl0aW5nQm91bmRhcmllcyk6CisgICAgICAgICogcmVuZGVyaW5n L1JlbmRlckJveC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJCb3g6OnBvc2l0aW9uRm9y UG9pbnQpOgorCiAyMDEyLTEyLTIwICBOYXRlIENoYXBpbiAgPGphcGhldEBjaHJvbWl1bS5vcmc+ CiAKICAgICAgICAgUmVuYW1lIHNob3VsZEJ1ZmZlckRhdGEgdG8gZGF0YUJ1ZmZlcmluZ1BvbGlj eQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrLmNwcCBi L1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9jay5jcHAKaW5kZXggOGM0NTBmODBi MDRlNGQzNWYxNTJhYTViODhjMzQ4YjMzMjIxNTEyNy4uOGU3NWI0MTk1YjQzNjFhMDkwMDBlYzk5 OWYzYjFkNWZhNmFjNzc1YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1Jl bmRlckJsb2NrLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2su Y3BwCkBAIC00OTM1LDIyICs0OTM1LDIyIEBAIFBvc2l0aW9uIFJlbmRlckJsb2NrOjpwb3NpdGlv bkZvckJveChJbmxpbmVCb3ggKmJveCwgYm9vbCBzdGFydCkgY29uc3QKICAgICBpZiAoIWJveCkK ICAgICAgICAgcmV0dXJuIFBvc2l0aW9uKCk7CiAKLSAgICBpZiAoIWJveC0+cmVuZGVyZXIoKS0+ bm9kZSgpKQotICAgICAgICByZXR1cm4gY3JlYXRlTGVnYWN5RWRpdGluZ1Bvc2l0aW9uKG5vZGUo KSwgc3RhcnQgPyBjYXJldE1pbk9mZnNldCgpIDogY2FyZXRNYXhPZmZzZXQoKSk7CisgICAgaWYg KCFib3gtPnJlbmRlcmVyKCktPm5vblBzZXVkb05vZGUoKSkKKyAgICAgICAgcmV0dXJuIGNyZWF0 ZUxlZ2FjeUVkaXRpbmdQb3NpdGlvbihub25Qc2V1ZG9Ob2RlKCksIHN0YXJ0ID8gY2FyZXRNaW5P ZmZzZXQoKSA6IGNhcmV0TWF4T2Zmc2V0KCkpOwogCiAgICAgaWYgKCFib3gtPmlzSW5saW5lVGV4 dEJveCgpKQotICAgICAgICByZXR1cm4gY3JlYXRlTGVnYWN5RWRpdGluZ1Bvc2l0aW9uKGJveC0+ cmVuZGVyZXIoKS0+bm9kZSgpLCBzdGFydCA/IGJveC0+cmVuZGVyZXIoKS0+Y2FyZXRNaW5PZmZz ZXQoKSA6IGJveC0+cmVuZGVyZXIoKS0+Y2FyZXRNYXhPZmZzZXQoKSk7CisgICAgICAgIHJldHVy biBjcmVhdGVMZWdhY3lFZGl0aW5nUG9zaXRpb24oYm94LT5yZW5kZXJlcigpLT5ub25Qc2V1ZG9O b2RlKCksIHN0YXJ0ID8gYm94LT5yZW5kZXJlcigpLT5jYXJldE1pbk9mZnNldCgpIDogYm94LT5y ZW5kZXJlcigpLT5jYXJldE1heE9mZnNldCgpKTsKIAogICAgIElubGluZVRleHRCb3gqIHRleHRC b3ggPSB0b0lubGluZVRleHRCb3goYm94KTsKLSAgICByZXR1cm4gY3JlYXRlTGVnYWN5RWRpdGlu Z1Bvc2l0aW9uKGJveC0+cmVuZGVyZXIoKS0+bm9kZSgpLCBzdGFydCA/IHRleHRCb3gtPnN0YXJ0 KCkgOiB0ZXh0Qm94LT5zdGFydCgpICsgdGV4dEJveC0+bGVuKCkpOworICAgIHJldHVybiBjcmVh dGVMZWdhY3lFZGl0aW5nUG9zaXRpb24oYm94LT5yZW5kZXJlcigpLT5ub25Qc2V1ZG9Ob2RlKCks IHN0YXJ0ID8gdGV4dEJveC0+c3RhcnQoKSA6IHRleHRCb3gtPnN0YXJ0KCkgKyB0ZXh0Qm94LT5s ZW4oKSk7CiB9CiAKIHN0YXRpYyBpbmxpbmUgYm9vbCBpc0VkaXRpbmdCb3VuZGFyeShSZW5kZXJP YmplY3QqIGFuY2VzdG9yLCBSZW5kZXJPYmplY3QqIGNoaWxkKQogewotICAgIEFTU0VSVCghYW5j ZXN0b3IgfHwgYW5jZXN0b3ItPm5vZGUoKSk7Ci0gICAgQVNTRVJUKGNoaWxkICYmIGNoaWxkLT5u b2RlKCkpOworICAgIEFTU0VSVCghYW5jZXN0b3IgfHwgYW5jZXN0b3ItPm5vblBzZXVkb05vZGUo KSk7CisgICAgQVNTRVJUKGNoaWxkICYmIGNoaWxkLT5ub25Qc2V1ZG9Ob2RlKCkpOwogICAgIHJl dHVybiAhYW5jZXN0b3IgfHwgIWFuY2VzdG9yLT5wYXJlbnQoKSB8fCAoYW5jZXN0b3ItPmhhc0xh eWVyKCkgJiYgYW5jZXN0b3ItPnBhcmVudCgpLT5pc1JlbmRlclZpZXcoKSkKLSAgICAgICAgfHwg YW5jZXN0b3ItPm5vZGUoKS0+cmVuZGVyZXJJc0VkaXRhYmxlKCkgPT0gY2hpbGQtPm5vZGUoKS0+ cmVuZGVyZXJJc0VkaXRhYmxlKCk7CisgICAgICAgIHx8IGFuY2VzdG9yLT5ub25Qc2V1ZG9Ob2Rl KCktPnJlbmRlcmVySXNFZGl0YWJsZSgpID09IGNoaWxkLT5ub25Qc2V1ZG9Ob2RlKCktPnJlbmRl cmVySXNFZGl0YWJsZSgpOwogfQogCiAvLyBGSVhNRTogVGhpcyBmdW5jdGlvbiBzaG91bGQgZ28g b24gUmVuZGVyT2JqZWN0IGFzIGFuIGluc3RhbmNlIG1ldGhvZC4gVGhlbgpAQCAtNDk2NiwxNCAr NDk2NiwxNCBAQCBzdGF0aWMgVmlzaWJsZVBvc2l0aW9uIHBvc2l0aW9uRm9yUG9pbnRSZXNwZWN0 aW5nRWRpdGluZ0JvdW5kYXJpZXMoUmVuZGVyQmxvY2sqCiAgICAgTGF5b3V0UG9pbnQgcG9pbnRJ bkNoaWxkQ29vcmRpbmF0ZXModG9MYXlvdXRQb2ludChwb2ludEluUGFyZW50Q29vcmRpbmF0ZXMg LSBjaGlsZExvY2F0aW9uKSk7CiAKICAgICAvLyBJZiB0aGlzIGlzIGFuIGFub255bW91cyByZW5k ZXJlciwgd2UganVzdCByZWN1ciBub3JtYWxseQotICAgIE5vZGUqIGNoaWxkTm9kZSA9IGNoaWxk LT5ub2RlKCk7CisgICAgTm9kZSogY2hpbGROb2RlID0gY2hpbGQtPm5vblBzZXVkb05vZGUoKTsK ICAgICBpZiAoIWNoaWxkTm9kZSkKICAgICAgICAgcmV0dXJuIGNoaWxkLT5wb3NpdGlvbkZvclBv aW50KHBvaW50SW5DaGlsZENvb3JkaW5hdGVzKTsKIAogICAgIC8vIE90aGVyd2lzZSwgZmlyc3Qg bWFrZSBzdXJlIHRoYXQgdGhlIGVkaXRhYmlsaXR5IG9mIHRoZSBwYXJlbnQgYW5kIGNoaWxkIGFn cmVlLgogICAgIC8vIElmIHRoZXkgZG9uJ3QgYWdyZWUsIHRoZW4gd2UgcmV0dXJuIGEgdmlzaWJs ZSBwb3NpdGlvbiBqdXN0IGJlZm9yZSBvciBhZnRlciB0aGUgY2hpbGQKICAgICBSZW5kZXJPYmpl Y3QqIGFuY2VzdG9yID0gcGFyZW50OwotICAgIHdoaWxlIChhbmNlc3RvciAmJiAhYW5jZXN0b3It Pm5vZGUoKSkKKyAgICB3aGlsZSAoYW5jZXN0b3IgJiYgIWFuY2VzdG9yLT5ub25Qc2V1ZG9Ob2Rl KCkpCiAgICAgICAgIGFuY2VzdG9yID0gYW5jZXN0b3ItPnBhcmVudCgpOwogCiAgICAgLy8gSWYg d2UgY2FuJ3QgZmluZCBhbiBhbmNlc3RvciB0byBjaGVjayBlZGl0YWJpbGl0eSBvbiwgb3IgZWRp dGFiaWxpdHkgaXMgdW5jaGFuZ2VkLCB3ZSByZWN1ciBsaWtlIG5vcm1hbApkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJveC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9y ZW5kZXJpbmcvUmVuZGVyQm94LmNwcAppbmRleCA1ZTBmMGY3OWZlNGU1OTIwZDBkNzFkODk3NjM5 ZGJiNjEzOTA1MzZkLi45MmJjNTNiOGMyNTBiZTkxZDg3ZmVhNWIzZmM5NjkzYmE2N2NkYjBiIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQm94LmNwcAorKysgYi9T b3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQm94LmNwcApAQCAtMzcxNSwxNiArMzcxNSwx NiBAQCBWaXNpYmxlUG9zaXRpb24gUmVuZGVyQm94Ojpwb3NpdGlvbkZvclBvaW50KGNvbnN0IExh eW91dFBvaW50JiBwb2ludCkKIHsKICAgICAvLyBubyBjaGlsZHJlbi4uLnJldHVybiB0aGlzIHJl bmRlciBvYmplY3QncyBlbGVtZW50LCBpZiB0aGVyZSBpcyBvbmUsIGFuZCBvZmZzZXQgMAogICAg IGlmICghZmlyc3RDaGlsZCgpKQotICAgICAgICByZXR1cm4gY3JlYXRlVmlzaWJsZVBvc2l0aW9u KG5vZGUoKSA/IGZpcnN0UG9zaXRpb25Jbk9yQmVmb3JlTm9kZShub2RlKCkpIDogUG9zaXRpb24o KSk7CisgICAgICAgIHJldHVybiBjcmVhdGVWaXNpYmxlUG9zaXRpb24obm9uUHNldWRvTm9kZSgp ID8gZmlyc3RQb3NpdGlvbkluT3JCZWZvcmVOb2RlKG5vblBzZXVkb05vZGUoKSkgOiBQb3NpdGlv bigpKTsKIAotICAgIGlmIChpc1RhYmxlKCkgJiYgbm9kZSgpKSB7CisgICAgaWYgKGlzVGFibGUo KSAmJiBub25Qc2V1ZG9Ob2RlKCkpIHsKICAgICAgICAgTGF5b3V0VW5pdCByaWdodCA9IGNvbnRl bnRXaWR0aCgpICsgYm9yZGVyQW5kUGFkZGluZ1dpZHRoKCk7CiAgICAgICAgIExheW91dFVuaXQg Ym90dG9tID0gY29udGVudEhlaWdodCgpICsgYm9yZGVyQW5kUGFkZGluZ0hlaWdodCgpOwogICAg ICAgICAKICAgICAgICAgaWYgKHBvaW50LngoKSA8IDAgfHwgcG9pbnQueCgpID4gcmlnaHQgfHwg cG9pbnQueSgpIDwgMCB8fCBwb2ludC55KCkgPiBib3R0b20pIHsKICAgICAgICAgICAgIGlmIChw b2ludC54KCkgPD0gcmlnaHQgLyAyKQotICAgICAgICAgICAgICAgIHJldHVybiBjcmVhdGVWaXNp YmxlUG9zaXRpb24oZmlyc3RQb3NpdGlvbkluT3JCZWZvcmVOb2RlKG5vZGUoKSkpOwotICAgICAg ICAgICAgcmV0dXJuIGNyZWF0ZVZpc2libGVQb3NpdGlvbihsYXN0UG9zaXRpb25Jbk9yQWZ0ZXJO b2RlKG5vZGUoKSkpOworICAgICAgICAgICAgICAgIHJldHVybiBjcmVhdGVWaXNpYmxlUG9zaXRp b24oZmlyc3RQb3NpdGlvbkluT3JCZWZvcmVOb2RlKG5vblBzZXVkb05vZGUoKSkpOworICAgICAg ICAgICAgcmV0dXJuIGNyZWF0ZVZpc2libGVQb3NpdGlvbihsYXN0UG9zaXRpb25Jbk9yQWZ0ZXJO b2RlKG5vblBzZXVkb05vZGUoKSkpOwogICAgICAgICB9CiAgICAgfQogCkBAIC0zNzkyLDcgKzM3 OTIsNyBAQCBWaXNpYmxlUG9zaXRpb24gUmVuZGVyQm94Ojpwb3NpdGlvbkZvclBvaW50KGNvbnN0 IExheW91dFBvaW50JiBwb2ludCkKICAgICBpZiAoY2xvc2VzdFJlbmRlcmVyKQogICAgICAgICBy ZXR1cm4gY2xvc2VzdFJlbmRlcmVyLT5wb3NpdGlvbkZvclBvaW50KGFkanVzdGVkUG9pbnQgLSBj bG9zZXN0UmVuZGVyZXItPmxvY2F0aW9uT2Zmc2V0KCkpOwogICAgIAotICAgIHJldHVybiBjcmVh dGVWaXNpYmxlUG9zaXRpb24oZmlyc3RQb3NpdGlvbkluT3JCZWZvcmVOb2RlKG5vZGUoKSkpOwor ICAgIHJldHVybiBjcmVhdGVWaXNpYmxlUG9zaXRpb24oZmlyc3RQb3NpdGlvbkluT3JCZWZvcmVO b2RlKG5vblBzZXVkb05vZGUoKSkpOwogfQogCiBib29sIFJlbmRlckJveDo6c2hyaW5rVG9Bdm9p ZEZsb2F0cygpIGNvbnN0CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlv dXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggNjAzOTkzNDY3YTlkZTBjN2RlMTYyMzk3ZjY4MGZhNzk2 MDdiNTRkYS4uNzIyODZhOWZlZmFlMGY1Y2EyYmQ4NjY5NzJhYmU5ZWViYTYwZTRkZCAxMDA2NDQK LS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpA QCAtMSwzICsxLDE1IEBACisyMDEyLTEyLTIwICBFbGxpb3R0IFNwcmVobiAgPGVzcHJlaG5AY2hy b21pdW0ub3JnPgorCisgICAgICAgIFJlbmRlckJsb2NrIGhpdCB0ZXN0aW5nIHNob3VsZCBpZ25v cmUgUHNldWRvRWxlbWVudHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTEwNTU0NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIEFkZCB0ZXN0IGZvciBoaXQgdGVzdGluZyBvbiBwc2V1ZG8gZWxlbWVudCBnZW5l cmF0ZWQgYmxvY2tzIGFuZCBib3hlcy4KKworICAgICAgICAqIGZhc3QvY3NzLWdlbmVyYXRlZC1j b250ZW50L2Jsb2NrLWFuZC1ib3gtaGl0LXRlc3RpbmctZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAg ICAgICAgKiBmYXN0L2Nzcy1nZW5lcmF0ZWQtY29udGVudC9ibG9jay1hbmQtYm94LWhpdC10ZXN0 aW5nLmh0bWw6IEFkZGVkLgorCiAyMDEyLTEyLTIwICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJr aXQub3JnPgogCiAgICAgICAgIFVwZGF0ZSBNYWMgdGVzdCBleHBlY3RhdGlvbiBwZXIgYnVncyAx MDU1NjYgYW5kIDEwNTU2Ny4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvY3NzLWdlbmVy YXRlZC1jb250ZW50L2Jsb2NrLWFuZC1ib3gtaGl0LXRlc3RpbmctZXhwZWN0ZWQudHh0IGIvTGF5 b3V0VGVzdHMvZmFzdC9jc3MtZ2VuZXJhdGVkLWNvbnRlbnQvYmxvY2stYW5kLWJveC1oaXQtdGVz dGluZy1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uNmY0ZTkwNzhkNWMxZGY1YjE5Y2MzMTI2MzE4 NzFjOWQxODQzNjA2MwotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvY3NzLWdl bmVyYXRlZC1jb250ZW50L2Jsb2NrLWFuZC1ib3gtaGl0LXRlc3RpbmctZXhwZWN0ZWQudHh0CkBA IC0wLDAgKzEgQEAKK0J1ZyAxMDU1NDUgLSBSZW5kZXJCbG9jayBhbmQgUmVuZGVyQm94IGhpdCB0 ZXN0aW5nIHNob3VsZCBpZ25vcmUgUHNldWRvRWxlbWVudHMKZGlmZiAtLWdpdCBhL0xheW91dFRl c3RzL2Zhc3QvY3NzLWdlbmVyYXRlZC1jb250ZW50L2Jsb2NrLWFuZC1ib3gtaGl0LXRlc3Rpbmcu aHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvY3NzLWdlbmVyYXRlZC1jb250ZW50L2Jsb2NrLWFuZC1i b3gtaGl0LXRlc3RpbmcuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi43NmUxYjliNmEwMGIyMGVhNzlhZTAyZjlm YzkwNjc0MTBhMTNlNDI4Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9jc3Mt Z2VuZXJhdGVkLWNvbnRlbnQvYmxvY2stYW5kLWJveC1oaXQtdGVzdGluZy5odG1sCkBAIC0wLDAg KzEsNDAgQEAKKzwhRE9DVFlQRSBodG1sPgorCis8c3R5bGU+CisgICAgaHRtbCwgYm9keSB7Cisg ICAgICAgIG1hcmdpbjogMDsKKyAgICAgICAgcGFkZGluZzogMDsKKyAgICAgICAgZm9udC1zaXpl OiAxNHB4OworICAgIH0KKworICAgIGRpdjpiZWZvcmUgeworICAgICAgICBkaXNwbGF5OiBibG9j azsKKyAgICAgICAgY29udGVudDogIkNsaWNraW5nIHRoZSByZWQgYm9yZGVyIHNob3VsZCBub3Qg Y3Jhc2guIjsKKyAgICAgICAgYm9yZGVyOiA1cHggc29saWQgcmVkOworICAgIH0KKworICAgIGRp djphZnRlciB7CisgICAgICAgIGRpc3BsYXk6IHRhYmxlOworICAgICAgICBjb250ZW50OiAiQ2xp Y2tpbmcgdGhlIG1hcmdpbiBzaG91bGQgbm90IGNyYXNoLiI7CisgICAgICAgIG1hcmdpbjogMTBw eDsKKyAgICAgICAgYmFja2dyb3VuZDogeWVsbG93OworICAgIH0KKzwvc3R5bGU+CisKKzxkaXY+ PC9kaXY+CisKKzxwPkJ1ZyAxMDU1NDUgLSBSZW5kZXJCbG9jayBhbmQgUmVuZGVyQm94IGhpdCB0 ZXN0aW5nIHNob3VsZCBpZ25vcmUgUHNldWRvRWxlbWVudHM8L3A+CisKKzxzY3JpcHQ+CitpZiAo d2luZG93LnRlc3RSdW5uZXIpCisgICAgdGVzdFJ1bm5lci5kdW1wQXNUZXh0KCk7CisKK2lmICh3 aW5kb3cuZXZlbnRTZW5kZXIpIHsKKyAgICBldmVudFNlbmRlci5tb3VzZU1vdmVUbygwLCAwKTsK KyAgICBldmVudFNlbmRlci5tb3VzZURvd24oKTsKKyAgICBldmVudFNlbmRlci5tb3VzZVVwKCk7 CisgICAgZXZlbnRTZW5kZXIubW91c2VNb3ZlVG8oMCwgNDApOworICAgIGV2ZW50U2VuZGVyLm1v dXNlRG93bigpOworICAgIGV2ZW50U2VuZGVyLm1vdXNlVXAoKTsKK30KKzwvc2NyaXB0Pgo=