105533 2012-12-20 06:53:20 -0800 Font description not synchronized correctly on orientation affecting property changes 2012-12-20 14:14:53 -0800 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 koivisto webkit-unassigned allan.jensen cmarcelo enrica eoconnor macpherson menard mitz mjs ojan.autocc webkit.review.bot oldest_to_newest 795412 0 koivisto 2012-12-20 06:53:20 -0800 in StyleResolver checkForOrientationChange() function checks if the new computed orientation differs from the parent orientation and updates the style's font description only if it does. This is not correct as that does not guarantee the new font description is actually up to date. We can leave the function with the computed orientation and the font description out of sync. 795432 1 180341 koivisto 2012-12-20 07:36:12 -0800 Created attachment 180341 patch 795538 2 enrica 2012-12-20 10:17:12 -0800 What I don't understand about your fix is why you've removed the knowledge of the parent style entirely. Is it ok? Would it be better to do something like: if (childFontOrientation == parentFontOrientation && childGlyphOrientation == parentGlyphOrientation && style->fontDescription().orientation() == childFontOrientation) return; It is even a smaller change than yours. 795574 3 180371 enrica 2012-12-20 11:03:57 -0800 Created attachment 180371 Another patch I'm uploading another patch with a smaller fix. 795594 4 enrica 2012-12-20 11:26:49 -0800 I've discussed this with Dan and I'm convinced that Antti's approach is the right thing to do. 795781 5 180341 enrica 2012-12-20 14:08:47 -0800 Comment on attachment 180341 patch looks good to me. Thanks! 795793 6 koivisto 2012-12-20 14:14:53 -0800 http://trac.webkit.org/changeset/138299 180341 2012-12-20 07:36:12 -0800 2012-12-20 14:08:47 -0800 patch text-orientation-change-2.patch text/plain 3450 koivisto SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEzODI1MSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIzIEBACisyMDEyLTEyLTIwICBBbnR0aSBL b2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KKworICAgICAgICBGb250IGRlc2NyaXB0aW9uIG5v dCBzeW5jaHJvbml6ZWQgY29ycmVjdGx5IG9uIG9yaWVudGF0aW9uIGFmZmVjdGluZyBwcm9wZXJ0 eSBjaGFuZ2VzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xMDU1MzMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBJbiBTdHlsZVJlc29sdmVyIGNoZWNrRm9yT3JpZW50YXRpb25DaGFuZ2UoKSBmdW5jdGlvbiBj aGVja3MgaWYgdGhlIG5ldyBjb21wdXRlZCBvcmllbnRhdGlvbiBkaWZmZXJzIGZyb20gdGhlIHBh cmVudAorICAgICAgICBvcmllbnRhdGlvbiBhbmQgdXBkYXRlcyB0aGUgc3R5bGUncyBmb250IGRl c2NyaXB0aW9uIG9ubHkgaWYgaXQgZG9lcy4gVGhpcyBpcyBub3QgY29ycmVjdCBhcyBlcXVhbCB2 YWx1ZXMgZG8gbm90IGd1YXJhbnRlZQorICAgICAgICB0aGUgbmV3IGZvbnQgZGVzY3JpcHRpb24g aXMgYWN0dWFsbHkgdXAgdG8gZGF0ZS4gV2UgY2FuIGxlYXZlIHRoZSBmdW5jdGlvbiB3aXRoIHRo ZSBjb21wdXRlZCBvcmllbnRhdGlvbiBhbmQgdGhlIGZvbnQKKyAgICAgICAgZGVzY3JpcHRpb24g c3RpbGwgb3V0IG9mIHN5bmMuCisgICAgICAgIAorICAgICAgICBGaXggYnkgYmFpbGluZyBvdXQg ZmFzdCBvbmx5IGlmIHRoZSBmb250IGRlc2NyaXB0aW9uIGlzIGFscmVhZHkgaW4gc3luYy4KKyAg ICAgICAgCisgICAgICAgIE5vIGxheW91dCB0ZXN0IHlldCwgdmVyaWZpZWQgd2l0aCBhIHRlc3Qg YXBwLgorCisgICAgICAgICogY3NzL1N0eWxlUmVzb2x2ZXIuY3BwOgorICAgICAgICAoV2ViQ29y ZTo6Y2hlY2tGb3JPcmllbnRhdGlvbkNoYW5nZSk6CisgICAgICAgIChXZWJDb3JlOjpTdHlsZVJl c29sdmVyOjp1cGRhdGVGb250KToKKwogMjAxMi0xMi0yMCAgRmxvcmluIE1hbGl0YSAgPGZtYWxp dGFAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIEluY29ycmVjdCBjb2xvciBzcGFjZSBjb252ZXJz aW9uIGZvciBGRUltYWdlCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9jc3MvU3R5bGVSZXNvbHZlci5j cHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvY3NzL1N0eWxlUmVzb2x2ZXIuY3BwCShy ZXZpc2lvbiAxMzgyNDcpCisrKyBTb3VyY2UvV2ViQ29yZS9jc3MvU3R5bGVSZXNvbHZlci5jcHAJ KHdvcmtpbmcgY29weSkKQEAgLTIxNTEsMjMgKzIxNTEsMTkgQEAgYm9vbCBTdHlsZVJlc29sdmVy OjpjaGVja1JlZ2lvblN0eWxlKEVsZQogICAgIHJldHVybiBmYWxzZTsKIH0KIAotc3RhdGljIHZv aWQgY2hlY2tGb3JPcmllbnRhdGlvbkNoYW5nZShSZW5kZXJTdHlsZSogc3R5bGUsIGNvbnN0IFJl bmRlclN0eWxlKiBwYXJlbnRTdHlsZSkKK3N0YXRpYyB2b2lkIGNoZWNrRm9yT3JpZW50YXRpb25D aGFuZ2UoUmVuZGVyU3R5bGUqIHN0eWxlKQogewotICAgIEZvbnRPcmllbnRhdGlvbiBjaGlsZEZv bnRPcmllbnRhdGlvbjsKLSAgICBOb25DSktHbHlwaE9yaWVudGF0aW9uIGNoaWxkR2x5cGhPcmll bnRhdGlvbjsKLSAgICBnZXRGb250QW5kR2x5cGhPcmllbnRhdGlvbihzdHlsZSwgY2hpbGRGb250 T3JpZW50YXRpb24sIGNoaWxkR2x5cGhPcmllbnRhdGlvbik7CisgICAgRm9udE9yaWVudGF0aW9u IGZvbnRPcmllbnRhdGlvbjsKKyAgICBOb25DSktHbHlwaE9yaWVudGF0aW9uIGdseXBoT3JpZW50 YXRpb247CisgICAgZ2V0Rm9udEFuZEdseXBoT3JpZW50YXRpb24oc3R5bGUsIGZvbnRPcmllbnRh dGlvbiwgZ2x5cGhPcmllbnRhdGlvbik7CiAKLSAgICBGb250T3JpZW50YXRpb24gcGFyZW50Rm9u dE9yaWVudGF0aW9uOwotICAgIE5vbkNKS0dseXBoT3JpZW50YXRpb24gcGFyZW50R2x5cGhPcmll bnRhdGlvbjsKLSAgICBnZXRGb250QW5kR2x5cGhPcmllbnRhdGlvbihwYXJlbnRTdHlsZSwgcGFy ZW50Rm9udE9yaWVudGF0aW9uLCBwYXJlbnRHbHlwaE9yaWVudGF0aW9uKTsKLQotICAgIGlmIChj aGlsZEZvbnRPcmllbnRhdGlvbiA9PSBwYXJlbnRGb250T3JpZW50YXRpb24gJiYgY2hpbGRHbHlw aE9yaWVudGF0aW9uID09IHBhcmVudEdseXBoT3JpZW50YXRpb24pCisgICAgY29uc3QgRm9udERl c2NyaXB0aW9uJiBmb250RGVzY3JpcHRpb24gPSBzdHlsZS0+Zm9udERlc2NyaXB0aW9uKCk7Cisg ICAgaWYgKGZvbnREZXNjcmlwdGlvbi5vcmllbnRhdGlvbigpID09IGZvbnRPcmllbnRhdGlvbiAm JiBmb250RGVzY3JpcHRpb24ubm9uQ0pLR2x5cGhPcmllbnRhdGlvbigpID09IGdseXBoT3JpZW50 YXRpb24pCiAgICAgICAgIHJldHVybjsKIAotICAgIGNvbnN0IEZvbnREZXNjcmlwdGlvbiYgY2hp bGRGb250ID0gc3R5bGUtPmZvbnREZXNjcmlwdGlvbigpOwotICAgIEZvbnREZXNjcmlwdGlvbiBu ZXdGb250RGVzY3JpcHRpb24oY2hpbGRGb250KTsKLSAgICBuZXdGb250RGVzY3JpcHRpb24uc2V0 Tm9uQ0pLR2x5cGhPcmllbnRhdGlvbihjaGlsZEdseXBoT3JpZW50YXRpb24pOwotICAgIG5ld0Zv bnREZXNjcmlwdGlvbi5zZXRPcmllbnRhdGlvbihjaGlsZEZvbnRPcmllbnRhdGlvbik7CisgICAg Rm9udERlc2NyaXB0aW9uIG5ld0ZvbnREZXNjcmlwdGlvbihmb250RGVzY3JpcHRpb24pOworICAg IG5ld0ZvbnREZXNjcmlwdGlvbi5zZXROb25DSktHbHlwaE9yaWVudGF0aW9uKGdseXBoT3JpZW50 YXRpb24pOworICAgIG5ld0ZvbnREZXNjcmlwdGlvbi5zZXRPcmllbnRhdGlvbihmb250T3JpZW50 YXRpb24pOwogICAgIHN0eWxlLT5zZXRGb250RGVzY3JpcHRpb24obmV3Rm9udERlc2NyaXB0aW9u KTsKIH0KIApAQCAtMjE3OSw3ICsyMTc1LDcgQEAgdm9pZCBTdHlsZVJlc29sdmVyOjp1cGRhdGVG b250KCkKICAgICBjaGVja0ZvclRleHRTaXplQWRqdXN0KCk7CiAgICAgY2hlY2tGb3JHZW5lcmlj RmFtaWx5Q2hhbmdlKHN0eWxlKCksIG1fcGFyZW50U3R5bGUpOwogICAgIGNoZWNrRm9yWm9vbUNo YW5nZShzdHlsZSgpLCBtX3BhcmVudFN0eWxlKTsKLSAgICBjaGVja0Zvck9yaWVudGF0aW9uQ2hh bmdlKHN0eWxlKCksIG1fcGFyZW50U3R5bGUpOworICAgIGNoZWNrRm9yT3JpZW50YXRpb25DaGFu Z2Uoc3R5bGUoKSk7CiAgICAgbV9zdHlsZS0+Zm9udCgpLnVwZGF0ZShtX2ZvbnRTZWxlY3Rvcik7 CiAgICAgbV9mb250RGlydHkgPSBmYWxzZTsKIH0K 180371 2012-12-20 11:03:57 -0800 2012-12-20 11:03:57 -0800 Another patch bug12880077.txt text/plain 2256 enrica SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEzODI3NCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIyIEBACisyMDEyLTEyLTIwICBFbnJpY2Eg Q2FzdWNjaSAgPGVucmljYUBhcHBsZS5jb20+CisKKyAgICAgICAgRm9udCBkZXNjcmlwdGlvbiBu b3Qgc3luY2hyb25pemVkIGNvcnJlY3RseSBvbiBvcmllbnRhdGlvbiBhZmZlY3RpbmcgcHJvcGVy dHkgY2hhbmdlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTA1NTMzCisgICAgICAgIAorICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBJbiBTdHlsZVJlc29sdmVyIGNoZWNrRm9yT3JpZW50YXRpb25DaGFuZ2UoKSBm dW5jdGlvbiBjaGVja3MgaWYgdGhlIG5ldyBjb21wdXRlZCBvcmllbnRhdGlvbiBkaWZmZXJzIGZy b20gdGhlIHBhcmVudAorICAgICAgICBvcmllbnRhdGlvbiBhbmQgdXBkYXRlcyB0aGUgc3R5bGUn cyBmb250IGRlc2NyaXB0aW9uIG9ubHkgaWYgaXQgZG9lcy4gVGhpcyBpcyBub3QgY29ycmVjdCBh cyBlcXVhbCB2YWx1ZXMgZG8gbm90IGd1YXJhbnRlZQorICAgICAgICB0aGUgbmV3IGZvbnQgZGVz Y3JpcHRpb24gaXMgYWN0dWFsbHkgdXAgdG8gZGF0ZS4gV2UgY2FuIGxlYXZlIHRoZSBmdW5jdGlv biB3aXRoIHRoZSBjb21wdXRlZCBvcmllbnRhdGlvbiBhbmQgdGhlIGZvbnQKKyAgICAgICAgZGVz Y3JpcHRpb24gc3RpbGwgb3V0IG9mIHN5bmMuCisKKyAgICAgICAgRml4IGJ5IGJhaWxpbmcgb3V0 IGZhc3Qgb25seSBpZiB0aGUgZm9udCBkZXNjcmlwdGlvbiBpcyBhbHJlYWR5IGluIHN5bmMuCisK KyAgICAgICAgTm8gbmV3IHRlc3RzIChPT1BTISkuCisKKyAgICAgICAgKiBjc3MvU3R5bGVSZXNv bHZlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpjaGVja0Zvck9yaWVudGF0aW9uQ2hhbmdlKToK KwogMjAxMi0xMi0yMCAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+ CiAKICAgICAgICAgW0dUS10gQWRkIEFQSSB0byBzZXQgYSBUTFMgZXJyb3JzIHBvbGljeSB0byBX ZWJLaXQyIEdUSysgQVBJCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9jc3MvU3R5bGVSZXNvbHZlci5j cHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvY3NzL1N0eWxlUmVzb2x2ZXIuY3BwCShy ZXZpc2lvbiAxMzgxOTUpCisrKyBTb3VyY2UvV2ViQ29yZS9jc3MvU3R5bGVSZXNvbHZlci5jcHAJ KHdvcmtpbmcgY29weSkKQEAgLTIxNjEsMTAgKzIxNjEsMTAgQEAgc3RhdGljIHZvaWQgY2hlY2tG b3JPcmllbnRhdGlvbkNoYW5nZShSZQogICAgIE5vbkNKS0dseXBoT3JpZW50YXRpb24gcGFyZW50 R2x5cGhPcmllbnRhdGlvbjsKICAgICBnZXRGb250QW5kR2x5cGhPcmllbnRhdGlvbihwYXJlbnRT dHlsZSwgcGFyZW50Rm9udE9yaWVudGF0aW9uLCBwYXJlbnRHbHlwaE9yaWVudGF0aW9uKTsKIAot ICAgIGlmIChjaGlsZEZvbnRPcmllbnRhdGlvbiA9PSBwYXJlbnRGb250T3JpZW50YXRpb24gJiYg Y2hpbGRHbHlwaE9yaWVudGF0aW9uID09IHBhcmVudEdseXBoT3JpZW50YXRpb24pCisgICAgY29u c3QgRm9udERlc2NyaXB0aW9uJiBjaGlsZEZvbnQgPSBzdHlsZS0+Zm9udERlc2NyaXB0aW9uKCk7 CisgICAgaWYgKGNoaWxkRm9udE9yaWVudGF0aW9uID09IHBhcmVudEZvbnRPcmllbnRhdGlvbiAm JiBjaGlsZEdseXBoT3JpZW50YXRpb24gPT0gcGFyZW50R2x5cGhPcmllbnRhdGlvbiAmJiBjaGls ZEZvbnQub3JpZW50YXRpb24oKSA9PSBjaGlsZEZvbnRPcmllbnRhdGlvbikKICAgICAgICAgcmV0 dXJuOwogCi0gICAgY29uc3QgRm9udERlc2NyaXB0aW9uJiBjaGlsZEZvbnQgPSBzdHlsZS0+Zm9u dERlc2NyaXB0aW9uKCk7CiAgICAgRm9udERlc2NyaXB0aW9uIG5ld0ZvbnREZXNjcmlwdGlvbihj aGlsZEZvbnQpOwogICAgIG5ld0ZvbnREZXNjcmlwdGlvbi5zZXROb25DSktHbHlwaE9yaWVudGF0 aW9uKGNoaWxkR2x5cGhPcmllbnRhdGlvbik7CiAgICAgbmV3Rm9udERlc2NyaXB0aW9uLnNldE9y aWVudGF0aW9uKGNoaWxkRm9udE9yaWVudGF0aW9uKTsK