105522 2012-12-20 02:58:29 -0800 REGRESSION (r138184): transitions/transitions-parsing.html is failing on GTK 2013-01-04 06:16:49 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Gtk, LayoutTestFailure, Regression P2 Normal --- 1 zan zan dglazkov webkit.review.bot xan.lopez zan oldest_to_newest 795318 0 zan 2012-12-20 02:58:29 -0800 The transitions/transitions-parsing.html layout test is failing since r138184 landed. http://trac.webkit.org/changeset/138184 Diff too large, so just trust me! :> 797313 1 180748 zan 2012-12-26 08:11:18 -0800 Created attachment 180748 Patch 797321 2 180748 webkit.review.bot 2012-12-26 08:56:54 -0800 Comment on attachment 180748 Patch Attachment 180748 did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/15542218 New failing tests: inspector-protocol/debugger-terminate-dedicated-worker-while-paused.html 797548 3 zan 2012-12-27 07:07:46 -0800 (In reply to comment #2) > (From update of attachment 180748 [details]) > Attachment 180748 [details] did not pass chromium-ews (chromium-xvfb): > Output: http://queues.webkit.org/results/15542218 > > New failing tests: > inspector-protocol/debugger-terminate-dedicated-worker-while-paused.html Yeah ... no. 800092 4 xan.lopez 2013-01-04 01:55:32 -0800 Just a question, if the configure.ac/makefile bits have no effect how can removing them make a test pass? other than that I support getting rid of them. 800122 5 zan 2013-01-04 03:06:51 -0800 (In reply to comment #4) > Just a question, if the configure.ac/makefile bits have no effect how can removing them make a test pass? other than that I support getting rid of them. Here's the AC_ARG_ENABLE prototype: > — Macro: AC_ARG_ENABLE (feature, help-string, [action-if-given], [action-if-not-given]) The `enable_css_transforms_animations_transitions_unprefixed` variable is only set to "yes" if the feature is not passed through the arguments. However, current code lists `xslt` as the 'feature', and that is given, so the default value is not assigned. That's why the Automake conditional was not set up and that resulted in the feature define (1 by default) being overriden with a 0 value. 800140 6 180748 xan.lopez 2013-01-04 04:09:30 -0800 Comment on attachment 180748 Patch Hah, I see, that's amusing actually. r=me 800168 7 180748 zan 2013-01-04 06:16:44 -0800 Comment on attachment 180748 Patch Clearing flags on attachment: 180748 Committed r138795: <http://trac.webkit.org/changeset/138795> 800169 8 zan 2013-01-04 06:16:49 -0800 All reviewed patches have been landed. Closing bug. 180748 2012-12-26 08:11:18 -0800 2013-01-04 06:16:44 -0800 Patch bug-105522-20121226170830.patch text/plain 5995 zan U3VidmVyc2lvbiBSZXZpc2lvbjogMTM4NDc0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTY5ODBjYmYzYmFlZmM3 ZWUxYzEzY2E1YmUzYjMyZjU2NGViMTY5My4uNWQ2ZTQyNzg4OTZmYmQ4NzAxZjQzYmFjODA0ZTZi ODc5MGVhMjM3MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTEyLTI2ICBaYW4g RG9iZXJzZWsgIDx6YW5kb2JlcnNla0BnbWFpbC5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTiAo cjEzODE4NCk6IHRyYW5zaXRpb25zL3RyYW5zaXRpb25zLXBhcnNpbmcuaHRtbCBpcyBmYWlsaW5n IG9uIEdUSworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTA1NTIyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg UmVtb3ZlIHRoZSBmZWF0dXJlIGRlZmluZSBvdmVycmlkaW5nIGZvciB0aGUgdW5wcmVmaXhlZCBD U1MgdHJhbnNpdGlvbiBwcm9wZXJ0eSBuYW1lcworICAgICAgICBkZWZpbmUgYXMgaXQgaXMgbm90 IHJlcXVpcmVkLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cyAtIG5vIG5ldyBmdW5jdGlvbmFsaXR5 LgorCisgICAgICAgICogR05VbWFrZWZpbGUuYW06CisKIDIwMTItMTItMjYgIFBhbiBEZW5nICA8 cGFuLmRlbmdAaW50ZWwuY29tPgogCiAgICAgICAgIFtXZWIgSW5zcGVjdG9yXVJlbW92ZSBQcmV2 aWV3IGFuZCBSZXNwb25zZSB0YWIgZnJvbSBuZXR3b3JrIHBhbmVsIGluIGNhc2Ugd2Vic29ja2V0 LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvR05VbWFrZWZpbGUuYW0gYi9Tb3VyY2UvV2Vi Q29yZS9HTlVtYWtlZmlsZS5hbQppbmRleCAwMmM0YzZkY2YwNDY0Njg3OTk4YjdhODFjNmZlMWU4 MDBlNGRjODI0Li4yOGI1MmI0OWNiMWM0ODY0ODRiOGJlNzgyNmFiNGNkYjNmYTE2NzE3IDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9HTlVtYWtlZmlsZS5hbQorKysgYi9Tb3VyY2UvV2ViQ29y ZS9HTlVtYWtlZmlsZS5hbQpAQCAtMTk3LDE1ICsxOTcsNiBAQCBmZWF0dXJlX2RlZmluZXNfb3Zl cnJpZGVzICs9IEVOQUJMRV9YU0xUPTAKIGVuZGlmICMgRU5EIEVOQUJMRV9YU0xUCiAKICMgLS0t LQotIyBVbnByZWZpeGVkIENTUyBUcmFuc2Zvcm1zLCBBbmltYXRpb24gYW5kIFRyYW5zaXRpb25z Ci0jIC0tLS0KLWlmIEVOQUJMRV9DU1NfVFJBTlNGT1JNU19BTklNQVRJT05TX1RSQU5TSVRJT05T X1VOUFJFRklYRUQKLWZlYXR1cmVfZGVmaW5lc19vdmVycmlkZXMgKz0gRU5BQkxFX0NTU19UUkFO U0ZPUk1TX0FOSU1BVElPTlNfVFJBTlNJVElPTlNfVU5QUkVGSVhFRD0xCi1lbHNlCi1mZWF0dXJl X2RlZmluZXNfb3ZlcnJpZGVzICs9IEVOQUJMRV9DU1NfVFJBTlNGT1JNU19BTklNQVRJT05TX1RS QU5TSVRJT05TX1VOUFJFRklYRUQ9MAotZW5kaWYgIyBFTkQgRU5BQkxFX0NTU19UUkFOU0ZPUk1T X0FOSU1BVElPTlNfVFJBTlNJVElPTlNfVU5QUkVGSVhFRAotCi0jIC0tLS0KICMgU2hhZGVycwog IyAtLS0tCiBpZiBFTkFCTEVfQ1NTX1NIQURFUlMKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0No YW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCA0NDk5NTYxODUyMmE1OTkyNmFi YzM3OGZhNTA2ZmY0ODhlNGM1NzdiLi5kYmJiZmNlMDgzOGVhYWYzZjBjYzUwNjZjMGRiMWMyNDlh ODkwNDA1IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVz dHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTItMTItMjYgIFphbiBEb2JlcnNlayAg PHphbmRvYmVyc2VrQGdtYWlsLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OIChyMTM4MTg0KTog dHJhbnNpdGlvbnMvdHJhbnNpdGlvbnMtcGFyc2luZy5odG1sIGlzIGZhaWxpbmcgb24gR1RLCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDU1MjIKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZW1vdmUgYSBm YWlsdXJlIGV4cGVjdGF0aW9uIGZvciBhIHRlc3QgdGhhdCdzIG5vdyBwYXNzaW5nLgorCisgICAg ICAgICogcGxhdGZvcm0vZ3RrL1Rlc3RFeHBlY3RhdGlvbnM6CisKIDIwMTItMTItMjUgIEFsZXhh bmRlciBQYXZsb3YgIDxhcGF2bG92QGNocm9taXVtLm9yZz4KIAogICAgICAgICBXZWIgSW5zcGVj dG9yOiBDcmFzaCB3aGVuIG1vZGlmeWluZyBhIHJ1bGUgdGhhdCBoYXMgYmVlbiByZW1vdmVkIHRo cm91Z2ggSmF2YVNjcmlwdApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1Rl c3RFeHBlY3RhdGlvbnMgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvVGVzdEV4cGVjdGF0aW9u cwppbmRleCBkZTc0YTkzMjRiYWRiM2QxMTAzOTZmM2Y3YTY3YjZhY2U2NDZmODM0Li4yODI0Yjg1 ZmNkMjQwMmRhODAyNGIxODAwNTI0MjVhM2VkYTM1ODgxIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9wbGF0Zm9ybS9ndGsvVGVzdEV4cGVjdGF0aW9ucworKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9y bS9ndGsvVGVzdEV4cGVjdGF0aW9ucwpAQCAtMTM4Niw4ICsxMzg2LDYgQEAgd2Via2l0Lm9yZy9i Lzg3NzM0IHN2Zy9kb20vdmlld3NwZWMtcGFyc2VyLTcuaHRtbCBbIEZhaWx1cmUgXQogCiB3ZWJr aXQub3JnL2IvMTA1NDQzIGFjY2Vzc2liaWxpdHkvYXJpYS1jb250cm9scy13aXRoLXRhYnMuaHRt bCBbIEZhaWx1cmUgXQogCi13ZWJraXQub3JnL2IvMTA1NTIyIHRyYW5zaXRpb25zL3RyYW5zaXRp b25zLXBhcnNpbmcuaHRtbCBbIEZhaWx1cmUgXQotCiB3ZWJraXQub3JnL2IvOTgxNDYgYWNjZXNz aWJpbGl0eS9zdmctYm91bmRzLmh0bWwgWyBGYWlsdXJlIF0KIAogIy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8KZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCA2 MzRkMmExNzc2M2ZjODNiMTk5NTU2OGE4ZWY1YWNiNzQ0NzkyNjIzLi5hNWY0M2M3NTNhMDdmNTU5 OGExZTBmNTBjODJmODcxOGYxMmVlMTk1IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTItMTItMjYgIFphbiBEb2JlcnNlayAgPHphbmRv YmVyc2VrQGdtYWlsLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OIChyMTM4MTg0KTogdHJhbnNp dGlvbnMvdHJhbnNpdGlvbnMtcGFyc2luZy5odG1sIGlzIGZhaWxpbmcgb24gR1RLCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDU1MjIKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZW1vdmUgdGhlIGNvbmZp Z3VyYXRpb24gZmxhZyBjb3ZlcmluZyB1bnByZWZpeGVkIENTUyB0cmFuc2l0aW9uIHByb3BlcnR5 IG5hbWVzLgorICAgICAgICBJdCBkb2VzIG5vdCBpbnRyb2R1Y2UgYW55IGRlcGVuZGVuY3kuIFRo ZSB1bnByZWZpeGVkIHByb3BlcnR5IG5hbWVzIHNob3VsZCBiZQorICAgICAgICBhdmFpbGFibGUg YnkgZGVmYXVsdC4KKworICAgICAgICAqIGNvbmZpZ3VyZS5hYzoKKwogMjAxMi0xMi0yNCAgS29u ZGFwYWxseSBLYWx5YW4gIDxrYWx5YW4ua29uZGFwYWxseUBpbnRlbC5jb20+CiAKICAgICAgICAg W0VGTCBbV2ViR0xdIEdMRVMyIGRldGVjdGlvbiBpcyBicm9rZW4uCmRpZmYgLS1naXQgYS9jb25m aWd1cmUuYWMgYi9jb25maWd1cmUuYWMKaW5kZXggNDIzMzNlMWJjNDEwYWNjMTRiM2VkNzYyYmRi MjA2NGIxMzUyMmUwZS4uMGE4ZmEyZDllOGVjMDliZTQwMDUxZDRlYWQ1NzYxMzk1YmU2YjgwMSAx MDA2NDQKLS0tIGEvY29uZmlndXJlLmFjCisrKyBiL2NvbmZpZ3VyZS5hYwpAQCAtNjczLDE0ICs2 NzMsNiBAQCBBQ19BUkdfRU5BQkxFKHhzbHQsCiAgICAgICAgICAgICAgIFtdLFtlbmFibGVfeHNs dD0ieWVzIl0pCiBBQ19NU0dfUkVTVUxUKFskZW5hYmxlX3hzbHRdKQogCi0jIGNoZWNrIHdoZXRo ZXIgdG8gZW5hYmxlIHVucHJlZml4ZWQgc3VwcG9ydCBmb3IgQ1NTIFRyYW5zZm9ybXMsIEFuaW1h dGlvbnMgYW5kIFRyYW5zaXRpb25zCi1BQ19NU0dfQ0hFQ0tJTkcoW3doZXRoZXIgdG8gZW5hYmxl IHN1cHBvcnQgZm9yIHVucHJlZml4ZWQgQ1NTIFRyYW5zZm9ybXMsIEFuaW1hdGlvbnMgYW5kIFRy YW5zaXRpb25zXSkKLUFDX0FSR19FTkFCTEUoeHNsdCwKLSAgICAgICAgICAgICAgQUNfSEVMUF9T VFJJTkcoWy0tZW5hYmxlLXVucHJlZml4ZWQtY3NzLXRyYW5zZm9ybXMtYW5pbWF0aW9ucy10cmFu c2l0aW9uc10sCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgIFtlbmFibGUgc3VwcG9ydCBm b3IgZm9yIHVucHJlZml4ZWQgQ1NTIFRyYW5zZm9ybXMsIEFuaW1hdGlvbnMgYW5kIFRyYW5zaXRp b25zIFtkZWZhdWx0PXllc11dKSwKLSAgICAgICAgICAgICAgW10sW2VuYWJsZV9jc3NfdHJhbnNm b3Jtc19hbmltYXRpb25zX3RyYW5zaXRpb25zX3VucHJlZml4ZWQ9InllcyJdKQotQUNfTVNHX1JF U1VMVChbJGVuYWJsZV9jc3NfdHJhbnNmb3Jtc19hbmltYXRpb25zX3RyYW5zaXRpb25zX3VucHJl Zml4ZWRdKQotCiAjIGNoZWNrIHdoZXRoZXIgdG8gZW5hYmxlIGdlb2xvY2F0aW9uIHN1cHBvcnQK IEFDX01TR19DSEVDS0lORyhbd2hldGhlciB0byBlbmFibGUgZ2VvbG9jYXRpb24gc3VwcG9ydF0p CiBBQ19BUkdfRU5BQkxFKGdlb2xvY2F0aW9uLApAQCAtMTE1OCw3ICsxMTUwLDYgQEAgQU1fQ09O RElUSU9OQUwoW0VOQUJMRV9XRUJLSVQyXSxbdGVzdCAiJGVuYWJsZV93ZWJraXQyIiA9ICJ5ZXMi XSkKIEFNX0NPTkRJVElPTkFMKFtFTkFCTEVfU1BFTExDSEVDS10sW3Rlc3QgIiRlbmFibGVfc3Bl bGxjaGVjayIgPSAieWVzIl0pCiBBTV9DT05ESVRJT05BTChbRU5BQkxFX0NTU19GSUxURVJTXSxb dGVzdCAiJGVuYWJsZV9jc3NfZmlsdGVycyIgPSAieWVzIl0pCiBBTV9DT05ESVRJT05BTChbRU5B QkxFX0NTU19TSEFERVJTXSxbdGVzdCAiJGVuYWJsZV9jc3Nfc2hhZGVycyIgPSAieWVzIl0pCi1B TV9DT05ESVRJT05BTChbRU5BQkxFX0NTU19UUkFOU0ZPUk1TX0FOSU1BVElPTlNfVFJBTlNJVElP TlNfVU5QUkVGSVhFRF0sW3Rlc3QgIiRlbmFibGVfY3NzX3RyYW5zZm9ybXNfYW5pbWF0aW9uc190 cmFuc2l0aW9uc191bnByZWZpeGVkIiA9ICJ5ZXMiXSkKIAogIyBHdGsgY29uZGl0aW9uYWxzCiBB TV9DT05ESVRJT05BTChbRU5BQkxFX0lOVFJPU1BFQ1RJT05dLFt0ZXN0ICIkZW5hYmxlX2ludHJv c3BlY3Rpb24iID0gInllcyJdKQpAQCAtMTIyMyw3ICsxMjE0LDYgQEAgRmVhdHVyZXM6CiAgU1ZH IGZvbnRzIHN1cHBvcnQgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgOiAk ZW5hYmxlX3N2Z19mb250cwogIFNWRyBzdXBwb3J0ICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgIDogJGVuYWJsZV9zdmcKICBTcGVsbGNoZWNrIHN1cHBvcnQgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICA6ICRlbmFibGVfc3BlbGxjaGVjawot IFVucHJlZml4ZWQgc3VwcG9ydCBmb3IgQ1NTIFRyYW5zZm9ybXMsIGFuaW1hdGlvbnMgYW5kIHRy YW5zdGlvbnMgOiBlbmFibGVfY3NzX3RyYW5zZm9ybXNfYW5pbWF0aW9uc190cmFuc2l0aW9uc191 bnByZWZpeGVkCiAgV2ViIEF1ZGlvIHN1cHBvcnQgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgOiAkZW5hYmxlX3dlYl9hdWRpbwogIFdlYkdMICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIDogJGVuYWJsZV93ZWJnbAogIFhTTFQg c3VwcG9ydCAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIDogJGVu YWJsZV94c2x0Cg==