105516 2012-12-20 02:14:52 -0800 PDFPlugin: Cannot drop files/URLs on PDFPlugin 2012-12-21 02:35:46 -0800 1 1 1 Unclassified WebKit PDF 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 thorton thorton oldest_to_newest 795299 0 thorton 2012-12-20 02:14:52 -0800 <rdar://problem/12729443> DragController has rejected drags onto PluginDocument since the beginning of time. PDFPlugin would rather this weren't the case, as we can guarantee it doesn't have anything else handling drags. 795304 1 180306 thorton 2012-12-20 02:29:24 -0800 Created attachment 180306 patch 795512 2 180306 ap 2012-12-20 09:55:06 -0800 Comment on attachment 180306 patch View in context: https://bugs.webkit.org/attachment.cgi?id=180306&action=review > we can guarantee it doesn't have anything else handling drags. Not even text fields in PDF forms? > Source/WebCore/page/DragController.cpp:413 > + if (doc->isPluginDocument()) { There is a null check for doc below. Either it's not needed, or this new code can crash. > Source/WebCore/page/DragController.cpp:415 > + const PluginViewBase* pluginView = widget && widget->isPluginViewBase() ? static_cast<const PluginViewBase*>(widget) : 0; I like to have braces around ternary conditions FWIW - it makes them look more like if () conditions. 795533 3 thorton 2012-12-20 10:11:35 -0800 (In reply to comment #2) > (From update of attachment 180306 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=180306&action=review > > > we can guarantee it doesn't have anything else handling drags. > > Not even text fields in PDF forms? Ugh. I will test. 796217 4 thorton 2012-12-21 02:32:46 -0800 http://trac.webkit.org/changeset/138361 796218 5 thorton 2012-12-21 02:35:46 -0800 (In reply to comment #3) > (In reply to comment #2) > > (From update of attachment 180306 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=180306&action=review > > > > > we can guarantee it doesn't have anything else handling drags. > > > > Not even text fields in PDF forms? > > Ugh. I will test. These are OK because they're handled as they would be in a normal page. They get the drag and not the document. 180306 2012-12-20 02:29:24 -0800 2012-12-20 09:55:06 -0800 patch dragging.diff text/plain 8720 thorton ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA2YTUxOTZmLi4zMjdkZjM1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTItMTItMjAgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CisK KyAgICAgICAgUERGUGx1Z2luOiBDYW5ub3QgZHJvcCBmaWxlcy9VUkxzIG9uIFBERlBsdWdpbgor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA1NTE2Cisg ICAgICAgIDxyZGFyOi8vcHJvYmxlbS8xMjcyOTQ0Mz4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBhZ2UvRHJhZ0NvbnRyb2xsZXIuY3BwOgorICAg ICAgICAoV2ViQ29yZTo6RHJhZ0NvbnRyb2xsZXI6Om9wZXJhdGlvbkZvckxvYWQpOiBJZiB3ZSBk cmFnIG92ZXIgYSBQbHVnaW5Eb2N1bWVudCwgY2hlY2sgaWYgaXRzIFBsdWdpblZpZXcKKyAgICAg ICAgY2xhaW1zIHRvIHN1cHBvcnQgbmF2aWdhdGlvbiByZXN1bHRpbmcgZnJvbSBhIGRyYWcgKG9u bHkgUERGUGx1Z2luIHdpbGwgZm9yIG5vdykuIElmIGl0IGRvZXMsIGFsbG93IHRoZSBkcmFnLgor ICAgICAgICAqIHBsdWdpbnMvUGx1Z2luVmlld0Jhc2UuaDoKKyAgICAgICAgKFdlYkNvcmU6OlBs dWdpblZpZXdCYXNlOjpzaG91bGRBbGxvd05hdmlnYXRpb25Gcm9tRHJhZ3MpOiBBZGQgc2hvdWxk QWxsb3dOYXZpZ2F0aW9uRnJvbURyYWdzLgorCiAyMDEyLTEyLTE5ICBDYXJsb3MgR2FyY2lhIENh bXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KIAogICAgICAgICBNYWtlIG9yZGVyIGl0ZXJhdG9y IG1lbWJlciBzdGFjayBhbGxvY2F0ZWQgaW4gUmVuZGVyRmxleGlibGVCb3gKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL3BhZ2UvRHJhZ0NvbnRyb2xsZXIuY3BwIGIvU291cmNlL1dlYkNvcmUv cGFnZS9EcmFnQ29udHJvbGxlci5jcHAKaW5kZXggNmUxM2U0ZS4uN2FkNGQwYiAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvcGFnZS9EcmFnQ29udHJvbGxlci5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvcGFnZS9EcmFnQ29udHJvbGxlci5jcHAKQEAgLTU4LDYgKzU4LDggQEAKICNpbmNsdWRl ICJOb2RlLmgiCiAjaW5jbHVkZSAiUGFnZS5oIgogI2luY2x1ZGUgIlBsYXRmb3JtS2V5Ym9hcmRF dmVudC5oIgorI2luY2x1ZGUgIlBsdWdpbkRvY3VtZW50LmgiCisjaW5jbHVkZSAiUGx1Z2luVmll d0Jhc2UuaCIKICNpbmNsdWRlICJSZW5kZXJGaWxlVXBsb2FkQ29udHJvbC5oIgogI2luY2x1ZGUg IlJlbmRlckltYWdlLmgiCiAjaW5jbHVkZSAiUmVuZGVyVmlldy5oIgpAQCAtNDA1LDcgKzQwNywx OCBAQCBEcmFnT3BlcmF0aW9uIERyYWdDb250cm9sbGVyOjpvcGVyYXRpb25Gb3JMb2FkKERyYWdE YXRhKiBkcmFnRGF0YSkKIHsKICAgICBBU1NFUlQoZHJhZ0RhdGEpOwogICAgIERvY3VtZW50KiBk b2MgPSBtX3BhZ2UtPm1haW5GcmFtZSgpLT5kb2N1bWVudEF0UG9pbnQoZHJhZ0RhdGEtPmNsaWVu dFBvc2l0aW9uKCkpOwotICAgIGlmIChkb2MgJiYgKG1fZGlkSW5pdGlhdGVEcmFnIHx8IGRvYy0+ aXNQbHVnaW5Eb2N1bWVudCgpIHx8IGRvYy0+cmVuZGVyZXJJc0VkaXRhYmxlKCkpKQorCisgICAg Ym9vbCBwbHVnaW5Eb2N1bWVudEFjY2VwdHNEcmFncyA9IGZhbHNlOworCisgICAgaWYgKGRvYy0+ aXNQbHVnaW5Eb2N1bWVudCgpKSB7CisgICAgICAgIGNvbnN0IFdpZGdldCogd2lkZ2V0ID0gc3Rh dGljX2Nhc3Q8UGx1Z2luRG9jdW1lbnQqPihkb2MpLT5wbHVnaW5XaWRnZXQoKTsKKyAgICAgICAg Y29uc3QgUGx1Z2luVmlld0Jhc2UqIHBsdWdpblZpZXcgPSB3aWRnZXQgJiYgd2lkZ2V0LT5pc1Bs dWdpblZpZXdCYXNlKCkgPyBzdGF0aWNfY2FzdDxjb25zdCBQbHVnaW5WaWV3QmFzZSo+KHdpZGdl dCkgOiAwOworCisgICAgICAgIGlmIChwbHVnaW5WaWV3KQorICAgICAgICAgICAgcGx1Z2luRG9j dW1lbnRBY2NlcHRzRHJhZ3MgPSBwbHVnaW5WaWV3LT5zaG91bGRBbGxvd05hdmlnYXRpb25Gcm9t RHJhZ3MoKTsKKyAgICB9CisKKyAgICBpZiAoZG9jICYmIChtX2RpZEluaXRpYXRlRHJhZyB8fCAo ZG9jLT5pc1BsdWdpbkRvY3VtZW50KCkgJiYgIXBsdWdpbkRvY3VtZW50QWNjZXB0c0RyYWdzKSB8 fCBkb2MtPnJlbmRlcmVySXNFZGl0YWJsZSgpKSkKICAgICAgICAgcmV0dXJuIERyYWdPcGVyYXRp b25Ob25lOwogICAgIHJldHVybiBkcmFnT3BlcmF0aW9uKGRyYWdEYXRhKTsKIH0KZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL3BsdWdpbnMvUGx1Z2luVmlld0Jhc2UuaCBiL1NvdXJjZS9XZWJD b3JlL3BsdWdpbnMvUGx1Z2luVmlld0Jhc2UuaAppbmRleCAwZmUzMjFiLi45NmQ2NWYwIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbHVnaW5zL1BsdWdpblZpZXdCYXNlLmgKKysrIGIvU291 cmNlL1dlYkNvcmUvcGx1Z2lucy9QbHVnaW5WaWV3QmFzZS5oCkBAIC03NSw2ICs3NSw4IEBAIHB1 YmxpYzoKIAogICAgIHZpcnR1YWwgYm9vbCBzaG91bGRBbHdheXNBdXRvU3RhcnQoKSBjb25zdCB7 IHJldHVybiBmYWxzZTsgfQogCisgICAgdmlydHVhbCBib29sIHNob3VsZEFsbG93TmF2aWdhdGlv bkZyb21EcmFncygpIGNvbnN0IHsgcmV0dXJuIGZhbHNlOyB9CisKIHByb3RlY3RlZDoKICAgICBl eHBsaWNpdCBQbHVnaW5WaWV3QmFzZShQbGF0Zm9ybVdpZGdldCB3aWRnZXQgPSAwKSA6IFdpZGdl dCh3aWRnZXQpIHsgfQogICAgIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9n IGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCmluZGV4IDQ4ODRmNjIuLjg5MGQwOGYgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFu Z2VMb2cKQEAgLTEsMyArMSwyOCBAQAorMjAxMi0xMi0yMCAgVGltIEhvcnRvbiAgPHRpbW90aHlf aG9ydG9uQGFwcGxlLmNvbT4KKworICAgICAgICBQREZQbHVnaW46IENhbm5vdCBkcm9wIGZpbGVz L1VSTHMgb24gUERGUGx1Z2luCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xMDU1MTYKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzEyNzI5NDQzPgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCBzaG91bGRB bGxvd05hdmlnYXRpb25Gcm9tRHJhZ3MgdG8gUGx1Z2luL1BsdWdpblZpZXcvZXRjLiwgd2hpY2gg V2ViQ29yZSB3aWxsCisgICAgICAgIGNvbnN1bHQgd2hlbiBkcmFnZ2luZyBvdmVyIGEgUGx1Z2lu RG9jdW1lbnQgdG8gZGVjaWRlIHdoZXRoZXIgb3Igbm90IGEgZHJhZyBtYXkgcmVzdWx0IGluIG5h dmlnYXRpb24uCisKKyAgICAgICAgKiBXZWJQcm9jZXNzL1BsdWdpbnMvTmV0c2NhcGUvTmV0c2Nh cGVQbHVnaW4uY3BwOgorICAgICAgICAoV2ViS2l0OjpOZXRzY2FwZVBsdWdpbjo6c2hvdWxkQWxs b3dOYXZpZ2F0aW9uRnJvbURyYWdzKTogQWRkZWQsIGFsd2F5cyByZXR1cm5pbmcgZmFsc2UgdG8g a2VlcCBleGlzdGluZyBiZWhhdmlvci4KKyAgICAgICAgKiBXZWJQcm9jZXNzL1BsdWdpbnMvTmV0 c2NhcGUvTmV0c2NhcGVQbHVnaW4uaDoKKyAgICAgICAgKE5ldHNjYXBlUGx1Z2luKTogQWRkZWQu CisgICAgICAgICogV2ViUHJvY2Vzcy9QbHVnaW5zL1BERi9TaW1wbGVQREZQbHVnaW4uaDoKKyAg ICAgICAgKFdlYktpdDo6U2ltcGxlUERGUGx1Z2luOjpzaG91bGRBbGxvd05hdmlnYXRpb25Gcm9t RHJhZ3MpOiBBZGRlZCwgYWx3YXlzIHJldHVybmluZyB0cnVlLiAoU2ltcGxlKVBERlBsdWdpbiBz aG91bGQKKyAgICAgICAgbmF2aWdhdGUgd2hlbiBkcm9wcGVkIG9udG8sIGp1c3QgbGlrZSBhbiBp bWFnZSBvciBIVE1MIGRvY3VtZW50IHdvdWxkLgorICAgICAgICAqIFdlYlByb2Nlc3MvUGx1Z2lu cy9QbHVnaW4uaDoKKyAgICAgICAgKFBsdWdpbik6IEFkZCBzaG91bGRBbGxvd05hdmlnYXRpb25G cm9tRHJhZ3MuCisgICAgICAgICogV2ViUHJvY2Vzcy9QbHVnaW5zL1BsdWdpblByb3h5Lmg6IEFk ZCBzaG91bGRBbGxvd05hdmlnYXRpb25Gcm9tRHJhZ3MuCisgICAgICAgICogV2ViUHJvY2Vzcy9Q bHVnaW5zL1BsdWdpblZpZXcuY3BwOgorICAgICAgICAoV2ViS2l0OjpQbHVnaW5WaWV3OjpzaG91 bGRBbGxvd05hdmlnYXRpb25Gcm9tRHJhZ3MpOiBGb3J3YXJkIHNob3VsZEFsbG93TmF2aWdhdGlv bkZyb21EcmFncyB0byB0aGUgcGx1Z2luLgorICAgICAgICAqIFdlYlByb2Nlc3MvUGx1Z2lucy9Q bHVnaW5WaWV3Lmg6IEFkZCBzaG91bGRBbGxvd05hdmlnYXRpb25Gcm9tRHJhZ3MuCisKIDIwMTIt MTItMjAgIEh1YW5nIERvbmdzdW5nICA8bHV4dGVsbGFAY29tcGFueTEwMC5uZXQ+CiAKICAgICAg ICAgUmVtb3ZlIEdyYXBoaWNzTGF5ZXI6OnNldEdyYXBoaWNzTGF5ZXJGYWN0b3J5KCkuCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1BsdWdpbnMvTmV0c2NhcGUvTmV0c2Nh cGVQbHVnaW4uY3BwIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9QbHVnaW5zL05ldHNjYXBl L05ldHNjYXBlUGx1Z2luLmNwcAppbmRleCBmMWUwZTViLi4wODg5NDlhIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1BsdWdpbnMvTmV0c2NhcGUvTmV0c2NhcGVQbHVnaW4u Y3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvUGx1Z2lucy9OZXRzY2FwZS9OZXRz Y2FwZVBsdWdpbi5jcHAKQEAgLTkyNiw2ICs5MjYsMTEgQEAgYm9vbCBOZXRzY2FwZVBsdWdpbjo6 c2hvdWxkQWxsb3dTY3JpcHRpbmcoKQogICAgIHJldHVybiB0cnVlOwogfQogCitib29sIE5ldHNj YXBlUGx1Z2luOjpzaG91bGRBbGxvd05hdmlnYXRpb25Gcm9tRHJhZ3MoKQoreworICAgIHJldHVy biBmYWxzZTsKK30KKwogYm9vbCBOZXRzY2FwZVBsdWdpbjo6aGFuZGxlc1BhZ2VTY2FsZUZhY3Rv cigpCiB7CiAgICAgcmV0dXJuIGZhbHNlOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvV2Vi UHJvY2Vzcy9QbHVnaW5zL05ldHNjYXBlL05ldHNjYXBlUGx1Z2luLmggYi9Tb3VyY2UvV2ViS2l0 Mi9XZWJQcm9jZXNzL1BsdWdpbnMvTmV0c2NhcGUvTmV0c2NhcGVQbHVnaW4uaAppbmRleCAyMDYz Y2NlLi41MWE5YWFkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1BsdWdp bnMvTmV0c2NhcGUvTmV0c2NhcGVQbHVnaW4uaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9j ZXNzL1BsdWdpbnMvTmV0c2NhcGUvTmV0c2NhcGVQbHVnaW4uaApAQCAtMjA4LDYgKzIwOCw3IEBA IHByaXZhdGU6CiAgICAgdmlydHVhbCBib29sIGlzRWRpdGluZ0NvbW1hbmRFbmFibGVkKGNvbnN0 IFN0cmluZyYpIE9WRVJSSURFOwogCiAgICAgdmlydHVhbCBib29sIHNob3VsZEFsbG93U2NyaXB0 aW5nKCkgT1ZFUlJJREU7CisgICAgdmlydHVhbCBib29sIHNob3VsZEFsbG93TmF2aWdhdGlvbkZy b21EcmFncygpIE9WRVJSSURFOwogICAgIAogICAgIHZpcnR1YWwgYm9vbCBoYW5kbGVzUGFnZVNj YWxlRmFjdG9yKCkgT1ZFUlJJREU7CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1dlYlBy b2Nlc3MvUGx1Z2lucy9QREYvU2ltcGxlUERGUGx1Z2luLmggYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQ cm9jZXNzL1BsdWdpbnMvUERGL1NpbXBsZVBERlBsdWdpbi5oCmluZGV4IDk5YjUxODQuLmUxOGNi MGQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvUGx1Z2lucy9QREYvU2lt cGxlUERGUGx1Z2luLmgKKysrIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9QbHVnaW5zL1BE Ri9TaW1wbGVQREZQbHVnaW4uaApAQCAtMTcyLDYgKzE3Miw3IEBAIHByb3RlY3RlZDoKICAgICB2 aXJ0dWFsIGJvb2wgaGFuZGxlc1BhZ2VTY2FsZUZhY3RvcigpIE9WRVJSSURFOwogCiAgICAgdmly dHVhbCBib29sIHNob3VsZEFsbG93U2NyaXB0aW5nKCkgT1ZFUlJJREUgeyByZXR1cm4gZmFsc2U7 IH0KKyAgICB2aXJ0dWFsIGJvb2wgc2hvdWxkQWxsb3dOYXZpZ2F0aW9uRnJvbURyYWdzKCkgeyBy ZXR1cm4gdHJ1ZTsgfQogCiAgICAgV2ViQ29yZTo6SW50U2l6ZSBtX3Njcm9sbE9mZnNldDsKIApk aWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9QbHVnaW5zL1BsdWdpbi5oIGIv U291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9QbHVnaW5zL1BsdWdpbi5oCmluZGV4IGNmZjRmMzgu LmRjNzUxNTAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvUGx1Z2lucy9Q bHVnaW4uaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1BsdWdpbnMvUGx1Z2luLmgK QEAgLTE5Nyw2ICsxOTcsOSBAQCBwdWJsaWM6CiAKICAgICAvLyBBc2sgdGhlIHBsdWctaW4gd2hl dGhlciBpdCBzaG91bGQgYmUgYWxsb3dlZCB0byBleGVjdXRlIEphdmFTY3JpcHQgb3IgbmF2aWdh dGUgdG8gSmF2YVNjcmlwdCBVUkxzLgogICAgIHZpcnR1YWwgYm9vbCBzaG91bGRBbGxvd1Njcmlw dGluZygpID0gMDsKKworICAgIC8vIEFzayB0aGUgcGx1Zy1pbiB3aGV0aGVyIGl0IHdhbnRzIFVS THMgYW5kIGZpbGVzIGRyYWdnZWQgb250byBpdCB0byBjYXVzZSBuYXZpZ2F0aW9uLgorICAgIHZp cnR1YWwgYm9vbCBzaG91bGRBbGxvd05hdmlnYXRpb25Gcm9tRHJhZ3MoKSA9IDA7CiAgICAgCiAg ICAgLy8gQXNrIHRoZSBwbHVnLWluIHdoZXRoZXIgaXQgd2FudHMgdG8gb3ZlcnJpZGUgZnVsbC1w YWdlIHpvb20uCiAgICAgdmlydHVhbCBib29sIGhhbmRsZXNQYWdlU2NhbGVGYWN0b3IoKSA9IDA7 CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1BsdWdpbnMvUGx1Z2luUHJv eHkuaCBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvUGx1Z2lucy9QbHVnaW5Qcm94eS5oCmlu ZGV4IGFmMWQ1ZTEuLjE2MjY5NDIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nl c3MvUGx1Z2lucy9QbHVnaW5Qcm94eS5oCisrKyBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3Mv UGx1Z2lucy9QbHVnaW5Qcm94eS5oCkBAIC0xMDUsNiArMTA1LDcgQEAgcHJpdmF0ZToKICAgICB2 aXJ0dWFsIGJvb2wgaGFuZGxlRWRpdGluZ0NvbW1hbmQoY29uc3QgU3RyaW5nJiBjb21tYW5kTmFt ZSwgY29uc3QgU3RyaW5nJiBhcmd1bWVudCkgT1ZFUlJJREU7CiAgICAgdmlydHVhbCBib29sIGlz RWRpdGluZ0NvbW1hbmRFbmFibGVkKGNvbnN0IFN0cmluZyYgY29tbWFuZE5hbWUpIE9WRVJSSURF OwogICAgIHZpcnR1YWwgYm9vbCBzaG91bGRBbGxvd1NjcmlwdGluZygpIE9WRVJSSURFIHsgcmV0 dXJuIHRydWU7IH0KKyAgICB2aXJ0dWFsIGJvb2wgc2hvdWxkQWxsb3dOYXZpZ2F0aW9uRnJvbURy YWdzKCkgT1ZFUlJJREUgeyByZXR1cm4gZmFsc2U7IH0KICAgICAKICAgICB2aXJ0dWFsIGJvb2wg aGFuZGxlc1BhZ2VTY2FsZUZhY3RvcigpOwogICAgIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktp dDIvV2ViUHJvY2Vzcy9QbHVnaW5zL1BsdWdpblZpZXcuY3BwIGIvU291cmNlL1dlYktpdDIvV2Vi UHJvY2Vzcy9QbHVnaW5zL1BsdWdpblZpZXcuY3BwCmluZGV4IGUwYzk5NzguLjJmZjMzOTAgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvUGx1Z2lucy9QbHVnaW5WaWV3LmNw cAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1BsdWdpbnMvUGx1Z2luVmlldy5jcHAK QEAgLTg1Niw2ICs4NTYsMTQgQEAgYm9vbCBQbHVnaW5WaWV3OjpzaG91bGRBbGxvd1NjcmlwdGlu ZygpCiAgICAgcmV0dXJuIG1fcGx1Z2luLT5zaG91bGRBbGxvd1NjcmlwdGluZygpOwogfQogCiti b29sIFBsdWdpblZpZXc6OnNob3VsZEFsbG93TmF2aWdhdGlvbkZyb21EcmFncygpIGNvbnN0Cit7 CisgICAgaWYgKCFtX2lzSW5pdGlhbGl6ZWQgfHwgIW1fcGx1Z2luKQorICAgICAgICByZXR1cm4g ZmFsc2U7CisKKyAgICByZXR1cm4gbV9wbHVnaW4tPnNob3VsZEFsbG93TmF2aWdhdGlvbkZyb21E cmFncygpOworfQorCiB2b2lkIFBsdWdpblZpZXc6Om5vdGlmeVdpZGdldChXaWRnZXROb3RpZmlj YXRpb24gbm90aWZpY2F0aW9uKQogewogICAgIHN3aXRjaCAobm90aWZpY2F0aW9uKSB7CmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1BsdWdpbnMvUGx1Z2luVmlldy5oIGIv U291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9QbHVnaW5zL1BsdWdpblZpZXcuaAppbmRleCA3ZjA2 Y2E4Li5hYzk2OTI5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1BsdWdp bnMvUGx1Z2luVmlldy5oCisrKyBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvUGx1Z2lucy9Q bHVnaW5WaWV3LmgKQEAgLTEzOCw2ICsxMzgsNyBAQCBwcml2YXRlOgogICAgIHZpcnR1YWwgV2Vi Q29yZTo6U2Nyb2xsYmFyKiB2ZXJ0aWNhbFNjcm9sbGJhcigpOwogICAgIHZpcnR1YWwgYm9vbCB3 YW50c1doZWVsRXZlbnRzKCk7CiAgICAgdmlydHVhbCBib29sIHNob3VsZEFsd2F5c0F1dG9TdGFy dCgpIGNvbnN0IE9WRVJSSURFOworICAgIHZpcnR1YWwgYm9vbCBzaG91bGRBbGxvd05hdmlnYXRp b25Gcm9tRHJhZ3MoKSBjb25zdCBPVkVSUklERTsKIAogICAgIC8vIFdlYkNvcmU6OldpZGdldAog ICAgIHZpcnR1YWwgdm9pZCBzZXRGcmFtZVJlY3QoY29uc3QgV2ViQ29yZTo6SW50UmVjdCYpOwo=