105505 2012-12-20 01:04:52 -0800 REGRESSION(r138215): it broke downstream compilation with clang (Requested by loislo on #webkit). 2012-12-20 01:09:07 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 104704 1 webkit.review.bot webkit.review.bot fishd loislo oldest_to_newest 795249 0 webkit.review.bot 2012-12-20 01:04:52 -0800 http://trac.webkit.org/changeset/138215 broke the build: it broke downstream compilation with clang (Requested by loislo on #webkit). This is an automatic bug report generated by the sheriff-bot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests case pain. "Only you can prevent forest fires." -- Smokey the Bear 795251 1 180292 webkit.review.bot 2012-12-20 01:05:36 -0800 Created attachment 180292 ROLLOUT of r138215 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the rollout will be successful. This process takes approximately 15 minutes. If you would like to land the rollout faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID where ATTACHMENT_ID is the ID of this attachment. 795253 2 loislo 2012-12-20 01:07:17 -0800 please fix downstream part first. ../../content/renderer/renderer_webkitplatformsupport_impl.h:71:46: error: 'sharedWorkerRepository' marked 'override' but does not override any member functions virtual WebKit::WebSharedWorkerRepository* sharedWorkerRepository() OVERRIDE; ^ 795255 3 180292 loislo 2012-12-20 01:09:01 -0800 Comment on attachment 180292 ROLLOUT of r138215 Clearing flags on attachment: 180292 Committed r138233: <http://trac.webkit.org/changeset/138233> 795256 4 loislo 2012-12-20 01:09:07 -0800 All reviewed patches have been landed. Closing bug. 180292 2012-12-20 01:05:36 -0800 2012-12-20 01:09:01 -0800 ROLLOUT of r138215 bug-105505-20121220091203.patch text/plain 3203 webkit.review.bot U3VidmVyc2lvbiBSZXZpc2lvbjogMTM4MjMyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDZkZjI4MjQ4NTM5M2Q3NTlmZGQxNTc3MWNkYTE1M2RmYjVkM2FlMmIuLjFiMDI5YjU1NGIwNGYw Nzk3ZGExYTIyMWI1ZjA4YTVlMWVmZTdlNzUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMjAgQEAKKzIwMTItMTItMjAgIFNoZXJpZmYgQm90ICA8d2Via2l0LnJldmlldy5i b3RAZ21haWwuY29tPgorCisgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHIxMzgyMTUu CisgICAgICAgIGh0dHA6Ly90cmFjLndlYmtpdC5vcmcvY2hhbmdlc2V0LzEzODIxNQorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA1NTA1CisKKyAgICAg ICAgaXQgYnJva2UgZG93bnN0cmVhbSBjb21waWxhdGlvbiB3aXRoIGNsYW5nIChSZXF1ZXN0ZWQg YnkKKyAgICAgICAgbG9pc2xvIG9uICN3ZWJraXQpLgorCisgICAgICAgICogcHVibGljL3BsYXRm b3JtL1dlYktpdFBsYXRmb3JtU3VwcG9ydC5oOgorICAgICAgICAoV2ViS2l0KToKKyAgICAgICAg KFdlYktpdFBsYXRmb3JtU3VwcG9ydCk6CisgICAgICAgIChXZWJLaXQ6OldlYktpdFBsYXRmb3Jt U3VwcG9ydDo6c2hhcmVkV29ya2VyUmVwb3NpdG9yeSk6CisgICAgICAgICogc3JjL1NoYXJlZFdv cmtlclJlcG9zaXRvcnkuY3BwOgorICAgICAgICAoV2ViS2l0OjpzaGFyZWRXb3JrZXJSZXBvc2l0 b3J5KToKKyAgICAgICAgKFdlYkNvcmU6OlNoYXJlZFdvcmtlclJlcG9zaXRvcnk6OmlzQXZhaWxh YmxlKToKKwogMjAxMi0xMi0xOSAgTWFyayBQaWxncmltICA8cGlsZ3JpbUBjaHJvbWl1bS5vcmc+ CiAKICAgICAgICAgW0Nocm9taXVtXSBSZW1vdmUgaWRiRmFjdG9yeSBmcm9tIFBsYXRmb3JtU3Vw cG9ydApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvcGxhdGZvcm0v V2ViS2l0UGxhdGZvcm1TdXBwb3J0LmggYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9w bGF0Zm9ybS9XZWJLaXRQbGF0Zm9ybVN1cHBvcnQuaAppbmRleCBiNjI0NWI5MzRlOTQ2NTEwNWQ4 MDkxYjkzODM5MzA3MmQyZGYxYjM0Li4wNTE5OWUzYWRlYzFkNGVlODJkZDdmZThkY2VkNTM3ZWNi NmQ5YTE2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9wbGF0Zm9y bS9XZWJLaXRQbGF0Zm9ybVN1cHBvcnQuaAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1 YmxpYy9wbGF0Zm9ybS9XZWJLaXRQbGF0Zm9ybVN1cHBvcnQuaApAQCAtMzYsNiArMzYsNyBAQAog bmFtZXNwYWNlIFdlYktpdCB7CiAKIGNsYXNzIFdlYklEQkZhY3Rvcnk7IC8vIEZJWE1FOiBEb2Vz IHRoaXMgYmVsb25nIGluIHBsYXRmb3JtPworY2xhc3MgV2ViU2hhcmVkV29ya2VyUmVwb3NpdG9y eTsgLy8gRklYTUU6IERvZXMgdGhpcyBiZWxvbmcgaW4gcGxhdGZvcm0/CiAKIC8vIEZJWE1FOiBF dmVudHVhbGx5IGFsbCB0aGVzZSBBUEkgd2lsbCBuZWVkIHRvIG1vdmUgdG8gV2ViS2l0OjpQbGF0 Zm9ybS4KIGNsYXNzIFdlYktpdFBsYXRmb3JtU3VwcG9ydCA6IHB1YmxpYyBQbGF0Zm9ybSB7CkBA IC00NCw2ICs0NSwxMSBAQCBwdWJsaWM6CiAKICAgICB2aXJ0dWFsIFdlYklEQkZhY3RvcnkqIGlk YkZhY3RvcnkoKSB7IHJldHVybiAwOyB9CiAKKworICAgIC8vIFNoYXJlZCBXb3JrZXJzIC0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQorCisgICAg dmlydHVhbCBXZWJTaGFyZWRXb3JrZXJSZXBvc2l0b3J5KiBzaGFyZWRXb3JrZXJSZXBvc2l0b3J5 KCkgeyByZXR1cm4gMDsgfQorCiBwcm90ZWN0ZWQ6CiAgICAgfldlYktpdFBsYXRmb3JtU3VwcG9y dCgpIHsgfQogfTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1NoYXJl ZFdvcmtlclJlcG9zaXRvcnkuY3BwIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvU2hhcmVk V29ya2VyUmVwb3NpdG9yeS5jcHAKaW5kZXggODQ0YjkwNTZmZTMyNjBhNWMzYzEyNjBiODgyMGY5 ZmU3MGUyOTQxZC4uZGEwMTliNDJlNDcyYzNmODE5NWU1ZDM5ZWNlMTIxYTRhYjJiZThhNCAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvU2hhcmVkV29ya2VyUmVwb3NpdG9y eS5jcHAKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvU2hhcmVkV29ya2VyUmVwb3Np dG9yeS5jcHAKQEAgLTY5LDggKzY5LDE1IEBAIHZvaWQgc2V0U2hhcmVkV29ya2VyUmVwb3NpdG9y eShXZWJTaGFyZWRXb3JrZXJSZXBvc2l0b3J5KiByZXBvc2l0b3J5KQogCiBzdGF0aWMgV2ViU2hh cmVkV29ya2VyUmVwb3NpdG9yeSogc2hhcmVkV29ya2VyUmVwb3NpdG9yeSgpCiB7Ci0gICAgLy8g V2lsbCBvbmx5IGJlIG5vbi16ZXJvIGlmIHRoZSBlbWJlZGRlciBoYXMgc2V0IHRoZSBzaGFyZWQg d29ya2VyIHJlcG9zaXRvcnkgdXBvbiBpbml0aWFsaXphdGlvbi4gTm90aGluZyBpbiBXZWJLaXQg c2V0cyB0aGlzLgotICAgIHJldHVybiBzX3NoYXJlZFdvcmtlclJlcG9zaXRvcnk7CisgICAgV2Vi U2hhcmVkV29ya2VyUmVwb3NpdG9yeSogcmVwb3NpdG9yeTsKKworICAgIHJlcG9zaXRvcnkgPSBz X3NoYXJlZFdvcmtlclJlcG9zaXRvcnk7CisgICAgaWYgKCFyZXBvc2l0b3J5KSB7CisgICAgICAg IHJlcG9zaXRvcnkgPSB3ZWJLaXRQbGF0Zm9ybVN1cHBvcnQoKS0+c2hhcmVkV29ya2VyUmVwb3Np dG9yeSgpOworICAgICAgICBzZXRTaGFyZWRXb3JrZXJSZXBvc2l0b3J5KHJlcG9zaXRvcnkpOwor ICAgIH0KKworICAgIHJldHVybiByZXBvc2l0b3J5OwogfQogCiB9CkBAIC0yMTEsNiArMjE4LDgg QEAgdm9pZCBTaGFyZWRXb3JrZXJTY3JpcHRMb2FkZXI6OmNvbm5lY3RlZCgpCiAKIGJvb2wgU2hh cmVkV29ya2VyUmVwb3NpdG9yeTo6aXNBdmFpbGFibGUoKQogeworICAgIC8vIEFsbG93IHRoZSBX ZWJLaXRQbGF0Zm9ybVN1cHBvcnQgdG8gZGV0ZXJtaW5lIGlmIFNoYXJlZFdvcmtlcnMKKyAgICAv LyBhcmUgYXZhaWxhYmxlLgogICAgIHJldHVybiBXZWJLaXQ6OnNoYXJlZFdvcmtlclJlcG9zaXRv cnkoKTsKIH0KIAo=