105496 2012-12-19 21:42:34 -0800 Follow WebVTT line breaking rules 2013-01-07 11:37:01 -0800 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 43668 105569 1 dino dino cmarcelo eric.carlson feature-media-reviews ian macpherson menard ojan.autocc silviapf vcarbune webkit.review.bot oldest_to_newest 795164 0 dino 2012-12-19 21:42:34 -0800 From the spec: Text runs must be wrapped according to the CSS line-wrapping rules, with the following additional constraints: Regardless of the value of the 'white-space' property, lines must be wrapped at the edge of their containing blocks, even if doing so requires splitting a word where there is no line breaking opportunity. (Thus, normally text wraps as needed, but if there is a particularly long word, it does not overflow as it normally would in CSS, it is instead forcibly wrapped at the box's edge.) Regardless of the value of the 'white-space' property, any line breaks inserted by the user agent for the purposes of line wrapping must be placed so as to minimize Δ across each run of consecutive lines between preserved newlines in the source. Δ for a set of lines is defined as the sum over each line of the absolute of the difference between the line's length and the mean line length of the set. I'm not sure we'll be able to do the latter part (nor what the benefit is). 795165 1 webkit-bug-importer 2012-12-19 21:43:10 -0800 <rdar://problem/12915747> 795166 2 webkit-bug-importer 2012-12-19 21:43:14 -0800 <rdar://problem/12915748> 795167 3 dino 2012-12-19 21:44:59 -0800 Ignore those two radars. The real one is <rdar://problem/12530021> 795177 4 180277 dino 2012-12-19 21:52:52 -0800 Created attachment 180277 Patch 795526 5 180277 eric.carlson 2012-12-20 10:04:51 -0800 Comment on attachment 180277 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=180277&action=review > LayoutTests/media/track/captions-webvtt/long-word.vtt:9 > +mmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmm Yummy caption :-) 795650 6 dino 2012-12-20 12:13:35 -0800 Committed r138282: <http://trac.webkit.org/changeset/138282> 795666 7 ian 2012-12-20 12:30:37 -0800 Re the wrapping, the benefit is it avoids cues wrapping like this: Hello World How Are You ...which is hard to read. 795678 8 dino 2012-12-20 12:40:18 -0800 (In reply to comment #7) > Re the wrapping, the benefit is it avoids cues wrapping like this: > > Hello World How Are > You > > ...which is hard to read. Got it. I had a suspicion that is what the specification text meant. This is something we'll have to add to our layout code. I'll open a followup. 180277 2012-12-19 21:52:52 -0800 2012-12-20 10:04:51 -0800 Patch bug-105496-20121220165007.patch text/plain 6838 dino U3VidmVyc2lvbiBSZXZpc2lvbjogMTM4MTk5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZGJkYmUxYmJjZjFmOWM0 MTYzZWI0MDRjNzAzYzcyMjJiNDBlN2Y4Zi4uODFhOGIzZTdkNTgwNjQ2MTcwODgzNWE1OWM1YmZl MjZiMzlhZGQwMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEyLTEyLTE5ICBEZWFu IEphY2tzb24gIDxkaW5vQGFwcGxlLmNvbT4KKworICAgICAgICBGb2xsb3cgV2ViVlRUIGxpbmUg YnJlYWtpbmcgcnVsZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTEwNTQ5NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFdlYlZUVCByZXF1aXJlcyB0aGF0IGNhcHRpb25zIG5ldmVyIG92ZXJmbG93IHRoZWly IGNvbnRhaW5lcnMuIEluIG90aGVyCisgICAgICAgIHdvcmRzLCB0aGF0IGl0IGlzIG9rIHRvIGJy ZWFrIHdpdGhpbiB3b3JkcyByYXRoZXIgdGhhbiBoaWRlIGNvbnRlbnQuCisgICAgICAgIEltcGxl bWVudCB0aGlzIGJ5IHVzaW5nIENTUydzIHdvcmQtYnJlYWsgcHJvcGVydHkuCisKKyAgICAgICAg VGVzdDogbWVkaWEvdHJhY2svdHJhY2std29yZC1icmVha2luZy5odG1sCisKKyAgICAgICAgKiBj c3MvbWVkaWFDb250cm9scy5jc3M6CisgICAgICAgICh2aWRlbzo6LXdlYmtpdC1tZWRpYS10ZXh0 LXRyYWNrLWNvbnRhaW5lcik6IEFkZCB3b3JkLWJyZWFrLgorICAgICAgICAqIGNzcy9tZWRpYUNv bnRyb2xzUXVpY2tUaW1lLmNzczogRHJpdmUtYnkgY2xlYW51cCB0byBtYWtlIHN1cmUgc2VsZWN0 aW9uIGRvZXNuJ3QgaGFwcGVuLgorICAgICAgICAoYXVkaW86Oi13ZWJraXQtbWVkaWEtY29udHJv bHMtY2xvc2VkLWNhcHRpb25zLWNvbnRhaW5lciwgdmlkZW86Oi13ZWJraXQtbWVkaWEtY29udHJv bHMtY2xvc2VkLWNhcHRpb25zLWNvbnRhaW5lcik6CisgICAgICAgIChhdWRpbzo6LXdlYmtpdC1t ZWRpYS1jb250cm9scy1jbG9zZWQtY2FwdGlvbnMtdHJhY2stbGlzdCwgdmlkZW86Oi13ZWJraXQt bWVkaWEtY29udHJvbHMtY2xvc2VkLWNhcHRpb25zLXRyYWNrLWxpc3QpOgorCiAyMDEyLTEyLTE5 ICBFbWlsIEEgRWtsdW5kICA8ZWFlQGNocm9taXVtLm9yZz4KIAogICAgICAgICBbUmVncmVzc2lv bl0gdGV4dC1vdmVyZmxvdyBlbGxpcHNpcyBjbGlwcyBjb250ZW50IHdoZW4gem9vbWVkCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9jc3MvbWVkaWFDb250cm9scy5jc3MgYi9Tb3VyY2UvV2Vi Q29yZS9jc3MvbWVkaWFDb250cm9scy5jc3MKaW5kZXggMDBlZmNiYmE2NWQ0NGFhMGIzMTY5MjYw MTYwYWQ2MDE5MzU0MjAxMC4uMTM4ZmYxZGU2ZDJkYzZhNjJiNDRjNWM1M2QwNWY3YWNkNDAxYmI2 OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvY3NzL21lZGlhQ29udHJvbHMuY3NzCisrKyBi L1NvdXJjZS9XZWJDb3JlL2Nzcy9tZWRpYUNvbnRyb2xzLmNzcwpAQCAtMjMzLDYgKzIzMyw3IEBA IHZpZGVvOjotd2Via2l0LW1lZGlhLXRleHQtdHJhY2stY29udGFpbmVyIHsKICAgICB0ZXh0LWRl Y29yYXRpb246IG5vbmU7CiAgICAgcG9pbnRlci1ldmVudHM6IG5vbmU7CiAgICAgLXdlYmtpdC11 c2VyLXNlbGVjdDogbm9uZTsKKyAgICB3b3JkLWJyZWFrOiBicmVhay13b3JkOwogCiAgICAgLXdl YmtpdC1ib3gtZmxleDogMTsKIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9tZWRp YUNvbnRyb2xzUXVpY2tUaW1lLmNzcyBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9tZWRpYUNvbnRyb2xz UXVpY2tUaW1lLmNzcwppbmRleCAwMDc1ZTJjZmI5YzAwMmFjZWQ4MGFlZmYxMTIyNDk2MGVjYjE5 ZGYzLi5hYjU1Y2ZmZTkxN2M1YmYzYjUyMjYwMzE5N2I2NGMxZWI0ZDg5YTAyIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9jc3MvbWVkaWFDb250cm9sc1F1aWNrVGltZS5jc3MKKysrIGIvU291 cmNlL1dlYkNvcmUvY3NzL21lZGlhQ29udHJvbHNRdWlja1RpbWUuY3NzCkBAIC0yNTIsNiArMjUy LDcgQEAgYXVkaW86Oi13ZWJraXQtbWVkaWEtY29udHJvbHMtY2xvc2VkLWNhcHRpb25zLWNvbnRh aW5lciwgdmlkZW86Oi13ZWJraXQtbWVkaWEtY28KICAgICBiYWNrZ3JvdW5kLWNvbG9yOiByZ2Jh KDAsIDAsIDAsIDAuODUpOwogICAgIGJvcmRlcjogMXB4IHNvbGlkIHJnYig2NiwgNjYsIDY2KTsK ICAgICBib3JkZXItcmFkaXVzOiA4cHg7CisgICAgY3Vyc29yOiBkZWZhdWx0OwogfQogCiBhdWRp bzo6LXdlYmtpdC1tZWRpYS1jb250cm9scy1jbG9zZWQtY2FwdGlvbnMtdHJhY2stbGlzdCwgdmlk ZW86Oi13ZWJraXQtbWVkaWEtY29udHJvbHMtY2xvc2VkLWNhcHRpb25zLXRyYWNrLWxpc3QgewpA QCAtMjY4LDYgKzI2OSw3IEBAIGF1ZGlvOjotd2Via2l0LW1lZGlhLWNvbnRyb2xzLWNsb3NlZC1j YXB0aW9ucy10cmFjay1saXN0LCB2aWRlbzo6LXdlYmtpdC1tZWRpYS1jCiAgICAgZm9udC1mYW1p bHk6ICJIZWx2ZXRpY2EgQm9sZCIsICJIZWx2ZXRpY2EiOwogICAgIGZvbnQtd2VpZ2h0OiBib2xk OwogICAgIGZvbnQtc2l6ZTogOXB0OworICAgIC13ZWJraXQtdXNlci1zZWxlY3Q6IG5vbmU7CiB9 CiAKIGF1ZGlvOjotd2Via2l0LW1lZGlhLWNvbnRyb2xzLWNsb3NlZC1jYXB0aW9ucy10cmFjay1s aXN0IGgzLApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCmluZGV4IDRlM2IzYjBiZDU0N2E2MGY0YWVjYzRhOTUwMzJkZDBjOTk5NTY0Y2Eu LjYwMTk3YTA1YWNmNmU2ZWE5NDAzZjc5ZmE5YWJlNzUzYThlODgyYzUgMTAwNjQ0Ci0tLSBhL0xh eW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyAr MSwyMCBAQAorMjAxMi0xMi0xOSAgRGVhbiBKYWNrc29uICA8ZGlub0BhcHBsZS5jb20+CisKKyAg ICAgICAgRm9sbG93IFdlYlZUVCBsaW5lIGJyZWFraW5nIHJ1bGVzCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDU0OTYKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUZXN0IHRoYXQgY2FwdGlvbnMgZG8gZW1l cmdlbmN5IGxpbmUgYnJlYWtpbmcuIFNpbmNlIHdlIGNhbid0CisgICAgICAgIHJlbHkgb24gdGV4 dCBkaW1lbnNpb25zLCB0aGUgdGVzdCBzaW1wbHkgY29tcGFyZXMgYSBjYXB0aW9uIHRoYXQKKyAg ICAgICAgd2lsbCBiZSBvbiBvbmUgbGluZSB0byBhIGNhcHRpb24gd2l0aCBhIHNpbmdsZSBodWdl IHdvcmQsIHRoYXQgbXVzdAorICAgICAgICBicmVhayBhdCBsZWFzdCB0d2ljZS4gSWYgdGhlIGJv dW5kaW5nIHJlY3RhbmdsZSBvZiB0aGUgc2Vjb25kIGNhcHRpb24KKyAgICAgICAgaXMgYmlnZ2Vy IHRoYW4gdGhlIGZpcnN0LCB3ZSBrbm93IHdlIGJyb2tlLgorCisgICAgICAgICogbWVkaWEvdHJh Y2svY2FwdGlvbnMtd2VidnR0L2xvbmctd29yZC52dHQ6IEFkZGVkLgorICAgICAgICAqIG1lZGlh L3RyYWNrL3RyYWNrLXdvcmQtYnJlYWtpbmctZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAg KiBtZWRpYS90cmFjay90cmFjay13b3JkLWJyZWFraW5nLmh0bWw6IEFkZGVkLgorCiAyMDEyLTEy LTE5ICBXLiBKYW1lcyBNYWNMZWFuICA8d2ptYWNsZWFuQGNocm9taXVtLm9yZz4KIAogICAgICAg ICBbY2hyb21pdW1dIHBsdWdpbnMvbnBwLXNldC13aW5kb3ctY2FsbGVkLWR1cmluZy1kZXN0cnVj dGlvbi5odG1sIGlzIGZsYWt5IG9uIFdpbgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvbWVkaWEv dHJhY2svY2FwdGlvbnMtd2VidnR0L2xvbmctd29yZC52dHQgYi9MYXlvdXRUZXN0cy9tZWRpYS90 cmFjay9jYXB0aW9ucy13ZWJ2dHQvbG9uZy13b3JkLnZ0dApuZXcgZmlsZSBtb2RlIDEwMDY0NApp bmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi5kNTQ4YjdkOGY0 YTA4N2E5NGQ0MzBlMDVjZjdhYjc5YzdlNmJkMTBmCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0 VGVzdHMvbWVkaWEvdHJhY2svY2FwdGlvbnMtd2VidnR0L2xvbmctd29yZC52dHQKQEAgLTAsMCAr MSw5IEBACitXRUJWVFQKKworMQorMDA6MDA6MDAuMDAwIC0tPiAwMDowMDowMi4wMDAKK2ZpcnN0 IGNhcHRpb24KKworMgorMDA6MDA6MDIuMDAwIC0tPiAwMDowMTowMC4wMDAKK21tbW1tbW1tbW1t bW1tbW1tbW1tbW1tbW1tbW1tbW1tbW1tbW1tbW1tbW1tbW1tbW1tbW1tbW1tbW1tbW1tbW1tbW1t bW1tbW1tbW1tbW1tbW1tbW1tbW1tbW1tbW1tbW1tbW1tbW1tbW1tbW1tbW1tbW1tbW1tbW1tbW1t bW1tbW1tbW1tbW1tbW1tbW1tbW1tbW1tbW1tbW1tbW1tbW1tbW1tbW1tbW1tbW1tbW1tbW1tbW1t bW1tbW1tbW1tbW1tbW1tbW1tbW1tbW1tbW1tbW1tbW1tbW1tbW1tbW1tbW1tbW1tbW1tbW1tbW1t bW1tbW1tbW1tbW1tbW1tbW1tbW1tbW1tbW1tbW1tbW1tbW1tbW1tbW1tbW1tbW1tbW1tbW1tbW1t bW1tbW1tbW1tbW1tbW1tbW1tbQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvbWVkaWEvdHJhY2sv dHJhY2std29yZC1icmVha2luZy1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9tZWRpYS90cmFj ay90cmFjay13b3JkLWJyZWFraW5nLWV4cGVjdGVkLnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NApp bmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi45MDA2NzE0NmVh YmU4ZDZjYjU0NzhhNjA4YzU4NTAzMTFhMzlmNGZmCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0 VGVzdHMvbWVkaWEvdHJhY2svdHJhY2std29yZC1icmVha2luZy1leHBlY3RlZC50eHQKQEAgLTAs MCArMSw3IEBACitUZXN0IHRoYXQgbGluZSBicmVha3MgYXJlIGZvcmNlZCBpbiBjYXB0aW9ucy4K K0VWRU5UKGNhbnBsYXl0aHJvdWdoKQorU2luZ2xlIGxpbmUgY2FwdGlvbiBoZWlnaHQgcmVjb3Jk ZWQuCitFVkVOVChzZWVrZWQpCitTZWNvbmQgY2FwdGlvbiB3YXMgbW9yZSB0aGFuIHR3aWNlIGFz IHRhbGwgYXMgZmlyc3QgY2FwdGlvbi4gT0sKK0VORCBPRiBURVNUCisKZGlmZiAtLWdpdCBhL0xh eW91dFRlc3RzL21lZGlhL3RyYWNrL3RyYWNrLXdvcmQtYnJlYWtpbmcuaHRtbCBiL0xheW91dFRl c3RzL21lZGlhL3RyYWNrL3RyYWNrLXdvcmQtYnJlYWtpbmcuaHRtbApuZXcgZmlsZSBtb2RlIDEw MDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi4yMGI4 ZWZkZGY3ODljYzc1OWUxM2QzMDI2YTRmNzdhZGZhNWQyYTAzCi0tLSAvZGV2L251bGwKKysrIGIv TGF5b3V0VGVzdHMvbWVkaWEvdHJhY2svdHJhY2std29yZC1icmVha2luZy5odG1sCkBAIC0wLDAg KzEsNDEgQEAKKzxodG1sPgorICAgIDxoZWFkPgorICAgICAgICA8c2NyaXB0IHNyYz0uLi9tZWRp YS1maWxlLmpzPjwvc2NyaXB0PgorICAgICAgICA8c2NyaXB0IHNyYz0uLi92aWRlby10ZXN0Lmpz Pjwvc2NyaXB0PgorICAgICAgICA8c2NyaXB0IHNyYz0uLi9tZWRpYS1jb250cm9scy5qcz48L3Nj cmlwdD4KKyAgICAgICAgPHNjcmlwdD4KKworICAgICAgICB2YXIgc2luZ2xlTGluZVJlY3Q7CisK KyAgICAgICAgZnVuY3Rpb24gdGVzdFVuYnJlYWthYmxlTGluZSgpCisgICAgICAgIHsKKyAgICAg ICAgICAgIHZhciBtdWx0aUxpbmVSZWN0ID0gdGV4dFRyYWNrRGlzcGxheUVsZW1lbnQodmlkZW8p LmZpcnN0Q2hpbGQuZmlyc3RDaGlsZC5nZXRCb3VuZGluZ0NsaWVudFJlY3QoKTsKKyAgICAgICAg ICAgIHZhciByYXRpbyA9IG11bHRpTGluZVJlY3QuaGVpZ2h0IC8gc2luZ2xlTGluZVJlY3QuaGVp Z2h0OworICAgICAgICAgICAgbG9nUmVzdWx0KHJhdGlvID4gMiwgIlNlY29uZCBjYXB0aW9uIHdh cyBtb3JlIHRoYW4gdHdpY2UgYXMgdGFsbCBhcyBmaXJzdCBjYXB0aW9uLiIpCisgICAgICAgICAg ICBlbmRUZXN0KCk7CisgICAgICAgIH0KKworICAgICAgICBmdW5jdGlvbiB0ZXN0U2luZ2xlTGlu ZSgpCisgICAgICAgIHsKKyAgICAgICAgICAgIHNpbmdsZUxpbmVSZWN0ID0gdGV4dFRyYWNrRGlz cGxheUVsZW1lbnQodmlkZW8pLmZpcnN0Q2hpbGQuZmlyc3RDaGlsZC5nZXRCb3VuZGluZ0NsaWVu dFJlY3QoKTsKKyAgICAgICAgICAgIGNvbnNvbGVXcml0ZSgiU2luZ2xlIGxpbmUgY2FwdGlvbiBo ZWlnaHQgcmVjb3JkZWQuIik7CisgICAgICAgICAgICB2aWRlby5jdXJyZW50VGltZSA9IDM7Cisg ICAgICAgIH0KKworICAgICAgICBmdW5jdGlvbiBsb2FkZWQoKQorICAgICAgICB7CisgICAgICAg ICAgICBjb25zb2xlV3JpdGUoJ1Rlc3QgdGhhdCBsaW5lIGJyZWFrcyBhcmUgZm9yY2VkIGluIGNh cHRpb25zLicpOworICAgICAgICAgICAgZmluZE1lZGlhRWxlbWVudCgpOworICAgICAgICAgICAg d2FpdEZvckV2ZW50KCdjYW5wbGF5dGhyb3VnaCcsIHRlc3RTaW5nbGVMaW5lKTsKKyAgICAgICAg ICAgIHdhaXRGb3JFdmVudCgnc2Vla2VkJywgdGVzdFVuYnJlYWthYmxlTGluZSk7CisgICAgICAg ICAgICB2aWRlby5zcmMgPSBmaW5kTWVkaWFGaWxlKCd2aWRlbycsICcuLi9jb250ZW50L3Rlc3Qn KTsKKyAgICAgICAgfQorCisgICAgICAgIDwvc2NyaXB0PgorICAgIDwvaGVhZD4KKyAgICA8Ym9k eSBvbmxvYWQ9ImxvYWRlZCgpIj4KKyAgICAgICAgPHZpZGVvIGNvbnRyb2xzID4KKyAgICAgICAg ICAgIDx0cmFjayBzcmM9ImNhcHRpb25zLXdlYnZ0dC9sb25nLXdvcmQudnR0IiBraW5kPSJjYXB0 aW9ucyIgZGVmYXVsdD4KKyAgICAgICAgPC92aWRlbz4KKyAgICA8L2JvZHk+Cis8L2h0bWw+Cg==