105478 2012-12-19 16:44:19 -0800 Implemet :lang() pseudo class support for the WebVTT ::cue pseudo element 2013-02-04 13:37:21 -0800 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 43668 0 dgorbik webkit-unassigned allan.jensen cmarcelo eric.carlson feature-media-reviews koivisto macpherson menard ojan.autocc silviapf vcarbune webkit-bug-importer webkit.review.bot oldest_to_newest 795038 0 dgorbik 2012-12-19 16:44:19 -0800 "For the purposes of the :lang() pseudo-class, WebVTT Internal Node Objects have the language described as the WebVTT Node Object's applicable language." http://dev.w3.org/html5/webvtt/#the-'::cue'-pseudo-element 795039 1 webkit-bug-importer 2012-12-19 16:47:43 -0800 <rdar://problem/12914550> 823532 2 186209 dgorbik 2013-02-01 20:46:41 -0800 Created attachment 186209 Proposed fix 0.1 823552 3 silviapf 2013-02-01 22:18:07 -0800 You're mistaken. <lang> is an actual element in WebVTT and not a pseudo-element. It's similar to <b>, <c>, <u> etc in that way. See http://dev.w3.org/html5/webvtt/#webvtt-cue-language-span . Your example should not be: ::cue(:lang(ru)) { color: lime; } ::cue(:lang(en)) { color: purple; } But rather: ::cue(lang[lang="ru"]) { color: lime; } ::cue(lang[lang="en"]) { color: purple; } 823553 4 silviapf 2013-02-01 22:20:11 -0800 Ha, I totally missed that there is also a :lang() pseudo-class - apologies! That's great! 823556 5 silviapf 2013-02-01 22:28:47 -0800 However, I now wonder what the other part of that example means: ::cue(c[lang="ru"]) { color: red; } ::cue(c[lang="en"]) { color: green; } As I understand it, the <c> tag in WebVTT does not have a lang attribute. The lang attribute is only defined on the <lang> element. I believe it might be caused by a typo in the table in http://dev.w3.org/html5/webvtt/#webvtt-cue-language-span . I've just registered https://www.w3.org/Bugs/Public/show_bug.cgi?id=20852 . 823561 6 dgorbik 2013-02-01 22:52:42 -0800 (In reply to comment #5) > However, I now wonder what the other part of that example means: > > ::cue(c[lang="ru"]) { color: red; } > ::cue(c[lang="en"]) { color: green; } > > As I understand it, the <c> tag in WebVTT does not have a lang attribute. The lang attribute is only defined on the <lang> element. > > I believe it might be caused by a typo in the table in http://dev.w3.org/html5/webvtt/#webvtt-cue-language-span . I've just registered https://www.w3.org/Bugs/Public/show_bug.cgi?id=20852 . Hm, interesting. It really looks like only webvtt lang objects have the 'lang' attribute. And I should store the language for those elements internally so that it's only accessible by using this :lang pseudo-class. But why can't we have a lang attribute for all elements? Is this something we should discuss? 823562 7 dgorbik 2013-02-01 22:55:11 -0800 (In reply to comment #5) > I believe it might be caused by a typo in the table in http://dev.w3.org/html5/webvtt/#webvtt-cue-language-span . I've just registered https://www.w3.org/Bugs/Public/show_bug.cgi?id=20852 . Yes, you are right! This part was confusing as well. :) 823566 8 silviapf 2013-02-01 23:06:06 -0800 (In reply to comment #6) >But why can't we have a lang attribute for all elements? Is this something we should discuss? It's not like in HTML where all elements have a @lang attribute. The intention is that a section (span? ;-) of text in a cue can be given in a different language to the default language of the file (which is somewhat specified in the @srclang attribute of <track>). It doesn't really make sense to have a bold section in a different language, or a class section - language is not bound to another element. More at https://www.w3.org/Bugs/Public/show_bug.cgi?id=15922 which led to the introduction of <lang> That reminds me to register a bug to actually have a default language for the file... 823568 9 silviapf 2013-02-01 23:14:14 -0800 I've registered https://www.w3.org/Bugs/Public/show_bug.cgi?id=20853 . I'll leave the lang([lang="xx"]) bug on WebKit to you. Thanks for all this great work on getting CSS styling for WebVTT! 823572 10 dgorbik 2013-02-01 23:40:49 -0800 (In reply to comment #9) > I've registered https://www.w3.org/Bugs/Public/show_bug.cgi?id=20853 . I'll leave the lang([lang="xx"]) bug on WebKit to you. Thanks for all this great work on getting CSS styling for WebVTT! Yeah, I will have to fix this separately, because it was introduced before in https://bugs.webkit.org/show_bug.cgi?id=107907. Thanks for the feedback, it's really helpful! 824670 11 186209 webkit.review.bot 2013-02-04 13:02:02 -0800 Comment on attachment 186209 Proposed fix 0.1 Clearing flags on attachment: 186209 Committed r141795: <http://trac.webkit.org/changeset/141795> 824672 12 webkit.review.bot 2013-02-04 13:02:08 -0800 All reviewed patches have been landed. Closing bug. 824689 13 186209 darin 2013-02-04 13:15:08 -0800 Comment on attachment 186209 Proposed fix 0.1 View in context: https://bugs.webkit.org/attachment.cgi?id=186209&action=review > Source/WebCore/css/SelectorChecker.cpp:825 > + value = element->getAttribute(langAttr); Should probably be fastGetAttribute. Are we guaranteed that there is always a lang attribute in WebVTT? Would we ever want to compute the inherited language instead? Is there a way to factor this so we don’t have to put this code into CSS? Maybe a virtual function? 824710 14 dgorbik 2013-02-04 13:37:21 -0800 (In reply to comment #13) > (From update of attachment 186209 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=186209&action=review > > > Source/WebCore/css/SelectorChecker.cpp:825 > > + value = element->getAttribute(langAttr); > > Should probably be fastGetAttribute. > > Are we guaranteed that there is always a lang attribute in WebVTT? Would we ever want to compute the inherited language instead? > > Is there a way to factor this so we don’t have to put this code into CSS? Maybe a virtual function? According to specs lang attribute should only exist for lang webvtt objects. We should store the language internally to all other nodes, so we will not get this attribute. This is something I have to modify soon. Specs also require to precalculate on the parsing stage so we probably will never do it the same way as we do for html elements. Renaming computeInheritedLanguage() function and making it virtual is a good idea, I will do that. 186209 2013-02-01 20:46:41 -0800 2013-02-04 13:15:08 -0800 Proposed fix 0.1 patch text/plain 4783 dgorbik ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBhNTRiMzNhLi44NDRmZWFiIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTMtMDIt MDEgIERpbWEgR29yYmlrICA8ZGdvcmJpa0BhcHBsZS5jb20+CisKKyAgICAgICAgSW1wbGVtZXQg OmxhbmcoKSBwc2V1ZG8gY2xhc3Mgc3VwcG9ydCBmb3IgdGhlIFdlYlZUVCA6OmN1ZSBwc2V1ZG8g ZWxlbWVudAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTA1NDc4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiBtZWRpYS90cmFjay9jYXB0aW9ucy13ZWJ2dHQvc3R5bGluZy1sYW5nLnZ0dDoKKyAgICAgICAg KiBtZWRpYS90cmFjay90cmFjay1jc3MtbWF0Y2hpbmctbGFuZy1leHBlY3RlZC50eHQ6CisgICAg ICAgICogbWVkaWEvdHJhY2svdHJhY2stY3NzLW1hdGNoaW5nLWxhbmcuaHRtbDoKKwogMjAxMy0w Mi0wMSAgQ2hyaXN0aWFuIEJpZXNpbmdlciAgPGNiaWVzaW5nZXJAY2hyb21pdW0ub3JnPgogCiAg ICAgICAgIFJlYmFzZWxpbmUgdGVzdHMgYWZ0ZXIgYnVnIDkyMjEKZGlmZiAtLWdpdCBhL0xheW91 dFRlc3RzL21lZGlhL3RyYWNrL2NhcHRpb25zLXdlYnZ0dC9zdHlsaW5nLWxhbmcudnR0IGIvTGF5 b3V0VGVzdHMvbWVkaWEvdHJhY2svY2FwdGlvbnMtd2VidnR0L3N0eWxpbmctbGFuZy52dHQKaW5k ZXggNjNlZGE5Ni4uZTdkMDkxYSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvbWVkaWEvdHJhY2sv Y2FwdGlvbnMtd2VidnR0L3N0eWxpbmctbGFuZy52dHQKKysrIGIvTGF5b3V0VGVzdHMvbWVkaWEv dHJhY2svY2FwdGlvbnMtd2VidnR0L3N0eWxpbmctbGFuZy52dHQKQEAgLTEsNSArMSw5IEBACiBX RUJWVFQKIAogMQotMDA6MDAuMDAwIC0tPiAwMDowMS4wMDAKKzAwOjAwLjAwMCAtLT4gMDA6MDAu NTAwCiA8bGFuZyBlbj48Yz5FbmdsaXNoPGxhbmcgcnU+PGM+INCg0YPRgdGB0LrQuNC5PGxhbmcg ZW4+PGM+IEVuZ2xpc2ggYWdhaW48L2M+PC9sYW5nPjwvYz48L2xhbmc+PC9jPjwvbGFuZz4KKwor MgorMDA6MDAuNTAwIC0tPiAwMDowMS4wMDAKKzxsYW5nIGVuPjxpPkVuZ2xpc2g8bGFuZyBydT48 Yj4g0KDRg9GB0YHQutC40Lk8bGFuZyBlbj48dT4gRW5nbGlzaCBhZ2FpbjwvdT48L2xhbmc+PC9i PjwvbGFuZz48L2k+PC9sYW5nPgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvbWVkaWEvdHJhY2sv dHJhY2stY3NzLW1hdGNoaW5nLWxhbmctZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvbWVkaWEv dHJhY2svdHJhY2stY3NzLW1hdGNoaW5nLWxhbmctZXhwZWN0ZWQudHh0CmluZGV4IGMyMDgzZDQu LjAzNTc4ZmMgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL21lZGlhL3RyYWNrL3RyYWNrLWNzcy1t YXRjaGluZy1sYW5nLWV4cGVjdGVkLnR4dAorKysgYi9MYXlvdXRUZXN0cy9tZWRpYS90cmFjay90 cmFjay1jc3MtbWF0Y2hpbmctbGFuZy1leHBlY3RlZC50eHQKQEAgLTQsNSArNCwxMSBAQCBFVkVO VChzZWVrZWQpCiBFWFBFQ1RFRCAoZ2V0Q29tcHV0ZWRTdHlsZShjdWVOb2RlKS5jb2xvciA9PSAn cmdiKDAsIDEyOCwgMCknKSBPSwogRVhQRUNURUQgKGdldENvbXB1dGVkU3R5bGUoY3VlTm9kZSku Y29sb3IgPT0gJ3JnYigyNTUsIDAsIDApJykgT0sKIEVYUEVDVEVEIChnZXRDb21wdXRlZFN0eWxl KGN1ZU5vZGUpLmNvbG9yID09ICdyZ2IoMCwgMTI4LCAwKScpIE9LCisKK1JVTih2aWRlby5jdXJy ZW50VGltZSA9IDAuNikKK0VWRU5UKHNlZWtlZCkKK0VYUEVDVEVEIChnZXRDb21wdXRlZFN0eWxl KGN1ZU5vZGUpLmNvbG9yID09ICdyZ2IoMTI4LCAwLCAxMjgpJykgT0sKK0VYUEVDVEVEIChnZXRD b21wdXRlZFN0eWxlKGN1ZU5vZGUpLmNvbG9yID09ICdyZ2IoMCwgMjU1LCAwKScpIE9LCitFWFBF Q1RFRCAoZ2V0Q29tcHV0ZWRTdHlsZShjdWVOb2RlKS5jb2xvciA9PSAncmdiKDEyOCwgMCwgMTI4 KScpIE9LCiBFTkQgT0YgVEVTVAogCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9tZWRpYS90cmFj ay90cmFjay1jc3MtbWF0Y2hpbmctbGFuZy5odG1sIGIvTGF5b3V0VGVzdHMvbWVkaWEvdHJhY2sv dHJhY2stY3NzLW1hdGNoaW5nLWxhbmcuaHRtbAppbmRleCA4NWU4NGM5Li5mYmVlOTI5IDEwMDY0 NAotLS0gYS9MYXlvdXRUZXN0cy9tZWRpYS90cmFjay90cmFjay1jc3MtbWF0Y2hpbmctbGFuZy5o dG1sCisrKyBiL0xheW91dFRlc3RzL21lZGlhL3RyYWNrL3RyYWNrLWNzcy1tYXRjaGluZy1sYW5n Lmh0bWwKQEAgLTgsNiArOCw4IEBACiAgICAgICAgIDxzY3JpcHQgc3JjPS4uL21lZGlhLWNvbnRy b2xzLmpzPjwvc2NyaXB0PgogCiAgICAgICAgIDxzdHlsZT4KKyAgICAgICAgOjpjdWUoOmxhbmco cnUpKSB7IGNvbG9yOiBsaW1lOyB9CisgICAgICAgIDo6Y3VlKDpsYW5nKGVuKSkgeyBjb2xvcjog cHVycGxlOyB9CiAgICAgICAgIDo6Y3VlKGNbbGFuZz0icnUiXSkgeyBjb2xvcjogcmVkOyB9CiAg ICAgICAgIDo6Y3VlKGNbbGFuZz0iZW4iXSkgeyBjb2xvcjogZ3JlZW47IH0KICAgICAgICAgPC9z dHlsZT4KQEAgLTE2LDkgKzE4LDEwIEBACiAKICAgICAgICAgdmFyIGN1ZU5vZGU7CiAgICAgICAg IHZhciBzZWVrZWRDb3VudCA9IDA7Ci0gICAgICAgIHZhciBzZWVrVGltZXMgPSBbMC4xXTsKKyAg ICAgICAgdmFyIHNlZWtUaW1lcyA9IFswLjEsIDAuNl07CiAKLSAgICAgICAgdmFyIGluZm8gPSBb WyJyZ2IoMCwgMTI4LCAwKSIsICJyZ2IoMjU1LCAwLCAwKSIsICJyZ2IoMCwgMTI4LCAwKSJdXTsK KyAgICAgICAgdmFyIGluZm8gPSBbWyJyZ2IoMCwgMTI4LCAwKSIsICJyZ2IoMjU1LCAwLCAwKSIs ICJyZ2IoMCwgMTI4LCAwKSJdLAorICAgICAgICAgICAgICAgICAgICBbInJnYigxMjgsIDAsIDEy OCkiLCAicmdiKDAsIDI1NSwgMCkiLCAicmdiKDEyOCwgMCwgMTI4KSJdXTsKIAogICAgICAgICBm dW5jdGlvbiBzZWVrZWQoKQogICAgICAgICB7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjkxZDNjZi4uZjI0OGRk ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEzLTAyLTAxICBEaW1hIEdvcmJpayAg PGRnb3JiaWtAYXBwbGUuY29tPgorCisgICAgICAgIEltcGxlbWV0IDpsYW5nKCkgcHNldWRvIGNs YXNzIHN1cHBvcnQgZm9yIHRoZSBXZWJWVFQgOjpjdWUgcHNldWRvIGVsZW1lbnQKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNTQ3OAorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEluIFdlYlZUVCBsYW5nIGlz IHByZXByb2Nlc3NlZCBhbmQgc3RvcmVkIGluIHRoZSBsYW5nIGF0dHJpYnV0ZSBvZiB0aGUgZWxl bWVudCwgCisgICAgICAgIHNvIHdlIGFjY2VzcyBpdCBpbnN0ZWFkIG9mIHdhbGtpbmcgdXAgdGhl IHRyZWUgdGhlIHdheSBpdCBpcyBkb25lIGluIEhUTUwuCisKKyAgICAgICAgRXhpc3RpbmcgdGVz dHMgd2VyZSBtb2RpZmllZCB0byBjb3ZlciB0aGlzIGNhc2UuCisKKyAgICAgICAgKiBjc3MvU2Vs ZWN0b3JDaGVja2VyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNlbGVjdG9yQ2hlY2tlcjo6Y2hl Y2tPbmUpOgorCiAyMDEzLTAyLTAxICBSb2dlciBGb25nICA8cm9nZXJfZm9uZ0BhcHBsZS5jb20+ CiAKICAgICAgICAgVW5yZXZpZXdlZC4gQ2xlYW4gdXAgV2ViQ29yZSBWUzIwMTAgcHJvamVjdC4K ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9TZWxlY3RvckNoZWNrZXIuY3BwIGIvU291 cmNlL1dlYkNvcmUvY3NzL1NlbGVjdG9yQ2hlY2tlci5jcHAKaW5kZXggZmFiNzA0OS4uM2NhNjRk ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvY3NzL1NlbGVjdG9yQ2hlY2tlci5jcHAKKysr IGIvU291cmNlL1dlYkNvcmUvY3NzL1NlbGVjdG9yQ2hlY2tlci5jcHAKQEAgLTgxOSw3ICs4MTks MTMgQEAgYm9vbCBTZWxlY3RvckNoZWNrZXI6OmNoZWNrT25lKGNvbnN0IFNlbGVjdG9yQ2hlY2tp bmdDb250ZXh0JiBjb250ZXh0LCBjb25zdCBTaWIKICAgICAgICAgICAgIGJyZWFrOwogICAgICAg ICBjYXNlIENTU1NlbGVjdG9yOjpQc2V1ZG9MYW5nOgogICAgICAgICAgICAgewotICAgICAgICAg ICAgICAgIEF0b21pY1N0cmluZyB2YWx1ZSA9IGVsZW1lbnQtPmNvbXB1dGVJbmhlcml0ZWRMYW5n dWFnZSgpOworICAgICAgICAgICAgICAgIEF0b21pY1N0cmluZyB2YWx1ZTsKKyNpZiBFTkFCTEUo VklERU9fVFJBQ0spCisgICAgICAgICAgICAgICAgaWYgKGVsZW1lbnQtPmlzV2ViVlRURWxlbWVu dCgpKQorICAgICAgICAgICAgICAgICAgICB2YWx1ZSA9IGVsZW1lbnQtPmdldEF0dHJpYnV0ZShs YW5nQXR0cik7CisgICAgICAgICAgICAgICAgZWxzZQorI2VuZGlmCisgICAgICAgICAgICAgICAg ICAgIHZhbHVlID0gZWxlbWVudC0+Y29tcHV0ZUluaGVyaXRlZExhbmd1YWdlKCk7CiAgICAgICAg ICAgICAgICAgY29uc3QgQXRvbWljU3RyaW5nJiBhcmd1bWVudCA9IHNlbGVjdG9yLT5hcmd1bWVu dCgpOwogICAgICAgICAgICAgICAgIGlmICh2YWx1ZS5pc0VtcHR5KCkgfHwgIXZhbHVlLnN0YXJ0 c1dpdGgoYXJndW1lbnQsIGZhbHNlKSkKICAgICAgICAgICAgICAgICAgICAgYnJlYWs7Cg==