105474 2012-12-19 16:01:43 -0800 [Shadow DOM] Inserting a shadow host into its own shadow crashes 2013-01-06 20:56:49 -0800 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED DUPLICATE 105066 data:text/html,<body><script>var s = document.body.webkitCreateShadowRoot(); s.appendChild(document.body);</script> P2 Normal --- 97279 1 dominicc shinyak adamk dominicc morrita ojan.autocc shinyak webcomponents-bugzilla webkit.review.bot oldest_to_newest 795013 0 dominicc 2012-12-19 16:01:43 -0800 I am not sure what the correct semantics are, but I think this should throw a DOM hierarchy exception. 797073 1 180695 shinyak 2012-12-24 18:56:52 -0800 Created attachment 180695 Patch 797147 2 180695 dominicc 2012-12-25 06:06:32 -0800 Comment on attachment 180695 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=180695&action=review This looks right to me. > LayoutTests/fast/dom/shadow/inserting-shadowroot-to-its-host.html:2 > +<html> You could omit open and close html and maybe body tags – I don’t think js-test-pre.js synchronously touches body > LayoutTests/fast/dom/shadow/inserting-shadowroot-to-its-host.html:22 > +container.innerHTML = ""; Be consistent about ' for string literals. 800937 3 180695 dglazkov 2013-01-05 11:23:26 -0800 Comment on attachment 180695 Patch Please address Dominic's comments. 801146 4 shinyak 2013-01-06 20:56:49 -0800 http://trac.webkit.org/changeset/138730 has fixed this issue already. *** This bug has been marked as a duplicate of bug 105066 *** 180695 2012-12-24 18:56:52 -0800 2013-01-05 11:23:26 -0800 Patch bug-105474-20121225115405.patch text/plain 4932 shinyak U3VidmVyc2lvbiBSZXZpc2lvbjogMTM4NDQ3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjQ2MmFhNTAxODAxYTk4 MjY1MWUxNjljOTFiZTUzNzg3OGU1ODAxZS4uNDk3ODc2OTlmYzFhN2FmNWZhODQxN2RkODNjOGU2 NGEwOTI1ZmE4NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTEyLTI0ICBTaGlu eWEgS2F3YW5ha2EgIDxzaGlueWFrQGNocm9taXVtLm9yZz4KKworICAgICAgICBJbnNlcnRpbmcg YSBzaGFkb3cgaG9zdCBpbnRvIGl0cyBvd24gc2hhZG93IGNyYXNoZXMKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNTQ3NAorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdoZW4gaW5zZXJ0aW5nIGEgbm9kZSBp bnRvIGFuIGVsZW1lbnQsIHdlJ3JlIGNoZWNraW5nIGEgY2lyY3VsYXRpb24gaXMgbm90IGNyZWF0 ZWQuCisgICAgICAgIEhvd2V2ZXIsIHdlIGRpZG4ndCBjaGVjayBzaGFkb3cgdHJlZXMgaGVyZS4g V2Ugc2hvdWxkIGNoZWNrIHNoYWRvdyB0cmVlcyBhbHNvLgorCisgICAgICAgIFRlc3Q6IGZhc3Qv ZG9tL3NoYWRvdy9pbnNlcnRpbmctc2hhZG93cm9vdC10by1pdHMtaG9zdC5odG1sCisKKyAgICAg ICAgKiBkb20vQ29udGFpbmVyTm9kZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpjaGVja0FjY2Vw dENoaWxkKToKKyAgICAgICAgKFdlYkNvcmU6OmNoZWNrQWNjZXB0Q2hpbGRHdWFyYW50ZWVkTm9k ZVR5cGVzKToKKwogMjAxMi0xMi0yNCAgVGlhbmNoZW5nIEppYW5nICA8dGlqaWFuZ0ByaW0uY29t PgogCiAgICAgICAgIFVwZGF0ZSBCQjEwIG1lZGlhIHJlbmRlciB0aGVtZS4KZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL2RvbS9Db250YWluZXJOb2RlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2Rv bS9Db250YWluZXJOb2RlLmNwcAppbmRleCA3NWZkNzA0MTIzMTc2ZDkwZjEyZGQ5NDg1NGMzYmE5 Njk1MDhiZjQ3Li42MjE4OWEyODk5YzhkOGRjZDRmOTk0NDg4NWNkYWQyODIxM2M4OTMxIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vQ29udGFpbmVyTm9kZS5jcHAKKysrIGIvU291cmNl L1dlYkNvcmUvZG9tL0NvbnRhaW5lck5vZGUuY3BwCkBAIC0xNDgsNyArMTQ4LDcgQEAgc3RhdGlj IGlubGluZSBFeGNlcHRpb25Db2RlIGNoZWNrQWNjZXB0Q2hpbGQoQ29udGFpbmVyTm9kZSogbmV3 UGFyZW50LCBOb2RlKiBuZXcKICAgICAgICAgQVNTRVJUKCFuZXdQYXJlbnQtPmlzUmVhZE9ubHlO b2RlKCkpOwogICAgICAgICBBU1NFUlQoIW5ld1BhcmVudC0+aXNEb2N1bWVudFR5cGVOb2RlKCkp OwogICAgICAgICBBU1NFUlQoaXNDaGlsZFR5cGVBbGxvd2VkKG5ld1BhcmVudCwgbmV3Q2hpbGQp KTsKLSAgICAgICAgaWYgKG5ld0NoaWxkLT5jb250YWlucyhuZXdQYXJlbnQpKQorICAgICAgICBp ZiAobmV3Q2hpbGQtPmNvbnRhaW5zSW5jbHVkaW5nU2hhZG93RE9NKG5ld1BhcmVudCkpCiAgICAg ICAgICAgICByZXR1cm4gSElFUkFSQ0hZX1JFUVVFU1RfRVJSOwogICAgICAgICByZXR1cm4gMDsK ICAgICB9CkBAIC0xNjIsNyArMTYyLDcgQEAgc3RhdGljIGlubGluZSBFeGNlcHRpb25Db2RlIGNo ZWNrQWNjZXB0Q2hpbGQoQ29udGFpbmVyTm9kZSogbmV3UGFyZW50LCBOb2RlKiBuZXcKICAgICAg ICAgcmV0dXJuIE5PX01PRElGSUNBVElPTl9BTExPV0VEX0VSUjsKICAgICBpZiAobmV3Q2hpbGQt PmluRG9jdW1lbnQoKSAmJiBuZXdDaGlsZC0+aXNEb2N1bWVudFR5cGVOb2RlKCkpCiAgICAgICAg IHJldHVybiBISUVSQVJDSFlfUkVRVUVTVF9FUlI7Ci0gICAgaWYgKG5ld0NoaWxkLT5jb250YWlu cyhuZXdQYXJlbnQpKQorICAgIGlmIChuZXdDaGlsZC0+Y29udGFpbnNJbmNsdWRpbmdTaGFkb3dE T00obmV3UGFyZW50KSkKICAgICAgICAgcmV0dXJuIEhJRVJBUkNIWV9SRVFVRVNUX0VSUjsKIAog ICAgIGlmIChvbGRDaGlsZCAmJiBuZXdQYXJlbnQtPmlzRG9jdW1lbnROb2RlKCkpIHsKQEAgLTE3 OSw3ICsxNzksNyBAQCBzdGF0aWMgaW5saW5lIGJvb2wgY2hlY2tBY2NlcHRDaGlsZEd1YXJhbnRl ZWROb2RlVHlwZXMoQ29udGFpbmVyTm9kZSogbmV3UGFyZW50LAogICAgIEFTU0VSVCghbmV3UGFy ZW50LT5pc1JlYWRPbmx5Tm9kZSgpKTsKICAgICBBU1NFUlQoIW5ld1BhcmVudC0+aXNEb2N1bWVu dFR5cGVOb2RlKCkpOwogICAgIEFTU0VSVChpc0NoaWxkVHlwZUFsbG93ZWQobmV3UGFyZW50LCBu ZXdDaGlsZCkpOwotICAgIGlmIChuZXdDaGlsZC0+Y29udGFpbnMobmV3UGFyZW50KSkgeworICAg IGlmIChuZXdDaGlsZC0+Y29udGFpbnNJbmNsdWRpbmdTaGFkb3dET00obmV3UGFyZW50KSkgewog ICAgICAgICBlYyA9IEhJRVJBUkNIWV9SRVFVRVNUX0VSUjsKICAgICAgICAgcmV0dXJuIGZhbHNl OwogICAgIH0KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwppbmRleCBkYzEwODQ5MWFhMzQ4Y2E2YTdiMjRhMDIwODYwZmZkZmI3ODE2OWFi Li5jY2ZmNDRmZmE3MDI4ZThkNzM1NmM4MGJkMjM3MGViZjQzY2Q0ZGQ5IDEwMDY0NAotLS0gYS9M YXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMg KzEsMTMgQEAKKzIwMTItMTItMjQgIFNoaW55YSBLYXdhbmFrYSAgPHNoaW55YWtAY2hyb21pdW0u b3JnPgorCisgICAgICAgIEluc2VydGluZyBhIHNoYWRvdyBob3N0IGludG8gaXRzIG93biBzaGFk b3cgY3Jhc2hlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTA1NDc0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgKiBmYXN0L2RvbS9zaGFkb3cvaW5zZXJ0aW5nLXNoYWRvd3Jvb3QtdG8taXRzLWhvc3QtZXhw ZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L2RvbS9zaGFkb3cvaW5zZXJ0aW5nLXNo YWRvd3Jvb3QtdG8taXRzLWhvc3QuaHRtbDogQWRkZWQuCisKIDIwMTItMTItMjQgIE1paG5lYSBP dmlkZW5pZSAgPG1paG5lYUBhZG9iZS5jb20+CiAKICAgICAgICAgW0NTUyBSZWdpb25zXSBDb252 ZXJ0IHNvbWUgZmFzdC9yZWdpb25zIHBpeGVsIHRlc3RzIHRvIHJlZnRlc3RzCmRpZmYgLS1naXQg YS9MYXlvdXRUZXN0cy9mYXN0L2RvbS9zaGFkb3cvaW5zZXJ0aW5nLXNoYWRvd3Jvb3QtdG8taXRz LWhvc3QtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvZmFzdC9kb20vc2hhZG93L2luc2VydGlu Zy1zaGFkb3dyb290LXRvLWl0cy1ob3N0LWV4cGVjdGVkLnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0 NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi43MDhkNzJi OTZhMjhjZTdiMWYzNjgzYjA1NjllMjU0NTM2MWNmODU1Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5 b3V0VGVzdHMvZmFzdC9kb20vc2hhZG93L2luc2VydGluZy1zaGFkb3dyb290LXRvLWl0cy1ob3N0 LWV4cGVjdGVkLnR4dApAQCAtMCwwICsxLDggQEAKK1doZW4gaW5zZXJ0aW5nIFNoYWRvd1Jvb3Qg dG8gaXRzIGhvc3QsIGEgY3Jhc2ggc2hvdWxkIG5vdCBoYXBwZW4uCisKK1BBU1Mgc2hhZG93Um9v dC5hcHBlbmRDaGlsZChob3N0KSB0aHJldyBleGNlcHRpb24gRXJyb3I6IEhpZXJhcmNoeVJlcXVl c3RFcnJvcjogRE9NIEV4Y2VwdGlvbiAzLgorUEFTUyBkaXYuYXBwZW5kQ2hpbGQoaG9zdCkgdGhy ZXcgZXhjZXB0aW9uIEVycm9yOiBIaWVyYXJjaHlSZXF1ZXN0RXJyb3I6IERPTSBFeGNlcHRpb24g My4KK1BBU1Mgc3VjY2Vzc2Z1bGx5UGFyc2VkIGlzIHRydWUKKworVEVTVCBDT01QTEVURQorCmRp ZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2RvbS9zaGFkb3cvaW5zZXJ0aW5nLXNoYWRvd3Jv b3QtdG8taXRzLWhvc3QuaHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvZG9tL3NoYWRvdy9pbnNlcnRp bmctc2hhZG93cm9vdC10by1pdHMtaG9zdC5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4 IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLmY5ODU5MTE4NTI4MDg4 MDFiZDA1OTFhZDVmMDU2N2I2MjZiMzc4MDkKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0 cy9mYXN0L2RvbS9zaGFkb3cvaW5zZXJ0aW5nLXNoYWRvd3Jvb3QtdG8taXRzLWhvc3QuaHRtbApA QCAtMCwwICsxLDI3IEBACis8IURPQ1RZUEUgaHRtbD4KKzxodG1sPgorPGJvZHk+Cis8c2NyaXB0 IHNyYz0iLi4vLi4vanMvcmVzb3VyY2VzL2pzLXRlc3QtcHJlLmpzIj48L3NjcmlwdD4KKworPHA+ V2hlbiBpbnNlcnRpbmcgU2hhZG93Um9vdCB0byBpdHMgaG9zdCwgYSBjcmFzaCBzaG91bGQgbm90 IGhhcHBlbi48L3A+CisKKzxkaXYgaWQ9ImNvbnRhaW5lciI+PGRpdiBpZD0iaG9zdCI+PC9kaXY+ PC9kaXY+Cis8cHJlIGlkPSJjb25zb2xlIj48L3ByZT4KKworPHNjcmlwdD4KK2lmICh3aW5kb3cu dGVzdFJ1bm5lcikKKyAgICB0ZXN0UnVubmVyLmR1bXBBc1RleHQoKTsKKwordmFyIHNoYWRvd1Jv b3QgPSBob3N0LndlYmtpdENyZWF0ZVNoYWRvd1Jvb3QoKTsKK3Nob3VsZFRocm93KCdzaGFkb3dS b290LmFwcGVuZENoaWxkKGhvc3QpJyk7CisKK3ZhciBkaXYgPSBkb2N1bWVudC5jcmVhdGVFbGVt ZW50KCdkaXYnKTsKK3NoYWRvd1Jvb3QuYXBwZW5kQ2hpbGQoZGl2KTsKK3Nob3VsZFRocm93KCdk aXYuYXBwZW5kQ2hpbGQoaG9zdCknKTsKKworY29udGFpbmVyLmlubmVySFRNTCA9ICIiOworPC9z Y3JpcHQ+CisKKzxzY3JpcHQgc3JjPSIuLi8uLi9qcy9yZXNvdXJjZXMvanMtdGVzdC1wb3N0Lmpz Ij48L3NjcmlwdD4KKzwvYm9keT4KKzwvaHRtbD4K