105466 2012-12-19 14:52:45 -0800 [CoordinatedGraphics] Layers should be deleted only with a pending flush 2013-06-20 22:28:54 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rafael.lobo rafael.lobo dongseong.hwang jturcotte noam sergio oldest_to_newest 794969 0 rafael.lobo 2012-12-19 14:52:45 -0800 [Coordinated] Layers should be deleted only with a pending flush 794977 1 180232 rafael.lobo 2012-12-19 14:56:40 -0800 Created attachment 180232 Patch 794991 2 rafael.lobo 2012-12-19 15:06:34 -0800 In theory, web process could send its pending delete layer events right before the flush event to ui process, but if the ui process runs a paint in between, it will cause a sync which will run those deletions without the flush, which would be an observable blink. I could not reproduce this sequence of events though, web process seems to send them in a batch of events to ui process, neither the ui process seems to read the incomplete sequence of events. What do you think? 795063 3 180232 dongseong.hwang 2012-12-19 17:31:44 -0800 Comment on attachment 180232 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=180232&action=review Could you check if there is no flash in http://media.24ways.org/2009/14/5/index.html after this patch. And Could you tell me which site flash that this patch fixes. In Bug 103522, I replaced detachedLayer after flushing layer states, because I wanted to fix above site flash. And this patch replaces again detachedLayer before flushing layer states. > Source/WebKit2/UIProcess/CoordinatedGraphics/LayerTreeRenderer.cpp:648 > + m_detachedLayers.clear(); It is not thread-safe. The rendering thread of QtQuick2 calls syncRemoteContent(). 795078 4 180232 noam 2012-12-19 18:00:10 -0800 Comment on attachment 180232 Patch This is the wrong way to go about it; You should accumulate the layersToDelete in the UI process, and then perform the actual deletion upon flush. 813869 5 184149 rafael.lobo 2013-01-22 23:00:16 -0800 Created attachment 184149 Test case - a blink in the end of animation when messages are sent right away 813872 6 184151 rafael.lobo 2013-01-22 23:04:50 -0800 Created attachment 184151 Changing CoreIPC to send messages right away to show bug and delaying web process This is a bit old patch showing how to reproduce this bug, by making CoreIPC send messages right away instead of scheduling. So right before WebProcess deliver "didRenderFrame", we could have done a series of delayed delete layers events. The blink occurs because we deliver those events on UIProcess and process them while painting (running animations make UIProcess schedule paints on its own). 902444 7 rafael.lobo 2013-06-20 22:28:54 -0700 I think this problem was "fixed" when we switched to "full state commits" rather than "action commits" that would sum themselves and define the changed state (i.e add and remove layers), so I'm closing this bug. 180232 2012-12-19 14:56:40 -0800 2012-12-19 18:00:09 -0800 Patch bug-105466-20121219195358.patch text/plain 8715 rafael.lobo U3VidmVyc2lvbiBSZXZpc2lvbjogMTM4MTg3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggYzQ3MzZhMTRmZDE1ZWUw YTA0OThmM2U5NzVmN2QwODlkMDMyMmIwNy4uMjRiMjI0Zjg5MTM2OWI2ZDRmMTJkMjZmYTQxN2Nm NDhhNmFkOGRkOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMzIEBACisyMDEyLTEyLTE5ICBSYWZh ZWwgQnJhbmRhbyAgPHJhZmFlbC5sb2JvQG9wZW5ib3NzYS5vcmc+CisKKyAgICAgICAgW0Nvb3Jk aW5hdGVkXSBMYXllcnMgc2hvdWxkIGJlIGRlbGV0ZWQgb25seSB3aXRoIGEgcGVuZGluZyBmbHVz aAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA1NDY2 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIGxv Z2ljIG9uIGRlbGF5ZWQgZGVsZXRlZCBsYXllcnMgc2hvdWxkIHN0YXkgb24gVUkgcHJvY2VzcyBi ZWNhdXNlCisgICAgICAgIGxheWVyIGRlbGV0aW9ucyBzaG91bGQgY29tZSB3aXRoIGEgZm9sbG93 aW5nIGZsdXNoLCBvdGhlcndpc2UgYSBwYWludAorICAgICAgICBjb3VsZCBtYWtlIGEgc3luYyB3 aGVyZSB0aGUgZmx1c2ggZXZlbnQgaXMgbm90IHlldCBxdWV1ZWQgYW5kIGEgYmxpbmsKKyAgICAg ICAgd291bGQgYmUgb2JzZXJ2YWJsZS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9Db29yZGluYXRl ZEdyYXBoaWNzL0Nvb3JkaW5hdGVkTGF5ZXJUcmVlSG9zdFByb3h5LmNwcDoKKyAgICAgICAgKFdl YktpdDo6Q29vcmRpbmF0ZWRMYXllclRyZWVIb3N0UHJveHk6OmRlbGV0ZUNvbXBvc2l0aW5nTGF5 ZXIpOgorICAgICAgICAoV2ViS2l0OjpDb29yZGluYXRlZExheWVyVHJlZUhvc3RQcm94eTo6ZGlk UmVuZGVyRnJhbWUpOgorICAgICAgICAqIFVJUHJvY2Vzcy9Db29yZGluYXRlZEdyYXBoaWNzL0xh eWVyVHJlZVJlbmRlcmVyLmNwcDoKKyAgICAgICAgKFdlYktpdDo6TGF5ZXJUcmVlUmVuZGVyZXI6 OkxheWVyVHJlZVJlbmRlcmVyKToKKyAgICAgICAgKFdlYktpdDo6TGF5ZXJUcmVlUmVuZGVyZXI6 OmZsdXNoTGF5ZXJDaGFuZ2VzKToKKyAgICAgICAgKFdlYktpdDo6TGF5ZXJUcmVlUmVuZGVyZXI6 OnN5bmNSZW1vdGVDb250ZW50KToKKyAgICAgICAgKFdlYktpdDo6TGF5ZXJUcmVlUmVuZGVyZXI6 OmRldGFjaExheWVyT25seUJlZm9yZUZsdXNoKToKKyAgICAgICAgKFdlYktpdCk6CisgICAgICAg IChXZWJLaXQ6OkxheWVyVHJlZVJlbmRlcmVyOjpzZXRBY3RpdmUpOgorICAgICAgICAqIFVJUHJv Y2Vzcy9Db29yZGluYXRlZEdyYXBoaWNzL0xheWVyVHJlZVJlbmRlcmVyLmg6CisgICAgICAgIChX ZWJLaXQ6OkxheWVyVHJlZVJlbmRlcmVyOjpkaWRSZXF1ZXN0Rmx1c2gpOgorICAgICAgICAoTGF5 ZXJUcmVlUmVuZGVyZXIpOgorICAgICAgICAqIFdlYlByb2Nlc3MvV2ViUGFnZS9Db29yZGluYXRl ZEdyYXBoaWNzL0Nvb3JkaW5hdGVkTGF5ZXJUcmVlSG9zdC5jcHA6CisgICAgICAgIChXZWJLaXQ6 OkNvb3JkaW5hdGVkTGF5ZXJUcmVlSG9zdDo6Zmx1c2hQZW5kaW5nTGF5ZXJDaGFuZ2VzKToKKyAg ICAgICAgKFdlYktpdDo6Q29vcmRpbmF0ZWRMYXllclRyZWVIb3N0OjpkZXRhY2hMYXllcik6Cisg ICAgICAgICogV2ViUHJvY2Vzcy9XZWJQYWdlL0Nvb3JkaW5hdGVkR3JhcGhpY3MvQ29vcmRpbmF0 ZWRMYXllclRyZWVIb3N0Lmg6CisKIDIwMTItMTItMTggIEpvbiBMZWUgIDxqb25sZWVAYXBwbGUu Y29tPgogCiAgICAgICAgIE5vdGlmeSBjb250ZXh0IGNsaWVudCBvZiBjaGFuZ2UgdG8gdGFibGUs IGFuZCBhbGxvdyBjbGllbnQgdG8gZ2V0IGEgY29weSBvZiBpdApkaWZmIC0tZ2l0IGEvU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL0Nvb3JkaW5hdGVkR3JhcGhpY3MvQ29vcmRpbmF0ZWRMYXllclRy ZWVIb3N0UHJveHkuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0Nvb3JkaW5hdGVkR3Jh cGhpY3MvQ29vcmRpbmF0ZWRMYXllclRyZWVIb3N0UHJveHkuY3BwCmluZGV4IGExMmY0MTRkODVi YmE2NzE1YzE2YTM3MzQ3YzRjMDQ1ZmUxNzk5MmEuLmMyZjc3Zjk4ZWI1YWM4MDU2MTdlMGI3MTlm ZDBhZjAyNjVlMzk4NTkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9Db29y ZGluYXRlZEdyYXBoaWNzL0Nvb3JkaW5hdGVkTGF5ZXJUcmVlSG9zdFByb3h5LmNwcAorKysgYi9T b3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQ29vcmRpbmF0ZWRHcmFwaGljcy9Db29yZGluYXRlZExh eWVyVHJlZUhvc3RQcm94eS5jcHAKQEAgLTk3LDcgKzk3LDcgQEAgdm9pZCBDb29yZGluYXRlZExh eWVyVHJlZUhvc3RQcm94eTo6cmVtb3ZlVXBkYXRlQXRsYXModWludDMyX3QgYXRsYXNJRCkKIAog dm9pZCBDb29yZGluYXRlZExheWVyVHJlZUhvc3RQcm94eTo6ZGVsZXRlQ29tcG9zaXRpbmdMYXll cihDb29yZGluYXRlZExheWVySUQgaWQpCiB7Ci0gICAgZGlzcGF0Y2hVcGRhdGUoYmluZCgmTGF5 ZXJUcmVlUmVuZGVyZXI6OmRlbGV0ZUxheWVyLCBtX3JlbmRlcmVyLmdldCgpLCBpZCkpOworICAg IG1fcmVuZGVyZXItPmRldGFjaExheWVyT25seUJlZm9yZUZsdXNoKGlkKTsKIH0KIAogdm9pZCBD b29yZGluYXRlZExheWVyVHJlZUhvc3RQcm94eTo6c2V0Um9vdENvbXBvc2l0aW5nTGF5ZXIoQ29v cmRpbmF0ZWRMYXllcklEIGlkKQpAQCAtMTM2LDYgKzEzNiw3IEBAIHZvaWQgQ29vcmRpbmF0ZWRM YXllclRyZWVIb3N0UHJveHk6OmNyZWF0ZUN1c3RvbUZpbHRlclByb2dyYW0oaW50IGlkLCBjb25z dCBXZWJDCiB2b2lkIENvb3JkaW5hdGVkTGF5ZXJUcmVlSG9zdFByb3h5OjpkaWRSZW5kZXJGcmFt ZShjb25zdCBXZWJDb3JlOjpJbnRTaXplJiBjb250ZW50c1NpemUsIGNvbnN0IFdlYkNvcmU6Oklu dFJlY3QmIGNvdmVyZWRSZWN0KQogewogICAgIGRpc3BhdGNoVXBkYXRlKGJpbmQoJkxheWVyVHJl ZVJlbmRlcmVyOjpmbHVzaExheWVyQ2hhbmdlcywgbV9yZW5kZXJlci5nZXQoKSkpOworICAgIG1f cmVuZGVyZXItPmRpZFJlcXVlc3RGbHVzaCgpOwogICAgIHVwZGF0ZVZpZXdwb3J0KCk7CiAjaWYg VVNFKFRJTEVEX0JBQ0tJTkdfU1RPUkUpCiAgICAgbV9kcmF3aW5nQXJlYVByb3h5LT5wYWdlKCkt PmRpZFJlbmRlckZyYW1lKGNvbnRlbnRzU2l6ZSwgY292ZXJlZFJlY3QpOwpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0Nvb3JkaW5hdGVkR3JhcGhpY3MvTGF5ZXJUcmVlUmVu ZGVyZXIuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0Nvb3JkaW5hdGVkR3JhcGhpY3Mv TGF5ZXJUcmVlUmVuZGVyZXIuY3BwCmluZGV4IDFhOWY1MWRhOTdhYWRkOTZkOTVkNDViYjRiZWQx MGM1NWE0NDNiMjIuLjVkNTgyNTNiMGVmOTk0OGNiNDI5MTNkOGIxNWUzMDk2MmY0MWViYWEgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9Db29yZGluYXRlZEdyYXBoaWNzL0xh eWVyVHJlZVJlbmRlcmVyLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQ29vcmRp bmF0ZWRHcmFwaGljcy9MYXllclRyZWVSZW5kZXJlci5jcHAKQEAgLTgxLDYgKzgxLDcgQEAgTGF5 ZXJUcmVlUmVuZGVyZXI6OkxheWVyVHJlZVJlbmRlcmVyKENvb3JkaW5hdGVkTGF5ZXJUcmVlSG9z dFByb3h5KiBjb29yZGluYXRlZEwKICNlbmRpZgogICAgICwgbV9iYWNrZ3JvdW5kQ29sb3IoQ29s b3I6OndoaXRlKQogICAgICwgbV9zZXREcmF3c0JhY2tncm91bmQoZmFsc2UpCisgICAgLCBtX2hh c1BlbmRpbmdGbHVzaChmYWxzZSkKIHsKICAgICBBU1NFUlQoaXNNYWluVGhyZWFkKCkpOwogfQpA QCAtNTk4LDYgKzU5OSw3IEBAIHZvaWQgTGF5ZXJUcmVlUmVuZGVyZXI6OmZsdXNoTGF5ZXJDaGFu Z2VzKCkKICAgICBtX3Jvb3RMYXllci0+Zmx1c2hDb21wb3NpdGluZ1N0YXRlKEZsb2F0UmVjdCgp KTsKICAgICBjb21taXRQZW5kaW5nQmFja2luZ1N0b3JlT3BlcmF0aW9ucygpOwogICAgIHJlbW92 ZVJlbGVhc2VkSW1hZ2VCYWNraW5nc0lmTmVlZGVkKCk7CisgICAgbV9oYXNQZW5kaW5nRmx1c2gg PSBmYWxzZTsKIAogICAgIC8vIFRoZSBwZW5kaW5nIHRpbGVzIHN0YXRlIGlzIG9uIGl0cyB3YXkg Zm9yIHRoZSBzY3JlZW4sIHRlbGwgdGhlIHdlYiBwcm9jZXNzIHRvIHJlbmRlciB0aGUgbmV4dCBv bmUuCiAgICAgZGlzcGF0Y2hPbk1haW5UaHJlYWQoYmluZCgmTGF5ZXJUcmVlUmVuZGVyZXI6OnJl bmRlck5leHRGcmFtZSwgdGhpcykpOwpAQCAtNjM5LDYgKzY0MSwxMyBAQCB2b2lkIExheWVyVHJl ZVJlbmRlcmVyOjpzeW5jUmVtb3RlQ29udGVudCgpCiAgICAgaWYgKCFjYWxsZWRPbk1haW5UaHJl YWQpCiAgICAgICAgIG1fcmVuZGVyUXVldWVNdXRleC51bmxvY2soKTsKIAorICAgIC8vIExheWVy cyBzaG91bGQgb25seSBiZSBkZWxldGVkIHdoZW4gdGhlcmUncyBhIHBlbmRpbmcgZmx1c2ggdG8g YmUgZXhlY3V0ZWQgYWxyZWFkeSBvbiB0aGUgcmVuZGVyIHF1ZXVlLgorICAgIGlmIChtX2hhc1Bl bmRpbmdGbHVzaCkgeworICAgICAgICBmb3IgKHNpemVfdCBpID0gMDsgaSA8IG1fZGV0YWNoZWRM YXllcnMuc2l6ZSgpOyArK2kpCisgICAgICAgICAgICBkZWxldGVMYXllcihtX2RldGFjaGVkTGF5 ZXJzW2ldKTsKKyAgICAgICAgbV9kZXRhY2hlZExheWVycy5jbGVhcigpOworICAgIH0KKwogICAg IGZvciAoc2l6ZV90IGkgPSAwOyBpIDwgcmVuZGVyUXVldWUuc2l6ZSgpOyArK2kpCiAgICAgICAg IHJlbmRlclF1ZXVlW2ldKCk7CiB9CkBAIC03MTQsNiArNzIzLDE1IEBAIHZvaWQgTGF5ZXJUcmVl UmVuZGVyZXI6OmFwcGVuZFVwZGF0ZShjb25zdCBGdW5jdGlvbjx2b2lkKCk+JiBmdW5jdGlvbikK ICAgICBtX3JlbmRlclF1ZXVlLmFwcGVuZChmdW5jdGlvbik7CiB9CiAKK3ZvaWQgTGF5ZXJUcmVl UmVuZGVyZXI6OmRldGFjaExheWVyT25seUJlZm9yZUZsdXNoKENvb3JkaW5hdGVkTGF5ZXJJRCBp ZCkKK3sKKyAgICBpZiAoIW1faXNBY3RpdmUpCisgICAgICAgIHJldHVybjsKKworICAgIEFTU0VS VChpc01haW5UaHJlYWQoKSk7CisgICAgbV9kZXRhY2hlZExheWVycy5hcHBlbmQoaWQpOworfQor CiB2b2lkIExheWVyVHJlZVJlbmRlcmVyOjpzZXRBY3RpdmUoYm9vbCBhY3RpdmUpCiB7CiAgICAg aWYgKG1faXNBY3RpdmUgPT0gYWN0aXZlKQpAQCAtNzIzLDYgKzc0MSw3IEBAIHZvaWQgTGF5ZXJU cmVlUmVuZGVyZXI6OnNldEFjdGl2ZShib29sIGFjdGl2ZSkKICAgICAvLyBJZiB0aGVyZSBhcmUg c29tZSB1cGRhdGVzIGluIHF1ZXVlIGR1cmluZyBhY3RpdmF0aW9uIHRoZW4gdGhvc2UgdXBkYXRl cyBhcmUgZnJvbSBwcmV2aW91cyBpbnN0YW5jZSBvZiBwYWludCBub2RlCiAgICAgLy8gYW5kIGNh bm5vdCBiZSBhcHBsaWVkIHRvIHRoZSBuZXdseSBjcmVhdGVkIGluc3RhbmNlLgogICAgIG1fcmVu ZGVyUXVldWUuY2xlYXIoKTsKKyAgICBtX2RldGFjaGVkTGF5ZXJzLmNsZWFyKCk7CiAgICAgbV9p c0FjdGl2ZSA9IGFjdGl2ZTsKICAgICBpZiAobV9pc0FjdGl2ZSkKICAgICAgICAgZGlzcGF0Y2hP bk1haW5UaHJlYWQoYmluZCgmTGF5ZXJUcmVlUmVuZGVyZXI6OnJlbmRlck5leHRGcmFtZSwgdGhp cykpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0Nvb3JkaW5hdGVkR3Jh cGhpY3MvTGF5ZXJUcmVlUmVuZGVyZXIuaCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9Db29y ZGluYXRlZEdyYXBoaWNzL0xheWVyVHJlZVJlbmRlcmVyLmgKaW5kZXggNjliODFhNDliYmIxMTQ3 NTU2MDRiN2FiZGNjMjFhNThlZTU0NzRlMy4uZmJkZDVhZjU0M2U4OTVkMzc3OTg2YmMzZDQ1ZTU4 NGRlZmRlYWZlNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0Nvb3JkaW5h dGVkR3JhcGhpY3MvTGF5ZXJUcmVlUmVuZGVyZXIuaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVBy b2Nlc3MvQ29vcmRpbmF0ZWRHcmFwaGljcy9MYXllclRyZWVSZW5kZXJlci5oCkBAIC0xMTMsNiAr MTEzLDkgQEAgcHVibGljOgogICAgIHZvaWQgc2V0QmFja2dyb3VuZENvbG9yKGNvbnN0IFdlYkNv cmU6OkNvbG9yJik7CiAgICAgdm9pZCBzZXREcmF3c0JhY2tncm91bmQoYm9vbCBlbmFibGUpIHsg bV9zZXREcmF3c0JhY2tncm91bmQgPSBlbmFibGU7IH0KIAorICAgIHZvaWQgZGlkUmVxdWVzdEZs dXNoKCkgeyBtX2hhc1BlbmRpbmdGbHVzaCA9IHRydWU7IH0KKyAgICB2b2lkIGRldGFjaExheWVy T25seUJlZm9yZUZsdXNoKENvb3JkaW5hdGVkTGF5ZXJJRCk7CisKICNpZiBFTkFCTEUoUkVRVUVT VF9BTklNQVRJT05fRlJBTUUpCiAgICAgdm9pZCByZXF1ZXN0QW5pbWF0aW9uRnJhbWUoKTsKICNl bmRpZgpAQCAtMTkzLDYgKzE5Niw4IEBAIHByaXZhdGU6CiAjZW5kaWYKICAgICBXZWJDb3JlOjpD b2xvciBtX2JhY2tncm91bmRDb2xvcjsKICAgICBib29sIG1fc2V0RHJhd3NCYWNrZ3JvdW5kOwor ICAgIGJvb2wgbV9oYXNQZW5kaW5nRmx1c2g7CisgICAgVmVjdG9yPENvb3JkaW5hdGVkTGF5ZXJJ RD4gbV9kZXRhY2hlZExheWVyczsKIAogI2lmIEVOQUJMRShDU1NfU0hBREVSUykKICAgICB0eXBl ZGVmIEhhc2hNYXA8aW50LCBSZWZQdHI8V2ViQ29yZTo6Q3VzdG9tRmlsdGVyUHJvZ3JhbT4gPiBD dXN0b21GaWx0ZXJQcm9ncmFtTWFwOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvV2ViUHJv Y2Vzcy9XZWJQYWdlL0Nvb3JkaW5hdGVkR3JhcGhpY3MvQ29vcmRpbmF0ZWRMYXllclRyZWVIb3N0 LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9Db29yZGluYXRlZEdyYXBo aWNzL0Nvb3JkaW5hdGVkTGF5ZXJUcmVlSG9zdC5jcHAKaW5kZXggNDg0NDQ1MGM5OGY5NDk1NDA1 NzVmYzQ4ZWEwYjExOTBkMzEwOGE2Zi4uZjZkMTdlNjEzMzY3Yzg0ZjY5ZTczNzFjNGZlMDY3ODBl ZGY5Yzc4YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL0Nv b3JkaW5hdGVkR3JhcGhpY3MvQ29vcmRpbmF0ZWRMYXllclRyZWVIb3N0LmNwcAorKysgYi9Tb3Vy Y2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvQ29vcmRpbmF0ZWRHcmFwaGljcy9Db29yZGlu YXRlZExheWVyVHJlZUhvc3QuY3BwCkBAIC0yODAsMTAgKzI4MCw2IEBAIGJvb2wgQ29vcmRpbmF0 ZWRMYXllclRyZWVIb3N0OjpmbHVzaFBlbmRpbmdMYXllckNoYW5nZXMoKQogCiAgICAgZmx1c2hQ ZW5kaW5nSW1hZ2VCYWNraW5nQ2hhbmdlcygpOwogCi0gICAgZm9yIChzaXplX3QgaSA9IDA7IGkg PCBtX2RldGFjaGVkTGF5ZXJzLnNpemUoKTsgKytpKQotICAgICAgICBtX3dlYlBhZ2UtPnNlbmQo TWVzc2FnZXM6OkNvb3JkaW5hdGVkTGF5ZXJUcmVlSG9zdFByb3h5OjpEZWxldGVDb21wb3NpdGlu Z0xheWVyKG1fZGV0YWNoZWRMYXllcnNbaV0pKTsKLSAgICBtX2RldGFjaGVkTGF5ZXJzLmNsZWFy KCk7Ci0KICAgICBpZiAobV9zaG91bGRTeW5jRnJhbWUpIHsKICAgICAgICAgZGlkU3luYyA9IHRy dWU7CiAKQEAgLTQyMyw3ICs0MTksNyBAQCB2b2lkIENvb3JkaW5hdGVkTGF5ZXJUcmVlSG9zdDo6 ZGV0YWNoTGF5ZXIoQ29vcmRpbmF0ZWRHcmFwaGljc0xheWVyKiBsYXllcikKIHsKICAgICBtX3Jl Z2lzdGVyZWRMYXllcnMucmVtb3ZlKGxheWVyKTsKICAgICBtX3Nob3VsZFN5bmNGcmFtZSA9IHRy dWU7Ci0gICAgbV9kZXRhY2hlZExheWVycy5hcHBlbmQobGF5ZXItPmlkKCkpOworICAgIG1fd2Vi UGFnZS0+c2VuZChNZXNzYWdlczo6Q29vcmRpbmF0ZWRMYXllclRyZWVIb3N0UHJveHk6OkRlbGV0 ZUNvbXBvc2l0aW5nTGF5ZXIobGF5ZXItPmlkKCkpKTsKICAgICBzY2hlZHVsZUxheWVyRmx1c2go KTsKIH0KIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL0Nv b3JkaW5hdGVkR3JhcGhpY3MvQ29vcmRpbmF0ZWRMYXllclRyZWVIb3N0LmggYi9Tb3VyY2UvV2Vi S2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvQ29vcmRpbmF0ZWRHcmFwaGljcy9Db29yZGluYXRlZExh eWVyVHJlZUhvc3QuaAppbmRleCAzM2ZlYzA3ZWFjOGM1M2ViMmJkYmI1ODQ1YzA1N2RhMzZlN2Y1 MTdmLi40ZDgzZGJkN2U0NzdlOWNjMTkwZGFiYzk0YjQ0ZTA1NGYxZDE5NDFmIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvQ29vcmRpbmF0ZWRHcmFwaGljcy9D b29yZGluYXRlZExheWVyVHJlZUhvc3QuaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNz L1dlYlBhZ2UvQ29vcmRpbmF0ZWRHcmFwaGljcy9Db29yZGluYXRlZExheWVyVHJlZUhvc3QuaApA QCAtMTczLDcgKzE3Myw2IEBAIHByaXZhdGU6CiAgICAgT3duUHRyPFdlYkNvcmU6OkdyYXBoaWNz TGF5ZXI+IG1fcGFnZU92ZXJsYXlMYXllcjsKIAogICAgIEhhc2hTZXQ8V2ViQ29yZTo6Q29vcmRp bmF0ZWRHcmFwaGljc0xheWVyKj4gbV9yZWdpc3RlcmVkTGF5ZXJzOwotICAgIFZlY3RvcjxDb29y ZGluYXRlZExheWVySUQ+IG1fZGV0YWNoZWRMYXllcnM7CiAgICAgdHlwZWRlZiBIYXNoTWFwPENv b3JkaW5hdGVkSW1hZ2VCYWNraW5nSUQsIFJlZlB0cjxDb29yZGluYXRlZEltYWdlQmFja2luZz4g PiBJbWFnZUJhY2tpbmdNYXA7CiAgICAgSW1hZ2VCYWNraW5nTWFwIG1faW1hZ2VCYWNraW5nczsK ICAgICBWZWN0b3I8T3duUHRyPFVwZGF0ZUF0bGFzPiA+IG1fdXBkYXRlQXRsYXNlczsK 184149 2013-01-22 23:00:16 -0800 2013-01-22 23:00:16 -0800 Test case - a blink in the end of animation when messages are sent right away animation-blink.html text/html 312 rafael.lobo PGh0bWw+CjxoZWFkPgo8L2hlYWQ+CjxzdHlsZSB0eXBlPSJ0ZXh0L2NzcyI+CiNib3ggewogIHBv c2l0aW9uOiBhYnNvbHV0ZTsKICB3aWR0aDogMjAwcHg7CiAgaGVpZ2h0OiAyMDBweDsKICB4OiAx MHB4OwogIHk6IDEwcHg7CiAgYmFja2dyb3VuZC1jb2xvcjogIzExMTsKICAtd2Via2l0LXRyYW5z aXRpb246IGFsbCAyLjBzIGVhc2UtaW4tb3V0Owp9CiNib3g6aG92ZXIgewogIC13ZWJraXQtdHJh bnNmb3JtOiB0cmFuc2xhdGUoNDAwcHgsIDApOwp9Cjwvc3R5bGU+Cjxib2R5Pgo8ZGl2IGlkPSJi b3giPjwvZGl2Pgo8L2JvZHk+CjwvaHRtbD4K 184151 2013-01-22 23:04:50 -0800 2013-01-22 23:04:50 -0800 Changing CoreIPC to send messages right away to show bug and delaying web process patch-blink-with-ipc-delay.diff text/plain 3560 rafael.lobo ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1BsYXRmb3JtL0NvcmVJUEMvQ29ubmVjdGlvbi5j cHAgYi9Tb3VyY2UvV2ViS2l0Mi9QbGF0Zm9ybS9Db3JlSVBDL0Nvbm5lY3Rpb24uY3BwCmluZGV4 IDNiMWE3NWQuLjNmZmJhNTIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1BsYXRmb3JtL0Nv cmVJUEMvQ29ubmVjdGlvbi5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvUGxhdGZvcm0vQ29yZUlQ Qy9Db25uZWN0aW9uLmNwcApAQCAtMzAzLDcgKzMwMyw5IEBAIGJvb2wgQ29ubmVjdGlvbjo6c2Vu ZE1lc3NhZ2UoTWVzc2FnZUlEIG1lc3NhZ2VJRCwgUGFzc093blB0cjxNZXNzYWdlRW5jb2Rlcj4g ZW5jCiAgICAgfQogICAgIAogICAgIC8vIEZJWE1FOiBXZSBzaG91bGQgYWRkIGEgYm9vbGVhbiBm bGFnIHNvIHdlIGRvbid0IGNhbGwgdGhpcyB3aGVuIHdvcmsgaGFzIGFscmVhZHkgYmVlbiBzY2hl ZHVsZWQuCi0gICAgbV9jb25uZWN0aW9uUXVldWUuZGlzcGF0Y2goV1RGOjpiaW5kKCZDb25uZWN0 aW9uOjpzZW5kT3V0Z29pbmdNZXNzYWdlcywgdGhpcykpOworICAgIC8vbV9jb25uZWN0aW9uUXVl dWUuZGlzcGF0Y2goV1RGOjpiaW5kKCZDb25uZWN0aW9uOjpzZW5kT3V0Z29pbmdNZXNzYWdlcywg dGhpcykpOworICAgIHNlbmRPdXRnb2luZ01lc3NhZ2VzKCk7CisKICAgICByZXR1cm4gdHJ1ZTsK IH0KIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0Nvb3JkaW5hdGVkR3Jh cGhpY3MvQ29vcmRpbmF0ZWRMYXllclRyZWVIb3N0UHJveHkuY3BwIGIvU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL0Nvb3JkaW5hdGVkR3JhcGhpY3MvQ29vcmRpbmF0ZWRMYXllclRyZWVIb3N0UHJv eHkuY3BwCmluZGV4IGJhYThmNjUuLjNlNDI4MTkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQy L1VJUHJvY2Vzcy9Db29yZGluYXRlZEdyYXBoaWNzL0Nvb3JkaW5hdGVkTGF5ZXJUcmVlSG9zdFBy b3h5LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQ29vcmRpbmF0ZWRHcmFwaGlj cy9Db29yZGluYXRlZExheWVyVHJlZUhvc3RQcm94eS5jcHAKQEAgLTEwMiw2ICsxMDIsNyBAQCB2 b2lkIENvb3JkaW5hdGVkTGF5ZXJUcmVlSG9zdFByb3h5OjpjcmVhdGVDb21wb3NpdGluZ0xheWVy KENvb3JkaW5hdGVkTGF5ZXJJRCBpZAogCiB2b2lkIENvb3JkaW5hdGVkTGF5ZXJUcmVlSG9zdFBy b3h5OjpkZWxldGVDb21wb3NpdGluZ0xheWVyKENvb3JkaW5hdGVkTGF5ZXJJRCBpZCkKIHsKKyAg ICBwcmludGYoInVpOiByZWNlaXZlZCBkZWxldGUgbGF5ZXJcbiIpOwogICAgIGRpc3BhdGNoVXBk YXRlKGJpbmQoJkxheWVyVHJlZVJlbmRlcmVyOjpkZWxldGVMYXllciwgbV9yZW5kZXJlci5nZXQo KSwgaWQpKTsKIH0KIApAQCAtMTQwLDYgKzE0MSw3IEBAIHZvaWQgQ29vcmRpbmF0ZWRMYXllclRy ZWVIb3N0UHJveHk6OmNyZWF0ZUN1c3RvbUZpbHRlclByb2dyYW0oaW50IGlkLCBjb25zdCBXZWJD CiAKIHZvaWQgQ29vcmRpbmF0ZWRMYXllclRyZWVIb3N0UHJveHk6OmRpZFJlbmRlckZyYW1lKGNv bnN0IFdlYkNvcmU6OkludFNpemUmIGNvbnRlbnRzU2l6ZSwgY29uc3QgV2ViQ29yZTo6SW50UmVj dCYgY292ZXJlZFJlY3QpCiB7CisgICAgcHJpbnRmKCJ1aTogcmVjZWl2ZWQgZGlkIHJlbmRlciBm cmFtZVxuIik7CiAgICAgZGlzcGF0Y2hVcGRhdGUoYmluZCgmTGF5ZXJUcmVlUmVuZGVyZXI6OmZs dXNoTGF5ZXJDaGFuZ2VzLCBtX3JlbmRlcmVyLmdldCgpKSk7CiAgICAgdXBkYXRlVmlld3BvcnQo KTsKICNpZiBVU0UoVElMRURfQkFDS0lOR19TVE9SRSkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJL aXQyL1VJUHJvY2Vzcy9Db29yZGluYXRlZEdyYXBoaWNzL0xheWVyVHJlZVJlbmRlcmVyLmNwcCBi L1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9Db29yZGluYXRlZEdyYXBoaWNzL0xheWVyVHJlZVJl bmRlcmVyLmNwcAppbmRleCA2ZTk3MzAyLi4xM2NiZjIwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi S2l0Mi9VSVByb2Nlc3MvQ29vcmRpbmF0ZWRHcmFwaGljcy9MYXllclRyZWVSZW5kZXJlci5jcHAK KysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0Nvb3JkaW5hdGVkR3JhcGhpY3MvTGF5ZXJU cmVlUmVuZGVyZXIuY3BwCkBAIC05MSw2ICs5MSw3IEBAIExheWVyVHJlZVJlbmRlcmVyOjp+TGF5 ZXJUcmVlUmVuZGVyZXIoKQogCiB2b2lkIExheWVyVHJlZVJlbmRlcmVyOjpwYWludFRvQ3VycmVu dEdMQ29udGV4dChjb25zdCBUcmFuc2Zvcm1hdGlvbk1hdHJpeCYgbWF0cml4LCBmbG9hdCBvcGFj aXR5LCBjb25zdCBGbG9hdFJlY3QmIGNsaXBSZWN0LCBUZXh0dXJlTWFwcGVyOjpQYWludEZsYWdz IFBhaW50RmxhZ3MpCiB7CisgICAgcHJpbnRmKCJ1aTogcGFpbnRpbmcgdG8gR0wgY29udGV4dC4u LlxuIik7CiAgICAgaWYgKCFtX3RleHR1cmVNYXBwZXIpIHsKICAgICAgICAgbV90ZXh0dXJlTWFw cGVyID0gVGV4dHVyZU1hcHBlcjo6Y3JlYXRlKFRleHR1cmVNYXBwZXI6Ok9wZW5HTE1vZGUpOwog ICAgICAgICBzdGF0aWNfY2FzdDxUZXh0dXJlTWFwcGVyR0wqPihtX3RleHR1cmVNYXBwZXIuZ2V0 KCkpLT5zZXRFbmFibGVFZGdlRGlzdGFuY2VBbnRpYWxpYXNpbmcodHJ1ZSk7CmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvQ29vcmRpbmF0ZWRHcmFwaGljcy9D b29yZGluYXRlZExheWVyVHJlZUhvc3QuY3BwIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9X ZWJQYWdlL0Nvb3JkaW5hdGVkR3JhcGhpY3MvQ29vcmRpbmF0ZWRMYXllclRyZWVIb3N0LmNwcApp bmRleCBiYjk5NTVlLi5hODI0N2Q5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9j ZXNzL1dlYlBhZ2UvQ29vcmRpbmF0ZWRHcmFwaGljcy9Db29yZGluYXRlZExheWVyVHJlZUhvc3Qu Y3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9Db29yZGluYXRlZEdy YXBoaWNzL0Nvb3JkaW5hdGVkTGF5ZXJUcmVlSG9zdC5jcHAKQEAgLTI4OSw2ICsyODksOCBAQCBi b29sIENvb3JkaW5hdGVkTGF5ZXJUcmVlSG9zdDo6Zmx1c2hQZW5kaW5nTGF5ZXJDaGFuZ2VzKCkK IAogICAgICAgICBJbnRTaXplIGNvbnRlbnRzU2l6ZSA9IHJvdW5kZWRJbnRTaXplKG1fbm9uQ29t cG9zaXRlZENvbnRlbnRMYXllci0+c2l6ZSgpKTsKICAgICAgICAgSW50UmVjdCBjb3ZlcmVkUmVj dCA9IHRvQ29vcmRpbmF0ZWRHcmFwaGljc0xheWVyKG1fbm9uQ29tcG9zaXRlZENvbnRlbnRMYXll ci5nZXQoKSktPmNvdmVyUmVjdCgpOworICAgICAgICBzbGVlcCgxKTsgLy8gYSB2ZXJ5IGNvc3Rs eSBvcGVyYXRpb24gaGVyZQorICAgICAgICBwcmludGYoIndlYjogc2VuZGluZyBkaWQgcmVuZGVy IGZyYW1lXG4iKTsKICAgICAgICAgbV93ZWJQYWdlLT5zZW5kKE1lc3NhZ2VzOjpDb29yZGluYXRl ZExheWVyVHJlZUhvc3RQcm94eTo6RGlkUmVuZGVyRnJhbWUoY29udGVudHNTaXplLCBjb3ZlcmVk UmVjdCkpOwogICAgICAgICBtX3dhaXRpbmdGb3JVSVByb2Nlc3MgPSB0cnVlOwogICAgICAgICBt X3Nob3VsZFN5bmNGcmFtZSA9IGZhbHNlOwo=