105465 2012-12-19 14:22:19 -0800 [Chromium] add setIDBFactory method for embedders to call 2012-12-19 21:45:35 -0800 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 82948 1 pilgrim pilgrim abarth dglazkov fishd haraken jamesr tkent+wkapi webkit.review.bot oldest_to_newest 794943 0 pilgrim 2012-12-19 14:22:19 -0800 [Chromium] add setIDBFactory method for embedders to call 794946 1 180227 pilgrim 2012-12-19 14:23:54 -0800 Created attachment 180227 Patch 794948 2 webkit.review.bot 2012-12-19 14:26:16 -0800 Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. 794955 3 180227 fishd 2012-12-19 14:30:07 -0800 Comment on attachment 180227 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=180227&action=review > Source/WebKit/chromium/src/IDBFactoryBackendProxy.cpp:64 > +WebIDBFactory* s_webIDBFactory = 0; nit: make this a static variable. that makes it invisible at link time to other .cpp files, and that means the compiler can generate slightly less code when you access s_webIDBFactory. 794957 4 180228 pilgrim 2012-12-19 14:33:30 -0800 Created attachment 180228 Patch 794959 5 180228 pilgrim 2012-12-19 14:33:57 -0800 Comment on attachment 180228 Patch Nits addressed. 795168 6 180228 webkit.review.bot 2012-12-19 21:45:31 -0800 Comment on attachment 180228 Patch Clearing flags on attachment: 180228 Committed r138221: <http://trac.webkit.org/changeset/138221> 795169 7 webkit.review.bot 2012-12-19 21:45:35 -0800 All reviewed patches have been landed. Closing bug. 180227 2012-12-19 14:23:54 -0800 2012-12-19 14:33:26 -0800 Patch bug-105465-20121219172023.patch text/plain 2664 pilgrim SW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCShyZXZpc2lvbiAxMzgxOTQpCisrKyBTb3Vy Y2UvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIz IEBACisyMDEyLTEyLTE5ICBNYXJrIFBpbGdyaW0gIDxwaWxncmltQGNocm9taXVtLm9yZz4KKwor ICAgICAgICBbQ2hyb21pdW1dIGFkZCBzZXRJREJGYWN0b3J5IG1ldGhvZCBmb3IgZW1iZWRkZXJz IHRvIGNhbGwKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTEwNTQ2NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFRoaXMgaXMgc3RlcCAxIG9mIGdldHRpbmcgcmlkIG9mIFdlYktpdFBsYXRmb3JtOjppZGJGYWN0 b3J5LiBUaGlzCisgICAgICAgIGFkZHMgYSBzZXR0ZXIgZm9yIGVtYmVkZGVycyB0byBjYWxsIHVw b24gaW5pdGlhbGl6YXRpb24sIHdoaWNoIChpZgorICAgICAgICBzZXQpIHdpbGwgYmUgdXNlZCBp bnN0ZWFkIG9mIGNhbGxpbmcgdGhlIGlkYkZhY3RvcnkoKQorICAgICAgICBtZXRob2QuIEV2ZW50 dWFsbHkgdGhlIGlkYkZhY3RvcnkoKSBtZXRob2Qgd2lsbCBnbyBhd2F5LCBhbmQgdGhpcworICAg ICAgICBzZXR0ZXIgd2lsbCBiZSB0aGUgb25seSB3YXkgdG8gaW5pdGlhbGl6ZSB0aGUgSW5kZXhl ZCBEYXRhYmFzZSBBUEkuCisKKyAgICAgICAgKiBwdWJsaWMvV2ViSURCRmFjdG9yeS5oOgorICAg ICAgICAoV2ViS2l0KToKKyAgICAgICAgKiBzcmMvSURCRmFjdG9yeUJhY2tlbmRQcm94eS5jcHA6 CisgICAgICAgIChXZWJLaXQpOgorICAgICAgICAoV2ViS2l0OjpzZXRJREJGYWN0b3J5KToKKyAg ICAgICAgKFdlYktpdDo6SURCRmFjdG9yeUJhY2tlbmRQcm94eTo6SURCRmFjdG9yeUJhY2tlbmRQ cm94eSk6CisKIDIwMTItMTItMTkgIEFsZXhpcyBNZW5hcmQgIDxhbGV4aXNAd2Via2l0Lm9yZz4K IAogICAgICAgICBJbXBsZW1lbnQgQ1NTIHBhcnNpbmcgZm9yIENTUyB0cmFuc2l0aW9ucyB1bnBy ZWZpeGVkLgpJbmRleDogU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViSURCRmFjdG9y eS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYklEQkZh Y3RvcnkuaAkocmV2aXNpb24gMTM4MTkzKQorKysgU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJs aWMvV2ViSURCRmFjdG9yeS5oCSh3b3JraW5nIGNvcHkpCkBAIC02Myw2ICs2Myw5IEBAIHB1Ymxp YzoKICAgICB2aXJ0dWFsIHZvaWQgZGVsZXRlRGF0YWJhc2UoY29uc3QgV2ViU3RyaW5nJiBuYW1l LCBXZWJJREJDYWxsYmFja3MqLCBjb25zdCBXZWJTZWN1cml0eU9yaWdpbiYsIFdlYkZyYW1lKiwg Y29uc3QgV2ViU3RyaW5nJiBkYXRhRGlyKSB7IFdFQktJVF9BU1NFUlRfTk9UX1JFQUNIRUQoKTsg fQogfTsKIAorLy8gSW5pdGlhbGl6ZXMgSW5kZXhlZERCIHN1cHBvcnQuCitXRUJLSVRfRVhQT1JU IHZvaWQgc2V0SURCRmFjdG9yeShXZWJJREJGYWN0b3J5Kik7CisKIH0gLy8gbmFtZXNwYWNlIFdl YktpdAogCiAjZW5kaWYgLy8gV2ViSURCRmFjdG9yeV9oCkluZGV4OiBTb3VyY2UvV2ViS2l0L2No cm9taXVtL3NyYy9JREJGYWN0b3J5QmFja2VuZFByb3h5LmNwcAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy Y2UvV2ViS2l0L2Nocm9taXVtL3NyYy9JREJGYWN0b3J5QmFja2VuZFByb3h5LmNwcAkocmV2aXNp b24gMTM4MTkzKQorKysgU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvSURCRmFjdG9yeUJhY2tl bmRQcm94eS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTYxLDE0ICs2MSwyNCBAQCB1c2luZyBuYW1l c3BhY2UgV2ViQ29yZTsKIAogbmFtZXNwYWNlIFdlYktpdCB7CiAKK1dlYklEQkZhY3RvcnkqIHNf d2ViSURCRmFjdG9yeSA9IDA7CisKK3ZvaWQgc2V0SURCRmFjdG9yeShXZWJJREJGYWN0b3J5KiBm YWN0b3J5KQoreworICAgIHNfd2ViSURCRmFjdG9yeSA9IGZhY3Rvcnk7Cit9CisKIFBhc3NSZWZQ dHI8SURCRmFjdG9yeUJhY2tlbmRJbnRlcmZhY2U+IElEQkZhY3RvcnlCYWNrZW5kUHJveHk6OmNy ZWF0ZSgpCiB7CiAgICAgcmV0dXJuIGFkb3B0UmVmKG5ldyBJREJGYWN0b3J5QmFja2VuZFByb3h5 KCkpOwogfQogCiBJREJGYWN0b3J5QmFja2VuZFByb3h5OjpJREJGYWN0b3J5QmFja2VuZFByb3h5 KCkKLSAgICA6IG1fd2ViSURCRmFjdG9yeSh3ZWJLaXRQbGF0Zm9ybVN1cHBvcnQoKS0+aWRiRmFj dG9yeSgpKQogeworICAgIGlmIChzX3dlYklEQkZhY3RvcnkpCisgICAgICAgIG1fd2ViSURCRmFj dG9yeSA9IHNfd2ViSURCRmFjdG9yeTsKKyAgICBlbHNlCisgICAgICAgIG1fd2ViSURCRmFjdG9y eSA9IHdlYktpdFBsYXRmb3JtU3VwcG9ydCgpLT5pZGJGYWN0b3J5KCk7CiB9CiAKIElEQkZhY3Rv cnlCYWNrZW5kUHJveHk6On5JREJGYWN0b3J5QmFja2VuZFByb3h5KCkK 180228 2012-12-19 14:33:30 -0800 2012-12-19 21:45:31 -0800 Patch bug-105465-20121219172959.patch text/plain 2671 pilgrim SW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCShyZXZpc2lvbiAxMzgxOTQpCisrKyBTb3Vy Y2UvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIz IEBACisyMDEyLTEyLTE5ICBNYXJrIFBpbGdyaW0gIDxwaWxncmltQGNocm9taXVtLm9yZz4KKwor ICAgICAgICBbQ2hyb21pdW1dIGFkZCBzZXRJREJGYWN0b3J5IG1ldGhvZCBmb3IgZW1iZWRkZXJz IHRvIGNhbGwKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTEwNTQ2NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFRoaXMgaXMgc3RlcCAxIG9mIGdldHRpbmcgcmlkIG9mIFdlYktpdFBsYXRmb3JtOjppZGJGYWN0 b3J5LiBUaGlzCisgICAgICAgIGFkZHMgYSBzZXR0ZXIgZm9yIGVtYmVkZGVycyB0byBjYWxsIHVw b24gaW5pdGlhbGl6YXRpb24sIHdoaWNoIChpZgorICAgICAgICBzZXQpIHdpbGwgYmUgdXNlZCBp bnN0ZWFkIG9mIGNhbGxpbmcgdGhlIGlkYkZhY3RvcnkoKQorICAgICAgICBtZXRob2QuIEV2ZW50 dWFsbHkgdGhlIGlkYkZhY3RvcnkoKSBtZXRob2Qgd2lsbCBnbyBhd2F5LCBhbmQgdGhpcworICAg ICAgICBzZXR0ZXIgd2lsbCBiZSB0aGUgb25seSB3YXkgdG8gaW5pdGlhbGl6ZSB0aGUgSW5kZXhl ZCBEYXRhYmFzZSBBUEkuCisKKyAgICAgICAgKiBwdWJsaWMvV2ViSURCRmFjdG9yeS5oOgorICAg ICAgICAoV2ViS2l0KToKKyAgICAgICAgKiBzcmMvSURCRmFjdG9yeUJhY2tlbmRQcm94eS5jcHA6 CisgICAgICAgIChXZWJLaXQpOgorICAgICAgICAoV2ViS2l0OjpzZXRJREJGYWN0b3J5KToKKyAg ICAgICAgKFdlYktpdDo6SURCRmFjdG9yeUJhY2tlbmRQcm94eTo6SURCRmFjdG9yeUJhY2tlbmRQ cm94eSk6CisKIDIwMTItMTItMTkgIEFsZXhpcyBNZW5hcmQgIDxhbGV4aXNAd2Via2l0Lm9yZz4K IAogICAgICAgICBJbXBsZW1lbnQgQ1NTIHBhcnNpbmcgZm9yIENTUyB0cmFuc2l0aW9ucyB1bnBy ZWZpeGVkLgpJbmRleDogU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViSURCRmFjdG9y eS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYklEQkZh Y3RvcnkuaAkocmV2aXNpb24gMTM4MTkzKQorKysgU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJs aWMvV2ViSURCRmFjdG9yeS5oCSh3b3JraW5nIGNvcHkpCkBAIC02Myw2ICs2Myw5IEBAIHB1Ymxp YzoKICAgICB2aXJ0dWFsIHZvaWQgZGVsZXRlRGF0YWJhc2UoY29uc3QgV2ViU3RyaW5nJiBuYW1l LCBXZWJJREJDYWxsYmFja3MqLCBjb25zdCBXZWJTZWN1cml0eU9yaWdpbiYsIFdlYkZyYW1lKiwg Y29uc3QgV2ViU3RyaW5nJiBkYXRhRGlyKSB7IFdFQktJVF9BU1NFUlRfTk9UX1JFQUNIRUQoKTsg fQogfTsKIAorLy8gSW5pdGlhbGl6ZXMgSW5kZXhlZERCIHN1cHBvcnQuCitXRUJLSVRfRVhQT1JU IHZvaWQgc2V0SURCRmFjdG9yeShXZWJJREJGYWN0b3J5Kik7CisKIH0gLy8gbmFtZXNwYWNlIFdl YktpdAogCiAjZW5kaWYgLy8gV2ViSURCRmFjdG9yeV9oCkluZGV4OiBTb3VyY2UvV2ViS2l0L2No cm9taXVtL3NyYy9JREJGYWN0b3J5QmFja2VuZFByb3h5LmNwcAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy Y2UvV2ViS2l0L2Nocm9taXVtL3NyYy9JREJGYWN0b3J5QmFja2VuZFByb3h5LmNwcAkocmV2aXNp b24gMTM4MTkzKQorKysgU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvSURCRmFjdG9yeUJhY2tl bmRQcm94eS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTYxLDE0ICs2MSwyNCBAQCB1c2luZyBuYW1l c3BhY2UgV2ViQ29yZTsKIAogbmFtZXNwYWNlIFdlYktpdCB7CiAKK3N0YXRpYyBXZWJJREJGYWN0 b3J5KiBzX3dlYklEQkZhY3RvcnkgPSAwOworCit2b2lkIHNldElEQkZhY3RvcnkoV2ViSURCRmFj dG9yeSogZmFjdG9yeSkKK3sKKyAgICBzX3dlYklEQkZhY3RvcnkgPSBmYWN0b3J5OworfQorCiBQ YXNzUmVmUHRyPElEQkZhY3RvcnlCYWNrZW5kSW50ZXJmYWNlPiBJREJGYWN0b3J5QmFja2VuZFBy b3h5OjpjcmVhdGUoKQogewogICAgIHJldHVybiBhZG9wdFJlZihuZXcgSURCRmFjdG9yeUJhY2tl bmRQcm94eSgpKTsKIH0KIAogSURCRmFjdG9yeUJhY2tlbmRQcm94eTo6SURCRmFjdG9yeUJhY2tl bmRQcm94eSgpCi0gICAgOiBtX3dlYklEQkZhY3Rvcnkod2ViS2l0UGxhdGZvcm1TdXBwb3J0KCkt PmlkYkZhY3RvcnkoKSkKIHsKKyAgICBpZiAoc193ZWJJREJGYWN0b3J5KQorICAgICAgICBtX3dl YklEQkZhY3RvcnkgPSBzX3dlYklEQkZhY3Rvcnk7CisgICAgZWxzZQorICAgICAgICBtX3dlYklE QkZhY3RvcnkgPSB3ZWJLaXRQbGF0Zm9ybVN1cHBvcnQoKS0+aWRiRmFjdG9yeSgpOwogfQogCiBJ REJGYWN0b3J5QmFja2VuZFByb3h5Ojp+SURCRmFjdG9yeUJhY2tlbmRQcm94eSgpCg==