105455 2012-12-19 12:45:31 -0800 Update video-controls-captions-trackmenu.html 2012-12-19 21:31:35 -0800 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 eric.carlson eric.carlson dino feature-media-reviews webkit-bug-importer webkit.review.bot oldest_to_newest 794867 0 eric.carlson 2012-12-19 12:45:31 -0800 After r137966 text tracks in the menu are not necessarily in the same order as in the TextTrackList object, so this test needs to be updated. 794868 1 webkit-bug-importer 2012-12-19 12:45:58 -0800 <rdar://problem/12912418> 794871 2 180212 eric.carlson 2012-12-19 12:53:38 -0800 Created attachment 180212 Proposed patch 794872 3 180212 dino 2012-12-19 13:04:22 -0800 Comment on attachment 180212 Proposed patch Thanks Eric. I'll clean up the test soon as well. 795155 4 180212 webkit.review.bot 2012-12-19 21:31:32 -0800 Comment on attachment 180212 Proposed patch Clearing flags on attachment: 180212 Committed r138219: <http://trac.webkit.org/changeset/138219> 795156 5 webkit.review.bot 2012-12-19 21:31:35 -0800 All reviewed patches have been landed. Closing bug. 180212 2012-12-19 12:53:38 -0800 2012-12-19 21:31:31 -0800 Proposed patch patch_2.txt text/plain 2760 eric.carlson SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDEzODE5MCkKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDEyLTEyLTE5ICBFcmljIENhcmxzb24gIDxl cmljLmNhcmxzb25AYXBwbGUuY29tPgorCisgICAgICAgIFVwZGF0ZSB2aWRlby1jb250cm9scy1j YXB0aW9ucy10cmFja21lbnUuaHRtbAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTA1NDU1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgKiBtZWRpYS92aWRlby1jb250cm9scy1jYXB0aW9ucy10cmFja21lbnUt ZXhwZWN0ZWQudHh0OiBVcGRhdGUgcmVzdWx0cy4KKyAgICAgICAgKiBtZWRpYS92aWRlby1jb250 cm9scy1jYXB0aW9ucy10cmFja21lbnUuaHRtbDogVXBkYXRlIHRlc3QgdG8gYWNjb3VudCBmb3Ig c29ydGVkIG1lbnUuCisKIDIwMTItMTItMTkgIExldmkgV2VpbnRyYXViICA8bGV2aXdAY2hyb21p dW0ub3JnPgogCiAgICAgICAgIFJlLXNraXBwaW5nIHRvdWNoLWlucHV0LWVsZW1lbnQtY2hhbmct ZG9jdW1lbnRzLmh0bWwgc2luY2UgaXQncyBzdGlsbApJbmRleDogTGF5b3V0VGVzdHMvbWVkaWEv dmlkZW8tY29udHJvbHMtY2FwdGlvbnMtdHJhY2ttZW51LWV4cGVjdGVkLnR4dAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBMYXlvdXRUZXN0cy9tZWRpYS92aWRlby1jb250cm9scy1jYXB0aW9ucy10cmFja21lbnUt ZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAxMzgxNzkpCisrKyBMYXlvdXRUZXN0cy9tZWRpYS92aWRl by1jb250cm9scy1jYXB0aW9ucy10cmFja21lbnUtZXhwZWN0ZWQudHh0CSh3b3JraW5nIGNvcHkp CkBAIC0xMiwxMCArMTIsMTAgQEAgUlVOKGludGVybmFscy5zZXRVc2VyUHJlZmVycmVkTGFuZ3Vh Z2VzKAogKioqIFR1cm5pbmcgY2FwdGlvbnMgb24KIEZvdW5kIDUgbWVudSBpdGVtcyBPSwogRVhQ RUNURUQgKHZpZGVvLnRleHRUcmFja3MubGVuZ3RoID09ICc0JykgT0sKLVRyYWNrIDAgc2hvdWxk IGJlIGRpc2FibGVkCi1FWFBFQ1RFRCAodmlkZW8udGV4dFRyYWNrc1swXS5tb2RlID09ICdkaXNh YmxlZCcpIE9LCi1UcmFjayAxIHNob3VsZCBiZSBzaG93aW5nCi1FWFBFQ1RFRCAodmlkZW8udGV4 dFRyYWNrc1sxXS5tb2RlID09ICdzaG93aW5nJykgT0sKK1RyYWNrIDAgc2hvdWxkIGJlIHNob3dp bmcKK0VYUEVDVEVEICh2aWRlby50ZXh0VHJhY2tzWzBdLm1vZGUgPT0gJ3Nob3dpbmcnKSBPSwor VHJhY2sgMSBzaG91bGQgYmUgZGlzYWJsZWQKK0VYUEVDVEVEICh2aWRlby50ZXh0VHJhY2tzWzFd Lm1vZGUgPT0gJ2Rpc2FibGVkJykgT0sKIFRyYWNrIDIgc2hvdWxkIGJlIGRpc2FibGVkCiBFWFBF Q1RFRCAodmlkZW8udGV4dFRyYWNrc1syXS5tb2RlID09ICdkaXNhYmxlZCcpIE9LCiBUcmFjayAz IHNob3VsZCBiZSBkaXNhYmxlZApJbmRleDogTGF5b3V0VGVzdHMvbWVkaWEvdmlkZW8tY29udHJv bHMtY2FwdGlvbnMtdHJhY2ttZW51Lmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvbWVk aWEvdmlkZW8tY29udHJvbHMtY2FwdGlvbnMtdHJhY2ttZW51Lmh0bWwJKHJldmlzaW9uIDEzODE3 OSkKKysrIExheW91dFRlc3RzL21lZGlhL3ZpZGVvLWNvbnRyb2xzLWNhcHRpb25zLXRyYWNrbWVu dS5odG1sCSh3b3JraW5nIGNvcHkpCkBAIC05NywxMCArOTcsMTAgQEAKICAgICAgICAgICAgIGZ1 bmN0aW9uIHRlc3RDYXB0aW9uc1Zpc2libGUoKQogICAgICAgICAgICAgewogICAgICAgICAgICAg ICAgIHRlc3RFeHBlY3RlZCgidmlkZW8udGV4dFRyYWNrcy5sZW5ndGgiLCA0KTsKLSAgICAgICAg ICAgICAgICBjb25zb2xlV3JpdGUoIlRyYWNrIDAgc2hvdWxkIGJlIGRpc2FibGVkIik7Ci0gICAg ICAgICAgICAgICAgdGVzdEV4cGVjdGVkKCJ2aWRlby50ZXh0VHJhY2tzWzBdLm1vZGUiLCAiZGlz YWJsZWQiKTsKLSAgICAgICAgICAgICAgICBjb25zb2xlV3JpdGUoIlRyYWNrIDEgc2hvdWxkIGJl IHNob3dpbmciKTsKLSAgICAgICAgICAgICAgICB0ZXN0RXhwZWN0ZWQoInZpZGVvLnRleHRUcmFj a3NbMV0ubW9kZSIsICJzaG93aW5nIik7CisgICAgICAgICAgICAgICAgY29uc29sZVdyaXRlKCJU cmFjayAwIHNob3VsZCBiZSBzaG93aW5nIik7CisgICAgICAgICAgICAgICAgdGVzdEV4cGVjdGVk KCJ2aWRlby50ZXh0VHJhY2tzWzBdLm1vZGUiLCAic2hvd2luZyIpOworICAgICAgICAgICAgICAg IGNvbnNvbGVXcml0ZSgiVHJhY2sgMSBzaG91bGQgYmUgZGlzYWJsZWQiKTsKKyAgICAgICAgICAg ICAgICB0ZXN0RXhwZWN0ZWQoInZpZGVvLnRleHRUcmFja3NbMV0ubW9kZSIsICJkaXNhYmxlZCIp OwogICAgICAgICAgICAgICAgIGNvbnNvbGVXcml0ZSgiVHJhY2sgMiBzaG91bGQgYmUgZGlzYWJs ZWQiKTsKICAgICAgICAgICAgICAgICB0ZXN0RXhwZWN0ZWQoInZpZGVvLnRleHRUcmFja3NbMl0u bW9kZSIsICJkaXNhYmxlZCIpOwogICAgICAgICAgICAgICAgIGNvbnNvbGVXcml0ZSgiVHJhY2sg MyBzaG91bGQgYmUgZGlzYWJsZWQiKTsK