105454 2012-12-19 12:25:09 -0800 [WK2 NetworkProcess] Cannot log into gmail/facebook with private browsing enabled 2012-12-20 12:09:45 -0800 1 1 1 Unclassified WebKit Page Loading 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ap ap andersca beidson roger_fong sam oldest_to_newest 794861 0 ap 2012-12-19 12:25:09 -0800 Cannot log into gmail/facebook with private browsing enabled. A wrong storage session is used after a redirect. This is because ResourceHandle::willSendRequest() first sets storage session, and then calls the client. NetworkProcess client in particular doesn't preserve the storage session, because it cannot be serialized for IPC. I don't think that the client should be able to change storage session, even for WebKit1, where NSURLRequest is part of API. <rdar://problem/12896478> 794865 1 180209 ap 2012-12-19 12:38:45 -0800 Created attachment 180209 proposed fix 794866 2 180209 beidson 2012-12-19 12:40:48 -0800 Comment on attachment 180209 proposed fix View in context: https://bugs.webkit.org/attachment.cgi?id=180209&action=review > Source/WebCore/platform/network/cf/ResourceHandleCFNet.cpp:565 > + // Client call may not preserve the session, especially it the request is sent over IPC. > + request.setStorageSession(d->m_storageSession.get()); s/especially it/especially if/ > Source/WebCore/platform/network/mac/ResourceHandleMac.mm:478 > + // Client call may not preserve the session, especially it the request is sent over IPC. > + request.setStorageSession(d->m_storageSession.get()); s/especially it/especially if/ 794875 3 ap 2012-12-19 13:07:18 -0800 Committed <http://trac.webkit.org/changeset/138191>. 795607 4 roger_fong 2012-12-20 11:44:33 -0800 It looks like this causes 12 test cases on Win7 to crash: http://build.webkit.org/results/Apple%20Win%207%20Release%20(Tests)/r138191%20(31080)/results.html 795644 5 ap 2012-12-20 12:09:45 -0800 Filed bug 105563. 180209 2012-12-19 12:38:45 -0800 2012-12-19 12:40:48 -0800 proposed fix PrivateGoogle.txt text/plain 2529 ap SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEzODE4NykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBACisyMDEyLTEyLTE5ICBBbGV4ZXkg UHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29tPgorCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8x Mjg5NjQ3OD4gQ2Fubm90IGxvZyBpbnRvIGdtYWlsL2ZhY2Vib29rIHdpdGggTmV0d29ya1Byb2Nl c3MgYW5kIHByaXZhdGUgYnJvd3NpbmcgZW5hYmxlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA1NDU0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgUmVxdWVzdCB3YXMgdXNpbmcgYSB3cm9uZyBzZXNzaW9u IGFmdGVyIGEgcmVkaXJlY3QsIGJlY2F1c2Ugc2Vzc2lvbiBjYW5ub3QgYmUKKyAgICAgICAgcHJl c2VydmVkIG92ZXIgSVBDLgorCisgICAgICAgIEp1c3Qgc2V0IHRoZSBzdG9yYWdlIHNlc3Npb24g YWZ0ZXIgY2FsbGluZyB0aGUgY2xpZW50LCBpdCBpcyBub3QgcmVhbGx5IG1lYW5pbmdmdWwKKyAg ICAgICAgZm9yIGEgY2xpZW50IHRvIGNoYW5nZSBzZXNzaW9uIGJlaGluZCBXZWJLaXQncyBiYWNr LgorCisgICAgICAgICogcGxhdGZvcm0vbmV0d29yay9jZi9SZXNvdXJjZUhhbmRsZUNGTmV0LmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OlJlc291cmNlSGFuZGxlOjp3aWxsU2VuZFJlcXVlc3QpOgor ICAgICAgICAqIHBsYXRmb3JtL25ldHdvcmsvbWFjL1Jlc291cmNlSGFuZGxlTWFjLm1tOgorICAg ICAgICAoV2ViQ29yZTo6UmVzb3VyY2VIYW5kbGU6OndpbGxTZW5kUmVxdWVzdCk6CisKIDIwMTIt MTItMTkgIEFsZXhpcyBNZW5hcmQgIDxhbGV4aXNAd2Via2l0Lm9yZz4KIAogICAgICAgICBJbXBs ZW1lbnQgQ1NTIHBhcnNpbmcgZm9yIENTUyB0cmFuc2l0aW9ucyB1bnByZWZpeGVkLgpJbmRleDog U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9jZi9SZXNvdXJjZUhhbmRsZUNGTmV0LmNw cAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2NmL1Jlc291 cmNlSGFuZGxlQ0ZOZXQuY3BwCShyZXZpc2lvbiAxMzgxNzMpCisrKyBTb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9uZXR3b3JrL2NmL1Jlc291cmNlSGFuZGxlQ0ZOZXQuY3BwCSh3b3JraW5nIGNvcHkp CkBAIC01NTksOSArNTU5LDEwIEBAIHZvaWQgUmVzb3VyY2VIYW5kbGU6OndpbGxTZW5kUmVxdWVz dChSZXMKICAgICAgICAgfQogICAgIH0KIAotICAgIHJlcXVlc3Quc2V0U3RvcmFnZVNlc3Npb24o ZC0+bV9zdG9yYWdlU2Vzc2lvbi5nZXQoKSk7Ci0KICAgICBjbGllbnQoKS0+d2lsbFNlbmRSZXF1 ZXN0KHRoaXMsIHJlcXVlc3QsIHJlZGlyZWN0UmVzcG9uc2UpOworCisgICAgLy8gQ2xpZW50IGNh bGwgbWF5IG5vdCBwcmVzZXJ2ZSB0aGUgc2Vzc2lvbiwgZXNwZWNpYWxseSBpdCB0aGUgcmVxdWVz dCBpcyBzZW50IG92ZXIgSVBDLgorICAgIHJlcXVlc3Quc2V0U3RvcmFnZVNlc3Npb24oZC0+bV9z dG9yYWdlU2Vzc2lvbi5nZXQoKSk7CiB9CiAKIGJvb2wgUmVzb3VyY2VIYW5kbGU6OnNob3VsZFVz ZUNyZWRlbnRpYWxTdG9yYWdlKCkKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdv cmsvbWFjL1Jlc291cmNlSGFuZGxlTWFjLm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL25ldHdvcmsvbWFjL1Jlc291cmNlSGFuZGxlTWFjLm1tCShyZXZpc2lvbiAxMzgx NzMpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL21hYy9SZXNvdXJjZUhhbmRs ZU1hYy5tbQkod29ya2luZyBjb3B5KQpAQCAtNDcyLDEwICs0NzIsMTAgQEAgdm9pZCBSZXNvdXJj ZUhhbmRsZTo6d2lsbFNlbmRSZXF1ZXN0KFJlcwogICAgICAgICB9CiAgICAgfQogCi0gICAgaWYg KGQtPm1fc3RvcmFnZVNlc3Npb24pCi0gICAgICAgIHJlcXVlc3Quc2V0U3RvcmFnZVNlc3Npb24o ZC0+bV9zdG9yYWdlU2Vzc2lvbi5nZXQoKSk7Ci0KICAgICBjbGllbnQoKS0+d2lsbFNlbmRSZXF1 ZXN0KHRoaXMsIHJlcXVlc3QsIHJlZGlyZWN0UmVzcG9uc2UpOworCisgICAgLy8gQ2xpZW50IGNh bGwgbWF5IG5vdCBwcmVzZXJ2ZSB0aGUgc2Vzc2lvbiwgZXNwZWNpYWxseSBpdCB0aGUgcmVxdWVz dCBpcyBzZW50IG92ZXIgSVBDLgorICAgIHJlcXVlc3Quc2V0U3RvcmFnZVNlc3Npb24oZC0+bV9z dG9yYWdlU2Vzc2lvbi5nZXQoKSk7CiB9CiAKIGJvb2wgUmVzb3VyY2VIYW5kbGU6OnNob3VsZFVz ZUNyZWRlbnRpYWxTdG9yYWdlKCkK