105448 2012-12-19 10:44:20 -0800 [GTK] Count failed and timed out tests separately 2012-12-20 00:55:11 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 berto webkit-unassigned cgarcia webkit.review.bot oldest_to_newest 794797 0 berto 2012-12-19 10:44:20 -0800 We're now considering timed out API tests as failures, but it would be nice to display them separately in the buildbot page. 794806 1 180196 berto 2012-12-19 10:51:25 -0800 Created attachment 180196 Patch 795236 2 180196 cgarcia 2012-12-20 00:30:27 -0800 Comment on attachment 180196 Patch Looks great, thanks! 795244 3 180196 webkit.review.bot 2012-12-20 00:55:08 -0800 Comment on attachment 180196 Patch Clearing flags on attachment: 180196 Committed r138231: <http://trac.webkit.org/changeset/138231> 795245 4 webkit.review.bot 2012-12-20 00:55:11 -0800 All reviewed patches have been landed. Closing bug. 180196 2012-12-19 10:51:25 -0800 2012-12-20 00:55:07 -0800 Patch tests.diff text/plain 4314 berto ZGlmZiAtLWdpdCBhL1Rvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29u ZmlnL21hc3Rlci5jZmcgYi9Ub29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3Jn LWNvbmZpZy9tYXN0ZXIuY2ZnCmluZGV4IGU2NDc4ZGIuLjllZWExMGYgMTAwNjQ0Ci0tLSBhL1Rv b2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL21hc3Rlci5jZmcK KysrIGIvVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvbWFz dGVyLmNmZwpAQCAtNTQwLDE1ICs1NDAsMzQgQEAgY2xhc3MgUnVuR3RrQVBJVGVzdHMoc2hlbGwu VGVzdCk6CiAgICAgICAgIHNoZWxsLlRlc3QuY29tbWFuZENvbXBsZXRlKHNlbGYsIGNtZCkKIAog ICAgICAgICBsb2dUZXh0ID0gY21kLmxvZ3NbJ3N0ZGlvJ10uZ2V0VGV4dCgpCi0gICAgICAgIGlu Y29ycmVjdExpbmVzID0gW10KLSAgICAgICAgZm9yIGxpbmUgaW4gbG9nVGV4dC5zcGxpdGxpbmVz KCk6Ci0gICAgICAgICAgICBpZiBsaW5lLnN0YXJ0c3dpdGgoJ0VSUk9SJykgb3IgbGluZS5lbmRz d2l0aCgnVElNRU9VVCcpOgotICAgICAgICAgICAgICAgIGluY29ycmVjdExpbmVzLmFwcGVuZChs aW5lKQogCi0gICAgICAgIHNlbGYuaW5jb3JyZWN0TGluZXMgPSBpbmNvcnJlY3RMaW5lcworICAg ICAgICBzZWxmLmluY29ycmVjdFRlc3RzID0gMAorICAgICAgICBzZWxmLnRpbWVkT3V0VGVzdHMg PSAwCisgICAgICAgIHNlbGYuc2tpcHBlZFRlc3RzID0gMAorICAgICAgICBzZWxmLnN0YXR1c0xp bmUgPSBbXQorCisgICAgICAgIGZvdW5kSXRlbXMgPSByZS5maW5kYWxsKCJUZXN0cyBmYWlsZWQg XCgoXGQrKVwpOiIsIGxvZ1RleHQpCisgICAgICAgIGlmIChmb3VuZEl0ZW1zKToKKyAgICAgICAg ICAgIHNlbGYuaW5jb3JyZWN0VGVzdHMgPSBpbnQoZm91bmRJdGVtc1swXSkKKworICAgICAgICBm b3VuZEl0ZW1zID0gcmUuZmluZGFsbCgiVGVzdHMgdGhhdCB0aW1lZCBvdXQgXCgoXGQrKVwpOiIs IGxvZ1RleHQpCisgICAgICAgIGlmIChmb3VuZEl0ZW1zKToKKyAgICAgICAgICAgIHNlbGYudGlt ZWRPdXRUZXN0cyA9IGludChmb3VuZEl0ZW1zWzBdKQorCisgICAgICAgIGZvdW5kSXRlbXMgPSBy ZS5maW5kYWxsKCJUZXN0cyBza2lwcGVkIFwoKFxkKylcKToiLCBsb2dUZXh0KQorICAgICAgICBp ZiAoZm91bmRJdGVtcyk6CisgICAgICAgICAgICBzZWxmLnNraXBwZWRUZXN0cyA9IGludChmb3Vu ZEl0ZW1zWzBdKQorCisgICAgICAgIHNlbGYudG90YWxGYWlsZWRUZXN0cyA9IHNlbGYuaW5jb3Jy ZWN0VGVzdHMgKyBzZWxmLnRpbWVkT3V0VGVzdHMKKworICAgICAgICBpZiBzZWxmLnRvdGFsRmFp bGVkVGVzdHMgPiAwOgorICAgICAgICAgICAgc2VsZi5zdGF0dXNMaW5lID0gWworICAgICAgICAg ICAgICAgICIlZCBBUEkgdGVzdHMgZmFpbGVkLCAlZCB0aW1lZCBvdXQsICVkIHNraXBwZWQiICUK KyAgICAgICAgICAgICAgICAoc2VsZi5pbmNvcnJlY3RUZXN0cywgc2VsZi50aW1lZE91dFRlc3Rz LCBzZWxmLnNraXBwZWRUZXN0cykKKyAgICAgICAgICAgIF0KIAogICAgIGRlZiBldmFsdWF0ZUNv bW1hbmQoc2VsZiwgY21kKToKLSAgICAgICAgaWYgc2VsZi5pbmNvcnJlY3RMaW5lczoKKyAgICAg ICAgaWYgc2VsZi50b3RhbEZhaWxlZFRlc3RzID4gMDoKICAgICAgICAgICAgIHJldHVybiBGQUlM VVJFCiAKICAgICAgICAgaWYgY21kLnJjICE9IDA6CkBAIC01NjAsOCArNTc5LDggQEAgY2xhc3Mg UnVuR3RrQVBJVGVzdHMoc2hlbGwuVGVzdCk6CiAgICAgICAgIHJldHVybiBzZWxmLmdldFRleHQy KGNtZCwgcmVzdWx0cykKIAogICAgIGRlZiBnZXRUZXh0MihzZWxmLCBjbWQsIHJlc3VsdHMpOgot ICAgICAgICBpZiByZXN1bHRzICE9IFNVQ0NFU1MgYW5kIHNlbGYuaW5jb3JyZWN0TGluZXM6Ci0g ICAgICAgICAgICByZXR1cm4gWyIlZCBBUEkgdGVzdHMgZmFpbGVkIiAlIGxlbihzZWxmLmluY29y cmVjdExpbmVzKV0KKyAgICAgICAgaWYgcmVzdWx0cyAhPSBTVUNDRVNTIGFuZCBzZWxmLnRvdGFs RmFpbGVkVGVzdHMgPiAwOgorICAgICAgICAgICAgcmV0dXJuIHNlbGYuc3RhdHVzTGluZQogCiAg ICAgICAgIHJldHVybiBbc2VsZi5uYW1lXQogCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYmIzNTMzYi4uZjVjOWQzMCAxMDA2NDQKLS0tIGEvVG9v bHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEy LTEyLTE5ICBBbGJlcnRvIEdhcmNpYSAgPGFnYXJjaWFAaWdhbGlhLmNvbT4KKworICAgICAgICBb R1RLXSBDb3VudCBmYWlsZWQgYW5kIHRpbWVkIG91dCB0ZXN0cyBzZXBhcmF0ZWx5CisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDU0NDgKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBEaXNwbGF5IHRoZSBudW1i ZXIgb2YgdGVzdHMgdGhhdCBmYWlsLCB0aW1lIG91dCBhbmQgYXJlIHNraXBwZWQKKyAgICAgICAg c2VwYXJhdGVseSBpbiB0aGUgYnVpbGRib3QgcGFnZS4KKworICAgICAgICAqIEJ1aWxkU2xhdmVT dXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL21hc3Rlci5jZmc6CisgICAgICAgIChSdW5H dGtBUElUZXN0cy5jb21tYW5kQ29tcGxldGUpOgorICAgICAgICAoUnVuR3RrQVBJVGVzdHMuZXZh bHVhdGVDb21tYW5kKToKKyAgICAgICAgKFJ1bkd0a0FQSVRlc3RzLmdldFRleHQyKToKKyAgICAg ICAgKiBTY3JpcHRzL3J1bi1ndGstdGVzdHM6CisgICAgICAgIChUZXN0UnVubmVyLnJ1bl90ZXN0 cyk6CisKIDIwMTItMTItMTkgIFplbm8gQWxiaXNzZXIgIDx6ZW5vQHdlYmtpdC5vcmc+CiAKICAg ICAgICAgW1F0XVtNYWNdIHJ1bi1sYXVuY2hlciBjYW5ub3QgZmluZCBRdDVXZWJLaXRXaWRnZXRz LgpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy9ydW4tZ3RrLXRlc3RzIGIvVG9vbHMvU2NyaXB0 cy9ydW4tZ3RrLXRlc3RzCmluZGV4IGJlMGExMTUuLjJiZDRiMWYgMTAwNzU1Ci0tLSBhL1Rvb2xz L1NjcmlwdHMvcnVuLWd0ay10ZXN0cworKysgYi9Ub29scy9TY3JpcHRzL3J1bi1ndGstdGVzdHMK QEAgLTMzNSwxNiArMzM1LDE4IEBAIGNsYXNzIFRlc3RSdW5uZXI6CiAKICAgICAgICAgaWYgZmFp bGVkX3Rlc3RzOgogICAgICAgICAgICAgbmFtZXMgPSBbdGVzdC5yZXBsYWNlKHNlbGYuX3Byb2dy YW1zX3BhdGgsICcnLCAxKSBmb3IgdGVzdCBpbiBmYWlsZWRfdGVzdHNdCi0gICAgICAgICAgICBz eXMuc3Rkb3V0LndyaXRlKCJUZXN0cyBmYWlsZWQ6ICVzXG4iICUgIiwgIi5qb2luKG5hbWVzKSkK KyAgICAgICAgICAgIHN5cy5zdGRvdXQud3JpdGUoIlRlc3RzIGZhaWxlZCAoJWQpOiAlc1xuIiAl IChsZW4obmFtZXMpLCAiLCAiLmpvaW4obmFtZXMpKSkKICAgICAgICAgICAgIHN5cy5zdGRvdXQu Zmx1c2goKQogCiAgICAgICAgIGlmIHRpbWVkX291dF90ZXN0czoKICAgICAgICAgICAgIG5hbWVz ID0gW3Rlc3QucmVwbGFjZShzZWxmLl9wcm9ncmFtc19wYXRoLCAnJywgMSkgZm9yIHRlc3QgaW4g dGltZWRfb3V0X3Rlc3RzXQotICAgICAgICAgICAgc3lzLnN0ZG91dC53cml0ZSgiVGVzdHMgdGhh dCB0aW1lZCBvdXQ6ICVzXG4iICUgIiwgIi5qb2luKG5hbWVzKSkKKyAgICAgICAgICAgIHN5cy5z dGRvdXQud3JpdGUoIlRlc3RzIHRoYXQgdGltZWQgb3V0ICglZCk6ICVzXG4iICUgKGxlbihuYW1l cyksICIsICIuam9pbihuYW1lcykpKQogICAgICAgICAgICAgc3lzLnN0ZG91dC5mbHVzaCgpCiAK ICAgICAgICAgaWYgc2VsZi5fc2tpcHBlZF90ZXN0cyBhbmQgc2VsZi5fb3B0aW9ucy5za2lwcGVk X2FjdGlvbiA9PSAnc2tpcCc6Ci0gICAgICAgICAgICBzeXMuc3Rkb3V0LndyaXRlKCJUZXN0cyBz a2lwcGVkOlxuJXNcbiIgJSAiXG4iLmpvaW4oW3N0cihza2lwcGVkKSBmb3Igc2tpcHBlZCBpbiBz ZWxmLl9za2lwcGVkX3Rlc3RzXSkpCisgICAgICAgICAgICBzeXMuc3Rkb3V0LndyaXRlKCJUZXN0 cyBza2lwcGVkICglZCk6XG4lc1xuIiAlCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgIChs ZW4oc2VsZi5fc2tpcHBlZF90ZXN0cyksCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAi XG4iLmpvaW4oW3N0cihza2lwcGVkKSBmb3Igc2tpcHBlZCBpbiBzZWxmLl9za2lwcGVkX3Rlc3Rz XSkpKQogICAgICAgICAgICAgc3lzLnN0ZG91dC5mbHVzaCgpCiAKICAgICAgICAgcmV0dXJuIGxl bihmYWlsZWRfdGVzdHMpICsgbGVuKHRpbWVkX291dF90ZXN0cykK