105445 2012-12-19 09:37:34 -0800 WebKitCSSTransformValue::customCssText() should always allocate once 2013-01-04 12:31:07 -0800 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 benjamin benjamin cmarcelo macpherson menard ojan.autocc sam webkit.review.bot oldest_to_newest 794747 0 benjamin 2012-12-19 09:37:34 -0800 The StringBuilder in WebKitCSSTransformValue::customCssText() has the unfortunate side effect of causing multiple String allocations. 794762 1 180184 benjamin 2012-12-19 09:47:45 -0800 Created attachment 180184 Patch 794786 2 180184 buildbot 2012-12-19 10:18:30 -0800 Comment on attachment 180184 Patch Attachment 180184 did not pass win-ews (win): Output: http://queues.webkit.org/results/15418643 794848 3 180202 benjamin 2012-12-19 12:04:09 -0800 Created attachment 180202 Patch 799790 4 180202 menard 2013-01-03 15:54:03 -0800 Comment on attachment 180202 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=180202&action=review Ok with comments. > Source/WebCore/ChangeLog:9 > + it was typically done with 2 memory allocation due to the string size in StringBuilder. Typo. allocation -> allocations. > Source/WebCore/ChangeLog:11 > + This patch change to code to use the String Concatenate opeartions in order Typo. Fix when landing. 800514 5 benjamin 2013-01-04 12:31:07 -0800 Committed r138829: <http://trac.webkit.org/changeset/138829> 180184 2012-12-19 09:47:45 -0800 2012-12-19 12:04:02 -0800 Patch bug-105445-20121219184500.patch text/plain 4637 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogMTM4MTI5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYmU0YzAzZWZjN2YyNWM2 ZDMyMzE0ZTM1ZGFkNzkxZmYwNzI1MjY0NC4uODk1ZWZkZTIyODNhNmM1NmQ1ZGNiZTViN2IwNDg4 MGE4NzVhYjlmZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI2IEBACiAyMDEyLTEyLTE5ICBCZW5q YW1pbiBQb3VsYWluICA8YmVuamFtaW5Ad2Via2l0Lm9yZz4KIAorICAgICAgICBXZWJLaXRDU1NU cmFuc2Zvcm1WYWx1ZTo6Y3VzdG9tQ3NzVGV4dCgpIHNob3VsZCBhbHdheXMgYWxsb2NhdGUgb25j ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA1NDQ1 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2hlbiBj b252ZXJ0aW5nIGEgV2ViS2l0Q1NTVHJhbnNmb3JtVmFsdWUgdG8gYSBTdHJpbmcgcmVwcmVzZW50 YXRpb24sCisgICAgICAgIGl0IHdhcyB0eXBpY2FsbHkgZG9uZSB3aXRoIDIgbWVtb3J5IGFsbG9j YXRpb24gZHVlIHRvIHRoZSBzdHJpbmcgc2l6ZSBpbiBTdHJpbmdCdWlsZGVyLgorCisgICAgICAg IFRoaXMgcGF0Y2ggY2hhbmdlIHRvIGNvZGUgdG8gdXNlIHRoZSBTdHJpbmcgQ29uY2F0ZW5hdGUg b3BlYXJ0aW9ucyBpbiBvcmRlcgorICAgICAgICB0byBjcmVhdGUgdGhlIHN0cmluZyBhdCBvbmNl LgorCisgICAgICAgIFRoZSBvcGVuaW5nIHBhcmVudGhlc2lzIGlzIGFsc28gbW92ZWQgaW4gdGhl IHByZWZpeCBuYW1lIGluIG9yZGVyIHRvIG1heGltaXplCisgICAgICAgIHRoZSByYW5nZSBjb3Bp ZWQgd2l0aCBtZW1jb3B5LgorCisgICAgICAgICogY3NzL1dlYktpdENTU1RyYW5zZm9ybVZhbHVl LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OnRyYW5zZm9ybVZhbHVlVG9Dc3NTdHJpbmcpOiBOZXcg Z2VuZXJpYyBmdW5jdGlvbiBmb3IgYm94aW5nIHZhbHVlcy4KKyAgICAgICAgKFdlYkNvcmU6Oldl YktpdENTU1RyYW5zZm9ybVZhbHVlOjpjdXN0b21Dc3NUZXh0KToKKyAgICAgICAgKFdlYkNvcmU6 OldlYktpdENTU1RyYW5zZm9ybVZhbHVlOjpjdXN0b21TZXJpYWxpemVSZXNvbHZpbmdWYXJpYWJs ZXMpOgorCisyMDEyLTEyLTE5ICBCZW5qYW1pbiBQb3VsYWluICA8YmVuamFtaW5Ad2Via2l0Lm9y Zz4KKwogICAgICAgICBEbyBub3QgYWxsb2NhdGUgYSBuZXcgU3RyaW5nIGZvciB0aGUgc2VwYXJh dG9yIG9mIENTU1ZhbHVlTGlzdDo6Y3VzdG9tQ3NzVGV4dAogICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA1NDE2CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL2Nzcy9XZWJLaXRDU1NUcmFuc2Zvcm1WYWx1ZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9j c3MvV2ViS2l0Q1NTVHJhbnNmb3JtVmFsdWUuY3BwCmluZGV4IDJmODZhZDkwZThmMGNkNTBkYTA2 OWQxOTU5ODJlMmJlMmI0NzhlYTEuLmE5NjZlNDU1OTdhMzQ2YjI3Y2U2NmYzM2YyNWFmMjRmZjMy ZDk5ZDkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9XZWJLaXRDU1NUcmFuc2Zvcm1W YWx1ZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvY3NzL1dlYktpdENTU1RyYW5zZm9ybVZhbHVl LmNwcApAQCAtMjksMzcgKzI5LDQ1IEBACiAjaW5jbHVkZSAiQ1NTVmFsdWVMaXN0LmgiCiAjaW5j bHVkZSAiV2ViQ29yZU1lbW9yeUluc3RydW1lbnRhdGlvbi5oIgogI2luY2x1ZGUgPHd0Zi9QYXNz UmVmUHRyLmg+Ci0jaW5jbHVkZSA8d3RmL3RleHQvU3RyaW5nQnVpbGRlci5oPgogI2luY2x1ZGUg PHd0Zi90ZXh0L1dURlN0cmluZy5oPgogCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKIC8vIFRoZXNl IG5hbWVzIG11c3QgYmUga2VwdCBpbiBzeW5jIHdpdGggVHJhbnNmb3JtT3BlcmF0aW9uVHlwZS4K LWNvbnN0IGNoYXIqIGNvbnN0IHRyYW5zZm9ybU5hbWVbXSA9IHsKLSAgICAgMCwKLSAgICAgInRy YW5zbGF0ZSIsCi0gICAgICJ0cmFuc2xhdGVYIiwKLSAgICAgInRyYW5zbGF0ZVkiLAotICAgICAi cm90YXRlIiwKLSAgICAgInNjYWxlIiwKLSAgICAgInNjYWxlWCIsCi0gICAgICJzY2FsZVkiLAot ICAgICAic2tldyIsCi0gICAgICJza2V3WCIsCi0gICAgICJza2V3WSIsCi0gICAgICJtYXRyaXgi LAotICAgICAidHJhbnNsYXRlWiIsCi0gICAgICJ0cmFuc2xhdGUzZCIsCi0gICAgICJyb3RhdGVY IiwKLSAgICAgInJvdGF0ZVkiLAotICAgICAicm90YXRlWiIsCi0gICAgICJyb3RhdGUzZCIsCi0g ICAgICJzY2FsZVoiLAotICAgICAic2NhbGUzZCIsCi0gICAgICJwZXJzcGVjdGl2ZSIsCi0gICAg ICJtYXRyaXgzZCIKK2NvbnN0IGNoYXIqIGNvbnN0IHRyYW5zZm9ybU5hbWVQcmVmaXhlc1tdID0g eworICAgIDAsCisgICAgInRyYW5zbGF0ZSgiLAorICAgICJ0cmFuc2xhdGVYKCIsCisgICAgInRy YW5zbGF0ZVkoIiwKKyAgICAicm90YXRlKCIsCisgICAgInNjYWxlKCIsCisgICAgInNjYWxlWCgi LAorICAgICJzY2FsZVkoIiwKKyAgICAic2tldygiLAorICAgICJza2V3WCgiLAorICAgICJza2V3 WSgiLAorICAgICJtYXRyaXgoIiwKKyAgICAidHJhbnNsYXRlWigiLAorICAgICJ0cmFuc2xhdGUz ZCgiLAorICAgICJyb3RhdGVYKCIsCisgICAgInJvdGF0ZVkoIiwKKyAgICAicm90YXRlWigiLAor ICAgICJyb3RhdGUzZCgiLAorICAgICJzY2FsZVooIiwKKyAgICAic2NhbGUzZCgiLAorICAgICJw ZXJzcGVjdGl2ZSgiLAorICAgICJtYXRyaXgzZCgiCiB9OwogCitzdGF0aWMgaW5saW5lIFN0cmlu ZyB0cmFuc2Zvcm1WYWx1ZVRvQ3NzU3RyaW5nKFdlYktpdENTU1RyYW5zZm9ybVZhbHVlOjpUcmFu c2Zvcm1PcGVyYXRpb25UeXBlIG9wZXJhdGlvbiwgY29uc3QgU3RyaW5nJiB2YWx1ZSkKK3sKKyAg ICBpZiAob3BlcmF0aW9uICE9IFdlYktpdENTU1RyYW5zZm9ybVZhbHVlOjpVbmtub3duVHJhbnNm b3JtT3BlcmF0aW9uKSB7CisgICAgICAgIEFTU0VSVChzdGF0aWNfY2FzdDxzaXplX3Q+KG9wZXJh dGlvbikgPCBXVEZfQVJSQVlfTEVOR1RIKHRyYW5zZm9ybVR5cGVQcmVmaXhlcykpOworICAgICAg ICByZXR1cm4gbWFrZVN0cmluZyh0cmFuc2Zvcm1OYW1lUHJlZml4ZXNbb3BlcmF0aW9uXSwgdmFs dWUsICcpJyk7CisgICAgfQorICAgIHJldHVybiBTdHJpbmcoKTsKK30KKwogV2ViS2l0Q1NTVHJh bnNmb3JtVmFsdWU6OldlYktpdENTU1RyYW5zZm9ybVZhbHVlKFRyYW5zZm9ybU9wZXJhdGlvblR5 cGUgb3ApCiAgICAgOiBDU1NWYWx1ZUxpc3QoV2ViS2l0Q1NTVHJhbnNmb3JtQ2xhc3MsIENvbW1h U2VwYXJhdG9yKQogICAgICwgbV90eXBlKG9wKQpAQCAtNjgsMjkgKzc2LDEzIEBAIFdlYktpdENT U1RyYW5zZm9ybVZhbHVlOjpXZWJLaXRDU1NUcmFuc2Zvcm1WYWx1ZShUcmFuc2Zvcm1PcGVyYXRp b25UeXBlIG9wKQogCiBTdHJpbmcgV2ViS2l0Q1NTVHJhbnNmb3JtVmFsdWU6OmN1c3RvbUNzc1Rl eHQoKSBjb25zdAogewotICAgIFN0cmluZ0J1aWxkZXIgcmVzdWx0OwotICAgIGlmIChtX3R5cGUg IT0gVW5rbm93blRyYW5zZm9ybU9wZXJhdGlvbikgewotICAgICAgICBBU1NFUlQoc3RhdGljX2Nh c3Q8c2l6ZV90PihtX3R5cGUpIDwgV1RGX0FSUkFZX0xFTkdUSCh0cmFuc2Zvcm1OYW1lKSk7Ci0g ICAgICAgIHJlc3VsdC5hcHBlbmQodHJhbnNmb3JtTmFtZVttX3R5cGVdKTsKLSAgICAgICAgcmVz dWx0LmFwcGVuZCgnKCcpOwotICAgICAgICByZXN1bHQuYXBwZW5kKENTU1ZhbHVlTGlzdDo6Y3Vz dG9tQ3NzVGV4dCgpKTsKLSAgICAgICAgcmVzdWx0LmFwcGVuZCgnKScpOwotICAgIH0KLSAgICBy ZXR1cm4gcmVzdWx0LnRvU3RyaW5nKCk7CisgICAgcmV0dXJuIHRyYW5zZm9ybVZhbHVlVG9Dc3NT dHJpbmcobV90eXBlLCBDU1NWYWx1ZUxpc3Q6OmN1c3RvbUNzc1RleHQoKSk7CiB9CiAKICNpZiBF TkFCTEUoQ1NTX1ZBUklBQkxFUykKIFN0cmluZyBXZWJLaXRDU1NUcmFuc2Zvcm1WYWx1ZTo6Y3Vz dG9tU2VyaWFsaXplUmVzb2x2aW5nVmFyaWFibGVzKGNvbnN0IEhhc2hNYXA8QXRvbWljU3RyaW5n LCBTdHJpbmc+JiB2YXJpYWJsZXMpIGNvbnN0CiB7Ci0gICAgU3RyaW5nQnVpbGRlciByZXN1bHQ7 Ci0gICAgaWYgKG1fdHlwZSAhPSBVbmtub3duVHJhbnNmb3JtT3BlcmF0aW9uKSB7Ci0gICAgICAg IEFTU0VSVChzdGF0aWNfY2FzdDxzaXplX3Q+KG1fdHlwZSkgPCBXVEZfQVJSQVlfTEVOR1RIKHRy YW5zZm9ybU5hbWUpKTsKLSAgICAgICAgcmVzdWx0LmFwcGVuZCh0cmFuc2Zvcm1OYW1lW21fdHlw ZV0pOwotICAgICAgICByZXN1bHQuYXBwZW5kKCcoJyk7Ci0gICAgICAgIHJlc3VsdC5hcHBlbmQo Q1NTVmFsdWVMaXN0OjpjdXN0b21TZXJpYWxpemVSZXNvbHZpbmdWYXJpYWJsZXModmFyaWFibGVz KSk7Ci0gICAgICAgIHJlc3VsdC5hcHBlbmQoJyknKTsKLSAgICB9Ci0gICAgcmV0dXJuIHJlc3Vs dC50b1N0cmluZygpOworICAgIHJldHVybiB0cmFuc2Zvcm1WYWx1ZVRvQ3NzU3RyaW5nKG1fdHlw ZSwgQ1NTVmFsdWVMaXN0OjpjdXN0b21TZXJpYWxpemVSZXNvbHZpbmdWYXJpYWJsZXModmFyaWFi bGVzKSk7CiB9CiAjZW5kaWYKIAo= 180202 2012-12-19 12:04:09 -0800 2013-01-03 15:54:03 -0800 Patch bug-105445-20121219210123.patch text/plain 4637 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogMTM4MTI5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYmU0YzAzZWZjN2YyNWM2 ZDMyMzE0ZTM1ZGFkNzkxZmYwNzI1MjY0NC4uODk1ZWZkZTIyODNhNmM1NmQ1ZGNiZTViN2IwNDg4 MGE4NzVhYjlmZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI2IEBACiAyMDEyLTEyLTE5ICBCZW5q YW1pbiBQb3VsYWluICA8YmVuamFtaW5Ad2Via2l0Lm9yZz4KIAorICAgICAgICBXZWJLaXRDU1NU cmFuc2Zvcm1WYWx1ZTo6Y3VzdG9tQ3NzVGV4dCgpIHNob3VsZCBhbHdheXMgYWxsb2NhdGUgb25j ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA1NDQ1 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2hlbiBj b252ZXJ0aW5nIGEgV2ViS2l0Q1NTVHJhbnNmb3JtVmFsdWUgdG8gYSBTdHJpbmcgcmVwcmVzZW50 YXRpb24sCisgICAgICAgIGl0IHdhcyB0eXBpY2FsbHkgZG9uZSB3aXRoIDIgbWVtb3J5IGFsbG9j YXRpb24gZHVlIHRvIHRoZSBzdHJpbmcgc2l6ZSBpbiBTdHJpbmdCdWlsZGVyLgorCisgICAgICAg IFRoaXMgcGF0Y2ggY2hhbmdlIHRvIGNvZGUgdG8gdXNlIHRoZSBTdHJpbmcgQ29uY2F0ZW5hdGUg b3BlYXJ0aW9ucyBpbiBvcmRlcgorICAgICAgICB0byBjcmVhdGUgdGhlIHN0cmluZyBhdCBvbmNl LgorCisgICAgICAgIFRoZSBvcGVuaW5nIHBhcmVudGhlc2lzIGlzIGFsc28gbW92ZWQgaW4gdGhl IHByZWZpeCBuYW1lIGluIG9yZGVyIHRvIG1heGltaXplCisgICAgICAgIHRoZSByYW5nZSBjb3Bp ZWQgd2l0aCBtZW1jb3B5LgorCisgICAgICAgICogY3NzL1dlYktpdENTU1RyYW5zZm9ybVZhbHVl LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OnRyYW5zZm9ybVZhbHVlVG9Dc3NTdHJpbmcpOiBOZXcg Z2VuZXJpYyBmdW5jdGlvbiBmb3IgYm94aW5nIHZhbHVlcy4KKyAgICAgICAgKFdlYkNvcmU6Oldl YktpdENTU1RyYW5zZm9ybVZhbHVlOjpjdXN0b21Dc3NUZXh0KToKKyAgICAgICAgKFdlYkNvcmU6 OldlYktpdENTU1RyYW5zZm9ybVZhbHVlOjpjdXN0b21TZXJpYWxpemVSZXNvbHZpbmdWYXJpYWJs ZXMpOgorCisyMDEyLTEyLTE5ICBCZW5qYW1pbiBQb3VsYWluICA8YmVuamFtaW5Ad2Via2l0Lm9y Zz4KKwogICAgICAgICBEbyBub3QgYWxsb2NhdGUgYSBuZXcgU3RyaW5nIGZvciB0aGUgc2VwYXJh dG9yIG9mIENTU1ZhbHVlTGlzdDo6Y3VzdG9tQ3NzVGV4dAogICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA1NDE2CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL2Nzcy9XZWJLaXRDU1NUcmFuc2Zvcm1WYWx1ZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9j c3MvV2ViS2l0Q1NTVHJhbnNmb3JtVmFsdWUuY3BwCmluZGV4IDJmODZhZDkwZThmMGNkNTBkYTA2 OWQxOTU5ODJlMmJlMmI0NzhlYTEuLjM2NGViMDIxMWExYzhiNTcxNGY3NmE1ZTEwNzZhODcxYTg1 YzkwOGEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9XZWJLaXRDU1NUcmFuc2Zvcm1W YWx1ZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvY3NzL1dlYktpdENTU1RyYW5zZm9ybVZhbHVl LmNwcApAQCAtMjksMzcgKzI5LDQ1IEBACiAjaW5jbHVkZSAiQ1NTVmFsdWVMaXN0LmgiCiAjaW5j bHVkZSAiV2ViQ29yZU1lbW9yeUluc3RydW1lbnRhdGlvbi5oIgogI2luY2x1ZGUgPHd0Zi9QYXNz UmVmUHRyLmg+Ci0jaW5jbHVkZSA8d3RmL3RleHQvU3RyaW5nQnVpbGRlci5oPgogI2luY2x1ZGUg PHd0Zi90ZXh0L1dURlN0cmluZy5oPgogCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKIC8vIFRoZXNl IG5hbWVzIG11c3QgYmUga2VwdCBpbiBzeW5jIHdpdGggVHJhbnNmb3JtT3BlcmF0aW9uVHlwZS4K LWNvbnN0IGNoYXIqIGNvbnN0IHRyYW5zZm9ybU5hbWVbXSA9IHsKLSAgICAgMCwKLSAgICAgInRy YW5zbGF0ZSIsCi0gICAgICJ0cmFuc2xhdGVYIiwKLSAgICAgInRyYW5zbGF0ZVkiLAotICAgICAi cm90YXRlIiwKLSAgICAgInNjYWxlIiwKLSAgICAgInNjYWxlWCIsCi0gICAgICJzY2FsZVkiLAot ICAgICAic2tldyIsCi0gICAgICJza2V3WCIsCi0gICAgICJza2V3WSIsCi0gICAgICJtYXRyaXgi LAotICAgICAidHJhbnNsYXRlWiIsCi0gICAgICJ0cmFuc2xhdGUzZCIsCi0gICAgICJyb3RhdGVY IiwKLSAgICAgInJvdGF0ZVkiLAotICAgICAicm90YXRlWiIsCi0gICAgICJyb3RhdGUzZCIsCi0g ICAgICJzY2FsZVoiLAotICAgICAic2NhbGUzZCIsCi0gICAgICJwZXJzcGVjdGl2ZSIsCi0gICAg ICJtYXRyaXgzZCIKK2NvbnN0IGNoYXIqIGNvbnN0IHRyYW5zZm9ybU5hbWVQcmVmaXhlc1tdID0g eworICAgIDAsCisgICAgInRyYW5zbGF0ZSgiLAorICAgICJ0cmFuc2xhdGVYKCIsCisgICAgInRy YW5zbGF0ZVkoIiwKKyAgICAicm90YXRlKCIsCisgICAgInNjYWxlKCIsCisgICAgInNjYWxlWCgi LAorICAgICJzY2FsZVkoIiwKKyAgICAic2tldygiLAorICAgICJza2V3WCgiLAorICAgICJza2V3 WSgiLAorICAgICJtYXRyaXgoIiwKKyAgICAidHJhbnNsYXRlWigiLAorICAgICJ0cmFuc2xhdGUz ZCgiLAorICAgICJyb3RhdGVYKCIsCisgICAgInJvdGF0ZVkoIiwKKyAgICAicm90YXRlWigiLAor ICAgICJyb3RhdGUzZCgiLAorICAgICJzY2FsZVooIiwKKyAgICAic2NhbGUzZCgiLAorICAgICJw ZXJzcGVjdGl2ZSgiLAorICAgICJtYXRyaXgzZCgiCiB9OwogCitzdGF0aWMgaW5saW5lIFN0cmlu ZyB0cmFuc2Zvcm1WYWx1ZVRvQ3NzU3RyaW5nKFdlYktpdENTU1RyYW5zZm9ybVZhbHVlOjpUcmFu c2Zvcm1PcGVyYXRpb25UeXBlIG9wZXJhdGlvbiwgY29uc3QgU3RyaW5nJiB2YWx1ZSkKK3sKKyAg ICBpZiAob3BlcmF0aW9uICE9IFdlYktpdENTU1RyYW5zZm9ybVZhbHVlOjpVbmtub3duVHJhbnNm b3JtT3BlcmF0aW9uKSB7CisgICAgICAgIEFTU0VSVChzdGF0aWNfY2FzdDxzaXplX3Q+KG9wZXJh dGlvbikgPCBXVEZfQVJSQVlfTEVOR1RIKHRyYW5zZm9ybU5hbWVQcmVmaXhlcykpOworICAgICAg ICByZXR1cm4gbWFrZVN0cmluZyh0cmFuc2Zvcm1OYW1lUHJlZml4ZXNbb3BlcmF0aW9uXSwgdmFs dWUsICcpJyk7CisgICAgfQorICAgIHJldHVybiBTdHJpbmcoKTsKK30KKwogV2ViS2l0Q1NTVHJh bnNmb3JtVmFsdWU6OldlYktpdENTU1RyYW5zZm9ybVZhbHVlKFRyYW5zZm9ybU9wZXJhdGlvblR5 cGUgb3ApCiAgICAgOiBDU1NWYWx1ZUxpc3QoV2ViS2l0Q1NTVHJhbnNmb3JtQ2xhc3MsIENvbW1h U2VwYXJhdG9yKQogICAgICwgbV90eXBlKG9wKQpAQCAtNjgsMjkgKzc2LDEzIEBAIFdlYktpdENT U1RyYW5zZm9ybVZhbHVlOjpXZWJLaXRDU1NUcmFuc2Zvcm1WYWx1ZShUcmFuc2Zvcm1PcGVyYXRp b25UeXBlIG9wKQogCiBTdHJpbmcgV2ViS2l0Q1NTVHJhbnNmb3JtVmFsdWU6OmN1c3RvbUNzc1Rl eHQoKSBjb25zdAogewotICAgIFN0cmluZ0J1aWxkZXIgcmVzdWx0OwotICAgIGlmIChtX3R5cGUg IT0gVW5rbm93blRyYW5zZm9ybU9wZXJhdGlvbikgewotICAgICAgICBBU1NFUlQoc3RhdGljX2Nh c3Q8c2l6ZV90PihtX3R5cGUpIDwgV1RGX0FSUkFZX0xFTkdUSCh0cmFuc2Zvcm1OYW1lKSk7Ci0g ICAgICAgIHJlc3VsdC5hcHBlbmQodHJhbnNmb3JtTmFtZVttX3R5cGVdKTsKLSAgICAgICAgcmVz dWx0LmFwcGVuZCgnKCcpOwotICAgICAgICByZXN1bHQuYXBwZW5kKENTU1ZhbHVlTGlzdDo6Y3Vz dG9tQ3NzVGV4dCgpKTsKLSAgICAgICAgcmVzdWx0LmFwcGVuZCgnKScpOwotICAgIH0KLSAgICBy ZXR1cm4gcmVzdWx0LnRvU3RyaW5nKCk7CisgICAgcmV0dXJuIHRyYW5zZm9ybVZhbHVlVG9Dc3NT dHJpbmcobV90eXBlLCBDU1NWYWx1ZUxpc3Q6OmN1c3RvbUNzc1RleHQoKSk7CiB9CiAKICNpZiBF TkFCTEUoQ1NTX1ZBUklBQkxFUykKIFN0cmluZyBXZWJLaXRDU1NUcmFuc2Zvcm1WYWx1ZTo6Y3Vz dG9tU2VyaWFsaXplUmVzb2x2aW5nVmFyaWFibGVzKGNvbnN0IEhhc2hNYXA8QXRvbWljU3RyaW5n LCBTdHJpbmc+JiB2YXJpYWJsZXMpIGNvbnN0CiB7Ci0gICAgU3RyaW5nQnVpbGRlciByZXN1bHQ7 Ci0gICAgaWYgKG1fdHlwZSAhPSBVbmtub3duVHJhbnNmb3JtT3BlcmF0aW9uKSB7Ci0gICAgICAg IEFTU0VSVChzdGF0aWNfY2FzdDxzaXplX3Q+KG1fdHlwZSkgPCBXVEZfQVJSQVlfTEVOR1RIKHRy YW5zZm9ybU5hbWUpKTsKLSAgICAgICAgcmVzdWx0LmFwcGVuZCh0cmFuc2Zvcm1OYW1lW21fdHlw ZV0pOwotICAgICAgICByZXN1bHQuYXBwZW5kKCcoJyk7Ci0gICAgICAgIHJlc3VsdC5hcHBlbmQo Q1NTVmFsdWVMaXN0OjpjdXN0b21TZXJpYWxpemVSZXNvbHZpbmdWYXJpYWJsZXModmFyaWFibGVz KSk7Ci0gICAgICAgIHJlc3VsdC5hcHBlbmQoJyknKTsKLSAgICB9Ci0gICAgcmV0dXJuIHJlc3Vs dC50b1N0cmluZygpOworICAgIHJldHVybiB0cmFuc2Zvcm1WYWx1ZVRvQ3NzU3RyaW5nKG1fdHlw ZSwgQ1NTVmFsdWVMaXN0OjpjdXN0b21TZXJpYWxpemVSZXNvbHZpbmdWYXJpYWJsZXModmFyaWFi bGVzKSk7CiB9CiAjZW5kaWYKIAo=