105427 2012-12-19 06:12:43 -0800 style checker complains about namespace indentation when there is no namespace 2014-07-12 19:38:28 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 noam webkit-unassigned commit-queue galpeter glenn llango.u-szeged ossy Szanka.Peter oldest_to_newest 794603 0 noam 2012-12-19 06:12:43 -0800 See false positive in https://bugs.webkit.org/show_bug.cgi?id=104815, the shader code has a few functions inside a STRINGIFY() macro, and the style checker complains about namespace indentation. 953962 1 217789 Szanka.Peter 2013-11-25 04:24:42 -0800 Created attachment 217789 Patch 968331 2 Szanka.Peter 2014-01-15 08:51:30 -0800 ping 990363 3 llango.u-szeged 2014-03-14 02:38:25 -0700 LGTM 1022070 4 217789 commit-queue 2014-07-12 19:38:25 -0700 Comment on attachment 217789 Patch Clearing flags on attachment: 217789 Committed r171044: <http://trac.webkit.org/changeset/171044> 1022071 5 commit-queue 2014-07-12 19:38:28 -0700 All reviewed patches have been landed. Closing bug. 217789 2013-11-25 04:24:42 -0800 2014-07-12 19:38:24 -0700 Patch bug-105427-20131125132441.patch text/plain 2631 Szanka.Peter U3VidmVyc2lvbiBSZXZpc2lvbjogMTU5NzQ1CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNGNjYzhiNjQ5ZjE4N2YzMTNlN2I0OWQ0YzE3NjM4OTQ0 Zjg2NWIwZC4uNTliMThhMjQxY2ZlODM5ZTRjYjJiNjllOTMzZDNjMjVlMjEyOTYyZiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3 IEBACisyMDEzLTExLTI1ICBQZXRlciBTemFua2EgIDxoODY4MDY0QHN0dWQudS1zemVnZWQuaHU+ CisKKyAgICAgICAgU3R5bGUgY2hlY2tlciBjb21wbGFpbnMgYWJvdXQgbmFtZXNwYWNlIGluZGVu dGF0aW9uIHdoZW4gdGhlcmUgaXMgbm8gbmFtZXNwYWNlCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDU0MjcKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tl cnMvY3BwLnB5OgorICAgICAgICAoY2hlY2tfbmFtZXNwYWNlX2luZGVudGF0aW9uKToKKyAgICAg ICAgKiBTY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcF91bml0dGVzdC5weToKKyAg ICAgICAgKFdlYktpdFN0eWxlVGVzdC50ZXN0X2luZGVudGF0aW9uKToKKworICAgICAgICBUaGUg aW5kZW50YXRpb24gbGV2ZWwgZGVwZW5kcyBvbiB0aGUgcGFyYW50aGVzZXMgdG9vLCB0byBhdm9p ZCBmYWxzZSB3YXJuaW5nIGluIGNhc2Ugb2Ygc2V2ZXJhbCBzdGF0ZW1lbnRzIGluc2lkZSBtYWNy b3MuCisKIDIwMTMtMTEtMjIgIERlYW4gSmFja3NvbiAgPGRpbm9AYXBwbGUuY29tPgogCiAgICAg ICAgIFNwZWN1bGF0aXZlIE1vdW50YWluIExpb24gYnVpbGQgZml4LgpkaWZmIC0tZ2l0IGEvVG9v bHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHAucHkgYi9Ub29scy9TY3JpcHRz L3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcC5weQppbmRleCAyZDU1OWJkNzMzNjlkODViMjZj MTlhOTc1ZjQxZGQyZmE1YWE5MWE3Li5mOGZlNDBkZmRhYTRiNTQyODA1YTY2ZDJmNWY5ZmM1ZjRk ZDhiZDE4IDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJz L2NwcC5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcC5w eQpAQCAtMjAzMiw2ICsyMDMyLDcgQEAgZGVmIGNoZWNrX25hbWVzcGFjZV9pbmRlbnRhdGlvbihj bGVhbl9saW5lcywgbGluZV9udW1iZXIsIGZpbGVfZXh0ZW5zaW9uLCBmaWxlX3MKICAgICAgICAg ZWxzZToKICAgICAgICAgICAgIGxvb2tpbmdfZm9yX3NlbWljb2xvbiA9IEZhbHNlOyAjIElmIHdl IGhhdmUgYSBicmFjZSB3ZSBtYXkgbm90IG5lZWQgYSBzZW1pY29sb24uCiAgICAgICAgIGN1cnJl bnRfaW5kZW50YXRpb25fbGV2ZWwgKz0gY3VycmVudF9saW5lLmNvdW50KCd7JykgLSBjdXJyZW50 X2xpbmUuY291bnQoJ30nKQorICAgICAgICBjdXJyZW50X2luZGVudGF0aW9uX2xldmVsICs9IGN1 cnJlbnRfbGluZS5jb3VudCgnKCcpIC0gY3VycmVudF9saW5lLmNvdW50KCcpJykKICAgICAgICAg aWYgY3VycmVudF9pbmRlbnRhdGlvbl9sZXZlbCA8IDA6CiAgICAgICAgICAgICBicmVhazsKIApk aWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHBfdW5p dHRlc3QucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcF91bml0 dGVzdC5weQppbmRleCBlMTQzNWJiNzQyNTgyNTgwZTVhZDMzYTc2NDEzZWU2ZjY4MDAxMTM3Li4y M2U1ZGM4MjdhZDM1NWRmNDMzNjIzYzZmNjRiMmQ3ZWYzZmFlYzMzIDEwMDY0NAotLS0gYS9Ub29s cy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcF91bml0dGVzdC5weQorKysgYi9U b29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcF91bml0dGVzdC5weQpAQCAt Mzc1OSw2ICszNzU5LDE1IEBAIGNsYXNzIFdlYktpdFN0eWxlVGVzdChDcHBTdHlsZVRlc3RCYXNl KToKICAgICAgICAgICAgICd9JywKICAgICAgICAgICAgICdDb2RlIGluc2lkZSBhIG5hbWVzcGFj ZSBzaG91bGQgbm90IGJlIGluZGVudGVkLiAgW3doaXRlc3BhY2UvaW5kZW50XSBbNF0nLAogICAg ICAgICAgICAgJ2Zvby5jcHAnKQorICAgICAgICBzZWxmLmFzc2VydF9tdWx0aV9saW5lX2xpbnQo CisgICAgICAgICAgICAnbmFtZXNwYWNlIFdlYkNvcmUge1xuJworICAgICAgICAgICAgJ3N0YXRp YyBjb25zdCBjaGFyKiB2ZXJ0ZXhUZW1wbGF0ZSA9XG4nCisgICAgICAgICAgICAnICAgIFNUUklO R0lGWShcbicKKyAgICAgICAgICAgICcgICAgICAgIGF0dHJpYnV0ZSB2ZWM0IGFfdmVydGV4O1xu JworICAgICAgICAgICAgJyAgICAgICAgdW5pZm9ybSBtYXQ0IHVfbW9kZWxWaWV3TWF0cml4O1xu JworICAgICAgICAgICAgJyAgICApO1xuJworICAgICAgICAgICAgJ31cbicsCisgICAgICAgICAg ICAnJykKIAogICAgICAgICAjIDUuIEEgY2FzZSBsYWJlbCBzaG91bGQgbGluZSB1cCB3aXRoIGl0 cyBzd2l0Y2ggc3RhdGVtZW50LiBUaGUKICAgICAgICAgIyAgICBjYXNlIHN0YXRlbWVudCBpcyBp bmRlbnRlZC4K