105422 2012-12-19 05:25:22 -0800 Web Inspector: scripts to evaluate on load are not removed from inspector state when Page agent is disabled 2012-12-19 07:47:34 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 caseq caseq apavlov keishi loislo pfeldman pmuellr vsevik web-inspector-bugs webkit.review.bot yurys oldest_to_newest 794563 0 caseq 2012-12-19 05:25:22 -0800 We maintain scripts to evaluate on load as part of the inspector state. The scripts are normally managed by the front-end, so their life time should match that of the front-end. Currently, scripts survive the agent being detached, which leads to bugs such as http://crbug.com/165445 794573 1 180143 caseq 2012-12-19 05:35:52 -0800 Created attachment 180143 Patch 794587 2 180143 apavlov 2012-12-19 05:52:05 -0800 Comment on attachment 180143 Patch r=me 794589 3 180143 webkit.review.bot 2012-12-19 05:57:45 -0800 Comment on attachment 180143 Patch Clearing flags on attachment: 180143 Committed r138150: <http://trac.webkit.org/changeset/138150> 794590 4 webkit.review.bot 2012-12-19 05:57:48 -0800 All reviewed patches have been landed. Closing bug. 794668 5 180143 pfeldman 2012-12-19 07:47:34 -0800 Comment on attachment 180143 Patch Should we now remove everything? 180143 2012-12-19 05:35:52 -0800 2012-12-19 07:47:34 -0800 Patch bug-105422-20121219173308.patch text/plain 3160 caseq U3VidmVyc2lvbiBSZXZpc2lvbjogMTM4MTQyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjk1NWYxNTA0MWIzN2Nk NTMwOTkwMTkzYzFiZGExY2VkYTg5MjhhMy4uZjE0ZDk2YmVhZTlhOTE1OTc1ZjFiMmJjMmQxM2Rl YWQ2MWZmYjFkMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEyLTEyLTE5ICBBbmRy ZXkgS29zeWFrb3YgIDxjYXNlcUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgV2ViIEluc3BlY3Rv cjogc2NyaXB0cyB0byBldmFsdWF0ZSBvbiBsb2FkIGFyZSBub3QgcmVtb3ZlZCBmcm9tIGluc3Bl Y3RvciBzdGF0ZSB3aGVuIFBhZ2UgYWdlbnQgaXMgZGlzYWJsZWQKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNTQyMgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIC0gcmVzZXQgc2NyaXB0cyB0byBldmFsdWF0 ZSBvbiBsb2FkIHdoZW4gSW5zcGVjdG9yUGFnZUFnZW50IGlzIGRpc2FibGVkLgorICAgICAgICAt IGFkZGVkIEluc3BlY3RvclN0YXRlOjpyZW1vdmUoKTsKKworICAgICAgICAqIGluc3BlY3Rvci9J bnNwZWN0b3JQYWdlQWdlbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SW5zcGVjdG9yUGFnZUFn ZW50OjpkaXNhYmxlKToKKyAgICAgICAgKiBpbnNwZWN0b3IvSW5zcGVjdG9yU3RhdGUuY3BwOgor ICAgICAgICAoV2ViQ29yZTo6SW5zcGVjdG9yU3RhdGU6OnJlbW92ZSk6CisgICAgICAgIChXZWJD b3JlKToKKyAgICAgICAgKiBpbnNwZWN0b3IvSW5zcGVjdG9yU3RhdGUuaDoKKyAgICAgICAgKElu c3BlY3RvclN0YXRlKToKKwogMjAxMi0xMi0xOSAgUmVuYXRhIEhvZG92YW4gIDxyZW5pQHdlYmtp dC5vcmc+CiAKICAgICAgICAgQ1NTUGFyc2VyIGNyYXNlcywgd2hlbiBubyBjb250ZXh0IGlzIGF2 YWlsYWJsZSwgYW5kIHRoZSB2YWx1ZSBpcyBhIHZhbGlkIGtleXdvcmQKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JQYWdlQWdlbnQuY3BwIGIvU291cmNlL1dl YkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvclBhZ2VBZ2VudC5jcHAKaW5kZXggNGIzMDZmNzdhZmZm ZDRiOGFmNWM3NDk1MTI2NjBhNjQwYWJkMmFmNi4uNWEzNTgyYTI3MmY1OWYwMDc4Mjg1N2I2ZGY4 MWMwNjViY2NkZjFhMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3Bl Y3RvclBhZ2VBZ2VudC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3Rv clBhZ2VBZ2VudC5jcHAKQEAgLTQwNyw2ICs0MDcsNyBAQCB2b2lkIEluc3BlY3RvclBhZ2VBZ2Vu dDo6ZGlzYWJsZShFcnJvclN0cmluZyopCiAgICAgbV9zdGF0ZS0+c2V0TG9uZyhQYWdlQWdlbnRT dGF0ZTo6cGFnZUFnZW50U2NyZWVuSGVpZ2h0T3ZlcnJpZGUsIDApOwogICAgIG1fc3RhdGUtPnNl dERvdWJsZShQYWdlQWdlbnRTdGF0ZTo6cGFnZUFnZW50Rm9udFNjYWxlRmFjdG9yT3ZlcnJpZGUs IDEpOwogICAgIG1fc3RhdGUtPnNldEJvb2xlYW4oUGFnZUFnZW50U3RhdGU6OnBhZ2VBZ2VudEZp dFdpbmRvdywgZmFsc2UpOworICAgIG1fc3RhdGUtPnJlbW92ZShQYWdlQWdlbnRTdGF0ZTo6cGFn ZUFnZW50U2NyaXB0c1RvRXZhbHVhdGVPbkxvYWQpOwogICAgIHVwZGF0ZVZpZXdNZXRyaWNzKDAs IDAsIDEsIGZhbHNlKTsKIH0KIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9y L0luc3BlY3RvclN0YXRlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JT dGF0ZS5jcHAKaW5kZXggYmFmMTBjOTcxZTExOTUzMjU3NmJmNDk0NTUyMmYzN2IwODMyNWFmYi4u Njc1ZDQ5OWQxZjVkMjZlZDFkMjc0NzY0NzE1ZmFlM2MyNjZmYjU2MyAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvclN0YXRlLmNwcAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yU3RhdGUuY3BwCkBAIC03NSw2ICs3NSwxMSBAQCB2b2lk IEluc3BlY3RvclN0YXRlOjpzZXRWYWx1ZShjb25zdCBTdHJpbmcmIHByb3BlcnR5TmFtZSwgUGFz c1JlZlB0cjxJbnNwZWN0b3JWYQogICAgIHVwZGF0ZUNvb2tpZSgpOwogfQogCit2b2lkIEluc3Bl Y3RvclN0YXRlOjpyZW1vdmUoY29uc3QgU3RyaW5nJiBwcm9wZXJ0eU5hbWUpCit7CisgICAgbV9w cm9wZXJ0aWVzLT5yZW1vdmUocHJvcGVydHlOYW1lKTsKK30KKwogYm9vbCBJbnNwZWN0b3JTdGF0 ZTo6Z2V0Qm9vbGVhbihjb25zdCBTdHJpbmcmIHByb3BlcnR5TmFtZSkKIHsKICAgICBJbnNwZWN0 b3JPYmplY3Q6Oml0ZXJhdG9yIGl0ID0gbV9wcm9wZXJ0aWVzLT5maW5kKHByb3BlcnR5TmFtZSk7 CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yU3RhdGUuaCBi L1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JTdGF0ZS5oCmluZGV4IDM2MGIyNTk3 NzQ3OTczNzg0MjYwOTAwOGUwODI1MmIwYTM0NTQwMmYuLjNkYzA5MGFiZDk1MzdjZmFiNjUwN2U1 MmU4MmZmZTI3YWVmNDFjNzkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9J bnNwZWN0b3JTdGF0ZS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JT dGF0ZS5oCkBAIC02NSw2ICs2NSw3IEBAIHB1YmxpYzoKICAgICB2b2lkIHNldERvdWJsZShjb25z dCBTdHJpbmcmIHByb3BlcnR5TmFtZSwgZG91YmxlIHZhbHVlKSB7IHNldFZhbHVlKHByb3BlcnR5 TmFtZSwgSW5zcGVjdG9yQmFzaWNWYWx1ZTo6Y3JlYXRlKHZhbHVlKSk7IH0KICAgICB2b2lkIHNl dE9iamVjdChjb25zdCBTdHJpbmcmIHByb3BlcnR5TmFtZSwgUGFzc1JlZlB0cjxJbnNwZWN0b3JP YmplY3Q+IHZhbHVlKSB7IHNldFZhbHVlKHByb3BlcnR5TmFtZSwgdmFsdWUpOyB9CiAKKyAgICB2 b2lkIHJlbW92ZShjb25zdCBTdHJpbmcmKTsKIHByaXZhdGU6CiAgICAgdm9pZCB1cGRhdGVDb29r aWUoKTsKICAgICB2b2lkIHNldFZhbHVlKGNvbnN0IFN0cmluZyYgcHJvcGVydHlOYW1lLCBQYXNz UmVmUHRyPEluc3BlY3RvclZhbHVlPik7Cg==