105412 2012-12-19 04:16:11 -0800 [EFL][WK2] Move deviceScaleFactor to our view as it's view related 2012-12-19 05:23:42 -0800 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 kenneth kenneth gyuyoung.kim laszlo.gombos lucas.de.marchi menard rakuco webkit.review.bot oldest_to_newest 794504 0 kenneth 2012-12-19 04:16:11 -0800 SSIA 794507 1 180130 kenneth 2012-12-19 04:17:38 -0800 Created attachment 180130 Patch 794536 2 180130 laszlo.gombos 2012-12-19 05:02:36 -0800 Comment on attachment 180130 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=180130&action=review Looks good to me but I would appreciate to address the comments below. > Source/WebKit2/UIProcess/API/efl/EwkViewImpl.cpp:292 > +void EwkViewImpl::setDeviceScaleFactor(float scale) Nit: Any reason not to use the same symbol name name as the implementation - EwkViewImpl::setIntrinsicDeviceScaleFactor ? > Source/WebKit2/UIProcess/API/efl/EwkViewImpl.cpp:302 > + // Note that the scale factor incl page and device scale for now. Nit: incl -> includes 794542 3 kenneth 2012-12-19 05:06:49 -0800 > > Source/WebKit2/UIProcess/API/efl/EwkViewImpl.cpp:292 > > +void EwkViewImpl::setDeviceScaleFactor(float scale) > > Nit: Any reason not to use the same symbol name name as the implementation - EwkViewImpl::setIntrinsicDeviceScaleFactor ? Yeah, because that is an implementation detail. There exists two methods. Elsewhere it is called by the shorter name. > > Source/WebKit2/UIProcess/API/efl/EwkViewImpl.cpp:302 > > + // Note that the scale factor incl page and device scale for now. > > Nit: incl -> includes Tried to keep the line short. 794560 4 180130 webkit.review.bot 2012-12-19 05:23:37 -0800 Comment on attachment 180130 Patch Clearing flags on attachment: 180130 Committed r138146: <http://trac.webkit.org/changeset/138146> 794561 5 webkit.review.bot 2012-12-19 05:23:42 -0800 All reviewed patches have been landed. Closing bug. 180130 2012-12-19 04:17:38 -0800 2012-12-19 05:23:37 -0800 Patch bug-105412-20121219131454.patch text/plain 3342 kenneth U3VidmVyc2lvbiBSZXZpc2lvbjogMTM4MTQwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZTc2ZDBmZTczZGE5ODVk ZmY1NWNhNGJkZjdkYjNlYTlmN2NhZDg2MS4uOGQ0MTFlMDQ1Y2NiOTk1YmZlOTFiZmVmOGUyNGI5 OTRlNjlhY2Q0NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTEyLTE5ICBLZW5u ZXRoIFJvaGRlIENocmlzdGlhbnNlbiAgPGtlbm5ldGhAd2Via2l0Lm9yZz4KKworICAgICAgICBb RUZMXVtXSzJdIE1vdmUgZGV2aWNlU2NhbGVGYWN0b3IgdG8gb3VyIHZpZXcgYXMgaXQncyB2aWV3 IHJlbGF0ZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTEwNTQxMgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogVUlQcm9jZXNzL0FQSS9lZmwvRXdrVmlld0ltcGwuY3BwOgorICAgICAgICAoRXdrVmlld0lt cGw6OnNldERldmljZVNjYWxlRmFjdG9yKToKKyAgICAgICAgKEV3a1ZpZXdJbXBsOjp0cmFuc2Zv cm1Gcm9tU2NlbmUpOgorICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvZWZsL0V3a1ZpZXdJbXBsLmg6 CisgICAgICAgIChFd2tWaWV3SW1wbCk6CisgICAgICAgICogVUlQcm9jZXNzL0FQSS9lZmwvZXdr X3ZpZXcuY3BwOgorICAgICAgICAoZXdrX3ZpZXdfZGV2aWNlX3BpeGVsX3JhdGlvX3NldCk6CisK IDIwMTItMTItMTkgIEt5dW5nVGFlIEtpbSAgPGt0Zi5raW1Ac2Ftc3VuZy5jb20+CiAKICAgICAg ICAgVW51c2VkIHBhcmFtZXRlcnMgb24gV2ViQ29udGV4dC5jcHAKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL0V3a1ZpZXdJbXBsLmNwcCBiL1NvdXJjZS9XZWJL aXQyL1VJUHJvY2Vzcy9BUEkvZWZsL0V3a1ZpZXdJbXBsLmNwcAppbmRleCA2ZGUxZjg1OGJmMWZm MWEwOTI2NzQ3NWMxMTFlYWMwY2YyNDcwNWFlLi42MmJlMWIzYmJiZWM4MDdmOTM5ZmMzMmMzYjlj NWVmZTNkNDRlMjlmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2Vm bC9Fd2tWaWV3SW1wbC5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwv RXdrVmlld0ltcGwuY3BwCkBAIC0yODksMTEgKzI4OSwxNyBAQCB2b2lkIEV3a1ZpZXdJbXBsOjpz ZXRDdXJzb3IoY29uc3QgQ3Vyc29yJiBjdXJzb3IpCiAgICAgZWNvcmVfZXZhc19vYmplY3RfY3Vy c29yX3NldChlY29yZUV2YXMsIGN1cnNvck9iamVjdC5yZWxlYXNlKCkubGVha1JlZigpLCBFVkFT X0xBWUVSX01BWCwgaG90c3BvdFgsIGhvdHNwb3RZKTsKIH0KIAordm9pZCBFd2tWaWV3SW1wbDo6 c2V0RGV2aWNlU2NhbGVGYWN0b3IoZmxvYXQgc2NhbGUpCit7CisgICAgcGFnZSgpLT5zZXRJbnRy aW5zaWNEZXZpY2VTY2FsZUZhY3RvcihzY2FsZSk7Cit9CisKIEFmZmluZVRyYW5zZm9ybSBFd2tW aWV3SW1wbDo6dHJhbnNmb3JtRnJvbVNjZW5lKCkgY29uc3QKIHsKICAgICBBZmZpbmVUcmFuc2Zv cm0gdHJhbnNmb3JtOwogCiAjaWYgVVNFKFRJTEVEX0JBQ0tJTkdfU1RPUkUpCisgICAgLy8gTm90 ZSB0aGF0IHRoZSBzY2FsZSBmYWN0b3IgaW5jbCBwYWdlIGFuZCBkZXZpY2Ugc2NhbGUgZm9yIG5v dy4KICAgICB0cmFuc2Zvcm0uc2NhbGUoMSAvIG1fc2NhbGVGYWN0b3IpOwogICAgIHRyYW5zZm9y bS50cmFuc2xhdGUocGFnZVBvc2l0aW9uKCkueCgpLCBwYWdlUG9zaXRpb24oKS55KCkpOwogI2Vu ZGlmCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9Fd2tWaWV3 SW1wbC5oIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvRXdrVmlld0ltcGwuaApp bmRleCA5OTk3OWMyMTQwZGUxZDVmZjk1ZmMxMzlkNjBiY2Q3OGYwNTc3OTUyLi40YmFmYzc3NzZi NDgyZGRiNjc2YWIwNTQxZDJhYzNhNzE3MGYyYmZiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9VSVByb2Nlc3MvQVBJL2VmbC9Fd2tWaWV3SW1wbC5oCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJ UHJvY2Vzcy9BUEkvZWZsL0V3a1ZpZXdJbXBsLmgKQEAgLTEwNyw4ICsxMDcsOCBAQCBwdWJsaWM6 CiAgICAgfkV3a1ZpZXdJbXBsKCk7CiAKICAgICBzdGF0aWMgRXdrVmlld0ltcGwqIGZyb21FdmFz T2JqZWN0KGNvbnN0IEV2YXNfT2JqZWN0KiB2aWV3KTsKLQogICAgIEV2YXNfT2JqZWN0KiB2aWV3 KCkgeyByZXR1cm4gbV92aWV3OyB9CisKICAgICBXS1BhZ2VSZWYgd2tQYWdlKCk7CiAgICAgV2Vi S2l0OjpXZWJQYWdlUHJveHkqIHBhZ2UoKSB7IHJldHVybiBtX3BhZ2VQcm94eS5nZXQoKTsgfQog ICAgIEV3a0NvbnRleHQqIGV3a0NvbnRleHQoKSB7IHJldHVybiBtX2NvbnRleHQuZ2V0KCk7IH0K QEAgLTEyMCw2ICsxMjAsOCBAQCBwdWJsaWM6CiAgICAgYm9vbCBpc0ZvY3VzZWQoKSBjb25zdDsK ICAgICBib29sIGlzVmlzaWJsZSgpIGNvbnN0OwogCisgICAgdm9pZCBzZXREZXZpY2VTY2FsZUZh Y3RvcihmbG9hdCBzY2FsZSk7CisKICAgICBXZWJDb3JlOjpBZmZpbmVUcmFuc2Zvcm0gdHJhbnNm b3JtVG9TY2VuZSgpIGNvbnN0OwogICAgIFdlYkNvcmU6OkFmZmluZVRyYW5zZm9ybSB0cmFuc2Zv cm1Gcm9tU2NlbmUoKSBjb25zdDsKICAgICBXZWJDb3JlOjpBZmZpbmVUcmFuc2Zvcm0gdHJhbnNm b3JtVG9TY3JlZW4oKSBjb25zdDsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vz cy9BUEkvZWZsL2V3a192aWV3LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZs L2V3a192aWV3LmNwcAppbmRleCA1MjA2YmQ2YzA3NDVlODVlNDBjNzIxY2MzNDU5MTBlMjY2NWM1 ODMyLi4xNTRlOWM2MWY3NjU4NTMwM2Q3M2JiZjVlN2YwMWE5MWNlM2E4NTY0IDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9ld2tfdmlldy5jcHAKKysrIGIvU291 cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvZXdrX3ZpZXcuY3BwCkBAIC02NDAsNyArNjQw LDcgQEAgRWluYV9Cb29sIGV3a192aWV3X2RldmljZV9waXhlbF9yYXRpb19zZXQoRXZhc19PYmpl Y3QqIGV3a1ZpZXcsIGZsb2F0IHJhdGlvKQogewogICAgIEVXS19WSUVXX0lNUExfR0VUX09SX1JF VFVSTihld2tWaWV3LCBpbXBsLCBmYWxzZSk7CiAKLSAgICBpbXBsLT5wYWdlKCktPnNldEludHJp bnNpY0RldmljZVNjYWxlRmFjdG9yKHJhdGlvKTsKKyAgICBpbXBsLT5zZXREZXZpY2VTY2FsZUZh Y3RvcihyYXRpbyk7CiAKICAgICByZXR1cm4gdHJ1ZTsKIH0K