105398 2012-12-19 00:37:00 -0800 [BlackBerry] Fix undesired re-entrant calls during media error dialog 2012-12-19 05:14:51 -0800 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mfeil mfeil eric.carlson feature-media-reviews mifenton rwlbuis tonikitoo webkit.review.bot yong.li.webkit oldest_to_newest 794408 0 mfeil 2012-12-19 00:37:00 -0800 A recent change in libwebview/fe1e943 to the dialog handling means that dialogs are not truly blocking anymore. While the dialog is up, a sub-event loop is called. Therefore the HTML5 media code will continue processing pps messages from mm-renderer, responding to periodic timers, etc., all while a media error dialog call higher up in the stack is waiting for the user to respond. Unfortunately some places in our code do not anticipate being called in a re-entrant way. This patch restores behaviour to how it was previous to libwebview/fe1e943. 794416 1 180111 mfeil 2012-12-19 00:43:13 -0800 Created attachment 180111 Patch 794544 2 180111 rwlbuis 2012-12-19 05:07:24 -0800 Comment on attachment 180111 Patch LGTM. 794553 3 180111 webkit.review.bot 2012-12-19 05:14:47 -0800 Comment on attachment 180111 Patch Clearing flags on attachment: 180111 Committed r138145: <http://trac.webkit.org/changeset/138145> 794554 4 webkit.review.bot 2012-12-19 05:14:51 -0800 All reviewed patches have been landed. Closing bug. 180111 2012-12-19 00:43:13 -0800 2012-12-19 05:14:47 -0800 Patch bug-105398-20121219034030.patch text/plain 2227 mfeil U3VidmVyc2lvbiBSZXZpc2lvbjogMTM4MDcwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNmQ4MjkwODk2NzBiZDc4 YWZhNjJkMzBlZTBhOWJlMjZhMmE4ZWQ2Ny4uZjhkZmFlZjBjMjJiMjdjNGMwZDMwNTAwMjE5YTg5 YTAwNmNjOTY0MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDEyLTEyLTE5ICBNYXgg RmVpbCAgPG1mZWlsQHJpbS5jb20+CisKKyAgICAgICAgW0JsYWNrQmVycnldIEZpeCB1bmRlc2ly ZWQgcmUtZW50cmFudCBjYWxscyBkdXJpbmcgbWVkaWEgZXJyb3IgZGlhbG9nCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDUzOTgKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBIHJlY2VudCBjaGFuZ2UgaW4g bGlid2VidmlldyAoUFIxOTQzNzkpIHRvIHRoZSBkaWFsb2cKKyAgICAgICAgaGFuZGxpbmcgbWVh bnMgdGhhdCBkaWFsb2dzIGFyZSBub3QgdHJ1bHkgYmxvY2tpbmcgYW55bW9yZS4KKyAgICAgICAg V2hpbGUgdGhlIGRpYWxvZyBpcyB1cCwgYSBzdWItZXZlbnQgbG9vcCBpcyBjYWxsZWQuIFRoZXJl Zm9yZQorICAgICAgICB0aGUgSFRNTDUgbWVkaWEgY29kZSB3aWxsIGNvbnRpbnVlIHByb2Nlc3Np bmcgcHBzIG1lc3NhZ2VzIGZyb20KKyAgICAgICAgbW0tcmVuZGVyZXIsIHJlc3BvbmRpbmcgdG8g cGVyaW9kaWMgdGltZXJzLCBldGMuLCBhbGwgd2hpbGUgYQorICAgICAgICBtZWRpYSBlcnJvciBk aWFsb2cgY2FsbCBoaWdoZXIgdXAgaW4gdGhlIHN0YWNrIGlzIHdhaXRpbmcgZm9yCisgICAgICAg IHRoZSB1c2VyIHRvIHJlc3BvbmQuIFVuZm9ydHVuYXRlbHkgY2VydGFpbiBwbGFjZXMgaW4gb3Vy IGNvZGUKKyAgICAgICAgZG8gbm90IGFudGljaXBhdGUgYmVpbmcgY2FsbGVkIGluIHRoaXMgcmUt ZW50cmFudCB3YXkuCisKKyAgICAgICAgVGhpcyBwYXRjaCByZXN0b3JlcyBwcmV2aW91cyBiZWhh dmlvdXIsIGNvdmVyZWQgYnkgZXhpc3RpbmcgdGVzdHMuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9n cmFwaGljcy9ibGFja2JlcnJ5L01lZGlhUGxheWVyUHJpdmF0ZUJsYWNrQmVycnkuY3BwOgorICAg ICAgICAoV2ViQ29yZTo6TWVkaWFQbGF5ZXJQcml2YXRlOjp3YWl0TWV0YWRhdGFUaW1lckZpcmVk KToKKwogMjAxMi0xMi0xOCAgQmV0aCBEYWtpbiAgPGJkYWtpbkBhcHBsZS5jb20+CiAKICAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMjU3OQpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvYmxhY2tiZXJyeS9NZWRpYVBs YXllclByaXZhdGVCbGFja0JlcnJ5LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBo aWNzL2JsYWNrYmVycnkvTWVkaWFQbGF5ZXJQcml2YXRlQmxhY2tCZXJyeS5jcHAKaW5kZXggOWRk ZWJlYmZjN2U2MjY2NmFmY2JmNTFhNmQzMmQxNjJkNGNjYTQxNi4uMzMzZTMyNjdlZDQxOTAyYjI3 ZTkxZDA1YTBmOWIzMWY0ZGU5ZDllYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvYmxhY2tiZXJyeS9NZWRpYVBsYXllclByaXZhdGVCbGFja0JlcnJ5LmNwcAor KysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9ibGFja2JlcnJ5L01lZGlhUGxh eWVyUHJpdmF0ZUJsYWNrQmVycnkuY3BwCkBAIC03MDYsNyArNzA2LDExIEBAIHZvaWQgTWVkaWFQ bGF5ZXJQcml2YXRlOjp3YWl0TWV0YWRhdGFUaW1lckZpcmVkKFRpbWVyPE1lZGlhUGxheWVyUHJp dmF0ZT4qKQogICAgIH0KICAgICBtX3dhaXRNZXRhZGF0YVBvcERpYWxvZ0NvdW50ZXIgPSAwOwog CisgICAgLy8gTmVlZCB0byBwcmV2ZW50IHJlLWVudHJhbnQgcGxheSBoZXJlCisgICAgbV9wbGF0 Zm9ybVBsYXllci0+c2V0UHJldmVudFJlZW50cmFudFBsYXkodHJ1ZSk7CiAgICAgaW50IHdhaXQg PSBzaG93RXJyb3JEaWFsb2coUGxhdGZvcm1QbGF5ZXI6Ok1lZGlhTWV0YURhdGFUaW1lb3V0RXJy b3IpOworICAgIG1fcGxhdGZvcm1QbGF5ZXItPnNldFByZXZlbnRSZWVudHJhbnRQbGF5KGZhbHNl KTsKKwogICAgIGlmICghd2FpdCkKICAgICAgICAgb25QYXVzZU5vdGlmaWVkKCk7CiAgICAgZWxz ZSB7Cg==