105395 2012-12-18 23:30:44 -0800 Unused parameters on WebContext.cpp 2012-12-19 00:22:28 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ktf.kim ktf.kim haraken webkit.review.bot oldest_to_newest 794378 0 ktf.kim 2012-12-18 23:30:44 -0800 The allowSpecificHTTPSCertificateForHost (by bug 105235 ) function's certificate, host parameters are not used if !ENABLE(NETWORK_PROCESS). Use UNUSED_PARAM macro to fix build warning. Source/WebKit2/UIProcess/WebContext.cpp:1051:6: warning: unused parameter 'certificate' [-Wunused-parameter] Source/WebKit2/UIProcess/WebContext.cpp:1051:6: warning: unused parameter 'host' [-Wunused-parameter] 794386 1 180102 ktf.kim 2012-12-18 23:35:09 -0800 Created attachment 180102 Patch 794403 2 180102 haraken 2012-12-19 00:02:59 -0800 Comment on attachment 180102 Patch ok 794406 3 180102 webkit.review.bot 2012-12-19 00:22:25 -0800 Comment on attachment 180102 Patch Clearing flags on attachment: 180102 Committed r138126: <http://trac.webkit.org/changeset/138126> 794407 4 webkit.review.bot 2012-12-19 00:22:28 -0800 All reviewed patches have been landed. Closing bug. 180102 2012-12-18 23:35:09 -0800 2012-12-19 00:22:25 -0800 Patch bug-105395-20121219163230.patch text/plain 1627 ktf.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMTM4MTE4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNTM5ZGVmZGE5NTQwMDZk MGVmZTQ5Yzc0OGRiNGU0ZDBkODU5ZWY1ZC4uNGVmNjU4ZGZmODY2YTZiZGJiZjA5OWRlOGEyOGU3 NzQ5ZWU5YTY4NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTEyLTE4ICBLeXVu Z1RhZSBLaW0gIDxrdGYua2ltQHNhbXN1bmcuY29tPgorCisgICAgICAgIFVudXNlZCBwYXJhbWV0 ZXJzIG9uIFdlYkNvbnRleHQuY3BwCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xMDUzOTUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBCZWNhdXNlIHRoZSBwYXJhbWV0ZXJzICdjZXJ0ZmljYXRlJywgJ2hvc3Qn IGFyZSBub3QgdXNlZCBpZiAhRU5BQkxFKE5FVFdPUktfUFJPQ0VTUyksIAorICAgICAgICB1c2Ug VU5VU0VEX1BBUkFNIG1hY3JvIHRvIGZpeCBidWlsZCB3YXJuaW5nIC1XdW51c2VkLXBhcmFtZXRl ci4KKworICAgICAgICAqIFVJUHJvY2Vzcy9XZWJDb250ZXh0LmNwcDoKKyAgICAgICAgKFdlYktp dDo6V2ViQ29udGV4dDo6YWxsb3dTcGVjaWZpY0hUVFBTQ2VydGlmaWNhdGVGb3JIb3N0KToKKwog MjAxMi0xMi0xOCAgQWxleGV5IFByb3NrdXJ5YWtvdiAgPGFwQGFwcGxlLmNvbT4KIAogICAgICAg ICBSZW1vdmUgdW5uZWNlc3NhcnkgZnVuY3Rpb25zIGZyb20gQ29va2llc1N0cmF0ZWd5CmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViQ29udGV4dC5jcHAgYi9Tb3VyY2Uv V2ViS2l0Mi9VSVByb2Nlc3MvV2ViQ29udGV4dC5jcHAKaW5kZXggNmZjZjlhYzEyNmY5YmJhOWRj ODE2NDQ3MWRmNjU4ZGJiN2JmZWQ1OC4uNmYxNjJiZDA4YmUyNzRiZDcxZmZhZjk5NzAyOWExNjgy MTM5Njc5OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYkNvbnRleHQu Y3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJDb250ZXh0LmNwcApAQCAtMTA1 NSw2ICsxMDU1LDkgQEAgdm9pZCBXZWJDb250ZXh0OjphbGxvd1NwZWNpZmljSFRUUFNDZXJ0aWZp Y2F0ZUZvckhvc3QoY29uc3QgV2ViQ2VydGlmaWNhdGVJbmZvKgogICAgICAgICBtX25ldHdvcmtQ cm9jZXNzLT5zZW5kKE1lc3NhZ2VzOjpOZXR3b3JrUHJvY2Vzczo6QWxsb3dTcGVjaWZpY0hUVFBT Q2VydGlmaWNhdGVGb3JIb3N0KGNlcnRpZmljYXRlLT5wbGF0Zm9ybUNlcnRpZmljYXRlSW5mbygp LCBob3N0KSwgMCk7CiAgICAgICAgIHJldHVybjsKICAgICB9CisjZWxzZQorICAgIFVOVVNFRF9Q QVJBTShjZXJ0aWZpY2F0ZSk7CisgICAgVU5VU0VEX1BBUkFNKGhvc3QpOwogI2VuZGlmCiAgICAg Ly8gRklYTUU6IEl0J3MgdW5jbGVhciB3aGV0aGVyIHdlIHdhbnQgdGhpcyBTUEkgdG8gYmUgZXhw b3NlZCBhbmQgdXNlZCBmb3IgY2xpZW50cyB0aGF0IGRvbid0IHVzZSB0aGUgTmV0d29ya1Byb2Nl c3MuCiAgICAgQVNTRVJUX05PVF9SRUFDSEVEKCk7Cg==