105392 2012-12-18 23:05:36 -0800 [EFL] regression(r138071) Add mission functions for build fix 2012-12-18 23:34:09 -0800 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ktf.kim ktf.kim webkit.review.bot oldest_to_newest 794365 0 ktf.kim 2012-12-18 23:05:36 -0800 r138071 add new functions in WebCore/platform/LocalizedStrings.cpp, but EFL port doesn't use it. So, add that functions to WebCore/platform/efl/LocalizedStringsEfl.cpp 794366 1 180095 ktf.kim 2012-12-18 23:08:36 -0800 Created attachment 180095 Patch 794371 2 180095 rniwa 2012-12-18 23:15:43 -0800 Comment on attachment 180095 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=180095&action=review > Source/WebCore/ChangeLog:9 > + So, add that functions to LocalizedStringsEfl.cpp add “those” functions. 794373 3 180100 ktf.kim 2012-12-18 23:16:59 -0800 Created attachment 180100 Patch 794384 4 180100 webkit.review.bot 2012-12-18 23:34:06 -0800 Comment on attachment 180100 Patch Clearing flags on attachment: 180100 Committed r138120: <http://trac.webkit.org/changeset/138120> 794385 5 webkit.review.bot 2012-12-18 23:34:09 -0800 All reviewed patches have been landed. Closing bug. 180095 2012-12-18 23:08:36 -0800 2012-12-18 23:16:54 -0800 Patch bug-105392-20121219160552.patch text/plain 1789 ktf.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMTM4MTE1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTQyNzk2MGUxMmNlMTEz YTgzNjBhYjcxMmI2ZjI4ZTdmNDkwMDgwMS4uZGQ4NDYyNDUxZmExYWNkZjViYTBlMTJhMThlN2U2 YTAzMGMxZGUzMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEyLTEyLTE4ICBLeXVu Z1RhZSBLaW0gIDxrdGYua2ltQHNhbXN1bmcuY29tPgorCisgICAgICAgIFtFRkxdIHJlZ3Jlc3Np b24ocjEzODA3MSkgQWRkIG1pc3Npb24gZnVuY3Rpb25zIGZvciBidWlsZCBmaXgKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNTM5MgorCisgICAgICAg IFVucmV2aWV3ZWQgYnVpbGQgZml4LgorCisgICAgICAgIHIxMzgwNzEgYWRkIG5ldyBmdW5jdGlv bnMgdG8gTG9jYWxpemVkU3RyaW5ncy5jcHAsIGJ1dCBFRkwgcG9ydCBkb2Vzbid0IHVzZSBpdC4K KyAgICAgICAgU28sIGFkZCB0aGF0IGZ1bmN0aW9ucyB0byBMb2NhbGl6ZWRTdHJpbmdzRWZsLmNw cCAKKworICAgICAgICAqIHBsYXRmb3JtL2VmbC9Mb2NhbGl6ZWRTdHJpbmdzRWZsLmNwcDoKKyAg ICAgICAgKFdlYkNvcmUpOgorICAgICAgICAoV2ViQ29yZTo6dGV4dFRyYWNrQ2xvc2VkQ2FwdGlv bnNUZXh0KToKKyAgICAgICAgKFdlYkNvcmU6OnRleHRUcmFja1N1YnRpdGxlc1RleHQpOgorICAg ICAgICAoV2ViQ29yZTo6dGV4dFRyYWNrT2ZmVGV4dCk6CisgICAgICAgIChXZWJDb3JlOjp0ZXh0 VHJhY2tOb0xhYmVsVGV4dCk6CisKIDIwMTItMTItMTggIFNoZXJpZmYgQm90ICA8d2Via2l0LnJl dmlldy5ib3RAZ21haWwuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHIx MzgwOTcuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9lZmwvTG9jYWxpemVk U3RyaW5nc0VmbC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9lZmwvTG9jYWxpemVkU3Ry aW5nc0VmbC5jcHAKaW5kZXggODdiOTU2YzM3NmYzN2YyNTdjNTc4YjA1YzU3NjEzZTU0NjZhOTBm Yi4uNTU0MjQyYmRjODQ2MzQzNjkzNmVlMTM2YzE3YzBhYmU5NGZmMjBmNCAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZWZsL0xvY2FsaXplZFN0cmluZ3NFZmwuY3BwCisrKyBi L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2VmbC9Mb2NhbGl6ZWRTdHJpbmdzRWZsLmNwcApAQCAt NTk0LDQgKzU5NCwyNiBAQCBTdHJpbmcgbG9jYWxpemVkU3RyaW5nKGNvbnN0IGNoYXIqIGtleSkK ICAgICByZXR1cm4gU3RyaW5nOjpmcm9tVVRGOChrZXksIHN0cmxlbihrZXkpKTsKIH0KIAorI2lm IEVOQUJMRShWSURFT19UUkFDSykKK1N0cmluZyB0ZXh0VHJhY2tDbG9zZWRDYXB0aW9uc1RleHQo KQoreworICAgIHJldHVybiBTdHJpbmc6OmZyb21VVEY4KCJDbG9zZWQgQ2FwdGlvbnMiKTsKK30K KworU3RyaW5nIHRleHRUcmFja1N1YnRpdGxlc1RleHQoKQoreworICAgIHJldHVybiBTdHJpbmc6 OmZyb21VVEY4KCJTdWJ0aXRsZXMiKTsKK30KKworU3RyaW5nIHRleHRUcmFja09mZlRleHQoKQor eworICAgIHJldHVybiBTdHJpbmc6OmZyb21VVEY4KCJPZmYiKTsKK30KKworU3RyaW5nIHRleHRU cmFja05vTGFiZWxUZXh0KCkKK3sKKyAgICByZXR1cm4gU3RyaW5nOjpmcm9tVVRGOCgiTm8gbGFi ZWwiKTsKK30KKyNlbmRpZgorCiB9Cg== 180100 2012-12-18 23:16:59 -0800 2012-12-18 23:34:06 -0800 Patch bug-105392-20121219161415.patch text/plain 1792 ktf.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMTM4MTE1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTQyNzk2MGUxMmNlMTEz YTgzNjBhYjcxMmI2ZjI4ZTdmNDkwMDgwMS4uYWFkMDY3MDMwNTQ0YzBjODVlNGVmMmY2ZDk4Yzk4 ZjE5NDU5NTRkOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEyLTEyLTE4ICBLeXVu Z1RhZSBLaW0gIDxrdGYua2ltQHNhbXN1bmcuY29tPgorCisgICAgICAgIFtFRkxdIHJlZ3Jlc3Np b24ocjEzODA3MSkgQWRkIG1pc3Npb24gZnVuY3Rpb25zIGZvciBidWlsZCBmaXgKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNTM5MgorCisgICAgICAg IFVucmV2aWV3ZWQgYnVpbGQgZml4LgorCisgICAgICAgIHIxMzgwNzEgYWRkIG5ldyBmdW5jdGlv bnMgdG8gTG9jYWxpemVkU3RyaW5ncy5jcHAsIGJ1dCBFRkwgcG9ydCBkb2Vzbid0IHVzZSB0aGVt LgorICAgICAgICBTbywgYWRkIHRob3NlIGZ1bmN0aW9ucyB0byBMb2NhbGl6ZWRTdHJpbmdzRWZs LmNwcCAKKworICAgICAgICAqIHBsYXRmb3JtL2VmbC9Mb2NhbGl6ZWRTdHJpbmdzRWZsLmNwcDoK KyAgICAgICAgKFdlYkNvcmUpOgorICAgICAgICAoV2ViQ29yZTo6dGV4dFRyYWNrQ2xvc2VkQ2Fw dGlvbnNUZXh0KToKKyAgICAgICAgKFdlYkNvcmU6OnRleHRUcmFja1N1YnRpdGxlc1RleHQpOgor ICAgICAgICAoV2ViQ29yZTo6dGV4dFRyYWNrT2ZmVGV4dCk6CisgICAgICAgIChXZWJDb3JlOjp0 ZXh0VHJhY2tOb0xhYmVsVGV4dCk6CisKIDIwMTItMTItMTggIFNoZXJpZmYgQm90ICA8d2Via2l0 LnJldmlldy5ib3RAZ21haWwuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0 IHIxMzgwOTcuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9lZmwvTG9jYWxp emVkU3RyaW5nc0VmbC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9lZmwvTG9jYWxpemVk U3RyaW5nc0VmbC5jcHAKaW5kZXggODdiOTU2YzM3NmYzN2YyNTdjNTc4YjA1YzU3NjEzZTU0NjZh OTBmYi4uNTU0MjQyYmRjODQ2MzQzNjkzNmVlMTM2YzE3YzBhYmU5NGZmMjBmNCAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZWZsL0xvY2FsaXplZFN0cmluZ3NFZmwuY3BwCisr KyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2VmbC9Mb2NhbGl6ZWRTdHJpbmdzRWZsLmNwcApA QCAtNTk0LDQgKzU5NCwyNiBAQCBTdHJpbmcgbG9jYWxpemVkU3RyaW5nKGNvbnN0IGNoYXIqIGtl eSkKICAgICByZXR1cm4gU3RyaW5nOjpmcm9tVVRGOChrZXksIHN0cmxlbihrZXkpKTsKIH0KIAor I2lmIEVOQUJMRShWSURFT19UUkFDSykKK1N0cmluZyB0ZXh0VHJhY2tDbG9zZWRDYXB0aW9uc1Rl eHQoKQoreworICAgIHJldHVybiBTdHJpbmc6OmZyb21VVEY4KCJDbG9zZWQgQ2FwdGlvbnMiKTsK K30KKworU3RyaW5nIHRleHRUcmFja1N1YnRpdGxlc1RleHQoKQoreworICAgIHJldHVybiBTdHJp bmc6OmZyb21VVEY4KCJTdWJ0aXRsZXMiKTsKK30KKworU3RyaW5nIHRleHRUcmFja09mZlRleHQo KQoreworICAgIHJldHVybiBTdHJpbmc6OmZyb21VVEY4KCJPZmYiKTsKK30KKworU3RyaW5nIHRl eHRUcmFja05vTGFiZWxUZXh0KCkKK3sKKyAgICByZXR1cm4gU3RyaW5nOjpmcm9tVVRGOCgiTm8g bGFiZWwiKTsKK30KKyNlbmRpZgorCiB9Cg==