105376 2012-12-18 18:41:39 -0800 StringImpl isolatedCopy unnecessarily copies text-segment character data 2012-12-19 14:00:26 -0800 1 1 1 Unclassified WebKit Web Template Framework 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 oliver oliver oldest_to_newest 794261 0 oliver 2012-12-18 18:41:39 -0800 As in the title, StringImpl::isolatedCopy is unnecessarily expensive 794910 1 180222 oliver 2012-12-19 13:57:07 -0800 Created attachment 180222 Patch 794913 2 oliver 2012-12-19 14:00:26 -0800 Committed r138194: <http://trac.webkit.org/changeset/138194> 180222 2012-12-19 13:57:07 -0800 2012-12-19 13:59:14 -0800 Patch bug-105376-20121219135423.patch text/plain 2098 oliver U3VidmVyc2lvbiBSZXZpc2lvbjogMTM4MTkzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDAwNjE3ZDdhNTA3MWI4MTQyODY2MzRl NTc1MDhkYjQ5ZmFkYTk0NmUuLmEwOTc3ZmRlYmU4YTQ4MjU3MGIxODdkOGM3MWE3ZWM1M2EwYmNj NTMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDUgKzEsMjEgQEAKIDIwMTItMTItMTkgIE9saXZlciBIdW50ICA8b2xpdmVy QGFwcGxlLmNvbT4KIAorICAgICAgICBTdHJpbmdJbXBsIGlzb2xhdGVkQ29weSB1bm5lY2Vzc2Fy aWx5IGNvcGllcyB0ZXh0LXNlZ21lbnQgY2hhcmFjdGVyIGRhdGEKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNTM3NgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgcGF0Y2ggYWRkcyBhIG5ldyAocHJp dmF0ZSkgaGVscGVyIHRvIFN0cmluZ0ltcGwgdGhhdCB0ZXN0cyB3aGV0aGVyIHRoZSBTdHJpbmdJ bXBsCisgICAgICAgIGlzIGJhY2tlZCBieSBhbiBBU0NJSSBsaXRlcmFsLiAgVGhpcyBhbGxvd3Mg aXNvbGF0ZWRDb3B5KCkgdG8gc2FmZWx5IHVzZSB0aGUgY3JlYXRlRnJvbUxpdGVyYWwKKyAgICAg ICAgY29uc3RydWN0b3IgcmF0aGVyIHRoYW4gbWFraW5nIGFuIHVubmVjZXNzYXJ5IGNvcHkuCisK KyAgICAgICAgKiB3dGYvdGV4dC9TdHJpbmdJbXBsLmg6CisgICAgICAgIChTdHJpbmdJbXBsKToK KyAgICAgICAgKFdURjo6U3RyaW5nSW1wbDo6aXNBU0NJSUxpdGVyYWwpOgorICAgICAgICAoV1RG OjpTdHJpbmdJbXBsOjppc29sYXRlZENvcHkpOgorCisyMDEyLTEyLTE5ICBPbGl2ZXIgSHVudCAg PG9saXZlckBhcHBsZS5jb20+CisKICAgICAgICAgV1RGIFN0cmluZyBmcm9tIEFTQ0lJTGl0ZXJh bCBmYWlscyB0byBjb3JyZWN0bHkgaGFuZGxlIGVtcHR5IHN0cmluZ3MuCiAgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDU0NTMKIApkaWZmIC0tZ2l0IGEv U291cmNlL1dURi93dGYvdGV4dC9TdHJpbmdJbXBsLmggYi9Tb3VyY2UvV1RGL3d0Zi90ZXh0L1N0 cmluZ0ltcGwuaAppbmRleCAyODYxOTQ5ZTVkYmM0MzUxMjM3NmU5MWZiOGM1ODAwYmI4MDQ5NzEx Li44ZjU0YTRiM2M0ZDJkNTcwYzVhNjhiN2U3ZjVhNGU5NWNmMjZhYjU1IDEwMDY0NAotLS0gYS9T b3VyY2UvV1RGL3d0Zi90ZXh0L1N0cmluZ0ltcGwuaAorKysgYi9Tb3VyY2UvV1RGL3d0Zi90ZXh0 L1N0cmluZ0ltcGwuaApAQCAtNzI5LDYgKzcyOSwxMiBAQCBwdWJsaWM6CiAjZW5kaWYKIAogcHJp dmF0ZToKKworICAgIGJvb2wgaXNBU0NJSUxpdGVyYWwoKSBjb25zdAorICAgIHsKKyAgICAgICAg cmV0dXJuIGlzOEJpdCgpICYmIGhhc0ludGVybmFsQnVmZmVyKCkgJiYgcmVpbnRlcnByZXRfY2Fz dDxjb25zdCB2b2lkKj4obV9kYXRhOCkgIT0gcmVpbnRlcnByZXRfY2FzdDxjb25zdCB2b2lkKj4o dGhpcyArIDEpOworICAgIH0KKwogICAgIC8vIFRoaXMgbnVtYmVyIG11c3QgYmUgYXQgbGVhc3Qg MiB0byBhdm9pZCBzaGFyaW5nIGVtcHR5LCBudWxsIGFzIHdlbGwgYXMgMSBjaGFyYWN0ZXIgc3Ry aW5ncyBmcm9tIFNtYWxsU3RyaW5ncy4KICAgICBzdGF0aWMgY29uc3QgdW5zaWduZWQgc19jb3B5 Q2hhcnNJbmxpbmVDdXRPZmYgPSAyMDsKIApAQCAtMTEyNiw2ICsxMTMyLDggQEAgc3RhdGljIGlu bGluZSBib29sIGlzU3BhY2VPck5ld2xpbmUoVUNoYXIgYykKIAogaW5saW5lIFBhc3NSZWZQdHI8 U3RyaW5nSW1wbD4gU3RyaW5nSW1wbDo6aXNvbGF0ZWRDb3B5KCkgY29uc3QKIHsKKyAgICBpZiAo aXNBU0NJSUxpdGVyYWwoKSkKKyAgICAgICAgcmV0dXJuIFN0cmluZ0ltcGw6OmNyZWF0ZUZyb21M aXRlcmFsKHJlaW50ZXJwcmV0X2Nhc3Q8Y29uc3QgY2hhcio+KG1fZGF0YTgpLCBtX2xlbmd0aCk7 CiAgICAgaWYgKGlzOEJpdCgpKQogICAgICAgICByZXR1cm4gY3JlYXRlKG1fZGF0YTgsIG1fbGVu Z3RoKTsKICAgICByZXR1cm4gY3JlYXRlKG1fZGF0YTE2LCBtX2xlbmd0aCk7Cg==