105370 2012-12-18 16:54:37 -0800 REGRESSION(r133820?): SimplifyMarkupTest API test asserts 2013-01-25 22:33:36 -0800 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 simon.fraser rniwa enrica mifenton rniwa simon.fraser webkit.review.bot oldest_to_newest 794185 0 simon.fraser 2012-12-18 16:54:37 -0800 http://build.webkit.org/builders/Apple%20MountainLion%20Debug%20WK1%20%28Tests%29/builds/3959/steps/run-api-tests/logs/stdio Note: Google Test filter = WebKit1.SimplifyMarkupTest [==========] Running 1 test from 1 test case. [----------] Global test environment set-up. [----------] 1 test from WebKit1 [ RUN ] WebKit1.SimplifyMarkupTest ASSERTION FAILED: m_refChild->parentNode() /Volumes/Data/slave/mountainlion-debug/build/Source/WebCore/editing/InsertNodeBeforeCommand.cpp(45) : WebCore::InsertNodeBeforeCommand::InsertNodeBeforeCommand(PassRefPtr<WebCore::Node>, PassRefPtr<WebCore::Node>, WebCore::ShouldAssumeContentIsAlwaysEditable) 1 0x10dff00d6 WebCore::InsertNodeBeforeCommand::InsertNodeBeforeCommand(WTF::PassRefPtr<WebCore::Node>, WTF::PassRefPtr<WebCore::Node>, WebCore::ShouldAssumeContentIsAlwaysEditable) 2 0x10dfefecb WebCore::InsertNodeBeforeCommand::InsertNodeBeforeCommand(WTF::PassRefPtr<WebCore::Node>, WTF::PassRefPtr<WebCore::Node>, WebCore::ShouldAssumeContentIsAlwaysEditable) 3 0x10d81b6f2 WebCore::InsertNodeBeforeCommand::create(WTF::PassRefPtr<WebCore::Node>, WTF::PassRefPtr<WebCore::Node>, WebCore::ShouldAssumeContentIsAlwaysEditable) 4 0x10d812f91 WebCore::CompositeEditCommand::insertNodeBefore(WTF::PassRefPtr<WebCore::Node>, WTF::PassRefPtr<WebCore::Node>, WebCore::ShouldAssumeContentIsAlwaysEditable) 5 0x10e8a9a2f WebCore::RemoveNodePreservingChildrenCommand::doApply() 6 0x10d8129bf WebCore::CompositeEditCommand::applyCommandToComposite(WTF::PassRefPtr<WebCore::EditCommand>) 7 0x10d813a0d WebCore::CompositeEditCommand::removeNodePreservingChildren(WTF::PassRefPtr<WebCore::Node>, WebCore::ShouldAssumeContentIsAlwaysEditable) 8 0x10ecb224c WebCore::SimplifyMarkupCommand::doApply() 9 0x10d812594 WebCore::CompositeEditCommand::apply() 10 0x10d8123c1 WebCore::applyCommand(WTF::PassRefPtr<WebCore::CompositeEditCommand>) 11 0x10dc2e948 WebCore::Editor::simplifyMarkup(WebCore::Node*, WebCore::Node*) 12 0x10adbb7fb -[WebView(WebViewEditingInMail) _simplifyMarkup:endNode:] 13 0x10a74cf07 TestWebKitAPI::WebKit1_SimplifyMarkupTest_Test::TestBody() 14 0x10a7d893a testing::Test::Run() 15 0x10a7d93ad testing::internal::TestInfoImpl::Run() 16 0x10a7d9f5d testing::TestCase::Run() 17 0x10a7dfec3 testing::internal::UnitTestImpl::RunAllTests() 18 0x10a7dfb19 testing::UnitTest::Run() 19 0x10a766b00 TestWebKitAPI::TestsController::run(int, char**) 20 0x10a708df1 main 21 0x7fff90b8c7e1 start 22 0x2 794203 1 simon.fraser 2012-12-18 17:16:37 -0800 Test disabled in http://trac.webkit.org/changeset/138089 795159 2 rniwa 2012-12-19 21:39:50 -0800 This is likely a regression from https://trac.webkit.org/changeset/133820. 795732 3 rniwa 2012-12-20 13:26:15 -0800 WTH... I swear I uploaded my patch last night :( I must have been half asleep back then. Uploading it now. 795734 4 180399 rniwa 2012-12-20 13:26:47 -0800 Created attachment 180399 Fixes the bug 795738 5 180400 rniwa 2012-12-20 13:32:11 -0800 Created attachment 180400 Improved the change log entry 795805 6 180400 simon.fraser 2012-12-20 14:30:17 -0800 Comment on attachment 180400 Improved the change log entry View in context: https://bugs.webkit.org/attachment.cgi?id=180400&action=review > Source/WebCore/editing/SimplifyMarkupCommand.cpp:114 > + if (pastLastNodeToRemove == startNodeIndex + 1) > + return 0; These return values are so mysterious. 795809 7 180400 rniwa 2012-12-20 14:32:16 -0800 Comment on attachment 180400 Improved the change log entry View in context: https://bugs.webkit.org/attachment.cgi?id=180400&action=review >> Source/WebCore/editing/SimplifyMarkupCommand.cpp:114 >> + return 0; > > These return values are so mysterious. Yeah :( 795818 8 180400 webkit.review.bot 2012-12-20 14:39:51 -0800 Comment on attachment 180400 Improved the change log entry Clearing flags on attachment: 180400 Committed r138303: <http://trac.webkit.org/changeset/138303> 795819 9 webkit.review.bot 2012-12-20 14:39:55 -0800 All reviewed patches have been landed. Closing bug. 795882 10 rniwa 2012-12-20 15:49:39 -0800 Reopening to attach new patch. 795883 11 180429 rniwa 2012-12-20 15:49:41 -0800 Created attachment 180429 Fixes the bug 795884 12 180429 rniwa 2012-12-20 15:50:06 -0800 Comment on attachment 180429 Fixes the bug Wrong patch. 180399 2012-12-20 13:26:47 -0800 2012-12-20 13:32:09 -0800 Fixes the bug bug-105370-20121220132404.patch text/plain 3252 rniwa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEzODIxOSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDEyLTEyLTE5ICBSeW9zdWtl IE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIFJFR1JFU1NJT04ocjEzMzgyMD8p OiBTaW1wbGlmeU1hcmt1cFRlc3QgQVBJIHRlc3QgYXNzZXJ0cworICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA1MzcwCisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ2hlY2sgaWYgd2UndmUgYWxyZWFkeSByZW1v dmVkIGEgcGFyZW50IG9yIG5vdCBmaXJzdC4KKworICAgICAgICBDb3ZlcnRlZCBieSBhbiBleGlz dGluZyBXZWJLaXQgQVBJIHRlc3QuCisKKyAgICAgICAgKiBlZGl0aW5nL1NpbXBsaWZ5TWFya3Vw Q29tbWFuZC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTaW1wbGlmeU1hcmt1cENvbW1hbmQ6OmRv QXBwbHkpOgorICAgICAgICAoV2ViQ29yZTo6U2ltcGxpZnlNYXJrdXBDb21tYW5kOjpwcnVuZVN1 YnNlcXVlbnRBbmNlc3RvcnNUb1JlbW92ZSk6CisgICAgICAgIChXZWJDb3JlKToKKwogMjAxMi0x Mi0xOSAgQ29zbWluIFRydXRhICA8Y3RydXRhQHJpbS5jb20+CiAKICAgICAgICAgW0JsYWNrQmVy cnldIFJTUyByZWFkZXIgbWFuZ2xlcyBVVEYtOApJbmRleDogU291cmNlL1dlYkNvcmUvZWRpdGlu Zy9TaW1wbGlmeU1hcmt1cENvbW1hbmQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3Jl L2VkaXRpbmcvU2ltcGxpZnlNYXJrdXBDb21tYW5kLmNwcAkocmV2aXNpb24gMTM4MTE5KQorKysg U291cmNlL1dlYkNvcmUvZWRpdGluZy9TaW1wbGlmeU1hcmt1cENvbW1hbmQuY3BwCSh3b3JraW5n IGNvcHkpCkBAIC0xMDUsMTUgKzEwNSwxMyBAQCBpbnQgU2ltcGxpZnlNYXJrdXBDb21tYW5kOjpw cnVuZVN1YnNlcXVlCiAgICAgICAgIEFTU0VSVChub2Rlc1RvUmVtb3ZlW3Bhc3RMYXN0Tm9kZVRv UmVtb3ZlXS0+Zmlyc3RDaGlsZCgpID09IG5vZGVzVG9SZW1vdmVbcGFzdExhc3ROb2RlVG9SZW1v dmVdLT5sYXN0Q2hpbGQoKSk7CiAgICAgfQogCi0gICAgaWYgKHBhc3RMYXN0Tm9kZVRvUmVtb3Zl ID09IHN0YXJ0Tm9kZUluZGV4ICsgMSkKLSAgICAgICAgcmV0dXJuIDA7Ci0KICAgICBOb2RlKiBo aWdoZXN0QW5jZXN0b3JUb1JlbW92ZSA9IG5vZGVzVG9SZW1vdmVbcGFzdExhc3ROb2RlVG9SZW1v dmUgLSAxXS5nZXQoKTsKLQotICAgIFJlZlB0cjxOb2RlPiBub2RlQWZ0ZXJIaWdoZXN0QW5jZXN0 b3JUb1JlbW92ZSA9IGhpZ2hlc3RBbmNlc3RvclRvUmVtb3ZlLT5uZXh0U2libGluZygpOwogICAg IFJlZlB0cjxDb250YWluZXJOb2RlPiBwYXJlbnQgPSBoaWdoZXN0QW5jZXN0b3JUb1JlbW92ZS0+ cGFyZW50Tm9kZSgpOwogICAgIGlmICghcGFyZW50KSAvLyBQYXJlbnQgaGFzIGFscmVhZHkgYmVl biByZW1vdmVkLgogICAgICAgICByZXR1cm4gLTE7CisgICAgCisgICAgaWYgKHBhc3RMYXN0Tm9k ZVRvUmVtb3ZlID09IHN0YXJ0Tm9kZUluZGV4ICsgMSkKKyAgICAgICAgcmV0dXJuIDA7CiAKICAg ICByZW1vdmVOb2RlKG5vZGVzVG9SZW1vdmVbc3RhcnROb2RlSW5kZXhdLCBBc3N1bWVDb250ZW50 SXNBbHdheXNFZGl0YWJsZSk7CiAgICAgaW5zZXJ0Tm9kZUJlZm9yZShub2Rlc1RvUmVtb3ZlW3N0 YXJ0Tm9kZUluZGV4XSwgaGlnaGVzdEFuY2VzdG9yVG9SZW1vdmUsIEFzc3VtZUNvbnRlbnRJc0Fs d2F5c0VkaXRhYmxlKTsKSW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29s cy9DaGFuZ2VMb2cJKHJldmlzaW9uIDEzODIxOSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDEyLTEyLTE5ICBSeW9zdWtlIE5pd2EgIDxybml3 YUB3ZWJraXQub3JnPgorCisgICAgICAgIFJFR1JFU1NJT04ocjEzMzgyMD8pOiBTaW1wbGlmeU1h cmt1cFRlc3QgQVBJIHRlc3QgYXNzZXJ0cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTA1MzcwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgUmUtZW5hYmxlIHRoZSB0ZXN0LgorCisgICAgICAgICogVGVzdFdl YktpdEFQSS9UZXN0cy9tYWMvU2ltcGxpZnlNYXJrdXAubW06CisgICAgICAgIChUZXN0V2ViS2l0 QVBJOjpURVNUKToKKwogMjAxMi0xMi0xOSAgUnlvc3VrZSBOaXdhICA8cm5pd2FAd2Via2l0Lm9y Zz4KIAogICAgICAgICBQZXJmVGVzdC5wYXJzZV9vdXRwdXQgZG9lcyB0b28gbXVjaApJbmRleDog VG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9tYWMvU2ltcGxpZnlNYXJrdXAubW0KPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9tYWMvU2ltcGxpZnlNYXJrdXAubW0JKHJl dmlzaW9uIDEzODExOSkKKysrIFRvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvbWFjL1NpbXBsaWZ5 TWFya3VwLm1tCSh3b3JraW5nIGNvcHkpCkBAIC00Nyw3ICs0Nyw3IEBAIC0gKHZvaWQpd2ViVmll dzooV2ViVmlldyAqKXNlbmRlciBkaWRGaW4KIAogbmFtZXNwYWNlIFRlc3RXZWJLaXRBUEkgewog Ci1URVNUKFdlYktpdDEsIERJU0FCTEVEX1NpbXBsaWZ5TWFya3VwVGVzdCkKK1RFU1QoV2ViS2l0 MSwgU2ltcGxpZnlNYXJrdXBUZXN0KQogewogICAgIFJldGFpblB0cjxXZWJWaWV3PiB3ZWJWaWV3 MShBZG9wdE5TLCBbW1dlYlZpZXcgYWxsb2NdIGluaXRXaXRoRnJhbWU6TlNNYWtlUmVjdCgwLCAw LCAxMjAsIDIwMCkgZnJhbWVOYW1lOm5pbCBncm91cE5hbWU6bmlsXSk7CiAgICAgUmV0YWluUHRy PFdlYlZpZXc+IHdlYlZpZXcyKEFkb3B0TlMsIFtbV2ViVmlldyBhbGxvY10gaW5pdFdpdGhGcmFt ZTpOU01ha2VSZWN0KDAsIDAsIDEyMCwgMjAwKSBmcmFtZU5hbWU6bmlsIGdyb3VwTmFtZTpuaWxd KTsK 180400 2012-12-20 13:32:11 -0800 2012-12-20 15:49:36 -0800 Improved the change log entry bug-105370-20121220132929.patch text/plain 3689 rniwa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEzODIxOSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIzIEBACisyMDEyLTEyLTE5ICBSeW9zdWtl IE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIFJFR1JFU1NJT04ocjEzMzgyMD8p OiBTaW1wbGlmeU1hcmt1cFRlc3QgQVBJIHRlc3QgYXNzZXJ0cworICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA1MzcwCisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIGJ1ZyB3YXMgY2F1c2VkIGJ5IFNpbXBs aWZ5TWFya3VwQ29tbWFuZDo6ZG9BcHBseSBjYWxsaW5nIHJlbW92ZU5vZGVQcmVzZXJ2aW5nQ2hp bGRyZW4gb24gbm9kZXMKKyAgICAgICAgdGhhdCBoYXZlIGFscmVhZHkgYmVlbiByZW1vdmVkLiBX ZSBub3JtYWxseSBjaGVjayB0aGlzIGNvbmRpdGlvbiBpbiBwcnVuZVN1YnNlcXVlbnRBbmNlc3Rv cnNUb1JlbW92ZQorICAgICAgICBidXQgd2Ugd2VyZW4ndCBjaGVja2luZyBpdCB3aGVuIHRoZXJl IHdlcmUgbm8gYW5jZXN0b3IgdG8gcmVtb3ZlIGJlY2F1c2Ugd2UgZWFybHkgZXhpdGVkIGluIHRo YXQgY2FzZS4KKworICAgICAgICBGaXhlZCB0aGUgYnVnIGJ5IGRvaW5nIHRoZSBlYXJseSBleGl0 IGZvciB3aGVuIHRoZSBub2RlJ3MgcGFyZW50IGhhZCBhbHJlYWR5IGJlZW4gcmVtb3ZlZCBmaXJz dC4KKworICAgICAgICBUZXN0OiBUZXN0V2ViS2l0QVBJL1Rlc3RzL21hYy9TaW1wbGlmeU1hcmt1 cC5tbQorCisgICAgICAgICogZWRpdGluZy9TaW1wbGlmeU1hcmt1cENvbW1hbmQuY3BwOgorICAg ICAgICAoV2ViQ29yZTo6U2ltcGxpZnlNYXJrdXBDb21tYW5kOjpkb0FwcGx5KToKKyAgICAgICAg KFdlYkNvcmU6OlNpbXBsaWZ5TWFya3VwQ29tbWFuZDo6cHJ1bmVTdWJzZXF1ZW50QW5jZXN0b3Jz VG9SZW1vdmUpOiBBbHNvIHJlbW92ZWQgYW4gdW51c2VkIHZhcmlhYmxlCisgICAgICAgIG5vZGVB ZnRlckhpZ2hlc3RBbmNlc3RvclRvUmVtb3ZlLgorCiAyMDEyLTEyLTE5ICBDb3NtaW4gVHJ1dGEg IDxjdHJ1dGFAcmltLmNvbT4KIAogICAgICAgICBbQmxhY2tCZXJyeV0gUlNTIHJlYWRlciBtYW5n bGVzIFVURi04CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9lZGl0aW5nL1NpbXBsaWZ5TWFya3VwQ29t bWFuZC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvZWRpdGluZy9TaW1wbGlmeU1h cmt1cENvbW1hbmQuY3BwCShyZXZpc2lvbiAxMzgxMTkpCisrKyBTb3VyY2UvV2ViQ29yZS9lZGl0 aW5nL1NpbXBsaWZ5TWFya3VwQ29tbWFuZC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTEwNSwxNSAr MTA1LDEzIEBAIGludCBTaW1wbGlmeU1hcmt1cENvbW1hbmQ6OnBydW5lU3Vic2VxdWUKICAgICAg ICAgQVNTRVJUKG5vZGVzVG9SZW1vdmVbcGFzdExhc3ROb2RlVG9SZW1vdmVdLT5maXJzdENoaWxk KCkgPT0gbm9kZXNUb1JlbW92ZVtwYXN0TGFzdE5vZGVUb1JlbW92ZV0tPmxhc3RDaGlsZCgpKTsK ICAgICB9CiAKLSAgICBpZiAocGFzdExhc3ROb2RlVG9SZW1vdmUgPT0gc3RhcnROb2RlSW5kZXgg KyAxKQotICAgICAgICByZXR1cm4gMDsKLQogICAgIE5vZGUqIGhpZ2hlc3RBbmNlc3RvclRvUmVt b3ZlID0gbm9kZXNUb1JlbW92ZVtwYXN0TGFzdE5vZGVUb1JlbW92ZSAtIDFdLmdldCgpOwotCi0g ICAgUmVmUHRyPE5vZGU+IG5vZGVBZnRlckhpZ2hlc3RBbmNlc3RvclRvUmVtb3ZlID0gaGlnaGVz dEFuY2VzdG9yVG9SZW1vdmUtPm5leHRTaWJsaW5nKCk7CiAgICAgUmVmUHRyPENvbnRhaW5lck5v ZGU+IHBhcmVudCA9IGhpZ2hlc3RBbmNlc3RvclRvUmVtb3ZlLT5wYXJlbnROb2RlKCk7CiAgICAg aWYgKCFwYXJlbnQpIC8vIFBhcmVudCBoYXMgYWxyZWFkeSBiZWVuIHJlbW92ZWQuCiAgICAgICAg IHJldHVybiAtMTsKKyAgICAKKyAgICBpZiAocGFzdExhc3ROb2RlVG9SZW1vdmUgPT0gc3RhcnRO b2RlSW5kZXggKyAxKQorICAgICAgICByZXR1cm4gMDsKIAogICAgIHJlbW92ZU5vZGUobm9kZXNU b1JlbW92ZVtzdGFydE5vZGVJbmRleF0sIEFzc3VtZUNvbnRlbnRJc0Fsd2F5c0VkaXRhYmxlKTsK ICAgICBpbnNlcnROb2RlQmVmb3JlKG5vZGVzVG9SZW1vdmVbc3RhcnROb2RlSW5kZXhdLCBoaWdo ZXN0QW5jZXN0b3JUb1JlbW92ZSwgQXNzdW1lQ29udGVudElzQWx3YXlzRWRpdGFibGUpOwpJbmRl eDogVG9vbHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL0NoYW5nZUxvZwkocmV2aXNp b24gMTM4MjE5KQorKysgVG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEs MTUgQEAKKzIwMTItMTItMTkgIFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CisKKyAg ICAgICAgUkVHUkVTU0lPTihyMTMzODIwPyk6IFNpbXBsaWZ5TWFya3VwVGVzdCBBUEkgdGVzdCBh c3NlcnRzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x MDUzNzAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBS ZS1lbmFibGUgdGhlIHRlc3QuCisKKyAgICAgICAgKiBUZXN0V2ViS2l0QVBJL1Rlc3RzL21hYy9T aW1wbGlmeU1hcmt1cC5tbToKKyAgICAgICAgKFRlc3RXZWJLaXRBUEk6OlRFU1QpOgorCiAyMDEy LTEyLTE5ICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgogCiAgICAgICAgIFBlcmZU ZXN0LnBhcnNlX291dHB1dCBkb2VzIHRvbyBtdWNoCkluZGV4OiBUb29scy9UZXN0V2ViS2l0QVBJ L1Rlc3RzL21hYy9TaW1wbGlmeU1hcmt1cC5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9UZXN0V2Vi S2l0QVBJL1Rlc3RzL21hYy9TaW1wbGlmeU1hcmt1cC5tbQkocmV2aXNpb24gMTM4MTE5KQorKysg VG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9tYWMvU2ltcGxpZnlNYXJrdXAubW0JKHdvcmtpbmcg Y29weSkKQEAgLTQ3LDcgKzQ3LDcgQEAgLSAodm9pZCl3ZWJWaWV3OihXZWJWaWV3ICopc2VuZGVy IGRpZEZpbgogCiBuYW1lc3BhY2UgVGVzdFdlYktpdEFQSSB7CiAKLVRFU1QoV2ViS2l0MSwgRElT QUJMRURfU2ltcGxpZnlNYXJrdXBUZXN0KQorVEVTVChXZWJLaXQxLCBTaW1wbGlmeU1hcmt1cFRl c3QpCiB7CiAgICAgUmV0YWluUHRyPFdlYlZpZXc+IHdlYlZpZXcxKEFkb3B0TlMsIFtbV2ViVmll dyBhbGxvY10gaW5pdFdpdGhGcmFtZTpOU01ha2VSZWN0KDAsIDAsIDEyMCwgMjAwKSBmcmFtZU5h bWU6bmlsIGdyb3VwTmFtZTpuaWxdKTsKICAgICBSZXRhaW5QdHI8V2ViVmlldz4gd2ViVmlldzIo QWRvcHROUywgW1tXZWJWaWV3IGFsbG9jXSBpbml0V2l0aEZyYW1lOk5TTWFrZVJlY3QoMCwgMCwg MTIwLCAyMDApIGZyYW1lTmFtZTpuaWwgZ3JvdXBOYW1lOm5pbF0pOwo= 180429 2012-12-20 15:49:41 -0800 2012-12-20 15:50:06 -0800 Fixes the bug bug-105370-20121220154657.patch text/plain 3252 rniwa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEzODIxOSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDEyLTEyLTE5ICBSeW9zdWtl IE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIFJFR1JFU1NJT04ocjEzMzgyMD8p OiBTaW1wbGlmeU1hcmt1cFRlc3QgQVBJIHRlc3QgYXNzZXJ0cworICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA1MzcwCisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ2hlY2sgaWYgd2UndmUgYWxyZWFkeSByZW1v dmVkIGEgcGFyZW50IG9yIG5vdCBmaXJzdC4KKworICAgICAgICBDb3ZlcnRlZCBieSBhbiBleGlz dGluZyBXZWJLaXQgQVBJIHRlc3QuCisKKyAgICAgICAgKiBlZGl0aW5nL1NpbXBsaWZ5TWFya3Vw Q29tbWFuZC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTaW1wbGlmeU1hcmt1cENvbW1hbmQ6OmRv QXBwbHkpOgorICAgICAgICAoV2ViQ29yZTo6U2ltcGxpZnlNYXJrdXBDb21tYW5kOjpwcnVuZVN1 YnNlcXVlbnRBbmNlc3RvcnNUb1JlbW92ZSk6CisgICAgICAgIChXZWJDb3JlKToKKwogMjAxMi0x Mi0xOSAgQ29zbWluIFRydXRhICA8Y3RydXRhQHJpbS5jb20+CiAKICAgICAgICAgW0JsYWNrQmVy cnldIFJTUyByZWFkZXIgbWFuZ2xlcyBVVEYtOApJbmRleDogU291cmNlL1dlYkNvcmUvZWRpdGlu Zy9TaW1wbGlmeU1hcmt1cENvbW1hbmQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3Jl L2VkaXRpbmcvU2ltcGxpZnlNYXJrdXBDb21tYW5kLmNwcAkocmV2aXNpb24gMTM4MTE5KQorKysg U291cmNlL1dlYkNvcmUvZWRpdGluZy9TaW1wbGlmeU1hcmt1cENvbW1hbmQuY3BwCSh3b3JraW5n IGNvcHkpCkBAIC0xMDUsMTUgKzEwNSwxMyBAQCBpbnQgU2ltcGxpZnlNYXJrdXBDb21tYW5kOjpw cnVuZVN1YnNlcXVlCiAgICAgICAgIEFTU0VSVChub2Rlc1RvUmVtb3ZlW3Bhc3RMYXN0Tm9kZVRv UmVtb3ZlXS0+Zmlyc3RDaGlsZCgpID09IG5vZGVzVG9SZW1vdmVbcGFzdExhc3ROb2RlVG9SZW1v dmVdLT5sYXN0Q2hpbGQoKSk7CiAgICAgfQogCi0gICAgaWYgKHBhc3RMYXN0Tm9kZVRvUmVtb3Zl ID09IHN0YXJ0Tm9kZUluZGV4ICsgMSkKLSAgICAgICAgcmV0dXJuIDA7Ci0KICAgICBOb2RlKiBo aWdoZXN0QW5jZXN0b3JUb1JlbW92ZSA9IG5vZGVzVG9SZW1vdmVbcGFzdExhc3ROb2RlVG9SZW1v dmUgLSAxXS5nZXQoKTsKLQotICAgIFJlZlB0cjxOb2RlPiBub2RlQWZ0ZXJIaWdoZXN0QW5jZXN0 b3JUb1JlbW92ZSA9IGhpZ2hlc3RBbmNlc3RvclRvUmVtb3ZlLT5uZXh0U2libGluZygpOwogICAg IFJlZlB0cjxDb250YWluZXJOb2RlPiBwYXJlbnQgPSBoaWdoZXN0QW5jZXN0b3JUb1JlbW92ZS0+ cGFyZW50Tm9kZSgpOwogICAgIGlmICghcGFyZW50KSAvLyBQYXJlbnQgaGFzIGFscmVhZHkgYmVl biByZW1vdmVkLgogICAgICAgICByZXR1cm4gLTE7CisgICAgCisgICAgaWYgKHBhc3RMYXN0Tm9k ZVRvUmVtb3ZlID09IHN0YXJ0Tm9kZUluZGV4ICsgMSkKKyAgICAgICAgcmV0dXJuIDA7CiAKICAg ICByZW1vdmVOb2RlKG5vZGVzVG9SZW1vdmVbc3RhcnROb2RlSW5kZXhdLCBBc3N1bWVDb250ZW50 SXNBbHdheXNFZGl0YWJsZSk7CiAgICAgaW5zZXJ0Tm9kZUJlZm9yZShub2Rlc1RvUmVtb3ZlW3N0 YXJ0Tm9kZUluZGV4XSwgaGlnaGVzdEFuY2VzdG9yVG9SZW1vdmUsIEFzc3VtZUNvbnRlbnRJc0Fs d2F5c0VkaXRhYmxlKTsKSW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29s cy9DaGFuZ2VMb2cJKHJldmlzaW9uIDEzODIxOSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDEyLTEyLTE5ICBSeW9zdWtlIE5pd2EgIDxybml3 YUB3ZWJraXQub3JnPgorCisgICAgICAgIFJFR1JFU1NJT04ocjEzMzgyMD8pOiBTaW1wbGlmeU1h cmt1cFRlc3QgQVBJIHRlc3QgYXNzZXJ0cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTA1MzcwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgUmUtZW5hYmxlIHRoZSB0ZXN0LgorCisgICAgICAgICogVGVzdFdl YktpdEFQSS9UZXN0cy9tYWMvU2ltcGxpZnlNYXJrdXAubW06CisgICAgICAgIChUZXN0V2ViS2l0 QVBJOjpURVNUKToKKwogMjAxMi0xMi0xOSAgUnlvc3VrZSBOaXdhICA8cm5pd2FAd2Via2l0Lm9y Zz4KIAogICAgICAgICBQZXJmVGVzdC5wYXJzZV9vdXRwdXQgZG9lcyB0b28gbXVjaApJbmRleDog VG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9tYWMvU2ltcGxpZnlNYXJrdXAubW0KPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9tYWMvU2ltcGxpZnlNYXJrdXAubW0JKHJl dmlzaW9uIDEzODExOSkKKysrIFRvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvbWFjL1NpbXBsaWZ5 TWFya3VwLm1tCSh3b3JraW5nIGNvcHkpCkBAIC00Nyw3ICs0Nyw3IEBAIC0gKHZvaWQpd2ViVmll dzooV2ViVmlldyAqKXNlbmRlciBkaWRGaW4KIAogbmFtZXNwYWNlIFRlc3RXZWJLaXRBUEkgewog Ci1URVNUKFdlYktpdDEsIERJU0FCTEVEX1NpbXBsaWZ5TWFya3VwVGVzdCkKK1RFU1QoV2ViS2l0 MSwgU2ltcGxpZnlNYXJrdXBUZXN0KQogewogICAgIFJldGFpblB0cjxXZWJWaWV3PiB3ZWJWaWV3 MShBZG9wdE5TLCBbW1dlYlZpZXcgYWxsb2NdIGluaXRXaXRoRnJhbWU6TlNNYWtlUmVjdCgwLCAw LCAxMjAsIDIwMCkgZnJhbWVOYW1lOm5pbCBncm91cE5hbWU6bmlsXSk7CiAgICAgUmV0YWluUHRy PFdlYlZpZXc+IHdlYlZpZXcyKEFkb3B0TlMsIFtbV2ViVmlldyBhbGxvY10gaW5pdFdpdGhGcmFt ZTpOU01ha2VSZWN0KDAsIDAsIDEyMCwgMjAwKSBmcmFtZU5hbWU6bmlsIGdyb3VwTmFtZTpuaWxd KTsK